<i18n dev> RFR: 8324998: Add test cases for String.regionMatches comparing Turkic dotted/dotless I with uppercase latin I
Naoto Sato
naoto at openjdk.org
Tue Jan 30 22:49:41 UTC 2024
On Tue, 30 Jan 2024 19:57:01 GMT, Eirik Bjørsnøs <eirbjo at openjdk.org> wrote:
> Please review this test-only PR which improves test coverage of `String.regionMatches` when comparing the Turkic "dotted I" and "dotless i" characters with their latin cousins.
>
> The test `CompactStrings/RegionMatches.java` currently includes cases comparing these characters against the lowercase latin "i" character, but not against the corresponding uppercase latin "I" character. It would be good to add test cases for the uppercase I as well.
>
> This was originally found in #12637, which was closed without being integrated. I think this test coverage enhancement is worth rescuing from that PR, where it did prove to catch a regression.
Looks reasonable to me.
-------------
Marked as reviewed by naoto (Reviewer).
PR Review: https://git.openjdk.org/jdk/pull/17639#pullrequestreview-1852521752
More information about the i18n-dev
mailing list