<i18n dev> RFR: 8336847: Use pattern match switch in NumberFormat classes

[Naoto Sato]

On Tue, 23 Jul 2024 17:29:10 GMT, Justin Lu <jlu at openjdk.org> wrote:

>> As discussed in https://github.com/openjdk/jdk/pull/19513#discussion_r1684957942, there is code within java.text.NumberFormat (and subclasses) that can use the pattern match switch to improve readability.
>> 
>> As this is simply cleanup, there is no regression test added. (Tiers 1-3 and java_text JCK ran to ensure clean migration).
>
> src/java.base/share/classes/java/text/DecimalFormat.java line 1797:
> 
>> 1795:             case Long l -> digitList.set(isNegative, l, maxDigits);
>> 1796:             case BigInteger bi -> digitList.set(isNegative, bi, maxDigits);
>> 1797:             default -> {} // do nothing
> 
> default case could also be thrown `AssertionError` if preferred.

Or a simple `assert` statement, as throwing an Error could change the behavior

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/20302#discussion_r1688492608