<i18n dev> RFR: 8337285: Examine java.text.DecimalFormat API for api/implXxx tag usage [v2]

[Justin Lu]

On Fri, 26 Jul 2024 20:05:53 GMT, Naoto Sato <naoto at openjdk.org> wrote:

>> Justin Lu has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   reflect review
>
> src/java.base/share/classes/java/text/DecimalFormat.java line 441:
> 
>> 439:      * @see NumberFormat#getNumberInstance()
>> 440:      * @see NumberFormat#getCurrencyInstance()
>> 441:      * @see NumberFormat#getPercentInstance()
> 
> The paragraph is for a "given" locale, probably factories that take Locale would be more appropriate than no-arg ones. (applies to other locations too)

I picked the no-arg methods because I imagine most users want the default locale instance. But I agree that it makes sense to use the Locale arg methods, since the phrasing does say "given locale" (twice). Updated here and in the other instances, thanks.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/20361#discussion_r1693589378