<i18n dev> RFR: 8333755: NumberFormat integer only parsing breaks when format has suffix [v2]

[Justin Lu]

On Wed, 12 Jun 2024 20:12:15 GMT, Naoto Sato <naoto at openjdk.org> wrote:

>> Justin Lu has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   specification improvements
>
> src/java.base/share/classes/java/text/DecimalFormat.java line 2446:
> 
>> 2444:     // To track the full parse index as well as the integer portion
>> 2445:     record Position(int intPos, int fullPos) {}
>> 2446: 
> 
> The record name may be more descriptive. Also I would expect more description here, such as what it is and those params are.

Thanks for the review Naoto.

Renamed to `NumericPosition`, as well as added further descritpion. Hesitant to rename to anything longer/detail too much, for what is essentially a limited scope helper class.

> test/jdk/java/text/Format/NumberFormat/StrictParseTest.java line 320:
> 
>> 318:     }
>> 319: 
>> 320:     // Overloaded method used for integer only parsing, where the expected
> 
> Is this method for `integer only` only?

A leftover comment, now removed.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/19664#discussion_r1637152902
PR Review Comment: https://git.openjdk.org/jdk/pull/19664#discussion_r1637152781