<i18n dev> RFR: 8333396: Performance regression of DecimalFormat.format [v5]

Chen Liang liach at openjdk.org
Thu Jun 13 19:36:14 UTC 2024


On Thu, 13 Jun 2024 16:51:30 GMT, Justin Lu <jlu at openjdk.org> wrote:

>> lingjun-cg has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   8333396: Performance regression of DecimalFormat.format
>
> src/java.base/share/classes/java/text/StringBuilderBufferProxy.java line 150:
> 
>> 148:     class StringBufferImpl implements StringBuilderBufferProxy {
>> 149: 
>> 150:         private StringBuffer sb;
> 
> Should this be `final`?

In fact, we should just make them sealed interfaces implemented by 2 records.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/19513#discussion_r1638781424


More information about the i18n-dev mailing list