<i18n dev> RFR: 8333396: Performance regression of DecimalFormat.format [v8]

[lingjun-cg]

On Tue, 18 Jun 2024 20:36:52 GMT, Justin Lu <jlu at openjdk.org> wrote:

>> lingjun-cg has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   8333396: Performance regression of DecimalFormat.format
>
> src/java.base/share/classes/java/text/Format.java line 278:
> 
>> 276:      *         {@code false} otherwise
>> 277:      */
>> 278:     boolean isInternalSubclass() {
> 
> Since this is defined in Format, can we apply similar changes of StringBuilder formatting to the other Format subclasses beyond just NumberFormat.
> 
> For example, in DateFormat, something such as,
> 
> 
> <T extends Appendable & CharSequence> T formatWithGeneric(Date date,
>                                                    T toAppendTo,
>                                                    FieldPosition pos) {
>         throw new UnsupportedOperationException("Subclasses should override this method");
> }

ok. I will update it if we have a conclusion about using  `StringBuf` or using `<T extends Appendable & CharSequence>`.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/19513#discussion_r1645300958