<i18n dev> RFR: 8330954: since-checker - Fix remaining @ since tags in java.base [v5]
Nizar Benalla
nbenalla at openjdk.org
Wed Jun 26 10:08:38 UTC 2024
> Please review this PR that aims to add all the remaining needed `@since` tags in `java.base`, and group them into a single fix.
> This is related to #18934 and my work around the `@since` checker feature.
> Explicit `@since` tags are needed for some overriding methods for the purpose of the checker.
>
> I will only give the example with the `CompletableFuture` class but here is the before where the methods only appeared in "Methods declared in interface N"
>
> <img width="1510" alt="Screenshot 2024-05-06 at 00 06 57" src="https://github.com/openjdk/jdk/assets/96922791/1749a355-133b-4a38-bffe-51ac415b2aac">
>
>
>
> and after where the method has it's own javadoc, the main description is added and the `@since` tags are added as intended.
>
> I don't have an account on `https://cr.openjdk.org/` but I could host the generated docs somewhere if that is needed.
>
> <img width="1511" alt="Screenshot 2024-05-06 at 00 07 16" src="https://github.com/openjdk/jdk/assets/96922791/89b92288-9b5e-48ed-8fa1-9342ea43e043">
>
> <img width="1505" alt="Screenshot 2024-05-06 at 00 08 06" src="https://github.com/openjdk/jdk/assets/96922791/9aef08ff-5030-4189-a996-582a7eef849b">
>
> <img width="1050" alt="Screenshot 2024-05-06 at 00 09 03" src="https://github.com/openjdk/jdk/assets/96922791/fdd75a26-0396-4c5e-8f59-a3717b7d7ec8">
>
>
> TIA
Nizar Benalla has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains 12 additional commits since the last revision:
- Merge remote-tracking branch 'upstream/master' into 8330954
- Merge remote-tracking branch 'upstream/master' into 8330954
- (C)
- (C)
- Move security classes changes to pr18373
- remove couple extra lines
- Pull request is now only about `@since` tags, might add an other commit
- add one more `{inheritDoc}` to `CompletableFuture.state`
- add `@throws` declarations to javadoc
- add ``{@inheritDoc}`` to new javadoc comments
- ... and 2 more: https://git.openjdk.org/jdk/compare/5654cccb...dbef517a
-------------
Changes:
- all: https://git.openjdk.org/jdk/pull/18954/files
- new: https://git.openjdk.org/jdk/pull/18954/files/b3574b97..dbef517a
Webrevs:
- full: https://webrevs.openjdk.org/?repo=jdk&pr=18954&range=04
- incr: https://webrevs.openjdk.org/?repo=jdk&pr=18954&range=03-04
Stats: 141869 lines in 2684 files changed: 97659 ins; 31514 del; 12696 mod
Patch: https://git.openjdk.org/jdk/pull/18954.diff
Fetch: git fetch https://git.openjdk.org/jdk.git pull/18954/head:pull/18954
PR: https://git.openjdk.org/jdk/pull/18954
More information about the i18n-dev
mailing list