<i18n dev> RFR: JDK-8326908: DecimalFormat::toPattern throws OutOfMemoryError when pattern is empty string [v2]
Justin Lu
jlu at openjdk.org
Tue Mar 5 00:32:47 UTC 2024
> Please review this PR and corresponding CSR which prevents an OutOfMemoryError by restricting the initial maximum fraction digits for an empty pattern DecimalFormat.
>
> For an empty String pattern DecimalFormat, the maximum fraction digits is initialized to `Integer.MAX_VALUE`. When toPattern() is invoked, StringBuilder internally doubles capacity attempting to append Integer.MAX_VALUE digits until OOME occurs. CSR covers potential behavioral compatibility changes.
Justin Lu has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains five additional commits since the last revision:
- cleanup/typo
- Merge branch 'master' into JDK-8326908-emptyPattern-OOME
- implement feedback + improve pattern related tests
- minor additions
- init
-------------
Changes:
- all: https://git.openjdk.org/jdk/pull/18094/files
- new: https://git.openjdk.org/jdk/pull/18094/files/fc8a7ce4..7ca56500
Webrevs:
- full: https://webrevs.openjdk.org/?repo=jdk&pr=18094&range=01
- incr: https://webrevs.openjdk.org/?repo=jdk&pr=18094&range=00-01
Stats: 5885 lines in 919 files changed: 2483 ins; 1248 del; 2154 mod
Patch: https://git.openjdk.org/jdk/pull/18094.diff
Fetch: git fetch https://git.openjdk.org/jdk.git pull/18094/head:pull/18094
PR: https://git.openjdk.org/jdk/pull/18094
More information about the i18n-dev
mailing list