<i18n dev> RFR: JDK-8326853 Missing @since tags for Charset related methods added in Java 10 [v7]

Nizar Benalla duke at openjdk.org
Tue Mar 19 17:08:23 UTC 2024


On Tue, 19 Mar 2024 16:13:49 GMT, Justin Lu <jlu at openjdk.org> wrote:

>> Nizar Benalla has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   update the latter years for the Oracle copyrights
>
> src/java.base/share/classes/java/nio/channels/Channels.java line 2:
> 
>> 1: /*
>> 2:  * Copyright (c) 2000, 2023, 2024, Oracle and/or its affiliates. All rights reserved.
> 
> Thanks for updating, but needs a little adjustment.
> 
> Rather than adding a third year, the format should be: "original year, current year, Oracle ..."
> So in this case ->  `2000, 2024,`

Thanks for the explanation, I have fixed it.
I have a couple other similar PRs, is the policy to update the copyright year every time a file is changed? whether it's an addition or removal of code?

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/18032#discussion_r1530770401


More information about the i18n-dev mailing list