<i18n dev> RFR: JDK-8326853 Missing @since tags for Charset related methods added in Java 10 [v8]
Justin Lu
jlu at openjdk.org
Tue Mar 19 17:32:21 UTC 2024
On Tue, 19 Mar 2024 17:02:36 GMT, Nizar Benalla <duke at openjdk.org> wrote:
>> # Issue
>> - JDK-8326853 Incorrect @\since Tags for Charset Related Methods Added in JDK 10
>>
>> I changed the @\since tags to better accurately show when the methods and constructors were introduced.
>
> Nizar Benalla has updated the pull request incrementally with two additional commits since the last revision:
>
> - update the copyright year to 2024
> - Revert "update the latter years for the Oracle copyrights"
>
> This reverts commit 8bcc364fef8287c4d9aff7c60ed6fc0ea9155f64.
Change looks good to me, but you will need someone with reviewer status to sponsor your changes before you can integrate them.
BTW, I also added a `noreg-doc` label to your JBS issue, which just means that no tests are needed for this change as it is a documentation only change.
-------------
Marked as reviewed by jlu (Committer).
PR Review: https://git.openjdk.org/jdk/pull/18032#pullrequestreview-1946933024
More information about the i18n-dev
mailing list