<i18n dev> RFR: JDK-8327640: Allow NumberFormat strict parsing [v2]
Justin Lu
jlu at openjdk.org
Thu Mar 21 18:12:52 UTC 2024
On Tue, 19 Mar 2024 08:56:46 GMT, Andrey Turbanov <aturbanov at openjdk.org> wrote:
>> Justin Lu has updated the pull request incrementally with one additional commit since the last revision:
>>
>> Replace protected field with a public getter -> isStrict().
>> Replace setLenient() with setStrict() to avoid messy inversion of boolean.
>> Add a leniency section to NumberFormat.
>> Overhaul of NumberFormat class specification to be much more organized/readable.
>
> src/java.base/share/classes/java/text/DecimalFormat.java line 2482:
>
>> 2480: // process digits or Inf, find decimal position
>> 2481: status[STATUS_INFINITE] = false;
>> 2482: if (!isExponent && text.regionMatches(position, symbols.getInfinity(),0,
>
> Suggestion:
>
> if (!isExponent && text.regionMatches(position, symbols.getInfinity(), 0,
Thanks, this and the other suggestions you provided should be fixed.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/18339#discussion_r1534407476
More information about the i18n-dev
mailing list