<i18n dev> RFR: JDK-8329118: Run MessageFormat additional subformat pattern tests under en_US locale [v4]

Naoto Sato naoto at openjdk.org
Tue Mar 26 23:44:21 UTC 2024


On Tue, 26 Mar 2024 23:32:34 GMT, Justin Lu <jlu at openjdk.org> wrote:

>> Please review this PR which updates two MessageFormat sub format related tests to be guaranteed to run under the `en_US` locale.
>> 
>> There exists locale that do not provide distinct instances for separate styles. For example, the `en_IN` locale provides the same LONG and SHORT compact number instances. The test data is built to test sub formats under the assumption that different styles do provide distinct instances.
>> 
>> As this is the case, these tests should be ran under a locale that does provide distinct instances for separate styles.
>
> Justin Lu has updated the pull request incrementally with one additional commit since the last revision:
> 
>   drop loc field for US constant

LGTM. Thanks for fixing it

-------------

Marked as reviewed by naoto (Reviewer).

PR Review: https://git.openjdk.org/jdk/pull/18498#pullrequestreview-1961949433


More information about the i18n-dev mailing list