<i18n dev> RFR: 8330954: Fix remaining `@since` tags in `java.base`

[Chen Liang]

On Fri, 26 Apr 2024 09:30:23 GMT, Nizar Benalla <duke at openjdk.org> wrote:

> We will effectively enforce javadoc comment for some method overrides with the checker

Those overriding methods don't even appear on the javadoc output. If you go to search for `CompletableFuture.resultNow` on https://docs.oracle.com/en/java/javase/22/docs/api/ you will find nothing. Why are we fixing "broken since tags" that don't even exist in the first place?

Also have you looked at the output documentation? Without the `@inheritDoc` tags the content will only have a since tag, which is definitely wrong.

> Recent [offline] discussions have showed that dealing with `@since` in overriding methods is complicated.
> The solution is to add an explicit `@since` to some overriding methods that do not have any javadoc as the only `@since` we can infer is that of the enclosing class.

If possible, I wish the others who joined the offline discussion can take part here. It seems you have some trouble understanding that overriding methods without explicit documentation are ignored by javadoc, and this ignorance makes the `@since` tags correct...

-------------

PR Comment: https://git.openjdk.org/jdk/pull/18954#issuecomment-2079550602
PR Comment: https://git.openjdk.org/jdk/pull/18954#issuecomment-2080532787