<i18n dev> RFR: 8331646: Add specific regression leap year tests [v4]

Naoto Sato naoto at openjdk.org
Thu May 9 22:40:03 UTC 2024


On Thu, 9 May 2024 09:10:20 GMT, serhiysachkov <duke at openjdk.org> wrote:

>> Calendar.add() tests that describe its behavior.
>
> serhiysachkov has updated the pull request incrementally with one additional commit since the last revision:
> 
>   JDK-8331646 updating impl according to review requests

LGTM. Please fix the typo before integrate

test/jdk/java/util/Calendar/CalendarLeapYearAddTest.java line 116:

> 114:                 Arguments.of("testDateAddSubtractLeapYear", 29, FEBRUARY, 2024, 365, -365, DATE, 29, FEBRUARY, 2024),
> 115:                 Arguments.of("testWeekOfYearAddSubtractLeapYear", 29, FEBRUARY, 2024, 52, -52, WEEK_OF_YEAR, 29, FEBRUARY, 2024),
> 116:                 Arguments.of("testDateOfMonthAddSubtractLeapYear", 29, FEBRUARY, 2024, 31, -31, DAY_OF_MONTH, 29, FEBRUARY, 2024),

"DateOfMonth" -> "DayOfMonth"

-------------

Marked as reviewed by naoto (Reviewer).

PR Review: https://git.openjdk.org/jdk/pull/19082#pullrequestreview-2048948832
PR Review Comment: https://git.openjdk.org/jdk/pull/19082#discussion_r1596061264


More information about the i18n-dev mailing list