<i18n dev> RFR: 8331879: Clean up non-standard use of /// comments in `java.base`

Naoto Sato naoto at openjdk.org
Tue May 28 20:31:04 UTC 2024


On Tue, 28 May 2024 18:50:38 GMT, Jonathan Gibbons <jjg at openjdk.org> wrote:

>> src/java.base/share/classes/jdk/internal/icu/impl/StringPrepDataReader.java line 122:
>> 
>>> 120:      * see store.c of gennorm for more information and values
>>> 121:      */
>>> 122:     // /* dataFormat="SPRP" 0x53, 0x50, 0x52, 0x50  */
>> 
>> This source file is coming from the upstream ICU4J project. Even if this is a `non-standard` comment, I would keep it as it is to minimize the merge effort.
>
> As a non-standard comment, it will trigger a warning (and hence an error), since the prevailing standard for `java.base` is to compile with all warnings enabled (`-Xlint`) and no warnings found (verified by `-Werror`)
> 
> The alternative would be to use `@SuppressWarnings` for the `dangling-doc-comment` warning, but that too would be a code change to these imported files.

OK, we will need to live with it.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/19130#discussion_r1617854422


More information about the i18n-dev mailing list