From jlu at openjdk.org  Fri Nov  1 16:37:33 2024
From: jlu at openjdk.org (Justin Lu)
Date: Fri, 1 Nov 2024 16:37:33 GMT
Subject: <i18n dev> RFR: 8343236: Use @apiNote and @implSpec in
 j.util.Currency [v2]
In-Reply-To: <2NvHXzsBqvT_RgQwlUCLW9khjqHFGQF3wtOoyc0U5eA=.36dc303f-c5fc-4557-bb7d-6c1d8958f766@github.com>
References: <HHNKr_ir5dwJqMqWChR37svmAbsBN5XWkTB3l7v_C6g=.6524c170-75c0-4b4d-83c1-b42f2a4a9f9e@github.com>
 <2NvHXzsBqvT_RgQwlUCLW9khjqHFGQF3wtOoyc0U5eA=.36dc303f-c5fc-4557-bb7d-6c1d8958f766@github.com>
Message-ID: <vn4Wf3NctuD0l5pkKEhXzpEk6SFljbj8OOoFj4ZSWJw=.812239ca-04c4-4237-a77a-612536dcccc3@github.com>

On Thu, 31 Oct 2024 19:40:06 GMT, Justin Lu <jlu at openjdk.org> wrote:

>> Please review this PR which aims to improve the _j.util.Currency_ specification by using `@apiNote` and `@implSpec`.
>> 
>> A corresponding CSR has been filed.
>
> Justin Lu has updated the pull request incrementally with one additional commit since the last revision:
> 
>   CSR review: implNote -> implSpec

Thank you for the reviews!

-------------

PR Comment: https://git.openjdk.org/jdk/pull/21793#issuecomment-2452184651

From jlu at openjdk.org  Fri Nov  1 16:37:33 2024
From: jlu at openjdk.org (Justin Lu)
Date: Fri, 1 Nov 2024 16:37:33 GMT
Subject: <i18n dev> Integrated: 8343236: Use @apiNote and @implSpec in
 j.util.Currency
In-Reply-To: <HHNKr_ir5dwJqMqWChR37svmAbsBN5XWkTB3l7v_C6g=.6524c170-75c0-4b4d-83c1-b42f2a4a9f9e@github.com>
References: <HHNKr_ir5dwJqMqWChR37svmAbsBN5XWkTB3l7v_C6g=.6524c170-75c0-4b4d-83c1-b42f2a4a9f9e@github.com>
Message-ID: <hTmH3_8NeTCSid0TFv8bjf_jU9k_ysQcGfgHLowT4DE=.a24d5bbb-47cc-4a16-98eb-d283c637a61a@github.com>

On Wed, 30 Oct 2024 20:34:04 GMT, Justin Lu <jlu at openjdk.org> wrote:

> Please review this PR which aims to improve the _j.util.Currency_ specification by using `@apiNote` and `@implSpec`.
> 
> A corresponding CSR has been filed.

This pull request has now been integrated.

Changeset: ea110c35
Author:    Justin Lu <jlu at openjdk.org>
URL:       https://git.openjdk.org/jdk/commit/ea110c35f5429f1e1de57a301e2256f508a4c324
Stats:     6 lines in 1 file changed: 2 ins; 0 del; 4 mod

8343236: Use @apiNote and @implSpec in j.util.Currency

Reviewed-by: iris, lancea, bpb, naoto

-------------

PR: https://git.openjdk.org/jdk/pull/21793

From joehw at openjdk.org  Fri Nov  1 20:30:23 2024
From: joehw at openjdk.org (Joe Wang)
Date: Fri, 1 Nov 2024 20:30:23 GMT
Subject: <i18n dev> RFR: 8333582: Update CLDR to Version 46.0 [v2]
In-Reply-To: <vwyPn_mWPIeHvteo6lmkD5H27EJRXjdQlBiBKVfkbcY=.597a468f-f00b-440a-bc1e-ebbe1b20b8b2@github.com>
References: <BC9maq8cicKr97KrRECyl-I_IulD7I4N07p2hmkACuo=.217bf2ae-9a89-4e88-b7d7-78de0aa2ce89@github.com>
 <vwyPn_mWPIeHvteo6lmkD5H27EJRXjdQlBiBKVfkbcY=.597a468f-f00b-440a-bc1e-ebbe1b20b8b2@github.com>
Message-ID: <qqUqpdAB57kWkl9EIIl4CknS-kWjzyC8Hpp3wAhGhis=.facbeb7b-b4d7-4217-b874-45ff103ac843@github.com>

On Thu, 31 Oct 2024 20:06:24 GMT, Naoto Sato <naoto at openjdk.org> wrote:

>> Upgrading the CLDR to version 46.0. A corresponding CSR has also been drafted.
>
> Naoto Sato has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Addresses review comments

Looks good to me.

test/jdk/sun/text/resources/LocaleDataTest.java line 44:

> 42:  *      8209775 8221432 8227127 8230284 8231273 8233579 8234288 8250665 8255086
> 43:  *      8251317 8274658 8283277 8283805 8265315 8287868 8295564 8284840 8296715
> 44:  *      8301206 8303472 8317979 8306116 8174269 8333582

Similar situation as TimeZoneNameTest.java? Looks like no other change than the bug id.

-------------

Marked as reviewed by joehw (Reviewer).

PR Review: https://git.openjdk.org/jdk/pull/21772#pullrequestreview-2410813842
PR Review Comment: https://git.openjdk.org/jdk/pull/21772#discussion_r1826253551

From naoto at openjdk.org  Fri Nov  1 20:40:30 2024
From: naoto at openjdk.org (Naoto Sato)
Date: Fri, 1 Nov 2024 20:40:30 GMT
Subject: <i18n dev> RFR: 8333582: Update CLDR to Version 46.0 [v2]
In-Reply-To: <qqUqpdAB57kWkl9EIIl4CknS-kWjzyC8Hpp3wAhGhis=.facbeb7b-b4d7-4217-b874-45ff103ac843@github.com>
References: <BC9maq8cicKr97KrRECyl-I_IulD7I4N07p2hmkACuo=.217bf2ae-9a89-4e88-b7d7-78de0aa2ce89@github.com>
 <vwyPn_mWPIeHvteo6lmkD5H27EJRXjdQlBiBKVfkbcY=.597a468f-f00b-440a-bc1e-ebbe1b20b8b2@github.com>
 <qqUqpdAB57kWkl9EIIl4CknS-kWjzyC8Hpp3wAhGhis=.facbeb7b-b4d7-4217-b874-45ff103ac843@github.com>
Message-ID: <q2s1pzJzyXxfVQ4iU58XKvbkX6CBKvWMKx015j7XSic=.bba258c3-f929-436d-9b0f-143d439029ca@github.com>

On Fri, 1 Nov 2024 20:10:02 GMT, Joe Wang <joehw at openjdk.org> wrote:

>> Naoto Sato has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Addresses review comments
>
> test/jdk/sun/text/resources/LocaleDataTest.java line 44:
> 
>> 42:  *      8209775 8221432 8227127 8230284 8231273 8233579 8234288 8250665 8255086
>> 43:  *      8251317 8274658 8283277 8283805 8265315 8287868 8295564 8284840 8296715
>> 44:  *      8301206 8303472 8317979 8306116 8174269 8333582
> 
> Similar situation as TimeZoneNameTest.java? Looks like no other change than the bug id.

There are changes in `LocaleData.cldr` data file, which is an input to this test case. Everytime the data file is modified, the bug id is recorded here.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/21772#discussion_r1826275066

From jlu at openjdk.org  Fri Nov  1 23:21:56 2024
From: jlu at openjdk.org (Justin Lu)
Date: Fri, 1 Nov 2024 23:21:56 GMT
Subject: <i18n dev> RFR: 8343237: Improve the copying of the available set
 of Currencies
Message-ID: <PuaktdmoJvTll6jpRanMGp6RoG85xw-FSn86s9IA0xQ=.f2db1c2e-3b14-48d3-a8f4-92a4ae338f52@github.com>

Please review this PR which is a small cleanup in `Currency.getAvailableCurrencies()`. We can use the `HashSet` constructor over `clone()` to make the defensive copy of the set of available currencies. This gets rid of the unsightly unchecked cast and SuppressWarnings annotation.

-------------

Commit messages:
 - init

Changes: https://git.openjdk.org/jdk/pull/21845/files
  Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=21845&range=00
  Issue: https://bugs.openjdk.org/browse/JDK-8343237
  Stats: 4 lines in 1 file changed: 0 ins; 3 del; 1 mod
  Patch: https://git.openjdk.org/jdk/pull/21845.diff
  Fetch: git fetch https://git.openjdk.org/jdk.git pull/21845/head:pull/21845

PR: https://git.openjdk.org/jdk/pull/21845

From bpb at openjdk.org  Sat Nov  2 01:29:27 2024
From: bpb at openjdk.org (Brian Burkhalter)
Date: Sat, 2 Nov 2024 01:29:27 GMT
Subject: <i18n dev> RFR: 8343237: Improve the copying of the available
 set of Currencies
In-Reply-To: <PuaktdmoJvTll6jpRanMGp6RoG85xw-FSn86s9IA0xQ=.f2db1c2e-3b14-48d3-a8f4-92a4ae338f52@github.com>
References: <PuaktdmoJvTll6jpRanMGp6RoG85xw-FSn86s9IA0xQ=.f2db1c2e-3b14-48d3-a8f4-92a4ae338f52@github.com>
Message-ID: <Zu0ANYKQCN3lmWC5ZlxAAJVPIf8dSQQkydjp3a3blrU=.344527ee-5056-45d6-985c-fa5f95d5d6ff@github.com>

On Fri, 1 Nov 2024 23:17:01 GMT, Justin Lu <jlu at openjdk.org> wrote:

> Please review this PR which is a small cleanup in `Currency.getAvailableCurrencies()`. We can use the `HashSet` constructor over `clone()` to make the defensive copy of the set of available currencies. This gets rid of the unsightly unchecked cast and SuppressWarnings annotation.

Looks fine.

-------------

Marked as reviewed by bpb (Reviewer).

PR Review: https://git.openjdk.org/jdk/pull/21845#pullrequestreview-2411110241

From acobbs at openjdk.org  Sat Nov  2 15:27:01 2024
From: acobbs at openjdk.org (Archie Cobbs)
Date: Sat, 2 Nov 2024 15:27:01 GMT
Subject: <i18n dev> RFR: 8343476: Remove unnecessary @SuppressWarnings
 annotations (client)
Message-ID: <Sa_OdV-UQBC_8sqALNkC2gOphd6PvXZ9EeisG_If2WQ=.36470214-24b9-457e-9183-24492a0d1df8@github.com>

Please review this patch which removes unnecessary `@SuppressWarnings` annotations.

-------------

Commit messages:
 - Remove unnecessary @SuppressWarnings annotations.

Changes: https://git.openjdk.org/jdk/pull/21850/files
  Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=21850&range=00
  Issue: https://bugs.openjdk.org/browse/JDK-8343476
  Stats: 156 lines in 101 files changed: 0 ins; 150 del; 6 mod
  Patch: https://git.openjdk.org/jdk/pull/21850.diff
  Fetch: git fetch https://git.openjdk.org/jdk.git pull/21850/head:pull/21850

PR: https://git.openjdk.org/jdk/pull/21850

From acobbs at openjdk.org  Sat Nov  2 15:45:00 2024
From: acobbs at openjdk.org (Archie Cobbs)
Date: Sat, 2 Nov 2024 15:45:00 GMT
Subject: <i18n dev> RFR: 8343478: Remove unnecessary @SuppressWarnings
 annotations (core-libs)
Message-ID: <9ZqHljyJeMr8fPG4-iU6bfQT9hQxTAwrGCl4xsQn3LA=.0b01f899-d849-4e23-8d50-8f186aade664@github.com>

Please review this patch which removes unnecessary `@SuppressWarnings` annotations.

-------------

Commit messages:
 - Remove unnecessary @SuppressWarnings annotations.

Changes: https://git.openjdk.org/jdk/pull/21852/files
  Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=21852&range=00
  Issue: https://bugs.openjdk.org/browse/JDK-8343478
  Stats: 113 lines in 89 files changed: 0 ins; 82 del; 31 mod
  Patch: https://git.openjdk.org/jdk/pull/21852.diff
  Fetch: git fetch https://git.openjdk.org/jdk.git pull/21852/head:pull/21852

PR: https://git.openjdk.org/jdk/pull/21852

From acobbs at openjdk.org  Sat Nov  2 16:28:57 2024
From: acobbs at openjdk.org (Archie Cobbs)
Date: Sat, 2 Nov 2024 16:28:57 GMT
Subject: <i18n dev> RFR: 8343486: Remove unnecessary @SuppressWarnings
 annotations and -Xlint:-foo options
Message-ID: <_0tXXRd0rjBqgxYxEKLI8xi7VmVYoDgHojrQKyGAVpg=.ed193b53-170e-4fcb-9d20-f402e467b92f@github.com>

Please review this patch which removes unnecessary `@SuppressWarnings` annotations and `-Xlint:-foo` options.

-------------

Commit messages:
 - Remove unnecessary @SuppressWarnings annotations and -Xlint:-key flags.

Changes: https://git.openjdk.org/jdk/pull/21859/files
  Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=21859&range=00
  Issue: https://bugs.openjdk.org/browse/JDK-8343486
  Stats: 115 lines in 13 files changed: 0 ins; 111 del; 4 mod
  Patch: https://git.openjdk.org/jdk/pull/21859.diff
  Fetch: git fetch https://git.openjdk.org/jdk.git pull/21859/head:pull/21859

PR: https://git.openjdk.org/jdk/pull/21859

From acobbs at openjdk.org  Sun Nov  3 03:09:53 2024
From: acobbs at openjdk.org (Archie Cobbs)
Date: Sun, 3 Nov 2024 03:09:53 GMT
Subject: <i18n dev> RFR: 8343476: Remove unnecessary @SuppressWarnings
 annotations (client) [v2]
In-Reply-To: <Sa_OdV-UQBC_8sqALNkC2gOphd6PvXZ9EeisG_If2WQ=.36470214-24b9-457e-9183-24492a0d1df8@github.com>
References: <Sa_OdV-UQBC_8sqALNkC2gOphd6PvXZ9EeisG_If2WQ=.36470214-24b9-457e-9183-24492a0d1df8@github.com>
Message-ID: <OsTpH-mXX1_GyeMbefsuL4aKMaP6H1sYL3UPJ9-iNO0=.466dd572-93f6-49b8-9d8f-b95169472d12@github.com>

> Please review this patch which removes unnecessary `@SuppressWarnings` annotations.

Archie Cobbs has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains four additional commits since the last revision:

 - Update copyright years.
 - Merge branch 'master' into SuppressWarningsCleanup-client
 - Merge branch 'master' into SuppressWarningsCleanup-client
 - Remove unnecessary @SuppressWarnings annotations.

-------------

Changes:
  - all: https://git.openjdk.org/jdk/pull/21850/files
  - new: https://git.openjdk.org/jdk/pull/21850/files/41705c55..c6723886

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jdk&pr=21850&range=01
 - incr: https://webrevs.openjdk.org/?repo=jdk&pr=21850&range=00-01

  Stats: 3315 lines in 213 files changed: 2078 ins; 749 del; 488 mod
  Patch: https://git.openjdk.org/jdk/pull/21850.diff
  Fetch: git fetch https://git.openjdk.org/jdk.git pull/21850/head:pull/21850

PR: https://git.openjdk.org/jdk/pull/21850

From acobbs at openjdk.org  Sun Nov  3 03:13:25 2024
From: acobbs at openjdk.org (Archie Cobbs)
Date: Sun, 3 Nov 2024 03:13:25 GMT
Subject: <i18n dev> RFR: 8343478: Remove unnecessary @SuppressWarnings
 annotations (core-libs) [v2]
In-Reply-To: <9ZqHljyJeMr8fPG4-iU6bfQT9hQxTAwrGCl4xsQn3LA=.0b01f899-d849-4e23-8d50-8f186aade664@github.com>
References: <9ZqHljyJeMr8fPG4-iU6bfQT9hQxTAwrGCl4xsQn3LA=.0b01f899-d849-4e23-8d50-8f186aade664@github.com>
Message-ID: <zvOlVozGs_y3wT3BPPdVPSG-pMZSon_S9jkoDYObhN4=.0b54a387-3926-460a-90a2-3a98cbc41ff1@github.com>

> Please review this patch which removes unnecessary `@SuppressWarnings` annotations.

Archie Cobbs has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains four additional commits since the last revision:

 - Update copyright years.
 - Merge branch 'master' into SuppressWarningsCleanup-core-libs
 - Merge branch 'master' into SuppressWarningsCleanup-core-libs
 - Remove unnecessary @SuppressWarnings annotations.

-------------

Changes:
  - all: https://git.openjdk.org/jdk/pull/21852/files
  - new: https://git.openjdk.org/jdk/pull/21852/files/9cef2ae6..7842dfea

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jdk&pr=21852&range=01
 - incr: https://webrevs.openjdk.org/?repo=jdk&pr=21852&range=00-01

  Stats: 3279 lines in 177 files changed: 2078 ins; 749 del; 452 mod
  Patch: https://git.openjdk.org/jdk/pull/21852.diff
  Fetch: git fetch https://git.openjdk.org/jdk.git pull/21852/head:pull/21852

PR: https://git.openjdk.org/jdk/pull/21852

From acobbs at openjdk.org  Sun Nov  3 03:17:14 2024
From: acobbs at openjdk.org (Archie Cobbs)
Date: Sun, 3 Nov 2024 03:17:14 GMT
Subject: <i18n dev> RFR: 8343486: Remove unnecessary @SuppressWarnings
 annotations and -Xlint:-foo options [v2]
In-Reply-To: <_0tXXRd0rjBqgxYxEKLI8xi7VmVYoDgHojrQKyGAVpg=.ed193b53-170e-4fcb-9d20-f402e467b92f@github.com>
References: <_0tXXRd0rjBqgxYxEKLI8xi7VmVYoDgHojrQKyGAVpg=.ed193b53-170e-4fcb-9d20-f402e467b92f@github.com>
Message-ID: <cy4UhZzE_EtKqRCdMIBIcwn91Mr7Vfga1zLdYR_PpJ4=.aca7bbd5-18eb-4396-8e77-45ef3d82fe4b@github.com>

> Please review this patch which removes unnecessary `@SuppressWarnings` annotations and `-Xlint:-foo` options.

Archie Cobbs has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains four additional commits since the last revision:

 - Update copyright years.
 - Merge branch 'master' into SuppressWarningsCleanup-build
 - Merge branch 'master' into SuppressWarningsCleanup-build
 - Remove unnecessary @SuppressWarnings annotations and -Xlint:-key flags.

-------------

Changes:
  - all: https://git.openjdk.org/jdk/pull/21859/files
  - new: https://git.openjdk.org/jdk/pull/21859/files/389dd678..79f5a620

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jdk&pr=21859&range=01
 - incr: https://webrevs.openjdk.org/?repo=jdk&pr=21859&range=00-01

  Stats: 3227 lines in 125 files changed: 2078 ins; 749 del; 400 mod
  Patch: https://git.openjdk.org/jdk/pull/21859.diff
  Fetch: git fetch https://git.openjdk.org/jdk.git pull/21859/head:pull/21859

PR: https://git.openjdk.org/jdk/pull/21859

From jwaters at openjdk.org  Mon Nov  4 06:05:29 2024
From: jwaters at openjdk.org (Julian Waters)
Date: Mon, 4 Nov 2024 06:05:29 GMT
Subject: <i18n dev> RFR: 8342868: Errors related to unused code on
 Windows after 8339120 in core libs [v2]
In-Reply-To: <vT6zJlWPUg235GuAHNJbyAxkoONF2vljAuFTVygBoGk=.05690f62-9641-4990-855a-c908df24e064@github.com>
References: <otTjiRgCFQEeUbpfFTMzhXUVBU1cal8q_i7IrGs_n94=.c2f02ad8-6b0c-4daa-9995-8e4b42131eb4@github.com>
 <vT6zJlWPUg235GuAHNJbyAxkoONF2vljAuFTVygBoGk=.05690f62-9641-4990-855a-c908df24e064@github.com>
Message-ID: <SISGIzeBVerZ_M9bBk4gV32GisaUXMUqUpPk-ZlMqy8=.182195cb-6055-4361-b1b9-f96f587f1329@github.com>

On Thu, 31 Oct 2024 05:43:11 GMT, Julian Waters <jwaters at openjdk.org> wrote:

>> After 8339120, gcc began catching many different instances of unused code in the Windows specific codebase. Some of these seem to be bugs. I've taken the effort to mark out all the relevant globals and locals that trigger the unused warnings and addressed all of them by commenting out the code as appropriate. I am confident that in many cases this simplistic approach of commenting out code does not fix the underlying issue, and the warning actually found a bug that should be fixed. In these instances, I will be aiming to fix these bugs with help from reviewers, so I recommend anyone reviewing who knows more about the code than I do to see whether there is indeed a bug that needs fixing in a different way than what I did
>
> Julian Waters has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Remove the got local

Thanks for the reviews! I would delete them entirely, but I don't want to invalidate the existing reviews and force you guys to re-approve again :(

-------------

PR Comment: https://git.openjdk.org/jdk/pull/21654#issuecomment-2453883009

From ihse at openjdk.org  Mon Nov  4 14:39:32 2024
From: ihse at openjdk.org (Magnus Ihse Bursie)
Date: Mon, 4 Nov 2024 14:39:32 GMT
Subject: <i18n dev> RFR: 8343486: Remove unnecessary @SuppressWarnings
 annotations and -Xlint:-foo options [v2]
In-Reply-To: <cy4UhZzE_EtKqRCdMIBIcwn91Mr7Vfga1zLdYR_PpJ4=.aca7bbd5-18eb-4396-8e77-45ef3d82fe4b@github.com>
References: <_0tXXRd0rjBqgxYxEKLI8xi7VmVYoDgHojrQKyGAVpg=.ed193b53-170e-4fcb-9d20-f402e467b92f@github.com>
 <cy4UhZzE_EtKqRCdMIBIcwn91Mr7Vfga1zLdYR_PpJ4=.aca7bbd5-18eb-4396-8e77-45ef3d82fe4b@github.com>
Message-ID: <IZYR7UYOfrmZot84NcsG-ADyW05upBo4YkLtl-Ou5-4=.a8146a2e-efb5-439f-97e1-2d12838fee17@github.com>

On Sun, 3 Nov 2024 03:17:14 GMT, Archie Cobbs <acobbs at openjdk.org> wrote:

>> Please review this patch which removes unnecessary `@SuppressWarnings` annotations and `-Xlint:-foo` options.
>
> Archie Cobbs has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains four additional commits since the last revision:
> 
>  - Update copyright years.
>  - Merge branch 'master' into SuppressWarningsCleanup-build
>  - Merge branch 'master' into SuppressWarningsCleanup-build
>  - Remove unnecessary @SuppressWarnings annotations and -Xlint:-key flags.

Changes under `make` looks good, thanks for cleaning this up!

I'm not sure who should review the changes under `src`. The `i18n` label does not seem correct for changes in dynalink and jsobject.

-------------

Marked as reviewed by ihse (Reviewer).

PR Review: https://git.openjdk.org/jdk/pull/21859#pullrequestreview-2413243273

From naoto at openjdk.org  Mon Nov  4 17:03:34 2024
From: naoto at openjdk.org (Naoto Sato)
Date: Mon, 4 Nov 2024 17:03:34 GMT
Subject: <i18n dev> RFR: 8333582: Update CLDR to Version 46.0 [v2]
In-Reply-To: <vwyPn_mWPIeHvteo6lmkD5H27EJRXjdQlBiBKVfkbcY=.597a468f-f00b-440a-bc1e-ebbe1b20b8b2@github.com>
References: <BC9maq8cicKr97KrRECyl-I_IulD7I4N07p2hmkACuo=.217bf2ae-9a89-4e88-b7d7-78de0aa2ce89@github.com>
 <vwyPn_mWPIeHvteo6lmkD5H27EJRXjdQlBiBKVfkbcY=.597a468f-f00b-440a-bc1e-ebbe1b20b8b2@github.com>
Message-ID: <0zYQ9HaoqGWKd2ujs7BtystGLV6pYBeWg1VoGkzbfa4=.31cdb5ca-c1bc-4c17-a1e3-468ed91cccf4@github.com>

On Thu, 31 Oct 2024 20:06:24 GMT, Naoto Sato <naoto at openjdk.org> wrote:

>> Upgrading the CLDR to version 46.0. A corresponding CSR has also been drafted.
>
> Naoto Sato has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Addresses review comments

Thank you for your reviews!

-------------

PR Comment: https://git.openjdk.org/jdk/pull/21772#issuecomment-2455235506

From naoto at openjdk.org  Mon Nov  4 17:03:35 2024
From: naoto at openjdk.org (Naoto Sato)
Date: Mon, 4 Nov 2024 17:03:35 GMT
Subject: <i18n dev> Integrated: 8333582: Update CLDR to Version 46.0
In-Reply-To: <BC9maq8cicKr97KrRECyl-I_IulD7I4N07p2hmkACuo=.217bf2ae-9a89-4e88-b7d7-78de0aa2ce89@github.com>
References: <BC9maq8cicKr97KrRECyl-I_IulD7I4N07p2hmkACuo=.217bf2ae-9a89-4e88-b7d7-78de0aa2ce89@github.com>
Message-ID: <wKo8yGcB_PuBErspWVxUY3F12FMPCo7eN3OA4OcSuu8=.f8692184-8fb7-406c-b10e-b46bdf247bbf@github.com>

On Tue, 29 Oct 2024 18:12:43 GMT, Naoto Sato <naoto at openjdk.org> wrote:

> Upgrading the CLDR to version 46.0. A corresponding CSR has also been drafted.

This pull request has now been integrated.

Changeset: 1c448347
Author:    Naoto Sato <naoto at openjdk.org>
URL:       https://git.openjdk.org/jdk/commit/1c4483473d878bb4c41e66f27fea84ef81ede8c9
Stats:     114740 lines in 290 files changed: 91794 ins; 7333 del; 15613 mod

8333582: Update CLDR to Version 46.0

Reviewed-by: joehw, srl, jlu

-------------

PR: https://git.openjdk.org/jdk/pull/21772

From liach at openjdk.org  Mon Nov  4 18:29:31 2024
From: liach at openjdk.org (Chen Liang)
Date: Mon, 4 Nov 2024 18:29:31 GMT
Subject: <i18n dev> RFR: 8343478: Remove unnecessary @SuppressWarnings
 annotations (core-libs) [v2]
In-Reply-To: <zvOlVozGs_y3wT3BPPdVPSG-pMZSon_S9jkoDYObhN4=.0b54a387-3926-460a-90a2-3a98cbc41ff1@github.com>
References: <9ZqHljyJeMr8fPG4-iU6bfQT9hQxTAwrGCl4xsQn3LA=.0b01f899-d849-4e23-8d50-8f186aade664@github.com>
 <zvOlVozGs_y3wT3BPPdVPSG-pMZSon_S9jkoDYObhN4=.0b54a387-3926-460a-90a2-3a98cbc41ff1@github.com>
Message-ID: <cN9PxkA-TmCSKrHxXRSaZvGeZv5s0nafAQEDZaB0Wzs=.0cb21a43-1493-4f49-8922-2b42eb918f70@github.com>

On Sun, 3 Nov 2024 03:13:25 GMT, Archie Cobbs <acobbs at openjdk.org> wrote:

>> Please review this patch which removes unnecessary `@SuppressWarnings` annotations.
>
> Archie Cobbs has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains four additional commits since the last revision:
> 
>  - Update copyright years.
>  - Merge branch 'master' into SuppressWarningsCleanup-core-libs
>  - Merge branch 'master' into SuppressWarningsCleanup-core-libs
>  - Remove unnecessary @SuppressWarnings annotations.

java.lang.invoke/reflect and jdk.internal.classfile changes look good.

-------------

PR Review: https://git.openjdk.org/jdk/pull/21852#pullrequestreview-2413824024

From acobbs at openjdk.org  Tue Nov  5 15:48:45 2024
From: acobbs at openjdk.org (Archie Cobbs)
Date: Tue, 5 Nov 2024 15:48:45 GMT
Subject: <i18n dev> RFR: 8343486: Remove unnecessary @SuppressWarnings
 annotations and -Xlint:-foo options [v2]
In-Reply-To: <cy4UhZzE_EtKqRCdMIBIcwn91Mr7Vfga1zLdYR_PpJ4=.aca7bbd5-18eb-4396-8e77-45ef3d82fe4b@github.com>
References: <_0tXXRd0rjBqgxYxEKLI8xi7VmVYoDgHojrQKyGAVpg=.ed193b53-170e-4fcb-9d20-f402e467b92f@github.com>
 <cy4UhZzE_EtKqRCdMIBIcwn91Mr7Vfga1zLdYR_PpJ4=.aca7bbd5-18eb-4396-8e77-45ef3d82fe4b@github.com>
Message-ID: <rJEEUyW0dvXcePsPJZT9PHar1YpvZBIbBGinzODZzb4=.9c1e615f-0c0f-4f35-bc89-143c9e9663b6@github.com>

On Sun, 3 Nov 2024 03:17:14 GMT, Archie Cobbs <acobbs at openjdk.org> wrote:

>> Please review this patch which removes unnecessary `@SuppressWarnings` annotations and `-Xlint:-foo` options.
>
> Archie Cobbs has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains four additional commits since the last revision:
> 
>  - Update copyright years.
>  - Merge branch 'master' into SuppressWarningsCleanup-build
>  - Merge branch 'master' into SuppressWarningsCleanup-build
>  - Remove unnecessary @SuppressWarnings annotations and -Xlint:-key flags.

Thanks for the quick review.

-------------

PR Comment: https://git.openjdk.org/jdk/pull/21859#issuecomment-2457521620

From acobbs at openjdk.org  Tue Nov  5 15:48:45 2024
From: acobbs at openjdk.org (Archie Cobbs)
Date: Tue, 5 Nov 2024 15:48:45 GMT
Subject: <i18n dev> Integrated: 8343486: Remove unnecessary
 @SuppressWarnings annotations and -Xlint:-foo options
In-Reply-To: <_0tXXRd0rjBqgxYxEKLI8xi7VmVYoDgHojrQKyGAVpg=.ed193b53-170e-4fcb-9d20-f402e467b92f@github.com>
References: <_0tXXRd0rjBqgxYxEKLI8xi7VmVYoDgHojrQKyGAVpg=.ed193b53-170e-4fcb-9d20-f402e467b92f@github.com>
Message-ID: <Am_dynZcEQrpKVvyTaIPcmPBFfOrg6xLqn1-BPX6p5U=.4fe19c55-9bd9-4b71-9380-744a5a67d342@github.com>

On Sat, 2 Nov 2024 16:23:34 GMT, Archie Cobbs <acobbs at openjdk.org> wrote:

> Please review this patch which removes unnecessary `@SuppressWarnings` annotations and `-Xlint:-foo` options.

This pull request has now been integrated.

Changeset: c799cad1
Author:    Archie Cobbs <acobbs at openjdk.org>
URL:       https://git.openjdk.org/jdk/commit/c799cad1de93aadfe60d9cbccb0499d7299f0598
Stats:     119 lines in 13 files changed: 0 ins; 111 del; 8 mod

8343486: Remove unnecessary @SuppressWarnings annotations and -Xlint:-foo options

Reviewed-by: ihse

-------------

PR: https://git.openjdk.org/jdk/pull/21859

From ihse at openjdk.org  Tue Nov  5 16:44:40 2024
From: ihse at openjdk.org (Magnus Ihse Bursie)
Date: Tue, 5 Nov 2024 16:44:40 GMT
Subject: <i18n dev> RFR: 8343486: Remove unnecessary @SuppressWarnings
 annotations and -Xlint:-foo options [v2]
In-Reply-To: <cy4UhZzE_EtKqRCdMIBIcwn91Mr7Vfga1zLdYR_PpJ4=.aca7bbd5-18eb-4396-8e77-45ef3d82fe4b@github.com>
References: <_0tXXRd0rjBqgxYxEKLI8xi7VmVYoDgHojrQKyGAVpg=.ed193b53-170e-4fcb-9d20-f402e467b92f@github.com>
 <cy4UhZzE_EtKqRCdMIBIcwn91Mr7Vfga1zLdYR_PpJ4=.aca7bbd5-18eb-4396-8e77-45ef3d82fe4b@github.com>
Message-ID: <dFd53WD_97y0FB4vY03dcObP1h_QtsWc3T247nP-uek=.36810fb2-821a-4864-ab16-6b10c0c5e4a7@github.com>

On Sun, 3 Nov 2024 03:17:14 GMT, Archie Cobbs <acobbs at openjdk.org> wrote:

>> Please review this patch which removes unnecessary `@SuppressWarnings` annotations and `-Xlint:-foo` options.
>
> Archie Cobbs has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains four additional commits since the last revision:
> 
>  - Update copyright years.
>  - Merge branch 'master' into SuppressWarningsCleanup-build
>  - Merge branch 'master' into SuppressWarningsCleanup-build
>  - Remove unnecessary @SuppressWarnings annotations and -Xlint:-key flags.

Eh... I tried to say that I had only reviewed part of this PR. Maybe I should have made that clearer by bumping the number of required reviewers as well; I usually do that but I forgot it this time.

The changes look fairly benign so I guess there is no harm done this time.

-------------

PR Comment: https://git.openjdk.org/jdk/pull/21859#issuecomment-2457671373

From acobbs at openjdk.org  Tue Nov  5 16:51:32 2024
From: acobbs at openjdk.org (Archie Cobbs)
Date: Tue, 5 Nov 2024 16:51:32 GMT
Subject: <i18n dev> RFR: 8343486: Remove unnecessary @SuppressWarnings
 annotations and -Xlint:-foo options [v2]
In-Reply-To: <dFd53WD_97y0FB4vY03dcObP1h_QtsWc3T247nP-uek=.36810fb2-821a-4864-ab16-6b10c0c5e4a7@github.com>
References: <_0tXXRd0rjBqgxYxEKLI8xi7VmVYoDgHojrQKyGAVpg=.ed193b53-170e-4fcb-9d20-f402e467b92f@github.com>
 <cy4UhZzE_EtKqRCdMIBIcwn91Mr7Vfga1zLdYR_PpJ4=.aca7bbd5-18eb-4396-8e77-45ef3d82fe4b@github.com>
 <dFd53WD_97y0FB4vY03dcObP1h_QtsWc3T247nP-uek=.36810fb2-821a-4864-ab16-6b10c0c5e4a7@github.com>
Message-ID: <qq2m1lO9RjyH96HUPlEznRnuSsiyKWaV4TZdaQUV09w=.32151e5b-1a82-483a-b5b0-88d0b527f7f8@github.com>

On Tue, 5 Nov 2024 16:42:17 GMT, Magnus Ihse Bursie <ihse at openjdk.org> wrote:

> Eh... I tried to say that I had only reviewed part of this PR. Maybe I should have made that clearer by bumping the number of required reviewers as well; I usually do that but I forgot it this time.

Argh, sorry... I was just blindly assuming the bot knew what it was doing... my mistake.

In any case it's probably worth getting another pair of eyes to review the other changes... if there ends up being an issue I'm happy to address it in another PR.

Thanks.

-------------

PR Comment: https://git.openjdk.org/jdk/pull/21859#issuecomment-2457686055

From ihse at openjdk.org  Tue Nov  5 16:56:38 2024
From: ihse at openjdk.org (Magnus Ihse Bursie)
Date: Tue, 5 Nov 2024 16:56:38 GMT
Subject: <i18n dev> RFR: 8343486: Remove unnecessary @SuppressWarnings
 annotations and -Xlint:-foo options [v2]
In-Reply-To: <cy4UhZzE_EtKqRCdMIBIcwn91Mr7Vfga1zLdYR_PpJ4=.aca7bbd5-18eb-4396-8e77-45ef3d82fe4b@github.com>
References: <_0tXXRd0rjBqgxYxEKLI8xi7VmVYoDgHojrQKyGAVpg=.ed193b53-170e-4fcb-9d20-f402e467b92f@github.com>
 <cy4UhZzE_EtKqRCdMIBIcwn91Mr7Vfga1zLdYR_PpJ4=.aca7bbd5-18eb-4396-8e77-45ef3d82fe4b@github.com>
Message-ID: <tqmTQ0cAm4dezSeC8e3q_Yh33Xb68-kySnA_ShpqkRY=.b7177d35-4ef8-485d-bb07-9fcc3e2ed995@github.com>

On Sun, 3 Nov 2024 03:17:14 GMT, Archie Cobbs <acobbs at openjdk.org> wrote:

>> Please review this patch which removes unnecessary `@SuppressWarnings` annotations and `-Xlint:-foo` options.
>
> Archie Cobbs has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains four additional commits since the last revision:
> 
>  - Update copyright years.
>  - Merge branch 'master' into SuppressWarningsCleanup-build
>  - Merge branch 'master' into SuppressWarningsCleanup-build
>  - Remove unnecessary @SuppressWarnings annotations and -Xlint:-key flags.

It's never quite that simple. As the bot is fond of saying, "This change now passes all automated pre-integration checks. [...] This project also has non-automated pre-integration requirements"...

-------------

PR Comment: https://git.openjdk.org/jdk/pull/21859#issuecomment-2457697650

From liach at openjdk.org  Tue Nov  5 17:03:41 2024
From: liach at openjdk.org (Chen Liang)
Date: Tue, 5 Nov 2024 17:03:41 GMT
Subject: <i18n dev> RFR: 8343486: Remove unnecessary @SuppressWarnings
 annotations and -Xlint:-foo options [v2]
In-Reply-To: <cy4UhZzE_EtKqRCdMIBIcwn91Mr7Vfga1zLdYR_PpJ4=.aca7bbd5-18eb-4396-8e77-45ef3d82fe4b@github.com>
References: <_0tXXRd0rjBqgxYxEKLI8xi7VmVYoDgHojrQKyGAVpg=.ed193b53-170e-4fcb-9d20-f402e467b92f@github.com>
 <cy4UhZzE_EtKqRCdMIBIcwn91Mr7Vfga1zLdYR_PpJ4=.aca7bbd5-18eb-4396-8e77-45ef3d82fe4b@github.com>
Message-ID: <1GACK-nnSc7U_jI4QwVbUCWMVGGrkgSykE9f_oGD2-w=.46cceecb-62a2-4ac3-ac21-b170018255f8@github.com>

On Sun, 3 Nov 2024 03:17:14 GMT, Archie Cobbs <acobbs at openjdk.org> wrote:

>> Please review this patch which removes unnecessary `@SuppressWarnings` annotations and `-Xlint:-foo` options.
>
> Archie Cobbs has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains four additional commits since the last revision:
> 
>  - Update copyright years.
>  - Merge branch 'master' into SuppressWarningsCleanup-build
>  - Merge branch 'master' into SuppressWarningsCleanup-build
>  - Remove unnecessary @SuppressWarnings annotations and -Xlint:-key flags.

Sorry for coming late, but I think bidi/icu is an external library and its updates are tracked by i18n engineers.  We might have to revert those specific changes for library parity dependent on i18n engineers' discretion.

-------------

PR Comment: https://git.openjdk.org/jdk/pull/21859#issuecomment-2457715191

From naoto at openjdk.org  Tue Nov  5 18:08:36 2024
From: naoto at openjdk.org (Naoto Sato)
Date: Tue, 5 Nov 2024 18:08:36 GMT
Subject: <i18n dev> RFR: 8343486: Remove unnecessary @SuppressWarnings
 annotations and -Xlint:-foo options [v2]
In-Reply-To: <1GACK-nnSc7U_jI4QwVbUCWMVGGrkgSykE9f_oGD2-w=.46cceecb-62a2-4ac3-ac21-b170018255f8@github.com>
References: <_0tXXRd0rjBqgxYxEKLI8xi7VmVYoDgHojrQKyGAVpg=.ed193b53-170e-4fcb-9d20-f402e467b92f@github.com>
 <cy4UhZzE_EtKqRCdMIBIcwn91Mr7Vfga1zLdYR_PpJ4=.aca7bbd5-18eb-4396-8e77-45ef3d82fe4b@github.com>
 <1GACK-nnSc7U_jI4QwVbUCWMVGGrkgSykE9f_oGD2-w=.46cceecb-62a2-4ac3-ac21-b170018255f8@github.com>
Message-ID: <Lmho-Iexnmwura8uD8orywGA1K5XkiV4Td3PP9cbX6I=.50a166a2-94f2-4a68-bd04-04335557195c@github.com>

On Tue, 5 Nov 2024 17:01:07 GMT, Chen Liang <liach at openjdk.org> wrote:

> Sorry for coming late, but I think bidi/icu is an external library and its updates are tracked by i18n engineers. We might have to revert those specific changes for library parity dependent on i18n engineers' discretion.

Thank you, Chen. I was aware that the ICU file was modified and I thought it was OK, as ICU sources are already diverted, not identical to the upstream. So unless the modification conflicts with the upstream it's fine.

-------------

PR Comment: https://git.openjdk.org/jdk/pull/21859#issuecomment-2457848064

From swen at openjdk.org  Tue Nov  5 19:37:53 2024
From: swen at openjdk.org (Shaojin Wen)
Date: Tue, 5 Nov 2024 19:37:53 GMT
Subject: <i18n dev> RFR: 8337279: Optimize format instant [v10]
In-Reply-To: <17bf2n2yLh8dwpk9nsTF9G9UKHYWLDXDh0kie-9YrcA=.f19351bb-d47f-4ded-8a63-07914de70b4f@github.com>
References: <17bf2n2yLh8dwpk9nsTF9G9UKHYWLDXDh0kie-9YrcA=.f19351bb-d47f-4ded-8a63-07914de70b4f@github.com>
Message-ID: <f8RcBY64AD_DC3vjsFGqGeET-tvBIx3Gc4XhTlX0DWs=.ce6ba313-0c33-4c45-864c-699cefa869c4@github.com>

> By removing the redundant code logic in DateTimeFormatterBuilder$InstantPrinterParser#formatTo, the codeSize can be reduced and the performance can be improved.

Shaojin Wen has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains 12 additional commits since the last revision:

 - Merge remote-tracking branch 'upstream/master' into optim_instant_fmt_202407
 - Merge remote-tracking branch 'upstream/master' into optim_instant_fmt_202407
 - suggestion from @jensli
 - Speed up Instant.toString using JavaTimeAccess
 - add JavaTimeAccess SharedSecrets
 - Merge remote-tracking branch 'upstream/master' into optim_instant_fmt_202407
 - breaking out the printNano methods
 - copyright
 - Update src/java.base/share/classes/java/time/format/DateTimeFormatterBuilder.java
   
   Co-authored-by: Stephen Colebourne <scolebourne at joda.org>
 - 1. fix handle fraction == -1
   2. Split two methods to make codeSize less than 325
 - ... and 2 more: https://git.openjdk.org/jdk/compare/8c44b116...a9c5a36e

-------------

Changes:
  - all: https://git.openjdk.org/jdk/pull/20353/files
  - new: https://git.openjdk.org/jdk/pull/20353/files/1c2482e7..a9c5a36e

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jdk&pr=20353&range=09
 - incr: https://webrevs.openjdk.org/?repo=jdk&pr=20353&range=08-09

  Stats: 183697 lines in 2937 files changed: 99517 ins; 70736 del; 13444 mod
  Patch: https://git.openjdk.org/jdk/pull/20353.diff
  Fetch: git fetch https://git.openjdk.org/jdk.git pull/20353/head:pull/20353

PR: https://git.openjdk.org/jdk/pull/20353

From nbenalla at openjdk.org  Fri Nov  8 15:33:59 2024
From: nbenalla at openjdk.org (Nizar Benalla)
Date: Fri, 8 Nov 2024 15:33:59 GMT
Subject: <i18n dev> RFR: 8343777: Add since checker tests to
 Internationalisation modules
Message-ID: <P18_8XcwZidhLGMVNcpIan2E2FYKKfw-FKyI7k9m1cs=.9e9102a2-5e6a-46fe-a8c6-4a1cbdb48c95@github.com>

Can I please get a review for this PR that add tests to verify the value of `@since` tags to the Internationalisation area modules. The test is described in this [email](https://mail.openjdk.org/pipermail/jdk-dev/2024-October/009474.html).

The benefit from this is helping API authors and reviewer validate the accuracy of `@since` in their source code (and subsequently, in the generated documentation). And lessen the burden on Reviewers.

The test has been added for `java.base` and a few other modules and has helped catch some bugs before they make it to the JDK.

TIA

-------------

Commit messages:
 - remove backticks
 - Add two new jtreg tests.

Changes: https://git.openjdk.org/jdk/pull/21985/files
  Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=21985&range=00
  Issue: https://bugs.openjdk.org/browse/JDK-8343777
  Stats: 6 lines in 2 files changed: 0 ins; 0 del; 6 mod
  Patch: https://git.openjdk.org/jdk/pull/21985.diff
  Fetch: git fetch https://git.openjdk.org/jdk.git pull/21985/head:pull/21985

PR: https://git.openjdk.org/jdk/pull/21985

From naoto at openjdk.org  Fri Nov  8 18:01:21 2024
From: naoto at openjdk.org (Naoto Sato)
Date: Fri, 8 Nov 2024 18:01:21 GMT
Subject: <i18n dev> RFR: 8343777: Add since checker tests to
 Internationalisation modules
In-Reply-To: <P18_8XcwZidhLGMVNcpIan2E2FYKKfw-FKyI7k9m1cs=.9e9102a2-5e6a-46fe-a8c6-4a1cbdb48c95@github.com>
References: <P18_8XcwZidhLGMVNcpIan2E2FYKKfw-FKyI7k9m1cs=.9e9102a2-5e6a-46fe-a8c6-4a1cbdb48c95@github.com>
Message-ID: <EcbDbkJB2O5UK8nI9EnDKQl9iLhzryT0K_qmaoNOxSM=.1ca9f9cb-f0ea-4d33-9fdb-1385dd664814@github.com>

On Fri, 8 Nov 2024 15:20:29 GMT, Nizar Benalla <nbenalla at openjdk.org> wrote:

> Can I please get a review for this PR that add tests to verify the value of `@since` tags to the Internationalisation area modules. The test is described in this [email](https://mail.openjdk.org/pipermail/jdk-dev/2024-October/009474.html). This issue is similar to JDK-8341399, JDK-8331051 and JDK-8343442.
> 
> The benefit from this is helping API authors and reviewer validate the accuracy of `@since` in their source code (and subsequently, in the generated documentation). And lessen the burden on Reviewers.
> 
> The test has been added for `java.base` and a few other modules and has helped catch some bugs before they make it to the JDK.
> 
> TIA

Hi Nizar,
Both modules are intended to provide implementations for charsets/localedata, and no public APIs are/will be provided. Do we need since check for these modules?

-------------

PR Comment: https://git.openjdk.org/jdk/pull/21985#issuecomment-2465440955

From acobbs at openjdk.org  Fri Nov  8 19:07:16 2024
From: acobbs at openjdk.org (Archie Cobbs)
Date: Fri, 8 Nov 2024 19:07:16 GMT
Subject: <i18n dev> RFR: 8343478: Remove unnecessary @SuppressWarnings
 annotations (core-libs) [v3]
In-Reply-To: <9ZqHljyJeMr8fPG4-iU6bfQT9hQxTAwrGCl4xsQn3LA=.0b01f899-d849-4e23-8d50-8f186aade664@github.com>
References: <9ZqHljyJeMr8fPG4-iU6bfQT9hQxTAwrGCl4xsQn3LA=.0b01f899-d849-4e23-8d50-8f186aade664@github.com>
Message-ID: <dnV6AR8eTDXrX505rYy-j0mocbws2Nlf2-HWGGCoVac=.cf4f83dd-e6cb-4d1b-96c8-680cf64457f3@github.com>

> Please review this patch which removes unnecessary `@SuppressWarnings` annotations.

Archie Cobbs has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains eight additional commits since the last revision:

 - Merge branch 'master' into SuppressWarningsCleanup-core-libs
 - Update copyright years.
 - Remove a few more @SuppressWarnings annotations.
 - Remove a few more @SuppressWarnings annotations.
 - Update copyright years.
 - Merge branch 'master' into SuppressWarningsCleanup-core-libs
 - Merge branch 'master' into SuppressWarningsCleanup-core-libs
 - Remove unnecessary @SuppressWarnings annotations.

-------------

Changes:
  - all: https://git.openjdk.org/jdk/pull/21852/files
  - new: https://git.openjdk.org/jdk/pull/21852/files/7842dfea..a64d5594

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jdk&pr=21852&range=02
 - incr: https://webrevs.openjdk.org/?repo=jdk&pr=21852&range=01-02

  Stats: 131613 lines in 758 files changed: 103986 ins; 9698 del; 17929 mod
  Patch: https://git.openjdk.org/jdk/pull/21852.diff
  Fetch: git fetch https://git.openjdk.org/jdk.git pull/21852/head:pull/21852

PR: https://git.openjdk.org/jdk/pull/21852

From acobbs at openjdk.org  Fri Nov  8 19:10:14 2024
From: acobbs at openjdk.org (Archie Cobbs)
Date: Fri, 8 Nov 2024 19:10:14 GMT
Subject: <i18n dev> RFR: 8343476: Remove unnecessary @SuppressWarnings
 annotations (client) [v3]
In-Reply-To: <Sa_OdV-UQBC_8sqALNkC2gOphd6PvXZ9EeisG_If2WQ=.36470214-24b9-457e-9183-24492a0d1df8@github.com>
References: <Sa_OdV-UQBC_8sqALNkC2gOphd6PvXZ9EeisG_If2WQ=.36470214-24b9-457e-9183-24492a0d1df8@github.com>
Message-ID: <0ExgLh5TmmXBoQuCw1Sy-wRmlsdXUd1qZ2nlSyVcE04=.b5204ad6-2f46-431f-9cc5-f34625b7b5e6@github.com>

> Please review this patch which removes unnecessary `@SuppressWarnings` annotations.

Archie Cobbs has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains five additional commits since the last revision:

 - Merge branch 'master' into SuppressWarningsCleanup-client
 - Update copyright years.
 - Merge branch 'master' into SuppressWarningsCleanup-client
 - Merge branch 'master' into SuppressWarningsCleanup-client
 - Remove unnecessary @SuppressWarnings annotations.

-------------

Changes:
  - all: https://git.openjdk.org/jdk/pull/21850/files
  - new: https://git.openjdk.org/jdk/pull/21850/files/c6723886..211b7051

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jdk&pr=21850&range=02
 - incr: https://webrevs.openjdk.org/?repo=jdk&pr=21850&range=01-02

  Stats: 131587 lines in 749 files changed: 103986 ins; 9680 del; 17921 mod
  Patch: https://git.openjdk.org/jdk/pull/21850.diff
  Fetch: git fetch https://git.openjdk.org/jdk.git pull/21850/head:pull/21850

PR: https://git.openjdk.org/jdk/pull/21850

From acobbs at openjdk.org  Fri Nov  8 19:47:14 2024
From: acobbs at openjdk.org (Archie Cobbs)
Date: Fri, 8 Nov 2024 19:47:14 GMT
Subject: <i18n dev> RFR: 8343478: Remove unnecessary @SuppressWarnings
 annotations (core-libs) [v4]
In-Reply-To: <9ZqHljyJeMr8fPG4-iU6bfQT9hQxTAwrGCl4xsQn3LA=.0b01f899-d849-4e23-8d50-8f186aade664@github.com>
References: <9ZqHljyJeMr8fPG4-iU6bfQT9hQxTAwrGCl4xsQn3LA=.0b01f899-d849-4e23-8d50-8f186aade664@github.com>
Message-ID: <gyv3FuuYnMooqIZ-RUDCDFFipdJUOZglHH6-k8WMv38=.f203c313-72a8-4f69-b47e-c97f5a5afe6c@github.com>

> Please review this patch which removes unnecessary `@SuppressWarnings` annotations.

Archie Cobbs has updated the pull request incrementally with one additional commit since the last revision:

  Put back @SuppressWarnings annotations to be fixed by JDK-8343286.

-------------

Changes:
  - all: https://git.openjdk.org/jdk/pull/21852/files
  - new: https://git.openjdk.org/jdk/pull/21852/files/a64d5594..9137373f

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jdk&pr=21852&range=03
 - incr: https://webrevs.openjdk.org/?repo=jdk&pr=21852&range=02-03

  Stats: 3 lines in 2 files changed: 3 ins; 0 del; 0 mod
  Patch: https://git.openjdk.org/jdk/pull/21852.diff
  Fetch: git fetch https://git.openjdk.org/jdk.git pull/21852/head:pull/21852

PR: https://git.openjdk.org/jdk/pull/21852

From aturbanov at openjdk.org  Tue Nov 12 11:41:18 2024
From: aturbanov at openjdk.org (Andrey Turbanov)
Date: Tue, 12 Nov 2024 11:41:18 GMT
Subject: <i18n dev> RFR: 8344025: Remove unused
 ISO2022.Encoder.maximumDesignatorLength
Message-ID: <uG52_HJEoX_lMiy2WpVMnlydNg3TQlRnDd2zwaZOJQY=.9c5dcaa9-1f95-41ab-9fe0-fb9a4d710aaf@github.com>

The field `sun.nio.cs.ext.ISO2022.Encoder#maximumDesignatorLength` appears to be unused.

-------------

Commit messages:
 - [PATCH] Remove unused ISO2022.Encoder.maximumDesignatorLength

Changes: https://git.openjdk.org/jdk/pull/22031/files
  Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=22031&range=00
  Issue: https://bugs.openjdk.org/browse/JDK-8344025
  Stats: 6 lines in 1 file changed: 0 ins; 5 del; 1 mod
  Patch: https://git.openjdk.org/jdk/pull/22031.diff
  Fetch: git fetch https://git.openjdk.org/jdk.git pull/22031/head:pull/22031

PR: https://git.openjdk.org/jdk/pull/22031

From nbenalla at openjdk.org  Tue Nov 12 16:32:05 2024
From: nbenalla at openjdk.org (Nizar Benalla)
Date: Tue, 12 Nov 2024 16:32:05 GMT
Subject: <i18n dev> RFR: 8343777: Add since checker tests to
 Internationalisation modules
In-Reply-To: <P18_8XcwZidhLGMVNcpIan2E2FYKKfw-FKyI7k9m1cs=.9e9102a2-5e6a-46fe-a8c6-4a1cbdb48c95@github.com>
References: <P18_8XcwZidhLGMVNcpIan2E2FYKKfw-FKyI7k9m1cs=.9e9102a2-5e6a-46fe-a8c6-4a1cbdb48c95@github.com>
Message-ID: <Glwth58XPjOBI5ygDvOrCFngK3xiudaucKU3e939dco=.a223e13e-a7b9-4175-8016-37e9dbb46bf5@github.com>

On Fri, 8 Nov 2024 15:20:29 GMT, Nizar Benalla <nbenalla at openjdk.org> wrote:

> Can I please get a review for this PR that add tests to verify the value of `@since` tags to the Internationalisation area modules. The test is described in this [email](https://mail.openjdk.org/pipermail/jdk-dev/2024-October/009474.html). This issue is similar to JDK-8341399, JDK-8331051 and JDK-8343442.
> 
> The benefit from this is helping API authors and reviewer validate the accuracy of `@since` in their source code (and subsequently, in the generated documentation). And lessen the burden on Reviewers.
> 
> The test has been added for `java.base` and a few other modules and has helped catch some bugs before they make it to the JDK.
> 
> TIA

Hi Naoto,
The test does check the `@since` declaration in the `module-info.java` file, adding it for these two modules would increase the test coverage.

What do you think?

-------------

PR Comment: https://git.openjdk.org/jdk/pull/21985#issuecomment-2470991497

From naoto at openjdk.org  Tue Nov 12 17:46:19 2024
From: naoto at openjdk.org (Naoto Sato)
Date: Tue, 12 Nov 2024 17:46:19 GMT
Subject: <i18n dev> RFR: 8343777: Add since checker tests to
 Internationalisation modules
In-Reply-To: <P18_8XcwZidhLGMVNcpIan2E2FYKKfw-FKyI7k9m1cs=.9e9102a2-5e6a-46fe-a8c6-4a1cbdb48c95@github.com>
References: <P18_8XcwZidhLGMVNcpIan2E2FYKKfw-FKyI7k9m1cs=.9e9102a2-5e6a-46fe-a8c6-4a1cbdb48c95@github.com>
Message-ID: <tVYGTmP2wkaFqeh4-SIw1Jt7rBBXYj57U0X9IM4-fGg=.1b67b251-a9e1-4cb0-bfc2-2dbe43441c82@github.com>

On Fri, 8 Nov 2024 15:20:29 GMT, Nizar Benalla <nbenalla at openjdk.org> wrote:

> Can I please get a review for this PR that add tests to verify the value of `@since` tags to the Internationalisation area modules. The test is described in this [email](https://mail.openjdk.org/pipermail/jdk-dev/2024-October/009474.html). This issue is similar to JDK-8341399, JDK-8331051 and JDK-8343442.
> 
> The benefit from this is helping API authors and reviewer validate the accuracy of `@since` in their source code (and subsequently, in the generated documentation). And lessen the burden on Reviewers.
> 
> The test has been added for `java.base` and a few other modules and has helped catch some bugs before they make it to the JDK.
> 
> TIA

OK, fine from the coverage perspective. I would appreciate some explanations in the test description though, as someone might think if public APIs may be added in these modules.

-------------

PR Comment: https://git.openjdk.org/jdk/pull/21985#issuecomment-2471185655

From naoto at openjdk.org  Tue Nov 12 19:16:45 2024
From: naoto at openjdk.org (Naoto Sato)
Date: Tue, 12 Nov 2024 19:16:45 GMT
Subject: <i18n dev> RFR: 8344025: Remove unused
 ISO2022.Encoder.maximumDesignatorLength
In-Reply-To: <uG52_HJEoX_lMiy2WpVMnlydNg3TQlRnDd2zwaZOJQY=.9c5dcaa9-1f95-41ab-9fe0-fb9a4d710aaf@github.com>
References: <uG52_HJEoX_lMiy2WpVMnlydNg3TQlRnDd2zwaZOJQY=.9c5dcaa9-1f95-41ab-9fe0-fb9a4d710aaf@github.com>
Message-ID: <2X2K43oYSm1k8qtVOLayKewSXEfHgoeqf2mA0npQjoo=.1273f798-bbfe-441c-a6bd-58275e67368e@github.com>

On Tue, 12 Nov 2024 08:53:38 GMT, Andrey Turbanov <aturbanov at openjdk.org> wrote:

> The field `sun.nio.cs.ext.ISO2022.Encoder#maximumDesignatorLength` appears to be unused.

Looks fine to me. It seems that the field was for the old sun.io converters and was a leftover when NIO coders were introduced.

-------------

Marked as reviewed by naoto (Reviewer).

PR Review: https://git.openjdk.org/jdk/pull/22031#pullrequestreview-2430478251

From rriggs at openjdk.org  Tue Nov 12 19:28:38 2024
From: rriggs at openjdk.org (Roger Riggs)
Date: Tue, 12 Nov 2024 19:28:38 GMT
Subject: <i18n dev> RFR: 8344039: Remove security manager dependency in
 java.time
Message-ID: <JWlgY0q0TS7r1RHK8wODwdyh_bBlhxwk6Vo1g8ywel8=.874d57a1-0990-406e-b74e-0b7207a70f02@github.com>

After [JDK-8338411](https://bugs.openjdk.org/browse/JDK-8338411), Serialization implementation dependencies on doPriviledged and AccessController are removed.
Some refactoring to cleanup the remaining code is expected.

-------------

Commit messages:
 - Merge branch 'master' into 8344039-sm-cleanup-java-time
 - 8344039: Remove security manager dependency in java.time
 - Merge remote-tracking branch 'jdk-sandbox/jep486' into JDK-8338411
 - Merge branch 'master' into jep486
 - Move remaining JEP 486 failing tests into correct groups.
 - Move JEP 486 failing tests into hotspot_runtime group.
 - test/jdk/java/rmi/server/RMIClassLoader/spi/DefaultProperty.java failing
 - Merge branch 'master' into jep486
 - Merge branch 'master' into jep486
 - Merge remote-tracking branch 'jdk-sandbox/jep486' into JDK-8338411
 - ... and 216 more: https://git.openjdk.org/jdk/compare/63eb4853...96a8d26c

Changes: https://git.openjdk.org/jdk/pull/22042/files
  Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=22042&range=00
  Issue: https://bugs.openjdk.org/browse/JDK-8344039
  Stats: 78 lines in 2 files changed: 1 ins; 31 del; 46 mod
  Patch: https://git.openjdk.org/jdk/pull/22042.diff
  Fetch: git fetch https://git.openjdk.org/jdk.git pull/22042/head:pull/22042

PR: https://git.openjdk.org/jdk/pull/22042

From naoto at openjdk.org  Wed Nov 13 01:29:30 2024
From: naoto at openjdk.org (Naoto Sato)
Date: Wed, 13 Nov 2024 01:29:30 GMT
Subject: <i18n dev> RFR: 8344039: Remove security manager dependency in
 java.time
In-Reply-To: <JWlgY0q0TS7r1RHK8wODwdyh_bBlhxwk6Vo1g8ywel8=.874d57a1-0990-406e-b74e-0b7207a70f02@github.com>
References: <JWlgY0q0TS7r1RHK8wODwdyh_bBlhxwk6Vo1g8ywel8=.874d57a1-0990-406e-b74e-0b7207a70f02@github.com>
Message-ID: <H-acSZmNGKAB02bu6iv-6vsjZ0HaN5lEUzILQpdCi4M=.16ee08b6-43c4-41eb-ae2c-687d5775c0bf@github.com>

On Tue, 12 Nov 2024 15:41:01 GMT, Roger Riggs <rriggs at openjdk.org> wrote:

> After [JDK-8338411](https://bugs.openjdk.org/browse/JDK-8338411), Serialization implementation dependencies on doPriviledged and AccessController are removed.
> Some refactoring to cleanup the remaining code is expected.

src/java.base/share/classes/java/time/zone/ZoneRulesProvider.java line 147:

> 145:         // if the property java.time.zone.DefaultZoneRulesProvider is
> 146:         // set then its value is the class name of the default provider
> 147:         @SuppressWarnings("removal")

Should this SuppressWarnings be removed?

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/22042#discussion_r1839174201

From rriggs at openjdk.org  Wed Nov 13 14:12:34 2024
From: rriggs at openjdk.org (Roger Riggs)
Date: Wed, 13 Nov 2024 14:12:34 GMT
Subject: <i18n dev> RFR: 8344039: Remove security manager dependency in
 java.time [v2]
In-Reply-To: <JWlgY0q0TS7r1RHK8wODwdyh_bBlhxwk6Vo1g8ywel8=.874d57a1-0990-406e-b74e-0b7207a70f02@github.com>
References: <JWlgY0q0TS7r1RHK8wODwdyh_bBlhxwk6Vo1g8ywel8=.874d57a1-0990-406e-b74e-0b7207a70f02@github.com>
Message-ID: <rxv94CJtaTg97A6girvDp3iEjOfciBpiZWfLdvYjPas=.422b522b-21b9-4d45-9905-54c09a37ec93@github.com>

> After [JDK-8338411](https://bugs.openjdk.org/browse/JDK-8338411), Serialization implementation dependencies on doPriviledged and AccessController are removed.
> Some refactoring to cleanup the remaining code is expected.

Roger Riggs has updated the pull request incrementally with one additional commit since the last revision:

  Remove unnecessary suppress warnings removal
  ServiceLoader configuration exceptions (in a static initialization) are rethrown as Error.
  Remove dependency on SecurityException thrown by ServiceLoader (as obsolete)

-------------

Changes:
  - all: https://git.openjdk.org/jdk/pull/22042/files
  - new: https://git.openjdk.org/jdk/pull/22042/files/96a8d26c..0f2e92f5

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jdk&pr=22042&range=01
 - incr: https://webrevs.openjdk.org/?repo=jdk&pr=22042&range=00-01

  Stats: 5 lines in 1 file changed: 0 ins; 4 del; 1 mod
  Patch: https://git.openjdk.org/jdk/pull/22042.diff
  Fetch: git fetch https://git.openjdk.org/jdk.git pull/22042/head:pull/22042

PR: https://git.openjdk.org/jdk/pull/22042

From mullan at openjdk.org  Wed Nov 13 14:31:41 2024
From: mullan at openjdk.org (Sean Mullan)
Date: Wed, 13 Nov 2024 14:31:41 GMT
Subject: <i18n dev> RFR: 8344039: Remove security manager dependency in
 java.time [v2]
In-Reply-To: <rxv94CJtaTg97A6girvDp3iEjOfciBpiZWfLdvYjPas=.422b522b-21b9-4d45-9905-54c09a37ec93@github.com>
References: <JWlgY0q0TS7r1RHK8wODwdyh_bBlhxwk6Vo1g8ywel8=.874d57a1-0990-406e-b74e-0b7207a70f02@github.com>
 <rxv94CJtaTg97A6girvDp3iEjOfciBpiZWfLdvYjPas=.422b522b-21b9-4d45-9905-54c09a37ec93@github.com>
Message-ID: <jby7R0SL7l_5JCJZ_4xLbQf2SXPM0NPoAOlTEiEDivs=.72a44c85-1d40-4b60-bbc7-f4b1c82cafe8@github.com>

On Wed, 13 Nov 2024 14:12:34 GMT, Roger Riggs <rriggs at openjdk.org> wrote:

>> After [JDK-8338411](https://bugs.openjdk.org/browse/JDK-8338411), Serialization implementation dependencies on doPriviledged and AccessController are removed.
>> Some refactoring to cleanup the remaining code is expected.
>
> Roger Riggs has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Remove unnecessary suppress warnings removal
>   ServiceLoader configuration exceptions (in a static initialization) are rethrown as Error.
>   Remove dependency on SecurityException thrown by ServiceLoader (as obsolete)

src/java.base/share/classes/java/time/zone/ZoneRulesProvider.java line 1:

> 1: /*

Lines 171-172:

                if (ex.getCause() instanceof SecurityException) {
                    continue;  // ignore the security exception, try the next provider
                }

You may be able to remove this code, but may be better to leave it as-is for now until the SL code has been checked for cleanup.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/22042#discussion_r1840369340

From mullan at openjdk.org  Wed Nov 13 14:36:35 2024
From: mullan at openjdk.org (Sean Mullan)
Date: Wed, 13 Nov 2024 14:36:35 GMT
Subject: <i18n dev> RFR: 8344039: Remove security manager dependency in
 java.time [v2]
In-Reply-To: <rxv94CJtaTg97A6girvDp3iEjOfciBpiZWfLdvYjPas=.422b522b-21b9-4d45-9905-54c09a37ec93@github.com>
References: <JWlgY0q0TS7r1RHK8wODwdyh_bBlhxwk6Vo1g8ywel8=.874d57a1-0990-406e-b74e-0b7207a70f02@github.com>
 <rxv94CJtaTg97A6girvDp3iEjOfciBpiZWfLdvYjPas=.422b522b-21b9-4d45-9905-54c09a37ec93@github.com>
Message-ID: <9Y6lZCntKbFfd7vt_4S1uA_DMgoKM_r0ur9py-KJgik=.4ced80c3-ef7b-4e48-a369-4e486de19203@github.com>

On Wed, 13 Nov 2024 14:12:34 GMT, Roger Riggs <rriggs at openjdk.org> wrote:

>> After [JDK-8338411](https://bugs.openjdk.org/browse/JDK-8338411), Serialization implementation dependencies on doPriviledged and AccessController are removed.
>> Some refactoring to cleanup the remaining code is expected.
>
> Roger Riggs has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Remove unnecessary suppress warnings removal
>   ServiceLoader configuration exceptions (in a static initialization) are rethrown as Error.
>   Remove dependency on SecurityException thrown by ServiceLoader (as obsolete)

Marked as reviewed by mullan (Reviewer).

-------------

PR Review: https://git.openjdk.org/jdk/pull/22042#pullrequestreview-2433433270

From alanb at openjdk.org  Wed Nov 13 14:41:57 2024
From: alanb at openjdk.org (Alan Bateman)
Date: Wed, 13 Nov 2024 14:41:57 GMT
Subject: <i18n dev> RFR: 8344039: Remove security manager dependency in
 java.time [v2]
In-Reply-To: <jby7R0SL7l_5JCJZ_4xLbQf2SXPM0NPoAOlTEiEDivs=.72a44c85-1d40-4b60-bbc7-f4b1c82cafe8@github.com>
References: <JWlgY0q0TS7r1RHK8wODwdyh_bBlhxwk6Vo1g8ywel8=.874d57a1-0990-406e-b74e-0b7207a70f02@github.com>
 <rxv94CJtaTg97A6girvDp3iEjOfciBpiZWfLdvYjPas=.422b522b-21b9-4d45-9905-54c09a37ec93@github.com>
 <jby7R0SL7l_5JCJZ_4xLbQf2SXPM0NPoAOlTEiEDivs=.72a44c85-1d40-4b60-bbc7-f4b1c82cafe8@github.com>
Message-ID: <UHnOrnTsL2N0Z0H0SYMUgW8ny82x1PrvKK-QpMjsGwE=.3e5aa5e7-fd78-4d96-864a-495d195fc8d9@github.com>

On Wed, 13 Nov 2024 14:13:59 GMT, Sean Mullan <mullan at openjdk.org> wrote:

>> Roger Riggs has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Remove unnecessary suppress warnings removal
>>   ServiceLoader configuration exceptions (in a static initialization) are rethrown as Error.
>>   Remove dependency on SecurityException thrown by ServiceLoader (as obsolete)
>
> src/java.base/share/classes/java/time/zone/ZoneRulesProvider.java line 1:
> 
>> 1: /*
> 
> Lines 171-172:
> 
>                 if (ex.getCause() instanceof SecurityException) {
>                     continue;  // ignore the security exception, try the next provider
>                 }
> 
> You may be able to remove this code, but may be better to leave it as-is for now until the SL code has been checked for cleanup.

The SL changes are in JDK-8344011.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/22042#discussion_r1840444817

From mullan at openjdk.org  Wed Nov 13 14:46:44 2024
From: mullan at openjdk.org (Sean Mullan)
Date: Wed, 13 Nov 2024 14:46:44 GMT
Subject: <i18n dev> RFR: 8344039: Remove security manager dependency in
 java.time [v2]
In-Reply-To: <rxv94CJtaTg97A6girvDp3iEjOfciBpiZWfLdvYjPas=.422b522b-21b9-4d45-9905-54c09a37ec93@github.com>
References: <JWlgY0q0TS7r1RHK8wODwdyh_bBlhxwk6Vo1g8ywel8=.874d57a1-0990-406e-b74e-0b7207a70f02@github.com>
 <rxv94CJtaTg97A6girvDp3iEjOfciBpiZWfLdvYjPas=.422b522b-21b9-4d45-9905-54c09a37ec93@github.com>
Message-ID: <WWzsZy-Qk5Iak-MBGe4ZOClBqNgkYVXAaqQee6jKtuE=.90e51c28-c6b8-4130-8d2d-8695c37ddfa6@github.com>

On Wed, 13 Nov 2024 14:12:34 GMT, Roger Riggs <rriggs at openjdk.org> wrote:

>> After [JDK-8338411](https://bugs.openjdk.org/browse/JDK-8338411), Serialization implementation dependencies on doPriviledged and AccessController are removed.
>> Some refactoring to cleanup the remaining code is expected.
>
> Roger Riggs has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Remove unnecessary suppress warnings removal
>   ServiceLoader configuration exceptions (in a static initialization) are rethrown as Error.
>   Remove dependency on SecurityException thrown by ServiceLoader (as obsolete)

The PR description above seems to be copied from the serialization PR.

-------------

PR Comment: https://git.openjdk.org/jdk/pull/22042#issuecomment-2473818246

From lancea at openjdk.org  Wed Nov 13 14:46:44 2024
From: lancea at openjdk.org (Lance Andersen)
Date: Wed, 13 Nov 2024 14:46:44 GMT
Subject: <i18n dev> RFR: 8344039: Remove security manager dependency in
 java.time [v2]
In-Reply-To: <rxv94CJtaTg97A6girvDp3iEjOfciBpiZWfLdvYjPas=.422b522b-21b9-4d45-9905-54c09a37ec93@github.com>
References: <JWlgY0q0TS7r1RHK8wODwdyh_bBlhxwk6Vo1g8ywel8=.874d57a1-0990-406e-b74e-0b7207a70f02@github.com>
 <rxv94CJtaTg97A6girvDp3iEjOfciBpiZWfLdvYjPas=.422b522b-21b9-4d45-9905-54c09a37ec93@github.com>
Message-ID: <kZ1reR6ZrflbqcQu0Vs3um0gILGSn7EcMYLmd2JZWLI=.30e900fe-b707-4df2-a6a6-380cbe1b85f1@github.com>

On Wed, 13 Nov 2024 14:12:34 GMT, Roger Riggs <rriggs at openjdk.org> wrote:

>> After [JDK-8338411](https://bugs.openjdk.org/browse/JDK-8338411), Serialization implementation dependencies on doPriviledged and AccessController are removed.
>> Some refactoring to cleanup the remaining code is expected.
>
> Roger Riggs has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Remove unnecessary suppress warnings removal
>   ServiceLoader configuration exceptions (in a static initialization) are rethrown as Error.
>   Remove dependency on SecurityException thrown by ServiceLoader (as obsolete)

Looks good to me Roger

-------------

Marked as reviewed by lancea (Reviewer).

PR Review: https://git.openjdk.org/jdk/pull/22042#pullrequestreview-2433460607

From rriggs at openjdk.org  Wed Nov 13 14:51:07 2024
From: rriggs at openjdk.org (Roger Riggs)
Date: Wed, 13 Nov 2024 14:51:07 GMT
Subject: <i18n dev> RFR: 8344039: Remove security manager dependency in
 java.time [v3]
In-Reply-To: <JWlgY0q0TS7r1RHK8wODwdyh_bBlhxwk6Vo1g8ywel8=.874d57a1-0990-406e-b74e-0b7207a70f02@github.com>
References: <JWlgY0q0TS7r1RHK8wODwdyh_bBlhxwk6Vo1g8ywel8=.874d57a1-0990-406e-b74e-0b7207a70f02@github.com>
Message-ID: <hp7BJFRImE16eDqCGvuvhS9_A6i_V4tbh8gs97uo1aA=.2018e299-f914-43b4-b8c6-481e90f76e38@github.com>

> After [JDK-8338411](https://bugs.openjdk.org/browse/JDK-8338411), Serialization implementation dependencies on doPriviledged and AccessController are removed.
> Some refactoring to cleanup the remaining code is expected.

Roger Riggs has updated the pull request incrementally with one additional commit since the last revision:

  Retain check for SecurityException until ServiceLoader cleanup is complete.

-------------

Changes:
  - all: https://git.openjdk.org/jdk/pull/22042/files
  - new: https://git.openjdk.org/jdk/pull/22042/files/0f2e92f5..23f149e2

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jdk&pr=22042&range=02
 - incr: https://webrevs.openjdk.org/?repo=jdk&pr=22042&range=01-02

  Stats: 4 lines in 1 file changed: 3 ins; 0 del; 1 mod
  Patch: https://git.openjdk.org/jdk/pull/22042.diff
  Fetch: git fetch https://git.openjdk.org/jdk.git pull/22042/head:pull/22042

PR: https://git.openjdk.org/jdk/pull/22042

From acobbs at openjdk.org  Wed Nov 13 15:57:13 2024
From: acobbs at openjdk.org (Archie Cobbs)
Date: Wed, 13 Nov 2024 15:57:13 GMT
Subject: <i18n dev> RFR: 8343476: Remove unnecessary @SuppressWarnings
 annotations (client) [v4]
In-Reply-To: <Sa_OdV-UQBC_8sqALNkC2gOphd6PvXZ9EeisG_If2WQ=.36470214-24b9-457e-9183-24492a0d1df8@github.com>
References: <Sa_OdV-UQBC_8sqALNkC2gOphd6PvXZ9EeisG_If2WQ=.36470214-24b9-457e-9183-24492a0d1df8@github.com>
Message-ID: <anBmdkjT8Ew2fkiwZtNywg2tHgFDYLcsJZxnqFcURfQ=.093f99fe-7da9-456e-a8f4-f9d707cecaa3@github.com>

> Please review this patch which removes unnecessary `@SuppressWarnings` annotations.

Archie Cobbs has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains six additional commits since the last revision:

 - Merge branch 'master' into SuppressWarningsCleanup-client
 - Merge branch 'master' into SuppressWarningsCleanup-client
 - Update copyright years.
 - Merge branch 'master' into SuppressWarningsCleanup-client
 - Merge branch 'master' into SuppressWarningsCleanup-client
 - Remove unnecessary @SuppressWarnings annotations.

-------------

Changes:
  - all: https://git.openjdk.org/jdk/pull/21850/files
  - new: https://git.openjdk.org/jdk/pull/21850/files/211b7051..00b05d93

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jdk&pr=21850&range=03
 - incr: https://webrevs.openjdk.org/?repo=jdk&pr=21850&range=02-03

  Stats: 95172 lines in 2626 files changed: 19948 ins; 68244 del; 6980 mod
  Patch: https://git.openjdk.org/jdk/pull/21850.diff
  Fetch: git fetch https://git.openjdk.org/jdk.git pull/21850/head:pull/21850

PR: https://git.openjdk.org/jdk/pull/21850

From acobbs at openjdk.org  Wed Nov 13 16:32:26 2024
From: acobbs at openjdk.org (Archie Cobbs)
Date: Wed, 13 Nov 2024 16:32:26 GMT
Subject: <i18n dev> RFR: 8343478: Remove unnecessary @SuppressWarnings
 annotations (core-libs) [v5]
In-Reply-To: <9ZqHljyJeMr8fPG4-iU6bfQT9hQxTAwrGCl4xsQn3LA=.0b01f899-d849-4e23-8d50-8f186aade664@github.com>
References: <9ZqHljyJeMr8fPG4-iU6bfQT9hQxTAwrGCl4xsQn3LA=.0b01f899-d849-4e23-8d50-8f186aade664@github.com>
Message-ID: <iqCXfJ4MwX4AbwXNhpEN6_aMMcaSdeEDB4Ag3xR8LNY=.1343bace-e197-4625-a5c5-bb5e2c7f1ce4@github.com>

> Please review this patch which removes unnecessary `@SuppressWarnings` annotations.

Archie Cobbs has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains 10 commits:

 - Merge branch 'master' into SuppressWarningsCleanup-core-libs
 - Put back @SuppressWarnings annotations to be fixed by JDK-8343286.
 - Merge branch 'master' into SuppressWarningsCleanup-core-libs
 - Update copyright years.
 - Remove a few more @SuppressWarnings annotations.
 - Remove a few more @SuppressWarnings annotations.
 - Update copyright years.
 - Merge branch 'master' into SuppressWarningsCleanup-core-libs
 - Merge branch 'master' into SuppressWarningsCleanup-core-libs
 - Remove unnecessary @SuppressWarnings annotations.

-------------

Changes: https://git.openjdk.org/jdk/pull/21852/files
  Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=21852&range=04
  Stats: 187 lines in 94 files changed: 0 ins; 95 del; 92 mod
  Patch: https://git.openjdk.org/jdk/pull/21852.diff
  Fetch: git fetch https://git.openjdk.org/jdk.git pull/21852/head:pull/21852

PR: https://git.openjdk.org/jdk/pull/21852

From acobbs at openjdk.org  Wed Nov 13 18:06:50 2024
From: acobbs at openjdk.org (Archie Cobbs)
Date: Wed, 13 Nov 2024 18:06:50 GMT
Subject: <i18n dev> RFR: 8343478: Remove unnecessary @SuppressWarnings
 annotations (core-libs) [v6]
In-Reply-To: <9ZqHljyJeMr8fPG4-iU6bfQT9hQxTAwrGCl4xsQn3LA=.0b01f899-d849-4e23-8d50-8f186aade664@github.com>
References: <9ZqHljyJeMr8fPG4-iU6bfQT9hQxTAwrGCl4xsQn3LA=.0b01f899-d849-4e23-8d50-8f186aade664@github.com>
Message-ID: <NOQPsQeegsOHLymZgFafYENdx8ZCVcECa6a_mSHvGRY=.746f8151-34fa-48e7-91d9-b614f9bd2d65@github.com>

> Please review this patch which removes unnecessary `@SuppressWarnings` annotations.

Archie Cobbs has updated the pull request incrementally with one additional commit since the last revision:

  Remove more unnecessary warning suppressions.

-------------

Changes:
  - all: https://git.openjdk.org/jdk/pull/21852/files
  - new: https://git.openjdk.org/jdk/pull/21852/files/300c0f98..378ca601

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jdk&pr=21852&range=05
 - incr: https://webrevs.openjdk.org/?repo=jdk&pr=21852&range=04-05

  Stats: 2 lines in 2 files changed: 0 ins; 2 del; 0 mod
  Patch: https://git.openjdk.org/jdk/pull/21852.diff
  Fetch: git fetch https://git.openjdk.org/jdk.git pull/21852/head:pull/21852

PR: https://git.openjdk.org/jdk/pull/21852

From naoto at openjdk.org  Wed Nov 13 18:20:32 2024
From: naoto at openjdk.org (Naoto Sato)
Date: Wed, 13 Nov 2024 18:20:32 GMT
Subject: <i18n dev> RFR: 8344039: Remove security manager dependency in
 java.time [v3]
In-Reply-To: <hp7BJFRImE16eDqCGvuvhS9_A6i_V4tbh8gs97uo1aA=.2018e299-f914-43b4-b8c6-481e90f76e38@github.com>
References: <JWlgY0q0TS7r1RHK8wODwdyh_bBlhxwk6Vo1g8ywel8=.874d57a1-0990-406e-b74e-0b7207a70f02@github.com>
 <hp7BJFRImE16eDqCGvuvhS9_A6i_V4tbh8gs97uo1aA=.2018e299-f914-43b4-b8c6-481e90f76e38@github.com>
Message-ID: <S1pdKdrCIG9_GD2l8Ol8X0kBwz0FcQbkYOtTnHwYyl8=.5c7e1e61-7654-4da2-9b77-4ed5ba8d2c9b@github.com>

On Wed, 13 Nov 2024 14:51:07 GMT, Roger Riggs <rriggs at openjdk.org> wrote:

>> After [JDK-8338411](https://bugs.openjdk.org/browse/JDK-8338411), java.time implementation dependencies on doPriviledged and AccessController are removed.
>> Some refactoring to cleanup the remaining code is expected.
>
> Roger Riggs has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Retain check for SecurityException until ServiceLoader cleanup is complete.

LGTM

-------------

Marked as reviewed by naoto (Reviewer).

PR Review: https://git.openjdk.org/jdk/pull/22042#pullrequestreview-2434088653

From jlu at openjdk.org  Wed Nov 13 19:44:48 2024
From: jlu at openjdk.org (Justin Lu)
Date: Wed, 13 Nov 2024 19:44:48 GMT
Subject: <i18n dev> RFR: 8344025: Remove unused
 ISO2022.Encoder.maximumDesignatorLength
In-Reply-To: <uG52_HJEoX_lMiy2WpVMnlydNg3TQlRnDd2zwaZOJQY=.9c5dcaa9-1f95-41ab-9fe0-fb9a4d710aaf@github.com>
References: <uG52_HJEoX_lMiy2WpVMnlydNg3TQlRnDd2zwaZOJQY=.9c5dcaa9-1f95-41ab-9fe0-fb9a4d710aaf@github.com>
Message-ID: <5jX2NvnFRHykJOCavQqEjqH-BQE2FBye4VfU-jgASjw=.6782379e-5ec1-4b3c-8a0d-44c1422b15b7@github.com>

On Tue, 12 Nov 2024 08:53:38 GMT, Andrey Turbanov <aturbanov at openjdk.org> wrote:

> The field `sun.nio.cs.ext.ISO2022.Encoder#maximumDesignatorLength` appears to be unused.

Looks fine.

-------------

Marked as reviewed by jlu (Committer).

PR Review: https://git.openjdk.org/jdk/pull/22031#pullrequestreview-2434254389

From rriggs at openjdk.org  Wed Nov 13 20:06:12 2024
From: rriggs at openjdk.org (Roger Riggs)
Date: Wed, 13 Nov 2024 20:06:12 GMT
Subject: <i18n dev> Integrated: 8344039: Remove security manager dependency
 in java.time
In-Reply-To: <JWlgY0q0TS7r1RHK8wODwdyh_bBlhxwk6Vo1g8ywel8=.874d57a1-0990-406e-b74e-0b7207a70f02@github.com>
References: <JWlgY0q0TS7r1RHK8wODwdyh_bBlhxwk6Vo1g8ywel8=.874d57a1-0990-406e-b74e-0b7207a70f02@github.com>
Message-ID: <v-E0VR1m_wp3_iFLoV2_88bc0jVQE7OB1H1TtX4tVME=.45591dc4-52c9-4703-b838-11bc0e64c95a@github.com>

On Tue, 12 Nov 2024 15:41:01 GMT, Roger Riggs <rriggs at openjdk.org> wrote:

> After [JDK-8338411](https://bugs.openjdk.org/browse/JDK-8338411), java.time implementation dependencies on doPriviledged and AccessController are removed.
> Some refactoring to cleanup the remaining code is expected.

This pull request has now been integrated.

Changeset: 5ac330b1
Author:    Roger Riggs <rriggs at openjdk.org>
URL:       https://git.openjdk.org/jdk/commit/5ac330b1ac81e932924e0ea10988f2536352be04
Stats:     79 lines in 2 files changed: 1 ins; 32 del; 46 mod

8344039: Remove security manager dependency in java.time

Reviewed-by: naoto, mullan, lancea

-------------

PR: https://git.openjdk.org/jdk/pull/22042

From nbenalla at openjdk.org  Thu Nov 14 01:13:07 2024
From: nbenalla at openjdk.org (Nizar Benalla)
Date: Thu, 14 Nov 2024 01:13:07 GMT
Subject: <i18n dev> RFR: 8343777: Add since checker tests to
 Internationalisation modules [v2]
In-Reply-To: <P18_8XcwZidhLGMVNcpIan2E2FYKKfw-FKyI7k9m1cs=.9e9102a2-5e6a-46fe-a8c6-4a1cbdb48c95@github.com>
References: <P18_8XcwZidhLGMVNcpIan2E2FYKKfw-FKyI7k9m1cs=.9e9102a2-5e6a-46fe-a8c6-4a1cbdb48c95@github.com>
Message-ID: <Qrv_5Ci8q6RDsz---7Crg8_CmnY95IByxBDwinYEVCQ=.75c32d94-8ba0-418a-8b42-d3f7082896f7@github.com>

> Can I please get a review for this PR that add tests to verify the value of `@since` tags to the Internationalisation area modules. The test is described in this [email](https://mail.openjdk.org/pipermail/jdk-dev/2024-October/009474.html). This issue is similar to JDK-8341399, JDK-8331051 and JDK-8343442.
> 
> The benefit from this is helping API authors and reviewer validate the accuracy of `@since` in their source code (and subsequently, in the generated documentation). And lessen the burden on Reviewers.
> 
> The test has been added for `java.base` and a few other modules and has helped catch some bugs before they make it to the JDK.
> 
> TIA

Nizar Benalla has updated the pull request incrementally with one additional commit since the last revision:

  add explanation to test summary, add backsticks when mentionning `@since`

-------------

Changes:
  - all: https://git.openjdk.org/jdk/pull/21985/files
  - new: https://git.openjdk.org/jdk/pull/21985/files/0f60fe56..e286bbea

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jdk&pr=21985&range=01
 - incr: https://webrevs.openjdk.org/?repo=jdk&pr=21985&range=00-01

  Stats: 2 lines in 2 files changed: 0 ins; 0 del; 2 mod
  Patch: https://git.openjdk.org/jdk/pull/21985.diff
  Fetch: git fetch https://git.openjdk.org/jdk.git pull/21985/head:pull/21985

PR: https://git.openjdk.org/jdk/pull/21985

From aturbanov at openjdk.org  Thu Nov 14 07:48:06 2024
From: aturbanov at openjdk.org (Andrey Turbanov)
Date: Thu, 14 Nov 2024 07:48:06 GMT
Subject: <i18n dev> Integrated: 8344025: Remove unused
 ISO2022.Encoder.maximumDesignatorLength
In-Reply-To: <uG52_HJEoX_lMiy2WpVMnlydNg3TQlRnDd2zwaZOJQY=.9c5dcaa9-1f95-41ab-9fe0-fb9a4d710aaf@github.com>
References: <uG52_HJEoX_lMiy2WpVMnlydNg3TQlRnDd2zwaZOJQY=.9c5dcaa9-1f95-41ab-9fe0-fb9a4d710aaf@github.com>
Message-ID: <43cO6XnISFHBOLWW0rqNc8nFnP8PYwKYCkfaNkF9wfQ=.0bfa2793-63ed-4198-87e4-851fc917d2ac@github.com>

On Tue, 12 Nov 2024 08:53:38 GMT, Andrey Turbanov <aturbanov at openjdk.org> wrote:

> The field `sun.nio.cs.ext.ISO2022.Encoder#maximumDesignatorLength` appears to be unused.

This pull request has now been integrated.

Changeset: b54bd824
Author:    Andrey Turbanov <aturbanov at openjdk.org>
URL:       https://git.openjdk.org/jdk/commit/b54bd824b59b6b5dff9278ddebab4e9e2dfaf57b
Stats:     6 lines in 1 file changed: 0 ins; 5 del; 1 mod

8344025: Remove unused ISO2022.Encoder.maximumDesignatorLength

Reviewed-by: naoto, jlu

-------------

PR: https://git.openjdk.org/jdk/pull/22031

From ihse at openjdk.org  Thu Nov 14 12:28:23 2024
From: ihse at openjdk.org (Magnus Ihse Bursie)
Date: Thu, 14 Nov 2024 12:28:23 GMT
Subject: <i18n dev> RFR: 8344191: Build code should not have classpath
 exception
Message-ID: <U0XAHfEgxgfvcpBaj8aOZgQgk0cU-GyAMyeJ9cyJrUA=.84aeedaa-ef83-48e9-9eea-1de1e8d0afd6@github.com>

In several (most? all?) of the build system files, the copyright header includes the classpath exception. This makes no sense, and should be removed. 

I have removed the classpath exception from makefiles, autoconf, shell scripts, properties files, configuration files, IDE support files, build tools and data.

The only places where the classpath exception is still kept in the make directory is as text strings in some build tools, which generate source code that is bundled with `src.zip`, and thus *must* have the classpath exception.

This is a huge and autogenerated, but content-wise trivial, PR, and I know such are hard to review. I recommend looking at the entire diff file instead of checking this file-by-file in the Github web GUI. (That's bound to be a painful experience)

-------------

Commit messages:
 - Update build tools, data and IDE support
 - Update makefiles, autoconf, shell scripts, properties files and configuration files

Changes: https://git.openjdk.org/jdk/pull/22104/files
  Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=22104&range=00
  Issue: https://bugs.openjdk.org/browse/JDK-8344191
  Stats: 2054 lines in 555 files changed: 0 ins; 1118 del; 936 mod
  Patch: https://git.openjdk.org/jdk/pull/22104.diff
  Fetch: git fetch https://git.openjdk.org/jdk.git pull/22104/head:pull/22104

PR: https://git.openjdk.org/jdk/pull/22104

From duke at openjdk.org  Thu Nov 14 13:34:44 2024
From: duke at openjdk.org (Abdelhak Zaaim)
Date: Thu, 14 Nov 2024 13:34:44 GMT
Subject: <i18n dev> RFR: 8344191: Build code should not have classpath
 exception
In-Reply-To: <U0XAHfEgxgfvcpBaj8aOZgQgk0cU-GyAMyeJ9cyJrUA=.84aeedaa-ef83-48e9-9eea-1de1e8d0afd6@github.com>
References: <U0XAHfEgxgfvcpBaj8aOZgQgk0cU-GyAMyeJ9cyJrUA=.84aeedaa-ef83-48e9-9eea-1de1e8d0afd6@github.com>
Message-ID: <_LlSFeUxsE5NIZ1tl6Fx_PV0NiHyVfwlkYD-91GkfOQ=.a5f09f9e-6116-4f3b-8860-c1e21474e213@github.com>

On Thu, 14 Nov 2024 12:22:36 GMT, Magnus Ihse Bursie <ihse at openjdk.org> wrote:

> In several (most? all?) of the build system files, the copyright header includes the classpath exception. This makes no sense, and should be removed. 
> 
> I have removed the classpath exception from makefiles, autoconf, shell scripts, properties files, configuration files, IDE support files, build tools and data.
> 
> The only places where the classpath exception is still kept in the make directory is as text strings in some build tools, which generate source code that is bundled with `src.zip`, and thus *must* have the classpath exception.
> 
> This is a huge and autogenerated, but content-wise trivial, PR, and I know such are hard to review. I recommend looking at the entire diff file instead of checking this file-by-file in the Github web GUI. (That's bound to be a painful experience)

Marked as reviewed by abdelhak-zaaim at github.com (no known OpenJDK username).

-------------

PR Review: https://git.openjdk.org/jdk/pull/22104#pullrequestreview-2436096366

From jjg at openjdk.org  Thu Nov 14 15:26:22 2024
From: jjg at openjdk.org (Jonathan Gibbons)
Date: Thu, 14 Nov 2024 15:26:22 GMT
Subject: <i18n dev> RFR: 8344191: Build code should not have classpath
 exception
In-Reply-To: <U0XAHfEgxgfvcpBaj8aOZgQgk0cU-GyAMyeJ9cyJrUA=.84aeedaa-ef83-48e9-9eea-1de1e8d0afd6@github.com>
References: <U0XAHfEgxgfvcpBaj8aOZgQgk0cU-GyAMyeJ9cyJrUA=.84aeedaa-ef83-48e9-9eea-1de1e8d0afd6@github.com>
Message-ID: <M9HkddCRkOHWT_JM7FBHAO4iFklBcnSdRrMwFYStuv0=.5cc2c74b-c7ec-4d2a-981d-93e1f5c4500a@github.com>

On Thu, 14 Nov 2024 12:22:36 GMT, Magnus Ihse Bursie <ihse at openjdk.org> wrote:

> In several (most? all?) of the build system files, the copyright header includes the classpath exception. This makes no sense, and should be removed. 
> 
> I have removed the classpath exception from makefiles, autoconf, shell scripts, properties files, configuration files, IDE support files, build tools and data.
> 
> The only places where the classpath exception is still kept in the make directory is as text strings in some build tools, which generate source code that is bundled with `src.zip`, and thus *must* have the classpath exception.
> 
> This is a huge and autogenerated, but content-wise trivial, PR, and I know such are hard to review. I recommend looking at the entire diff file instead of checking this file-by-file in the Github web GUI. (That's bound to be a painful experience)

The policy has long been to use Classpath Exception in the `src` and `make` directories, but not in the `test` directories. If you're changing the policy, you might want to check and update any documentation where the policy might be written down.

-------------

PR Comment: https://git.openjdk.org/jdk/pull/22104#issuecomment-2476698524

From jlu at openjdk.org  Thu Nov 14 17:31:41 2024
From: jlu at openjdk.org (Justin Lu)
Date: Thu, 14 Nov 2024 17:31:41 GMT
Subject: <i18n dev> RFR: 8343777: Add since checker tests to
 Internationalisation modules [v2]
In-Reply-To: <Qrv_5Ci8q6RDsz---7Crg8_CmnY95IByxBDwinYEVCQ=.75c32d94-8ba0-418a-8b42-d3f7082896f7@github.com>
References: <P18_8XcwZidhLGMVNcpIan2E2FYKKfw-FKyI7k9m1cs=.9e9102a2-5e6a-46fe-a8c6-4a1cbdb48c95@github.com>
 <Qrv_5Ci8q6RDsz---7Crg8_CmnY95IByxBDwinYEVCQ=.75c32d94-8ba0-418a-8b42-d3f7082896f7@github.com>
Message-ID: <Tacb2n0Ehu3pIO24-WVRlQ8uLMMrag-jlY9fLpyQOZg=.10bdefd5-dfb7-4126-9261-2741d1f336cd@github.com>

On Thu, 14 Nov 2024 01:13:07 GMT, Nizar Benalla <nbenalla at openjdk.org> wrote:

>> Can I please get a review for this PR that add tests to verify the value of `@since` tags to the Internationalisation area modules. The test is described in this [email](https://mail.openjdk.org/pipermail/jdk-dev/2024-October/009474.html). This issue is similar to JDK-8341399, JDK-8331051 and JDK-8343442.
>> 
>> The benefit from this is helping API authors and reviewer validate the accuracy of `@since` in their source code (and subsequently, in the generated documentation). And lessen the burden on Reviewers.
>> 
>> The test has been added for `java.base` and a few other modules and has helped catch some bugs before they make it to the JDK.
>> 
>> TIA
>
> Nizar Benalla has updated the pull request incrementally with one additional commit since the last revision:
> 
>   add explanation to test summary, add backsticks when mentionning `@since`

LGTM w/ the summary clarification

-------------

Marked as reviewed by jlu (Committer).

PR Review: https://git.openjdk.org/jdk/pull/21985#pullrequestreview-2436768808

From naoto at openjdk.org  Thu Nov 14 18:09:43 2024
From: naoto at openjdk.org (Naoto Sato)
Date: Thu, 14 Nov 2024 18:09:43 GMT
Subject: <i18n dev> RFR: 8343777: Add since checker tests to
 Internationalisation modules [v2]
In-Reply-To: <Qrv_5Ci8q6RDsz---7Crg8_CmnY95IByxBDwinYEVCQ=.75c32d94-8ba0-418a-8b42-d3f7082896f7@github.com>
References: <P18_8XcwZidhLGMVNcpIan2E2FYKKfw-FKyI7k9m1cs=.9e9102a2-5e6a-46fe-a8c6-4a1cbdb48c95@github.com>
 <Qrv_5Ci8q6RDsz---7Crg8_CmnY95IByxBDwinYEVCQ=.75c32d94-8ba0-418a-8b42-d3f7082896f7@github.com>
Message-ID: <D0c-YuUOvd1ohYgj-K-xCNsyVbz7JqSxvQigdFXvjnA=.d9df067a-d044-4f2f-9c52-4f32331698f4@github.com>

On Thu, 14 Nov 2024 01:13:07 GMT, Nizar Benalla <nbenalla at openjdk.org> wrote:

>> Can I please get a review for this PR that add tests to verify the value of `@since` tags to the Internationalisation area modules. The test is described in this [email](https://mail.openjdk.org/pipermail/jdk-dev/2024-October/009474.html). This issue is similar to JDK-8341399, JDK-8331051 and JDK-8343442.
>> 
>> The benefit from this is helping API authors and reviewer validate the accuracy of `@since` in their source code (and subsequently, in the generated documentation). And lessen the burden on Reviewers.
>> 
>> The test has been added for `java.base` and a few other modules and has helped catch some bugs before they make it to the JDK.
>> 
>> TIA
>
> Nizar Benalla has updated the pull request incrementally with one additional commit since the last revision:
> 
>   add explanation to test summary, add backsticks when mentionning `@since`

LGTM. Thank you for making the comments.

-------------

Marked as reviewed by naoto (Reviewer).

PR Review: https://git.openjdk.org/jdk/pull/21985#pullrequestreview-2436848962

From prr at openjdk.org  Thu Nov 14 18:50:34 2024
From: prr at openjdk.org (Phil Race)
Date: Thu, 14 Nov 2024 18:50:34 GMT
Subject: <i18n dev> RFR: 8344062: Remove doPrivileged calls from awt and
 beans classes in the java.desktop module
Message-ID: <HqH_hCtljmoDyr7SlqEyCKy5VMnajlnDEOp_BZdR3Ls=.362ae3ff-2e11-46fa-adb8-18df7b1aff7c@github.com>

Remove doPrivileged from java.awt and java.beans packages.
Automated tests pass. SwingSet OK.

-------------

Commit messages:
 - 8344062

Changes: https://git.openjdk.org/jdk/pull/22114/files
  Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=22114&range=00
  Issue: https://bugs.openjdk.org/browse/JDK-8344062
  Stats: 465 lines in 25 files changed: 2 ins; 367 del; 96 mod
  Patch: https://git.openjdk.org/jdk/pull/22114.diff
  Fetch: git fetch https://git.openjdk.org/jdk.git pull/22114/head:pull/22114

PR: https://git.openjdk.org/jdk/pull/22114

From rriggs at openjdk.org  Thu Nov 14 22:17:47 2024
From: rriggs at openjdk.org (Roger Riggs)
Date: Thu, 14 Nov 2024 22:17:47 GMT
Subject: <i18n dev> RFR: 8344252: SM cleanup in java.util classes
Message-ID: <qNhTDnRy7n4KURBP8p5dGB7ugAtoNBJwtxyFBM2LkDA=.d9259c4d-10b3-4fa0-a624-a34b01640589@github.com>

Remove use of doPrivileged and SecurityManager in java.util.

-------------

Commit messages:
 - 8344252: SM cleanup in java.util classes

Changes: https://git.openjdk.org/jdk/pull/22122/files
  Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=22122&range=00
  Issue: https://bugs.openjdk.org/browse/JDK-8344252
  Stats: 367 lines in 13 files changed: 36 ins; 204 del; 127 mod
  Patch: https://git.openjdk.org/jdk/pull/22122.diff
  Fetch: git fetch https://git.openjdk.org/jdk.git pull/22122/head:pull/22122

PR: https://git.openjdk.org/jdk/pull/22122

From naoto at openjdk.org  Thu Nov 14 22:48:16 2024
From: naoto at openjdk.org (Naoto Sato)
Date: Thu, 14 Nov 2024 22:48:16 GMT
Subject: <i18n dev> RFR: 8344252: SM cleanup in java.util classes
In-Reply-To: <qNhTDnRy7n4KURBP8p5dGB7ugAtoNBJwtxyFBM2LkDA=.d9259c4d-10b3-4fa0-a624-a34b01640589@github.com>
References: <qNhTDnRy7n4KURBP8p5dGB7ugAtoNBJwtxyFBM2LkDA=.d9259c4d-10b3-4fa0-a624-a34b01640589@github.com>
Message-ID: <0g8MtkAcfB0kf4ojqySrmBX2pKqc3-yU_xbXGDjBYVE=.4c3caa78-d52d-45b9-b47d-9f050c50b32d@github.com>

On Thu, 14 Nov 2024 22:09:59 GMT, Roger Riggs <rriggs at openjdk.org> wrote:

> Remove use of doPrivileged and SecurityManager in java.util.

src/java.base/share/classes/java/util/Properties.java line 952:

> 950: 
> 951:     private static void writeDateComment(BufferedWriter bw) throws IOException {
> 952:         // value of java.properties.date system property isn't sensitive

Left over comment?

src/java.base/share/classes/java/util/ResourceBundle.java line 1889:

> 1887:                 return s;
> 1888:             }
> 1889:         } catch (ClassNotFoundException e) {}

Suggestion:

        } catch (ClassNotFoundException _) {}

src/java.base/share/classes/java/util/spi/AbstractResourceBundleProvider.java line 82:

> 80:  *
> 81:  * @see <a href="../ResourceBundle.html#resource-bundle-modules">
> 82:  * Resource Bundles and Named Modules</a>

Could be replaced with 

ResourceBundle##resource-bundle-modules
    Resource Bundles and Named Modules

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/22122#discussion_r1842966914
PR Review Comment: https://git.openjdk.org/jdk/pull/22122#discussion_r1842977529
PR Review Comment: https://git.openjdk.org/jdk/pull/22122#discussion_r1842974477

From ihse at openjdk.org  Fri Nov 15 00:10:24 2024
From: ihse at openjdk.org (Magnus Ihse Bursie)
Date: Fri, 15 Nov 2024 00:10:24 GMT
Subject: <i18n dev> RFR: 8344191: Build code should not have classpath
 exception
In-Reply-To: <M9HkddCRkOHWT_JM7FBHAO4iFklBcnSdRrMwFYStuv0=.5cc2c74b-c7ec-4d2a-981d-93e1f5c4500a@github.com>
References: <U0XAHfEgxgfvcpBaj8aOZgQgk0cU-GyAMyeJ9cyJrUA=.84aeedaa-ef83-48e9-9eea-1de1e8d0afd6@github.com>
 <M9HkddCRkOHWT_JM7FBHAO4iFklBcnSdRrMwFYStuv0=.5cc2c74b-c7ec-4d2a-981d-93e1f5c4500a@github.com>
Message-ID: <_ewi33QvJz3HiyEkrJ64eWTUOl52LKXiMkWF4SUfxgM=.33f058b7-f21f-4259-abd2-0cb7e7a2da1a@github.com>

On Thu, 14 Nov 2024 15:23:35 GMT, Jonathan Gibbons <jjg at openjdk.org> wrote:

> The policy has long been to use Classpath Exception in the src and make directories, but not in the test directories. If you're changing the policy, you might want to check and update any documentation where the policy might be written down.

I did not know there was such a policy. My understanding is that the classpath exception only makes sense for java files that are distributed as part of the JDK. That `test` was excluded from classpath should therefore be a logical consequence that it is not distributed. And `src` is not generally using CPE; for instance, Hotspot does not have CPE.

-------------

PR Comment: https://git.openjdk.org/jdk/pull/22104#issuecomment-2477665315

From smarks at openjdk.org  Fri Nov 15 00:17:36 2024
From: smarks at openjdk.org (Stuart Marks)
Date: Fri, 15 Nov 2024 00:17:36 GMT
Subject: <i18n dev> RFR: 8344252: SM cleanup in java.util classes
In-Reply-To: <qNhTDnRy7n4KURBP8p5dGB7ugAtoNBJwtxyFBM2LkDA=.d9259c4d-10b3-4fa0-a624-a34b01640589@github.com>
References: <qNhTDnRy7n4KURBP8p5dGB7ugAtoNBJwtxyFBM2LkDA=.d9259c4d-10b3-4fa0-a624-a34b01640589@github.com>
Message-ID: <EQGyF-i8_8BZA_h4MtP-U18WoXYs5lSxMilKNaTNUjo=.9fe572ce-df0e-470d-b947-d32e8a364602@github.com>

On Thu, 14 Nov 2024 22:09:59 GMT, Roger Riggs <rriggs at openjdk.org> wrote:

> Remove use of doPrivileged and SecurityManager in java.util.

Marked as reviewed by smarks (Reviewer).

I mainly wanted to look at Arrays, and I looked briefly at the other stuff too. All looks good.

-------------

PR Review: https://git.openjdk.org/jdk/pull/22122#pullrequestreview-2437432619
PR Comment: https://git.openjdk.org/jdk/pull/22122#issuecomment-2477672974

From serb at openjdk.org  Fri Nov 15 00:46:24 2024
From: serb at openjdk.org (Sergey Bylokhov)
Date: Fri, 15 Nov 2024 00:46:24 GMT
Subject: <i18n dev> RFR: 8344062: Remove doPrivileged calls from awt and
 beans classes in the java.desktop module
In-Reply-To: <HqH_hCtljmoDyr7SlqEyCKy5VMnajlnDEOp_BZdR3Ls=.362ae3ff-2e11-46fa-adb8-18df7b1aff7c@github.com>
References: <HqH_hCtljmoDyr7SlqEyCKy5VMnajlnDEOp_BZdR3Ls=.362ae3ff-2e11-46fa-adb8-18df7b1aff7c@github.com>
Message-ID: <u0qTKQ9umHuUPTEM2A06X7irCldM81-O1j5Q1y9C-VA=.ed95e86f-9ec6-4e1c-aa88-74d51462651f@github.com>

On Thu, 14 Nov 2024 18:45:00 GMT, Phil Race <prr at openjdk.org> wrote:

> Remove doPrivileged from java.awt and java.beans packages.
> Automated tests pass. SwingSet OK.

Marked as reviewed by serb (Reviewer).

Interestingly, none of the tests had to be updated.

-------------

PR Review: https://git.openjdk.org/jdk/pull/22114#pullrequestreview-2437457976
PR Comment: https://git.openjdk.org/jdk/pull/22114#issuecomment-2477713658

From rriggs at openjdk.org  Fri Nov 15 16:06:41 2024
From: rriggs at openjdk.org (Roger Riggs)
Date: Fri, 15 Nov 2024 16:06:41 GMT
Subject: <i18n dev> RFR: 8344252: SM cleanup in java.util classes [v2]
In-Reply-To: <qNhTDnRy7n4KURBP8p5dGB7ugAtoNBJwtxyFBM2LkDA=.d9259c4d-10b3-4fa0-a624-a34b01640589@github.com>
References: <qNhTDnRy7n4KURBP8p5dGB7ugAtoNBJwtxyFBM2LkDA=.d9259c4d-10b3-4fa0-a624-a34b01640589@github.com>
Message-ID: <cj90fQBlZT8HZwgJIz6dRtGg6HhTrrzYbCLPySTeSWo=.b6e32d55-6676-4d68-a307-88157955e734@github.com>

> Remove use of doPrivileged and SecurityManager in java.util.

Roger Riggs has updated the pull request incrementally with one additional commit since the last revision:

  Applied suggestions from review comments

-------------

Changes:
  - all: https://git.openjdk.org/jdk/pull/22122/files
  - new: https://git.openjdk.org/jdk/pull/22122/files/9021ee53..f8e518f7

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jdk&pr=22122&range=01
 - incr: https://webrevs.openjdk.org/?repo=jdk&pr=22122&range=00-01

  Stats: 3 lines in 3 files changed: 0 ins; 1 del; 2 mod
  Patch: https://git.openjdk.org/jdk/pull/22122.diff
  Fetch: git fetch https://git.openjdk.org/jdk.git pull/22122/head:pull/22122

PR: https://git.openjdk.org/jdk/pull/22122

From naoto at openjdk.org  Fri Nov 15 17:08:12 2024
From: naoto at openjdk.org (Naoto Sato)
Date: Fri, 15 Nov 2024 17:08:12 GMT
Subject: <i18n dev> RFR: 8344252: SM cleanup in java.util classes [v2]
In-Reply-To: <cj90fQBlZT8HZwgJIz6dRtGg6HhTrrzYbCLPySTeSWo=.b6e32d55-6676-4d68-a307-88157955e734@github.com>
References: <qNhTDnRy7n4KURBP8p5dGB7ugAtoNBJwtxyFBM2LkDA=.d9259c4d-10b3-4fa0-a624-a34b01640589@github.com>
 <cj90fQBlZT8HZwgJIz6dRtGg6HhTrrzYbCLPySTeSWo=.b6e32d55-6676-4d68-a307-88157955e734@github.com>
Message-ID: <Au0s3SZgCys6ZkYeRij8qws78ujjpclSw84G2SO1UTs=.f195da55-d664-49f1-b9f2-75d2f9baf012@github.com>

On Fri, 15 Nov 2024 16:06:41 GMT, Roger Riggs <rriggs at openjdk.org> wrote:

>> Remove use of doPrivileged and SecurityManager in java.util.
>
> Roger Riggs has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Applied suggestions from review comments

src/java.base/share/classes/java/util/spi/AbstractResourceBundleProvider.java line 82:

> 80:  *
> 81:  * @see <a href="ResourceBundle##resource-bundle-modules">
> 82:  * Resource Bundles and Named Modules</a>

I think HTML tag is not needed:
Suggestion:

 * @see ResourceBundle##resource-bundle-modules
 * Resource Bundles and Named Modules

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/22122#discussion_r1844187533

From rriggs at openjdk.org  Fri Nov 15 17:52:28 2024
From: rriggs at openjdk.org (Roger Riggs)
Date: Fri, 15 Nov 2024 17:52:28 GMT
Subject: <i18n dev> RFR: 8344252: SM cleanup in java.util classes [v3]
In-Reply-To: <qNhTDnRy7n4KURBP8p5dGB7ugAtoNBJwtxyFBM2LkDA=.d9259c4d-10b3-4fa0-a624-a34b01640589@github.com>
References: <qNhTDnRy7n4KURBP8p5dGB7ugAtoNBJwtxyFBM2LkDA=.d9259c4d-10b3-4fa0-a624-a34b01640589@github.com>
Message-ID: <4MWPGqjfxblaSlsMPqS9V49dZxHfUckyAdopHxdpXFc=.3ba4f181-e96f-4228-afc9-ec2221a2fc45@github.com>

> Remove use of doPrivileged and SecurityManager in java.util.

Roger Riggs has updated the pull request incrementally with one additional commit since the last revision:

  Correct @see link syntax in AbstractResourceBundleProvider

-------------

Changes:
  - all: https://git.openjdk.org/jdk/pull/22122/files
  - new: https://git.openjdk.org/jdk/pull/22122/files/f8e518f7..1a0814ce

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jdk&pr=22122&range=02
 - incr: https://webrevs.openjdk.org/?repo=jdk&pr=22122&range=01-02

  Stats: 2 lines in 1 file changed: 0 ins; 1 del; 1 mod
  Patch: https://git.openjdk.org/jdk/pull/22122.diff
  Fetch: git fetch https://git.openjdk.org/jdk.git pull/22122/head:pull/22122

PR: https://git.openjdk.org/jdk/pull/22122

From naoto at openjdk.org  Fri Nov 15 18:39:58 2024
From: naoto at openjdk.org (Naoto Sato)
Date: Fri, 15 Nov 2024 18:39:58 GMT
Subject: <i18n dev> RFR: 8344252: SM cleanup in java.util classes [v3]
In-Reply-To: <4MWPGqjfxblaSlsMPqS9V49dZxHfUckyAdopHxdpXFc=.3ba4f181-e96f-4228-afc9-ec2221a2fc45@github.com>
References: <qNhTDnRy7n4KURBP8p5dGB7ugAtoNBJwtxyFBM2LkDA=.d9259c4d-10b3-4fa0-a624-a34b01640589@github.com>
 <4MWPGqjfxblaSlsMPqS9V49dZxHfUckyAdopHxdpXFc=.3ba4f181-e96f-4228-afc9-ec2221a2fc45@github.com>
Message-ID: <Q3r0BIlPSFr_npTQd3eJDD9XZ3wMfJmSZrDMD-r-gho=.3fe201a6-f68a-440f-93f3-56a58a5c74ed@github.com>

On Fri, 15 Nov 2024 17:52:28 GMT, Roger Riggs <rriggs at openjdk.org> wrote:

>> Remove use of doPrivileged and SecurityManager in java.util.
>
> Roger Riggs has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Correct @see link syntax in AbstractResourceBundleProvider

LGTM

-------------

Marked as reviewed by naoto (Reviewer).

PR Review: https://git.openjdk.org/jdk/pull/22122#pullrequestreview-2439370295

From prr at openjdk.org  Fri Nov 15 19:05:51 2024
From: prr at openjdk.org (Phil Race)
Date: Fri, 15 Nov 2024 19:05:51 GMT
Subject: <i18n dev> Integrated: 8344062: Remove doPrivileged calls from awt
 and beans classes in the java.desktop module
In-Reply-To: <HqH_hCtljmoDyr7SlqEyCKy5VMnajlnDEOp_BZdR3Ls=.362ae3ff-2e11-46fa-adb8-18df7b1aff7c@github.com>
References: <HqH_hCtljmoDyr7SlqEyCKy5VMnajlnDEOp_BZdR3Ls=.362ae3ff-2e11-46fa-adb8-18df7b1aff7c@github.com>
Message-ID: <zI7TOH1wXhl2eY5yj9hKzES40IJTD4N2RQKgm40Lz4c=.9830eac7-e16d-4012-b2c2-e4941e4adcfb@github.com>

On Thu, 14 Nov 2024 18:45:00 GMT, Phil Race <prr at openjdk.org> wrote:

> Remove doPrivileged from java.awt and java.beans packages.
> Automated tests pass. SwingSet OK.

This pull request has now been integrated.

Changeset: 1bb0d3ba
Author:    Phil Race <prr at openjdk.org>
URL:       https://git.openjdk.org/jdk/commit/1bb0d3baaa3e6b0bf81445f818e74a41394df22b
Stats:     465 lines in 25 files changed: 2 ins; 367 del; 96 mod

8344062: Remove doPrivileged calls from awt and beans classes in the java.desktop module

Reviewed-by: serb

-------------

PR: https://git.openjdk.org/jdk/pull/22114

From prr at openjdk.org  Fri Nov 15 19:30:24 2024
From: prr at openjdk.org (Phil Race)
Date: Fri, 15 Nov 2024 19:30:24 GMT
Subject: <i18n dev> RFR: 8344061: Remove doPrivileged calls from shared
 implementation code in the java.desktop module : part 2
Message-ID: <0ecs2MAtGLHGFdT_GvAnU6168RvQza-I0DF5Fi_KdPU=.92e80dc7-3dbb-47ea-b525-e0ffdcea8435@github.com>

Update 21 desktop module shared implementation files to remove doPrivileged.
All the usual tests still pass.

-------------

Commit messages:
 - 8344061

Changes: https://git.openjdk.org/jdk/pull/22161/files
  Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=22161&range=00
  Issue: https://bugs.openjdk.org/browse/JDK-8344061
  Stats: 1045 lines in 21 files changed: 136 ins; 520 del; 389 mod
  Patch: https://git.openjdk.org/jdk/pull/22161.diff
  Fetch: git fetch https://git.openjdk.org/jdk.git pull/22161/head:pull/22161

PR: https://git.openjdk.org/jdk/pull/22161

From prr at openjdk.org  Fri Nov 15 19:30:24 2024
From: prr at openjdk.org (Phil Race)
Date: Fri, 15 Nov 2024 19:30:24 GMT
Subject: <i18n dev> RFR: 8344061: Remove doPrivileged calls from shared
 implementation code in the java.desktop module : part 2
In-Reply-To: <0ecs2MAtGLHGFdT_GvAnU6168RvQza-I0DF5Fi_KdPU=.92e80dc7-3dbb-47ea-b525-e0ffdcea8435@github.com>
References: <0ecs2MAtGLHGFdT_GvAnU6168RvQza-I0DF5Fi_KdPU=.92e80dc7-3dbb-47ea-b525-e0ffdcea8435@github.com>
Message-ID: <vkyxfbZvRwhV7WPeb_OFEtKSRgCu5BstgK-Qv4XtIX8=.7f83d25a-59e1-488a-85e9-505ec766c0e6@github.com>

On Fri, 15 Nov 2024 19:18:15 GMT, Phil Race <prr at openjdk.org> wrote:

> Update 21 desktop module shared implementation files to remove doPrivileged.
> All the usual tests still pass.

src/java.desktop/share/classes/sun/awt/datatransfer/DataTransferer.java line 1013:

> 1011:     }
> 1012: 
> 1013:     private static ProtectionDomain getUserProtectionDomain(Transferable contents) {

NB this particular source file has a lot more than doPrivileged that we should look at, but I stuck to doPrivileged, as is the brief, and submitted a bug to come back to this file later : https://bugs.openjdk.org/browse/JDK-8344256

src/java.desktop/share/classes/sun/font/CreatedFontTracker.java line 115:

> 113: 
> 114:         private static Thread t = null;
> 115:         @SuppressWarnings("removal")

This whole file may be obsolete now. But I stuck to the doPrivileged brief, and updated the existing tracker clean up bug to include looking at this file : https://bugs.openjdk.org/browse/JDK-8344146

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/22161#discussion_r1844355388
PR Review Comment: https://git.openjdk.org/jdk/pull/22161#discussion_r1844357020

From naoto at openjdk.org  Fri Nov 15 19:32:05 2024
From: naoto at openjdk.org (Naoto Sato)
Date: Fri, 15 Nov 2024 19:32:05 GMT
Subject: <i18n dev> RFR: 8344330: Remove AccessController.doPrivileged()
 from jdk.charsets module
Message-ID: <D9qv9BoD-2vpuLANukXj-KzNrWnODzQR0lgW8IqXrxA=.b6a032fb-f2c0-4474-9abc-ade3bfd2031c@github.com>

Removing a `AccessController.doPrivileged()` call from jdk.charsets module after JEP486 integration.

-------------

Commit messages:
 - initial commit

Changes: https://git.openjdk.org/jdk/pull/22162/files
  Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=22162&range=00
  Issue: https://bugs.openjdk.org/browse/JDK-8344330
  Stats: 12 lines in 1 file changed: 0 ins; 9 del; 3 mod
  Patch: https://git.openjdk.org/jdk/pull/22162.diff
  Fetch: git fetch https://git.openjdk.org/jdk.git pull/22162/head:pull/22162

PR: https://git.openjdk.org/jdk/pull/22162

From lancea at openjdk.org  Fri Nov 15 19:35:55 2024
From: lancea at openjdk.org (Lance Andersen)
Date: Fri, 15 Nov 2024 19:35:55 GMT
Subject: <i18n dev> RFR: 8344330: Remove AccessController.doPrivileged()
 from jdk.charsets module
In-Reply-To: <D9qv9BoD-2vpuLANukXj-KzNrWnODzQR0lgW8IqXrxA=.b6a032fb-f2c0-4474-9abc-ade3bfd2031c@github.com>
References: <D9qv9BoD-2vpuLANukXj-KzNrWnODzQR0lgW8IqXrxA=.b6a032fb-f2c0-4474-9abc-ade3bfd2031c@github.com>
Message-ID: <lvdNwtr7eBc1bqhPXa89G9EZLNb7rLPhzXM2rxaIycs=.1ae64177-3d95-4044-b2fd-b69a7e594448@github.com>

On Fri, 15 Nov 2024 19:26:15 GMT, Naoto Sato <naoto at openjdk.org> wrote:

> Removing a `AccessController.doPrivileged()` call from jdk.charsets module after JEP486 integration.

Marked as reviewed by lancea (Reviewer).

-------------

PR Review: https://git.openjdk.org/jdk/pull/22162#pullrequestreview-2439458103

From bpb at openjdk.org  Fri Nov 15 19:41:48 2024
From: bpb at openjdk.org (Brian Burkhalter)
Date: Fri, 15 Nov 2024 19:41:48 GMT
Subject: <i18n dev> RFR: 8344330: Remove AccessController.doPrivileged()
 from jdk.charsets module
In-Reply-To: <D9qv9BoD-2vpuLANukXj-KzNrWnODzQR0lgW8IqXrxA=.b6a032fb-f2c0-4474-9abc-ade3bfd2031c@github.com>
References: <D9qv9BoD-2vpuLANukXj-KzNrWnODzQR0lgW8IqXrxA=.b6a032fb-f2c0-4474-9abc-ade3bfd2031c@github.com>
Message-ID: <aUCgEKWaQo4QZ_kVrd6RwdqtTLu8uF3T4CQpg5qu270=.cabd94dc-f2ff-446b-b55b-957ebab33339@github.com>

On Fri, 15 Nov 2024 19:26:15 GMT, Naoto Sato <naoto at openjdk.org> wrote:

> Removing a `AccessController.doPrivileged()` call from jdk.charsets module after JEP486 integration.

Looks fine.

-------------

Marked as reviewed by bpb (Reviewer).

PR Review: https://git.openjdk.org/jdk/pull/22162#pullrequestreview-2439470029

From naoto at openjdk.org  Fri Nov 15 20:17:59 2024
From: naoto at openjdk.org (Naoto Sato)
Date: Fri, 15 Nov 2024 20:17:59 GMT
Subject: <i18n dev> RFR: 8344330: Remove AccessController.doPrivileged()
 from jdk.charsets module [v2]
In-Reply-To: <D9qv9BoD-2vpuLANukXj-KzNrWnODzQR0lgW8IqXrxA=.b6a032fb-f2c0-4474-9abc-ade3bfd2031c@github.com>
References: <D9qv9BoD-2vpuLANukXj-KzNrWnODzQR0lgW8IqXrxA=.b6a032fb-f2c0-4474-9abc-ade3bfd2031c@github.com>
Message-ID: <I2oi1fMP0yb47PWlQb31Rw8PKU9DT5qHcG3W13f_ubk=.866bf702-9312-42d6-8d89-6a414a77412e@github.com>

> Removing a `AccessController.doPrivileged()` call from jdk.charsets module after JEP486 integration.

Naoto Sato has updated the pull request incrementally with one additional commit since the last revision:

  fixed import

-------------

Changes:
  - all: https://git.openjdk.org/jdk/pull/22162/files
  - new: https://git.openjdk.org/jdk/pull/22162/files/ebd0523f..03d25e8f

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jdk&pr=22162&range=01
 - incr: https://webrevs.openjdk.org/?repo=jdk&pr=22162&range=00-01

  Stats: 1 line in 1 file changed: 0 ins; 0 del; 1 mod
  Patch: https://git.openjdk.org/jdk/pull/22162.diff
  Fetch: git fetch https://git.openjdk.org/jdk.git pull/22162/head:pull/22162

PR: https://git.openjdk.org/jdk/pull/22162

From rriggs at openjdk.org  Fri Nov 15 20:17:59 2024
From: rriggs at openjdk.org (Roger Riggs)
Date: Fri, 15 Nov 2024 20:17:59 GMT
Subject: <i18n dev> RFR: 8344330: Remove AccessController.doPrivileged()
 from jdk.charsets module [v2]
In-Reply-To: <I2oi1fMP0yb47PWlQb31Rw8PKU9DT5qHcG3W13f_ubk=.866bf702-9312-42d6-8d89-6a414a77412e@github.com>
References: <D9qv9BoD-2vpuLANukXj-KzNrWnODzQR0lgW8IqXrxA=.b6a032fb-f2c0-4474-9abc-ade3bfd2031c@github.com>
 <I2oi1fMP0yb47PWlQb31Rw8PKU9DT5qHcG3W13f_ubk=.866bf702-9312-42d6-8d89-6a414a77412e@github.com>
Message-ID: <KDfDQ0yMi-H3O7fVwMHkOVryETpEYG1dNAwfqH2bqsw=.fe6a54e5-93d3-4979-82f2-e2e1438136d4@github.com>

On Fri, 15 Nov 2024 20:15:10 GMT, Naoto Sato <naoto at openjdk.org> wrote:

>> Removing a `AccessController.doPrivileged()` call from jdk.charsets module after JEP486 integration.
>
> Naoto Sato has updated the pull request incrementally with one additional commit since the last revision:
> 
>   fixed import

looks good.

-------------

Marked as reviewed by rriggs (Reviewer).

PR Review: https://git.openjdk.org/jdk/pull/22162#pullrequestreview-2439536041

From rriggs at openjdk.org  Fri Nov 15 20:31:56 2024
From: rriggs at openjdk.org (Roger Riggs)
Date: Fri, 15 Nov 2024 20:31:56 GMT
Subject: <i18n dev> Integrated: 8344252: SM cleanup in java.util classes
In-Reply-To: <qNhTDnRy7n4KURBP8p5dGB7ugAtoNBJwtxyFBM2LkDA=.d9259c4d-10b3-4fa0-a624-a34b01640589@github.com>
References: <qNhTDnRy7n4KURBP8p5dGB7ugAtoNBJwtxyFBM2LkDA=.d9259c4d-10b3-4fa0-a624-a34b01640589@github.com>
Message-ID: <SZPSz5zQ-2fs6ShL-Q0Q2muKCokIueE73L3jGn_Rjds=.e39ec63d-6f9d-44c3-bb3a-2d68759bcbba@github.com>

On Thu, 14 Nov 2024 22:09:59 GMT, Roger Riggs <rriggs at openjdk.org> wrote:

> Remove use of doPrivileged and SecurityManager in java.util.

This pull request has now been integrated.

Changeset: c5b6ed8c
Author:    Roger Riggs <rriggs at openjdk.org>
URL:       https://git.openjdk.org/jdk/commit/c5b6ed8ca0d4f9862fd6a890bcd457f73582696d
Stats:     369 lines in 13 files changed: 36 ins; 206 del; 127 mod

8344252: SM cleanup in java.util classes

Reviewed-by: naoto, smarks

-------------

PR: https://git.openjdk.org/jdk/pull/22122

From bpb at openjdk.org  Fri Nov 15 23:15:53 2024
From: bpb at openjdk.org (Brian Burkhalter)
Date: Fri, 15 Nov 2024 23:15:53 GMT
Subject: <i18n dev> RFR: 8344330: Remove AccessController.doPrivileged()
 from jdk.charsets module [v2]
In-Reply-To: <I2oi1fMP0yb47PWlQb31Rw8PKU9DT5qHcG3W13f_ubk=.866bf702-9312-42d6-8d89-6a414a77412e@github.com>
References: <D9qv9BoD-2vpuLANukXj-KzNrWnODzQR0lgW8IqXrxA=.b6a032fb-f2c0-4474-9abc-ade3bfd2031c@github.com>
 <I2oi1fMP0yb47PWlQb31Rw8PKU9DT5qHcG3W13f_ubk=.866bf702-9312-42d6-8d89-6a414a77412e@github.com>
Message-ID: <u7ix4dvk3Q-rCODNCtmONmzuVdK36IqG1ITYCTLxBkY=.743d5508-52f9-4d92-a724-7c578e6bb2ce@github.com>

On Fri, 15 Nov 2024 20:17:59 GMT, Naoto Sato <naoto at openjdk.org> wrote:

>> Removing a `AccessController.doPrivileged()` call from jdk.charsets module after JEP486 integration.
>
> Naoto Sato has updated the pull request incrementally with one additional commit since the last revision:
> 
>   fixed import

Updated version looks fine.

-------------

Marked as reviewed by bpb (Reviewer).

PR Review: https://git.openjdk.org/jdk/pull/22162#pullrequestreview-2439914323

From honkar at openjdk.org  Fri Nov 15 23:19:47 2024
From: honkar at openjdk.org (Harshitha Onkar)
Date: Fri, 15 Nov 2024 23:19:47 GMT
Subject: <i18n dev> RFR: 8344061: Remove doPrivileged calls from shared
 implementation code in the java.desktop module : part 2
In-Reply-To: <0ecs2MAtGLHGFdT_GvAnU6168RvQza-I0DF5Fi_KdPU=.92e80dc7-3dbb-47ea-b525-e0ffdcea8435@github.com>
References: <0ecs2MAtGLHGFdT_GvAnU6168RvQza-I0DF5Fi_KdPU=.92e80dc7-3dbb-47ea-b525-e0ffdcea8435@github.com>
Message-ID: <gytKw2yB_DAoueOU2YLiFZvHsQbXD3O2jvdR_h7c6cc=.d513b428-31c3-440d-930a-eb5f65c7eb70@github.com>

On Fri, 15 Nov 2024 19:18:15 GMT, Phil Race <prr at openjdk.org> wrote:

> Update 21 desktop module shared implementation files to remove doPrivileged.
> All the usual tests still pass.

src/java.desktop/share/classes/sun/awt/AppContext.java line 248:

> 246:             new ThreadLocal<AppContext>();
> 247: 
> 248:     //@SuppressWarnings("removal")

`@SuppressWarnings("removal")` is commented out? Probably meant to remove it?

src/java.desktop/share/classes/sun/awt/CausedFocusEvent.java line 73:

> 71:     }
> 72: 
> 73:     //@SuppressWarnings("removal")

Same here - did you mean to remove it?

src/java.desktop/share/classes/sun/awt/FontConfiguration.java line 163:

> 161:         } catch (Exception e) {
> 162:         }
> 163:         return exists.booleanValue();

Looks good since now exists boolean value is returned and doesn't require  return Boolean.FALSE; in catch block.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/22161#discussion_r1844649682
PR Review Comment: https://git.openjdk.org/jdk/pull/22161#discussion_r1844651087
PR Review Comment: https://git.openjdk.org/jdk/pull/22161#discussion_r1844652930

From lancea at openjdk.org  Sat Nov 16 00:06:42 2024
From: lancea at openjdk.org (Lance Andersen)
Date: Sat, 16 Nov 2024 00:06:42 GMT
Subject: <i18n dev> RFR: 8344330: Remove AccessController.doPrivileged()
 from jdk.charsets module [v2]
In-Reply-To: <I2oi1fMP0yb47PWlQb31Rw8PKU9DT5qHcG3W13f_ubk=.866bf702-9312-42d6-8d89-6a414a77412e@github.com>
References: <D9qv9BoD-2vpuLANukXj-KzNrWnODzQR0lgW8IqXrxA=.b6a032fb-f2c0-4474-9abc-ade3bfd2031c@github.com>
 <I2oi1fMP0yb47PWlQb31Rw8PKU9DT5qHcG3W13f_ubk=.866bf702-9312-42d6-8d89-6a414a77412e@github.com>
Message-ID: <fti-qykjyUPhLPAHCtflVlp5R8-ohdNwamRgOcicmkU=.0ba22560-082d-43a8-b83a-b1a6ac0aecf7@github.com>

On Fri, 15 Nov 2024 20:17:59 GMT, Naoto Sato <naoto at openjdk.org> wrote:

>> Removing a `AccessController.doPrivileged()` call from jdk.charsets module after JEP486 integration.
>
> Naoto Sato has updated the pull request incrementally with one additional commit since the last revision:
> 
>   fixed import

Marked as reviewed by lancea (Reviewer).

-------------

PR Review: https://git.openjdk.org/jdk/pull/22162#pullrequestreview-2439986238

From jlu at openjdk.org  Sat Nov 16 01:05:41 2024
From: jlu at openjdk.org (Justin Lu)
Date: Sat, 16 Nov 2024 01:05:41 GMT
Subject: <i18n dev> RFR: 8344330: Remove AccessController.doPrivileged()
 from jdk.charsets module [v2]
In-Reply-To: <I2oi1fMP0yb47PWlQb31Rw8PKU9DT5qHcG3W13f_ubk=.866bf702-9312-42d6-8d89-6a414a77412e@github.com>
References: <D9qv9BoD-2vpuLANukXj-KzNrWnODzQR0lgW8IqXrxA=.b6a032fb-f2c0-4474-9abc-ade3bfd2031c@github.com>
 <I2oi1fMP0yb47PWlQb31Rw8PKU9DT5qHcG3W13f_ubk=.866bf702-9312-42d6-8d89-6a414a77412e@github.com>
Message-ID: <k1lmU1CEpzVUOACEOjyLTdIAEosMQ7iquvYwnPH2r8Y=.91b8d6e9-49c8-4108-8387-9188beda51ab@github.com>

On Fri, 15 Nov 2024 20:17:59 GMT, Naoto Sato <naoto at openjdk.org> wrote:

>> Removing a `AccessController.doPrivileged()` call from jdk.charsets module after JEP486 integration.
>
> Naoto Sato has updated the pull request incrementally with one additional commit since the last revision:
> 
>   fixed import

Marked as reviewed by jlu (Committer).

-------------

PR Review: https://git.openjdk.org/jdk/pull/22162#pullrequestreview-2440013905

From dholmes at openjdk.org  Sat Nov 16 12:24:42 2024
From: dholmes at openjdk.org (David Holmes)
Date: Sat, 16 Nov 2024 12:24:42 GMT
Subject: <i18n dev> RFR: 8344191: Build code should not have classpath
 exception
In-Reply-To: <_ewi33QvJz3HiyEkrJ64eWTUOl52LKXiMkWF4SUfxgM=.33f058b7-f21f-4259-abd2-0cb7e7a2da1a@github.com>
References: <U0XAHfEgxgfvcpBaj8aOZgQgk0cU-GyAMyeJ9cyJrUA=.84aeedaa-ef83-48e9-9eea-1de1e8d0afd6@github.com>
 <M9HkddCRkOHWT_JM7FBHAO4iFklBcnSdRrMwFYStuv0=.5cc2c74b-c7ec-4d2a-981d-93e1f5c4500a@github.com>
 <_ewi33QvJz3HiyEkrJ64eWTUOl52LKXiMkWF4SUfxgM=.33f058b7-f21f-4259-abd2-0cb7e7a2da1a@github.com>
Message-ID: <yBnJF8M2Mq6PH2pwEFI1aHQZcOvjPAubcXJJUBfFtMg=.1c674802-e31e-4f50-9d28-b05b31697604@github.com>

On Fri, 15 Nov 2024 00:07:07 GMT, Magnus Ihse Bursie <ihse at openjdk.org> wrote:

> The policy has long been to use Classpath Exception in the `src` and `make` directories, but not in the `test` directories. If you're changing the policy, you might want to check and update any documentation where the policy might be written down.

What policy is that? The Classpath exception is for executing classfiles. It is meaningless in any other context.

-------------

PR Comment: https://git.openjdk.org/jdk/pull/22104#issuecomment-2480542305

From nbenalla at openjdk.org  Sat Nov 16 20:31:02 2024
From: nbenalla at openjdk.org (Nizar Benalla)
Date: Sat, 16 Nov 2024 20:31:02 GMT
Subject: <i18n dev> RFR: 8343777: Add since checker tests to
 Internationalisation modules [v2]
In-Reply-To: <Qrv_5Ci8q6RDsz---7Crg8_CmnY95IByxBDwinYEVCQ=.75c32d94-8ba0-418a-8b42-d3f7082896f7@github.com>
References: <P18_8XcwZidhLGMVNcpIan2E2FYKKfw-FKyI7k9m1cs=.9e9102a2-5e6a-46fe-a8c6-4a1cbdb48c95@github.com>
 <Qrv_5Ci8q6RDsz---7Crg8_CmnY95IByxBDwinYEVCQ=.75c32d94-8ba0-418a-8b42-d3f7082896f7@github.com>
Message-ID: <GTBqRzF8aS5IoMT4sXTPyL3QOZE22RzVlUXuy9_lT1A=.f0c1fcf4-dd15-40ab-8787-fc2a588afc22@github.com>

On Thu, 14 Nov 2024 01:13:07 GMT, Nizar Benalla <nbenalla at openjdk.org> wrote:

>> Can I please get a review for this PR that add tests to verify the value of `@since` tags to the Internationalisation area modules. The test is described in this [email](https://mail.openjdk.org/pipermail/jdk-dev/2024-October/009474.html). This issue is similar to JDK-8341399, JDK-8331051 and JDK-8343442.
>> 
>> The benefit from this is helping API authors and reviewer validate the accuracy of `@since` in their source code (and subsequently, in the generated documentation). And lessen the burden on Reviewers.
>> 
>> The test has been added for `java.base` and a few other modules and has helped catch some bugs before they make it to the JDK.
>> 
>> TIA
>
> Nizar Benalla has updated the pull request incrementally with one additional commit since the last revision:
> 
>   add explanation to test summary, add backsticks when mentionning `@since`

Thank you for the reviews, I hope those comments are helpful to people.

-------------

PR Comment: https://git.openjdk.org/jdk/pull/21985#issuecomment-2480798480

From nbenalla at openjdk.org  Sat Nov 16 20:31:02 2024
From: nbenalla at openjdk.org (Nizar Benalla)
Date: Sat, 16 Nov 2024 20:31:02 GMT
Subject: <i18n dev> Integrated: 8343777: Add since checker tests to
 Internationalisation modules
In-Reply-To: <P18_8XcwZidhLGMVNcpIan2E2FYKKfw-FKyI7k9m1cs=.9e9102a2-5e6a-46fe-a8c6-4a1cbdb48c95@github.com>
References: <P18_8XcwZidhLGMVNcpIan2E2FYKKfw-FKyI7k9m1cs=.9e9102a2-5e6a-46fe-a8c6-4a1cbdb48c95@github.com>
Message-ID: <DU4PFUhWOM4o45dIvxsA_Bj7KUb5KQNpEdul-KCk3iU=.bd5bc370-b340-4dab-8487-7b61a6dd1272@github.com>

On Fri, 8 Nov 2024 15:20:29 GMT, Nizar Benalla <nbenalla at openjdk.org> wrote:

> Can I please get a review for this PR that add tests to verify the value of `@since` tags to the Internationalisation area modules. The test is described in this [email](https://mail.openjdk.org/pipermail/jdk-dev/2024-October/009474.html). This issue is similar to JDK-8341399, JDK-8331051 and JDK-8343442.
> 
> The benefit from this is helping API authors and reviewer validate the accuracy of `@since` in their source code (and subsequently, in the generated documentation). And lessen the burden on Reviewers.
> 
> The test has been added for `java.base` and a few other modules and has helped catch some bugs before they make it to the JDK.
> 
> TIA

This pull request has now been integrated.

Changeset: fec0d1cf
Author:    Nizar Benalla <nbenalla at openjdk.org>
URL:       https://git.openjdk.org/jdk/commit/fec0d1cf5b1e219db3f58c271939b0dbb291404e
Stats:     60 lines in 2 files changed: 60 ins; 0 del; 0 mod

8343777: Add since checker tests to Internationalisation modules

Reviewed-by: jlu, naoto

-------------

PR: https://git.openjdk.org/jdk/pull/21985

From prr at openjdk.org  Sun Nov 17 06:07:07 2024
From: prr at openjdk.org (Phil Race)
Date: Sun, 17 Nov 2024 06:07:07 GMT
Subject: <i18n dev> RFR: 8344061: Remove doPrivileged calls from shared
 implementation code in the java.desktop module : part 2 [v2]
In-Reply-To: <0ecs2MAtGLHGFdT_GvAnU6168RvQza-I0DF5Fi_KdPU=.92e80dc7-3dbb-47ea-b525-e0ffdcea8435@github.com>
References: <0ecs2MAtGLHGFdT_GvAnU6168RvQza-I0DF5Fi_KdPU=.92e80dc7-3dbb-47ea-b525-e0ffdcea8435@github.com>
Message-ID: <nsosE_nMjgVU8rG4bsAyVKuVDtNHzn-hkLe7XYdbZYs=.725ba993-1886-4285-83f4-fe3392df7af8@github.com>

> Update 21 desktop module shared implementation files to remove doPrivileged.
> All the usual tests still pass.

Phil Race has updated the pull request incrementally with one additional commit since the last revision:

  8344061

-------------

Changes:
  - all: https://git.openjdk.org/jdk/pull/22161/files
  - new: https://git.openjdk.org/jdk/pull/22161/files/b4bb1cef..00441d79

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jdk&pr=22161&range=01
 - incr: https://webrevs.openjdk.org/?repo=jdk&pr=22161&range=00-01

  Stats: 2 lines in 2 files changed: 0 ins; 2 del; 0 mod
  Patch: https://git.openjdk.org/jdk/pull/22161.diff
  Fetch: git fetch https://git.openjdk.org/jdk.git pull/22161/head:pull/22161

PR: https://git.openjdk.org/jdk/pull/22161

From prr at openjdk.org  Sun Nov 17 06:07:07 2024
From: prr at openjdk.org (Phil Race)
Date: Sun, 17 Nov 2024 06:07:07 GMT
Subject: <i18n dev> RFR: 8344061: Remove doPrivileged calls from shared
 implementation code in the java.desktop module : part 2 [v2]
In-Reply-To: <gytKw2yB_DAoueOU2YLiFZvHsQbXD3O2jvdR_h7c6cc=.d513b428-31c3-440d-930a-eb5f65c7eb70@github.com>
References: <0ecs2MAtGLHGFdT_GvAnU6168RvQza-I0DF5Fi_KdPU=.92e80dc7-3dbb-47ea-b525-e0ffdcea8435@github.com>
 <gytKw2yB_DAoueOU2YLiFZvHsQbXD3O2jvdR_h7c6cc=.d513b428-31c3-440d-930a-eb5f65c7eb70@github.com>
Message-ID: <qjkjvy_DsUdLdRb0tReygdjOgRXqKblQ70J2SlqEjp4=.0fe035e4-6b9b-4386-b8ae-6f932c46abb0@github.com>

On Fri, 15 Nov 2024 23:04:31 GMT, Harshitha Onkar <honkar at openjdk.org> wrote:

>> Phil Race has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   8344061
>
> src/java.desktop/share/classes/sun/awt/AppContext.java line 248:
> 
>> 246:             new ThreadLocal<AppContext>();
>> 247: 
>> 248:     //@SuppressWarnings("removal")
> 
> `@SuppressWarnings("removal")` is commented out? Probably meant to remove it?

ok

> src/java.desktop/share/classes/sun/awt/CausedFocusEvent.java line 73:
> 
>> 71:     }
>> 72: 
>> 73:     //@SuppressWarnings("removal")
> 
> Same here - did you mean to remove it?

effectively is removed. deleted

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/22161#discussion_r1845297916
PR Review Comment: https://git.openjdk.org/jdk/pull/22161#discussion_r1845297959

From psadhukhan at openjdk.org  Sun Nov 17 11:13:46 2024
From: psadhukhan at openjdk.org (Prasanta Sadhukhan)
Date: Sun, 17 Nov 2024 11:13:46 GMT
Subject: <i18n dev> RFR: 8344061: Remove doPrivileged calls from shared
 implementation code in the java.desktop module : part 2 [v2]
In-Reply-To: <nsosE_nMjgVU8rG4bsAyVKuVDtNHzn-hkLe7XYdbZYs=.725ba993-1886-4285-83f4-fe3392df7af8@github.com>
References: <0ecs2MAtGLHGFdT_GvAnU6168RvQza-I0DF5Fi_KdPU=.92e80dc7-3dbb-47ea-b525-e0ffdcea8435@github.com>
 <nsosE_nMjgVU8rG4bsAyVKuVDtNHzn-hkLe7XYdbZYs=.725ba993-1886-4285-83f4-fe3392df7af8@github.com>
Message-ID: <kWZOz4ZZklCcqZh89VC82bSE_h3cXNh3SjU83whryYY=.57ac4833-d92a-42c4-9764-6928a3bd17ec@github.com>

On Sun, 17 Nov 2024 06:07:07 GMT, Phil Race <prr at openjdk.org> wrote:

>> Update 21 desktop module shared implementation files to remove doPrivileged.
>> All the usual tests still pass.
>
> Phil Race has updated the pull request incrementally with one additional commit since the last revision:
> 
>   8344061

src/java.desktop/share/classes/sun/font/CreatedFontTracker.java line 131:

> 129:                      */
> 130:                     t.setContextClassLoader(null);
> 131:                     Runtime.getRuntime().addShutdownHook(t);

addShutdownHook is removed? accidentally?

src/java.desktop/share/classes/sun/font/SunLayoutEngine.java line 168:

> 166:     static boolean useFFM = true;
> 167:     static {
> 168:         @SuppressWarnings("removal")

SuppressWarning required?

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/22161#discussion_r1845409403
PR Review Comment: https://git.openjdk.org/jdk/pull/22161#discussion_r1845410575

From prr at openjdk.org  Sun Nov 17 20:59:29 2024
From: prr at openjdk.org (Phil Race)
Date: Sun, 17 Nov 2024 20:59:29 GMT
Subject: <i18n dev> RFR: 8344061: Remove doPrivileged calls from shared
 implementation code in the java.desktop module : part 2 [v3]
In-Reply-To: <0ecs2MAtGLHGFdT_GvAnU6168RvQza-I0DF5Fi_KdPU=.92e80dc7-3dbb-47ea-b525-e0ffdcea8435@github.com>
References: <0ecs2MAtGLHGFdT_GvAnU6168RvQza-I0DF5Fi_KdPU=.92e80dc7-3dbb-47ea-b525-e0ffdcea8435@github.com>
Message-ID: <4Lhg9jCIAJUc1boDnowUeWxK12-u2pU5fyUCh4EqQHk=.eb1e1e88-8ae4-42b3-98f9-bb7ad2866905@github.com>

> Update 21 desktop module shared implementation files to remove doPrivileged.
> All the usual tests still pass.

Phil Race has updated the pull request incrementally with one additional commit since the last revision:

  8344061

-------------

Changes:
  - all: https://git.openjdk.org/jdk/pull/22161/files
  - new: https://git.openjdk.org/jdk/pull/22161/files/00441d79..86509da0

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jdk&pr=22161&range=02
 - incr: https://webrevs.openjdk.org/?repo=jdk&pr=22161&range=01-02

  Stats: 2 lines in 2 files changed: 1 ins; 1 del; 0 mod
  Patch: https://git.openjdk.org/jdk/pull/22161.diff
  Fetch: git fetch https://git.openjdk.org/jdk.git pull/22161/head:pull/22161

PR: https://git.openjdk.org/jdk/pull/22161

From prr at openjdk.org  Sun Nov 17 20:59:29 2024
From: prr at openjdk.org (Phil Race)
Date: Sun, 17 Nov 2024 20:59:29 GMT
Subject: <i18n dev> RFR: 8344061: Remove doPrivileged calls from shared
 implementation code in the java.desktop module : part 2 [v3]
In-Reply-To: <kWZOz4ZZklCcqZh89VC82bSE_h3cXNh3SjU83whryYY=.57ac4833-d92a-42c4-9764-6928a3bd17ec@github.com>
References: <0ecs2MAtGLHGFdT_GvAnU6168RvQza-I0DF5Fi_KdPU=.92e80dc7-3dbb-47ea-b525-e0ffdcea8435@github.com>
 <nsosE_nMjgVU8rG4bsAyVKuVDtNHzn-hkLe7XYdbZYs=.725ba993-1886-4285-83f4-fe3392df7af8@github.com>
 <kWZOz4ZZklCcqZh89VC82bSE_h3cXNh3SjU83whryYY=.57ac4833-d92a-42c4-9764-6928a3bd17ec@github.com>
Message-ID: <Tg2m979cAI7spVsWaOjV6QKcWQRLzl2MQYejqp0bkHg=.61441171-e5aa-4c2f-83fa-15290f556534@github.com>

On Sun, 17 Nov 2024 11:00:35 GMT, Prasanta Sadhukhan <psadhukhan at openjdk.org> wrote:

>> Phil Race has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   8344061
>
> src/java.desktop/share/classes/sun/font/CreatedFontTracker.java line 131:
> 
>> 129:                      */
>> 130:                     t.setContextClassLoader(null);
>> 131:                     Runtime.getRuntime().addShutdownHook(t);
> 
> addShutdownHook is removed? accidentally?

oops, fixed

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/22161#discussion_r1845642360

From prr at openjdk.org  Sun Nov 17 20:59:30 2024
From: prr at openjdk.org (Phil Race)
Date: Sun, 17 Nov 2024 20:59:30 GMT
Subject: <i18n dev> RFR: 8344061: Remove doPrivileged calls from shared
 implementation code in the java.desktop module : part 2 [v2]
In-Reply-To: <kWZOz4ZZklCcqZh89VC82bSE_h3cXNh3SjU83whryYY=.57ac4833-d92a-42c4-9764-6928a3bd17ec@github.com>
References: <0ecs2MAtGLHGFdT_GvAnU6168RvQza-I0DF5Fi_KdPU=.92e80dc7-3dbb-47ea-b525-e0ffdcea8435@github.com>
 <nsosE_nMjgVU8rG4bsAyVKuVDtNHzn-hkLe7XYdbZYs=.725ba993-1886-4285-83f4-fe3392df7af8@github.com>
 <kWZOz4ZZklCcqZh89VC82bSE_h3cXNh3SjU83whryYY=.57ac4833-d92a-42c4-9764-6928a3bd17ec@github.com>
Message-ID: <ukTtfjqEdhPhm8U0qjh8DF5cl79j1kfh2RT28Kh9rZk=.caaebf16-47f9-4b86-b77e-210e3f3f40ee@github.com>

On Sun, 17 Nov 2024 11:07:28 GMT, Prasanta Sadhukhan <psadhukhan at openjdk.org> wrote:

>> Phil Race has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   8344061
>
> src/java.desktop/share/classes/sun/font/SunLayoutEngine.java line 168:
> 
>> 166:     static boolean useFFM = true;
>> 167:     static {
>> 168:         @SuppressWarnings("removal")
> 
> SuppressWarning required?

fixed

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/22161#discussion_r1845642485

From jlu at openjdk.org  Mon Nov 18 00:19:02 2024
From: jlu at openjdk.org (Justin Lu)
Date: Mon, 18 Nov 2024 00:19:02 GMT
Subject: <i18n dev> RFR: 8343237: Improve the copying of the available
 set of Currencies
In-Reply-To: <PuaktdmoJvTll6jpRanMGp6RoG85xw-FSn86s9IA0xQ=.f2db1c2e-3b14-48d3-a8f4-92a4ae338f52@github.com>
References: <PuaktdmoJvTll6jpRanMGp6RoG85xw-FSn86s9IA0xQ=.f2db1c2e-3b14-48d3-a8f4-92a4ae338f52@github.com>
Message-ID: <rO1pkNCeOTcctrBGTXn0fj0x99NkFNfkW_M4xkgrYfs=.b40f948a-ddcd-4075-9d56-7f90bff6e5e7@github.com>

On Fri, 1 Nov 2024 23:17:01 GMT, Justin Lu <jlu at openjdk.org> wrote:

> Please review this PR which is a small cleanup in `Currency.getAvailableCurrencies()`. We can use the `HashSet` constructor over `clone()` to make the defensive copy of the set of available currencies. This gets rid of the unsightly unchecked cast and SuppressWarnings annotation.

Thanks for the review.

-------------

PR Comment: https://git.openjdk.org/jdk/pull/21845#issuecomment-2481695608

From jlu at openjdk.org  Mon Nov 18 00:19:02 2024
From: jlu at openjdk.org (Justin Lu)
Date: Mon, 18 Nov 2024 00:19:02 GMT
Subject: <i18n dev> Integrated: 8343237: Improve the copying of the
 available set of Currencies
In-Reply-To: <PuaktdmoJvTll6jpRanMGp6RoG85xw-FSn86s9IA0xQ=.f2db1c2e-3b14-48d3-a8f4-92a4ae338f52@github.com>
References: <PuaktdmoJvTll6jpRanMGp6RoG85xw-FSn86s9IA0xQ=.f2db1c2e-3b14-48d3-a8f4-92a4ae338f52@github.com>
Message-ID: <GzwJayK7_OpTGZhKkSszMS2dAsfNcBZHsnWqMHRETI4=.74d4a3eb-f90e-413d-956a-d88a8cd008be@github.com>

On Fri, 1 Nov 2024 23:17:01 GMT, Justin Lu <jlu at openjdk.org> wrote:

> Please review this PR which is a small cleanup in `Currency.getAvailableCurrencies()`. We can use the `HashSet` constructor over `clone()` to make the defensive copy of the set of available currencies. This gets rid of the unsightly unchecked cast and SuppressWarnings annotation.

This pull request has now been integrated.

Changeset: e1c4b497
Author:    Justin Lu <jlu at openjdk.org>
URL:       https://git.openjdk.org/jdk/commit/e1c4b4977ec613efe4f51151433e242a256204ee
Stats:     4 lines in 1 file changed: 0 ins; 3 del; 1 mod

8343237: Improve the copying of the available set of Currencies

Reviewed-by: bpb

-------------

PR: https://git.openjdk.org/jdk/pull/21845

From jlu at openjdk.org  Mon Nov 18 07:45:57 2024
From: jlu at openjdk.org (Justin Lu)
Date: Mon, 18 Nov 2024 07:45:57 GMT
Subject: <i18n dev> RFR: 8341923: java.util.Locale class specification
 improvements
Message-ID: <a8ibOqDLUAn4-KOJtPQtD-FKDX73ZnvMI51UWLuDhPY=.f48b60d9-fe3b-401a-a952-38bbcc6cd843@github.com>

Please review this PR and corresponding CSR which includes a wide range of specification improvements for java.util.Locale. See the CSR for further detail. Other changes/suggestions are welcomed to be included as part of this change. Alternatively the diffs can be viewed on the API diff link attached on the CSR.

-------------

Commit messages:
 - remove the manual dashes
 - init

Changes: https://git.openjdk.org/jdk/pull/22192/files
  Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=22192&range=00
  Issue: https://bugs.openjdk.org/browse/JDK-8341923
  Stats: 298 lines in 1 file changed: 101 ins; 87 del; 110 mod
  Patch: https://git.openjdk.org/jdk/pull/22192.diff
  Fetch: git fetch https://git.openjdk.org/jdk.git pull/22192/head:pull/22192

PR: https://git.openjdk.org/jdk/pull/22192

From rriggs at openjdk.org  Mon Nov 18 14:58:09 2024
From: rriggs at openjdk.org (Roger Riggs)
Date: Mon, 18 Nov 2024 14:58:09 GMT
Subject: <i18n dev> RFR: 8344330: Remove AccessController.doPrivileged()
 from jdk.charsets module [v2]
In-Reply-To: <I2oi1fMP0yb47PWlQb31Rw8PKU9DT5qHcG3W13f_ubk=.866bf702-9312-42d6-8d89-6a414a77412e@github.com>
References: <D9qv9BoD-2vpuLANukXj-KzNrWnODzQR0lgW8IqXrxA=.b6a032fb-f2c0-4474-9abc-ade3bfd2031c@github.com>
 <I2oi1fMP0yb47PWlQb31Rw8PKU9DT5qHcG3W13f_ubk=.866bf702-9312-42d6-8d89-6a414a77412e@github.com>
Message-ID: <VvC4fSK1bQ0zHD1v2W2Odv3-aAE6DbxwI_h0rh95E1Y=.4fa68137-fe71-4c48-8052-badb1cc502d1@github.com>

On Fri, 15 Nov 2024 20:17:59 GMT, Naoto Sato <naoto at openjdk.org> wrote:

>> Removing a `AccessController.doPrivileged()` call from jdk.charsets module after JEP486 integration.
>
> Naoto Sato has updated the pull request incrementally with one additional commit since the last revision:
> 
>   fixed import

Marked as reviewed by rriggs (Reviewer).

-------------

PR Review: https://git.openjdk.org/jdk/pull/22162#pullrequestreview-2442860753

From aivanov at openjdk.org  Mon Nov 18 18:03:47 2024
From: aivanov at openjdk.org (Alexey Ivanov)
Date: Mon, 18 Nov 2024 18:03:47 GMT
Subject: <i18n dev> RFR: 8344061: Remove doPrivileged calls from shared
 implementation code in the java.desktop module : part 2 [v3]
In-Reply-To: <4Lhg9jCIAJUc1boDnowUeWxK12-u2pU5fyUCh4EqQHk=.eb1e1e88-8ae4-42b3-98f9-bb7ad2866905@github.com>
References: <0ecs2MAtGLHGFdT_GvAnU6168RvQza-I0DF5Fi_KdPU=.92e80dc7-3dbb-47ea-b525-e0ffdcea8435@github.com>
 <4Lhg9jCIAJUc1boDnowUeWxK12-u2pU5fyUCh4EqQHk=.eb1e1e88-8ae4-42b3-98f9-bb7ad2866905@github.com>
Message-ID: <k8lcIwC4WUhz4WBilPOKw1NDufe4brY5DXHrh4ZtuRA=.ddeaffe5-7a6b-46e2-bdfe-5208b8b2d3a1@github.com>

On Sun, 17 Nov 2024 20:59:29 GMT, Phil Race <prr at openjdk.org> wrote:

>> Update 21 desktop module shared implementation files to remove doPrivileged.
>> All the usual tests still pass.
>
> Phil Race has updated the pull request incrementally with one additional commit since the last revision:
> 
>   8344061

Changes requested by aivanov (Reviewer).

src/java.desktop/share/classes/sun/awt/AppContext.java line 521:

> 519:                 // Create a thread that belongs to the thread group associated
> 520:                 // with the AppContext and invokes EventQueue.postEvent.
> 521:                 Thread thread = new Thread(r);

Previously, the thread was created in the app context thread group and the properties of the created thread were modified, such as its priority and daemon flag.

https://github.com/openjdk/jdk/blob/d76b5b888e15b507631068f508e261cab75c841e/src/java.desktop/share/classes/sun/awt/AppContext.java#L559-L563

src/java.desktop/share/classes/sun/awt/FontConfiguration.java line 163:

> 161:         } catch (Exception e) {
> 162:         }
> 163:         return exists.booleanValue();

Suggestion:

        try {
            File f = new File(fileName);
            return f.exists();
        } catch (Exception e) {
            return false;
        }

In this case, no variable is need.

If you prefer to have the variable, it can now be of primitive type `boolean`.

Can an exception be thrown at all? Neither `new File` nor `f.exists()` throw a checked exception.

src/java.desktop/share/classes/sun/font/CreatedFontTracker.java line 1:

> 1: /*

The following imports are unused now:

import java.security.AccessController;
import java.security.PrivilegedAction;

src/java.desktop/share/classes/sun/font/FileFont.java line 38:

> 36: import sun.java2d.DisposerRecord;
> 37: 
> 38: import java.io.IOException;

`java.io.IOException` is unused now.

src/java.desktop/share/classes/sun/font/SunFontManager.java line 1705:

> 1703:                 f = new File(pathDirs[p] + File.separator + s);
> 1704:                 if (f.exists()) {
> 1705:                     path = f.getAbsolutePath();

This can now be

return f.getAbsolutePath();

Then `path` variable can be removed.

-------------

PR Review: https://git.openjdk.org/jdk/pull/22161#pullrequestreview-2443244947
PR Review Comment: https://git.openjdk.org/jdk/pull/22161#discussion_r1847001461
PR Review Comment: https://git.openjdk.org/jdk/pull/22161#discussion_r1846985440
PR Review Comment: https://git.openjdk.org/jdk/pull/22161#discussion_r1847022204
PR Review Comment: https://git.openjdk.org/jdk/pull/22161#discussion_r1847024301
PR Review Comment: https://git.openjdk.org/jdk/pull/22161#discussion_r1846971254

From naoto at openjdk.org  Mon Nov 18 18:24:55 2024
From: naoto at openjdk.org (Naoto Sato)
Date: Mon, 18 Nov 2024 18:24:55 GMT
Subject: <i18n dev> RFR: 8344330: Remove AccessController.doPrivileged()
 from jdk.charsets module [v2]
In-Reply-To: <I2oi1fMP0yb47PWlQb31Rw8PKU9DT5qHcG3W13f_ubk=.866bf702-9312-42d6-8d89-6a414a77412e@github.com>
References: <D9qv9BoD-2vpuLANukXj-KzNrWnODzQR0lgW8IqXrxA=.b6a032fb-f2c0-4474-9abc-ade3bfd2031c@github.com>
 <I2oi1fMP0yb47PWlQb31Rw8PKU9DT5qHcG3W13f_ubk=.866bf702-9312-42d6-8d89-6a414a77412e@github.com>
Message-ID: <WczcXqXBNNc65alyRCEp03ofhcQnSEEETVKcEZXOvXU=.ee032011-4057-4a21-8337-93dcd703624b@github.com>

On Fri, 15 Nov 2024 20:17:59 GMT, Naoto Sato <naoto at openjdk.org> wrote:

>> Removing a `AccessController.doPrivileged()` call from jdk.charsets module after JEP486 integration.
>
> Naoto Sato has updated the pull request incrementally with one additional commit since the last revision:
> 
>   fixed import

Thank you for your reviews!

-------------

PR Comment: https://git.openjdk.org/jdk/pull/22162#issuecomment-2483799286

From naoto at openjdk.org  Mon Nov 18 18:24:56 2024
From: naoto at openjdk.org (Naoto Sato)
Date: Mon, 18 Nov 2024 18:24:56 GMT
Subject: <i18n dev> Integrated: 8344330: Remove
 AccessController.doPrivileged() from jdk.charsets module
In-Reply-To: <D9qv9BoD-2vpuLANukXj-KzNrWnODzQR0lgW8IqXrxA=.b6a032fb-f2c0-4474-9abc-ade3bfd2031c@github.com>
References: <D9qv9BoD-2vpuLANukXj-KzNrWnODzQR0lgW8IqXrxA=.b6a032fb-f2c0-4474-9abc-ade3bfd2031c@github.com>
Message-ID: <uQ0jSNtYfmGheaGR6ZTjsW2r0Q_UQVAvSsvCKKCDJnA=.7c6957f3-f5c9-4ec8-a806-0185bcac1f10@github.com>

On Fri, 15 Nov 2024 19:26:15 GMT, Naoto Sato <naoto at openjdk.org> wrote:

> Removing a `AccessController.doPrivileged()` call from jdk.charsets module after JEP486 integration.

This pull request has now been integrated.

Changeset: c59adf68
Author:    Naoto Sato <naoto at openjdk.org>
URL:       https://git.openjdk.org/jdk/commit/c59adf68d9ac49b41fb778041e3949a8057e8d7f
Stats:     12 lines in 1 file changed: 0 ins; 9 del; 3 mod

8344330: Remove AccessController.doPrivileged() from jdk.charsets module

Reviewed-by: lancea, bpb, rriggs, jlu

-------------

PR: https://git.openjdk.org/jdk/pull/22162

From liach at openjdk.org  Mon Nov 18 21:06:00 2024
From: liach at openjdk.org (Chen Liang)
Date: Mon, 18 Nov 2024 21:06:00 GMT
Subject: <i18n dev> RFR: 8341923: java.util.Locale class specification
 improvements
In-Reply-To: <a8ibOqDLUAn4-KOJtPQtD-FKDX73ZnvMI51UWLuDhPY=.f48b60d9-fe3b-401a-a952-38bbcc6cd843@github.com>
References: <a8ibOqDLUAn4-KOJtPQtD-FKDX73ZnvMI51UWLuDhPY=.f48b60d9-fe3b-401a-a952-38bbcc6cd843@github.com>
Message-ID: <O57GqoLTBEtabzWDMOeoOAXR20htwuHtTBBHHxbKCYw=.0c083485-8426-4fb6-9957-9726594a7e43@github.com>

On Mon, 18 Nov 2024 07:41:31 GMT, Justin Lu <jlu at openjdk.org> wrote:

> Please review this PR and corresponding CSR which includes a wide range of specification improvements for java.util.Locale. See the CSR for further detail. Other changes/suggestions are welcomed to be included as part of this change. Alternatively the diffs can be viewed on the API diff link attached on the CSR.

Would be nice if you can render the APIDiff and javadoc and share on cr.openjdk.org :)

src/java.base/share/classes/java/util/Locale.java line 94:

> 92:  * <p> A {@code Locale} is composed of the bolded fields described below; note that a
> 93:  * {@code Locale} need not have all such fields. For example, {@link
> 94:  * Locale#ENGLISH Locale.ENGLISH} is only comprised of the <em>language</em> field.

Side remark: in the `Locale` class itself, you can just use `{@link #ENGLISH Locale.ENGLISH}` to generate the link.

src/java.base/share/classes/java/util/Locale.java line 95:

> 93:  * {@code Locale} need not have all such fields. For example, {@link
> 94:  * Locale#ENGLISH Locale.ENGLISH} is only comprised of the <em>language</em> field.
> 95:  * Contrarily, a {@code Locale} such as the one returned by {@code

"Contrarily" is fine, but I think we use "In contrast" more often.

src/java.base/share/classes/java/util/Locale.java line 100:

> 98:  * the United States using the Latin alphabet and numerics for use in POSIX
> 99:  * environments.
> 100:  * {@code Locale} implements IETF BCP 47 and any deviations should be observed

I recommend a paragraph break here with `<p>`

src/java.base/share/classes/java/util/Locale.java line 120:

> 118:  *
> 119:  *   <dd> <em>Syntax:</em> Well-formed {@code language} values have the form {@code [a-zA-Z]{2,8}}.
> 120:  *   BCP 47 deviation: this is not the full BCP 47 language production, since it excludes

Should we add `<br>` before these deviations for more straightforward rendering?

src/java.base/share/classes/java/util/Locale.java line 210:

> 208:  * only checks if an individual field satisfies the syntactic
> 209:  * requirement (is well-formed), but does not validate the value
> 210:  * itself. Conversely, {@link #of(String, String, String)} and its overloads do not

Suggestion:

 * itself. Conversely, {@link #of(String, String, String) Locale::of} and its overloads do not


I think javadoc tends to render those arguments as full-blown `of(java.lang.String, java.lang.String, java.lang.String)`, which is most likely not what you want.

src/java.base/share/classes/java/util/Locale.java line 333:

> 331:  *  {@link Locale#US Locale.US} is the {@code Locale} object for the United States.</dd>
> 332:  *  <dt><b>Factory Methods</b></dt>
> 333:  *  <dd>The method {@link #of(String, String, String)} and its overloads obtain a

Same link remarks.  Also for `forLanguageTag` below.

src/java.base/share/classes/java/util/Locale.java line 343:

> 341:  *
> 342:  * {@snippet lang=java :
> 343:  *     // The following are all equivalent

Suggestion:

 * <p>The following are all equivalent:
 * {@snippet lang=java :

src/java.base/share/classes/java/util/Locale.java line 376:

> 374:  * Locale.Category#FORMAT FORMAT} locale :
> 375:  * {@snippet lang=java :
> 376:  *     // The following are equivalent

Still recommend moving this comment to official javadoc, so the last sentence can be


The latter uses the default {@link Locale.Category#FORMAT FORMAT} locale, so
the following are equivalent:

src/java.base/share/classes/java/util/Locale.java line 399:

> 397:  * resources for multiple locales, it sometimes needs to find one or more
> 398:  * locales (or language tags) which meet each user's specific preferences. Note
> 399:  * that the term "language tag" is used interchangeably with "locale" in the following

Should we add an index to "language tag", like:
Suggestion:

 * that the term "<dfn>{@index "language tag"}</dfn>" is used interchangeably with "locale" in the following

src/java.base/share/classes/java/util/Locale.java line 476:

> 474:  *
> 475:  * <h2>Compatibility</h2>
> 476:  * @implNote

I believe `@implNote` is a higher-level tag than a `<h2>`; all following contents will be indented. Recommended moving the `<h2>` into the `@implNote`.

src/java.base/share/classes/java/util/Locale.java line 500:

> 498:  * <p>Because of these issues, it is recommended that apps migrate
> 499:  * away from constructing non-conforming locales and use the
> 500:  * {@link #forLanguageTag} and {@link Locale.Builder} APIs instead.

Same remarks for links, add a override render text to prevent javadoc from generating long parameter lists.

src/java.base/share/classes/java/util/Locale.java line 2106:

> 2104:      * is en_US, getDisplayCountry() will return "France"; if the locale is en_US and
> 2105:      * inLocale is fr_FR, getDisplayCountry() will return "Etats-Unis".
> 2106:      * If the name returned cannot be localized according to inLocale.

Suggestion:

     * If the name returned cannot be localized according to inLocale,

-------------

PR Review: https://git.openjdk.org/jdk/pull/22192#pullrequestreview-2443672580
PR Review Comment: https://git.openjdk.org/jdk/pull/22192#discussion_r1847236829
PR Review Comment: https://git.openjdk.org/jdk/pull/22192#discussion_r1847240545
PR Review Comment: https://git.openjdk.org/jdk/pull/22192#discussion_r1847243076
PR Review Comment: https://git.openjdk.org/jdk/pull/22192#discussion_r1847253411
PR Review Comment: https://git.openjdk.org/jdk/pull/22192#discussion_r1847259756
PR Review Comment: https://git.openjdk.org/jdk/pull/22192#discussion_r1847261730
PR Review Comment: https://git.openjdk.org/jdk/pull/22192#discussion_r1847263166
PR Review Comment: https://git.openjdk.org/jdk/pull/22192#discussion_r1847266745
PR Review Comment: https://git.openjdk.org/jdk/pull/22192#discussion_r1847267850
PR Review Comment: https://git.openjdk.org/jdk/pull/22192#discussion_r1847270260
PR Review Comment: https://git.openjdk.org/jdk/pull/22192#discussion_r1847271943
PR Review Comment: https://git.openjdk.org/jdk/pull/22192#discussion_r1847272982

From liach at openjdk.org  Mon Nov 18 21:10:00 2024
From: liach at openjdk.org (Chen Liang)
Date: Mon, 18 Nov 2024 21:10:00 GMT
Subject: <i18n dev> RFR: 8341923: java.util.Locale class specification
 improvements
In-Reply-To: <a8ibOqDLUAn4-KOJtPQtD-FKDX73ZnvMI51UWLuDhPY=.f48b60d9-fe3b-401a-a952-38bbcc6cd843@github.com>
References: <a8ibOqDLUAn4-KOJtPQtD-FKDX73ZnvMI51UWLuDhPY=.f48b60d9-fe3b-401a-a952-38bbcc6cd843@github.com>
Message-ID: <UgDQ8ok59nT0ZzAXkElB5VlOVHrXFH09PSqUvp2HNXM=.3fd9b8dd-094f-40c1-ae43-4f311e7fa6cd@github.com>

On Mon, 18 Nov 2024 07:41:31 GMT, Justin Lu <jlu at openjdk.org> wrote:

> Please review this PR and corresponding CSR which includes a wide range of specification improvements for java.util.Locale. See the CSR for further detail. Other changes/suggestions are welcomed to be included as part of this change. Alternatively the diffs can be viewed on the API diff link attached on the CSR.

Update: Didn't notice you posted apidiff and javadoc beforehand:
APIDiff: https://cr.openjdk.org/~jlu/8341923_apidiff/java.base/java/util/Locale.html
Javadoc: https://cr.openjdk.org/~jlu/api/java.base/java/util/Locale.html

-------------

PR Comment: https://git.openjdk.org/jdk/pull/22192#issuecomment-2484131045

From prr at openjdk.org  Mon Nov 18 22:18:19 2024
From: prr at openjdk.org (Phil Race)
Date: Mon, 18 Nov 2024 22:18:19 GMT
Subject: <i18n dev> RFR: 8344451: Deprecate for removal
 java.awt.Window.getWarningString()
Message-ID: <cZN3bZf5PIhmNeTvGZezBoleZkq5oNWQI9GUlneoPAk=.d1a819dd-d7b7-4708-bb66-d57fab85191d@github.com>

This fix deprecates for removal java.awt.Window.getWarningString() and also javax.swing.JInternalFrame.getWarningString()
l java.awt.Window.getWarningString() is only relevant with a SecurityManager and javax.swing.JInternalFrame.getWarningString() is just there for symmetry.

A few other spec changes ensue - the serial form variable warningString is removed is the main one.
The AWTPermission showWindowWithoutWarningBanner is obsolete
Reference to the system property  "awt.appletWarning" was actually already removed by JEP 486

There is a CSR for the spec. changes, which will need a reviewer : https://bugs.openjdk.org/browse/JDK-8344451

But the vast majority of the changes here are all the downstream obsoleted implementation
The warning string and warning icon, and warning windows are all obsoleted.
I think I tracked down all of it, but it is hard to be sure.
Automated tests are passing, and I've manually tested SwingSet2 on all 3 platforms.

-------------

Commit messages:
 - 8344451

Changes: https://git.openjdk.org/jdk/pull/22221/files
  Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=22221&range=00
  Issue: https://bugs.openjdk.org/browse/JDK-8344451
  Stats: 2028 lines in 39 files changed: 5 ins; 2014 del; 9 mod
  Patch: https://git.openjdk.org/jdk/pull/22221.diff
  Fetch: git fetch https://git.openjdk.org/jdk.git pull/22221/head:pull/22221

PR: https://git.openjdk.org/jdk/pull/22221

From prr at openjdk.org  Mon Nov 18 22:41:19 2024
From: prr at openjdk.org (Phil Race)
Date: Mon, 18 Nov 2024 22:41:19 GMT
Subject: <i18n dev> RFR: 8344061: Remove doPrivileged calls from shared
 implementation code in the java.desktop module : part 2 [v4]
In-Reply-To: <0ecs2MAtGLHGFdT_GvAnU6168RvQza-I0DF5Fi_KdPU=.92e80dc7-3dbb-47ea-b525-e0ffdcea8435@github.com>
References: <0ecs2MAtGLHGFdT_GvAnU6168RvQza-I0DF5Fi_KdPU=.92e80dc7-3dbb-47ea-b525-e0ffdcea8435@github.com>
Message-ID: <CZdeyjPIhnbGNvTX_4yTE_zeI2OaH5HeWMBV7_qUOV4=.b2e5cce1-2743-4d05-aa23-053db0914be3@github.com>

> Update 21 desktop module shared implementation files to remove doPrivileged.
> All the usual tests still pass.

Phil Race has updated the pull request incrementally with one additional commit since the last revision:

  v

-------------

Changes:
  - all: https://git.openjdk.org/jdk/pull/22161/files
  - new: https://git.openjdk.org/jdk/pull/22161/files/86509da0..a753e913

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jdk&pr=22161&range=03
 - incr: https://webrevs.openjdk.org/?repo=jdk&pr=22161&range=02-03

  Stats: 21 lines in 5 files changed: 4 ins; 13 del; 4 mod
  Patch: https://git.openjdk.org/jdk/pull/22161.diff
  Fetch: git fetch https://git.openjdk.org/jdk.git pull/22161/head:pull/22161

PR: https://git.openjdk.org/jdk/pull/22161

From prr at openjdk.org  Mon Nov 18 22:41:20 2024
From: prr at openjdk.org (Phil Race)
Date: Mon, 18 Nov 2024 22:41:20 GMT
Subject: <i18n dev> RFR: 8344061: Remove doPrivileged calls from shared
 implementation code in the java.desktop module : part 2 [v3]
In-Reply-To: <k8lcIwC4WUhz4WBilPOKw1NDufe4brY5DXHrh4ZtuRA=.ddeaffe5-7a6b-46e2-bdfe-5208b8b2d3a1@github.com>
References: <0ecs2MAtGLHGFdT_GvAnU6168RvQza-I0DF5Fi_KdPU=.92e80dc7-3dbb-47ea-b525-e0ffdcea8435@github.com>
 <4Lhg9jCIAJUc1boDnowUeWxK12-u2pU5fyUCh4EqQHk=.eb1e1e88-8ae4-42b3-98f9-bb7ad2866905@github.com>
 <k8lcIwC4WUhz4WBilPOKw1NDufe4brY5DXHrh4ZtuRA=.ddeaffe5-7a6b-46e2-bdfe-5208b8b2d3a1@github.com>
Message-ID: <TsgFcl8nGnm7pSZR1gDzWefyD--4UGwmqX6I3u2lUbo=.8f8be666-8e8a-4f60-9ebb-43331c53ae8c@github.com>

On Mon, 18 Nov 2024 17:37:50 GMT, Alexey Ivanov <aivanov at openjdk.org> wrote:

>> Phil Race has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   8344061
>
> src/java.desktop/share/classes/sun/awt/AppContext.java line 521:
> 
>> 519:                 // Create a thread that belongs to the thread group associated
>> 520:                 // with the AppContext and invokes EventQueue.postEvent.
>> 521:                 Thread thread = new Thread(r);
> 
> Previously, the thread was created in the app context thread group and the properties of the created thread were modified, such as its priority and daemon flag.
> 
> https://github.com/openjdk/jdk/blob/d76b5b888e15b507631068f508e261cab75c841e/src/java.desktop/share/classes/sun/awt/AppContext.java#L559-L563

I don't know what I was thinking here.

> src/java.desktop/share/classes/sun/awt/FontConfiguration.java line 163:
> 
>> 161:         } catch (Exception e) {
>> 162:         }
>> 163:         return exists.booleanValue();
> 
> Suggestion:
> 
>         try {
>             File f = new File(fileName);
>             return f.exists();
>         } catch (Exception e) {
>             return false;
>         }
> 
> In this case, no variable is need.
> 
> If you prefer to have the variable, it can now be of primitive type `boolean`.
> 
> Can an exception be thrown at all? Neither `new File` nor `f.exists()` throw a checked exception.

f.exists() could throw SecurityException - unchecked - so that is why it WAS there.
I guess it is legitimate to remove that now.

> src/java.desktop/share/classes/sun/font/CreatedFontTracker.java line 1:
> 
>> 1: /*
> 
> The following imports are unused now:
> 
> import java.security.AccessController;
> import java.security.PrivilegedAction;

ok

> src/java.desktop/share/classes/sun/font/FileFont.java line 38:
> 
>> 36: import sun.java2d.DisposerRecord;
>> 37: 
>> 38: import java.io.IOException;
> 
> `java.io.IOException` is unused now.

ok

> src/java.desktop/share/classes/sun/font/SunFontManager.java line 1705:
> 
>> 1703:                 f = new File(pathDirs[p] + File.separator + s);
>> 1704:                 if (f.exists()) {
>> 1705:                     path = f.getAbsolutePath();
> 
> This can now be
> 
> return f.getAbsolutePath();
> 
> Then `path` variable can be removed.

I've been avoiding refactoring wihout an SM relevant reason. I will make this update but generally don't want to do this.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/22161#discussion_r1847358729
PR Review Comment: https://git.openjdk.org/jdk/pull/22161#discussion_r1847363922
PR Review Comment: https://git.openjdk.org/jdk/pull/22161#discussion_r1847365402
PR Review Comment: https://git.openjdk.org/jdk/pull/22161#discussion_r1847365763
PR Review Comment: https://git.openjdk.org/jdk/pull/22161#discussion_r1847368489

From jlu at openjdk.org  Tue Nov 19 07:58:22 2024
From: jlu at openjdk.org (Justin Lu)
Date: Tue, 19 Nov 2024 07:58:22 GMT
Subject: <i18n dev> RFR: 8341923: java.util.Locale class specification
 improvements [v2]
In-Reply-To: <O57GqoLTBEtabzWDMOeoOAXR20htwuHtTBBHHxbKCYw=.0c083485-8426-4fb6-9957-9726594a7e43@github.com>
References: <a8ibOqDLUAn4-KOJtPQtD-FKDX73ZnvMI51UWLuDhPY=.f48b60d9-fe3b-401a-a952-38bbcc6cd843@github.com>
 <O57GqoLTBEtabzWDMOeoOAXR20htwuHtTBBHHxbKCYw=.0c083485-8426-4fb6-9957-9726594a7e43@github.com>
Message-ID: <o5taAJFCDkIFk262TZHm12HSfYy3uPQ8k1bI3oShnBo=.3cde8c0f-33cc-44fd-973d-9accc57a39e6@github.com>

On Mon, 18 Nov 2024 20:37:27 GMT, Chen Liang <liach at openjdk.org> wrote:

>> Justin Lu has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   address Chen's review; make other similar changes
>
> src/java.base/share/classes/java/util/Locale.java line 94:
> 
>> 92:  * <p> A {@code Locale} is composed of the bolded fields described below; note that a
>> 93:  * {@code Locale} need not have all such fields. For example, {@link
>> 94:  * Locale#ENGLISH Locale.ENGLISH} is only comprised of the <em>language</em> field.
> 
> Side remark: in the `Locale` class itself, you can just use `{@link #ENGLISH Locale.ENGLISH}` to generate the link.

Thanks for taking a look Chen.

https://github.com/openjdk/jdk/pull/22192/commits/6b5b5cd067a42dbb98033314851255841e0d91fb should address your comments, and includes other changes that are in line with your suggestions. The apidiff and javadoc links have also been refreshed.

> Update: Didn't notice you posted apidiff and javadoc beforehand:
> APIDiff: https://cr.openjdk.org/~jlu/8341923_apidiff/java.base/java/util/Locale.html
> Javadoc: https://cr.openjdk.org/~jlu/api/java.base/java/util/Locale.html

(Sorry, I should have linked these directly on this PR).

> src/java.base/share/classes/java/util/Locale.java line 120:
> 
>> 118:  *
>> 119:  *   <dd> <em>Syntax:</em> Well-formed {@code language} values have the form {@code [a-zA-Z]{2,8}}.
>> 120:  *   BCP 47 deviation: this is not the full BCP 47 language production, since it excludes
> 
> Should we add `<br>` before these deviations for more straightforward rendering?

Good point. Went ahead and just prefixed with a `<dd>` instead (for consistency).

> src/java.base/share/classes/java/util/Locale.java line 500:
> 
>> 498:  * <p>Because of these issues, it is recommended that apps migrate
>> 499:  * away from constructing non-conforming locales and use the
>> 500:  * {@link #forLanguageTag} and {@link Locale.Builder} APIs instead.
> 
> Same remarks for links, add a override render text to prevent javadoc from generating long parameter lists.

I gave the `Locale.of` links an explicit render. I think the `forLanguageTag` links were fine w/o an explicit render, as long as `{@link #forLanguageTag(String)}` was used, not `{@link #forLanguageTag}` (so that the fully qualified class name is omitted).

On a side note, the default render was pretty nasty for the `Locale.LanguageRange` see tags.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/22192#discussion_r1847824296
PR Review Comment: https://git.openjdk.org/jdk/pull/22192#discussion_r1847826300
PR Review Comment: https://git.openjdk.org/jdk/pull/22192#discussion_r1847831453

From jlu at openjdk.org  Tue Nov 19 07:58:22 2024
From: jlu at openjdk.org (Justin Lu)
Date: Tue, 19 Nov 2024 07:58:22 GMT
Subject: <i18n dev> RFR: 8341923: java.util.Locale class specification
 improvements [v2]
In-Reply-To: <a8ibOqDLUAn4-KOJtPQtD-FKDX73ZnvMI51UWLuDhPY=.f48b60d9-fe3b-401a-a952-38bbcc6cd843@github.com>
References: <a8ibOqDLUAn4-KOJtPQtD-FKDX73ZnvMI51UWLuDhPY=.f48b60d9-fe3b-401a-a952-38bbcc6cd843@github.com>
Message-ID: <8W7-Y64Rn1pVLuPfLoAktG-ekfebPelcoWQbxxiEMjE=.f07e118b-99ea-4ef0-909d-6141b08e4a55@github.com>

> Please review this PR and corresponding CSR which includes a wide range of specification improvements for java.util.Locale. See the CSR for further detail. Other changes/suggestions are welcomed to be included as part of this change.
> 
> APIDiff: https://cr.openjdk.org/~jlu/8341923_apidiff/java.base/java/util/Locale.html
> Javadoc: https://cr.openjdk.org/~jlu/api/java.base/java/util/Locale.html

Justin Lu has updated the pull request incrementally with one additional commit since the last revision:

  address Chen's review; make other similar changes

-------------

Changes:
  - all: https://git.openjdk.org/jdk/pull/22192/files
  - new: https://git.openjdk.org/jdk/pull/22192/files/6b2eff66..6b5b5cd0

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jdk&pr=22192&range=01
 - incr: https://webrevs.openjdk.org/?repo=jdk&pr=22192&range=00-01

  Stats: 53 lines in 1 file changed: 5 ins; 6 del; 42 mod
  Patch: https://git.openjdk.org/jdk/pull/22192.diff
  Fetch: git fetch https://git.openjdk.org/jdk.git pull/22192/head:pull/22192

PR: https://git.openjdk.org/jdk/pull/22192

From erikj at openjdk.org  Tue Nov 19 17:28:48 2024
From: erikj at openjdk.org (Erik Joelsson)
Date: Tue, 19 Nov 2024 17:28:48 GMT
Subject: <i18n dev> RFR: 8344451: Deprecate for removal
 java.awt.Window.getWarningString()
In-Reply-To: <cZN3bZf5PIhmNeTvGZezBoleZkq5oNWQI9GUlneoPAk=.d1a819dd-d7b7-4708-bb66-d57fab85191d@github.com>
References: <cZN3bZf5PIhmNeTvGZezBoleZkq5oNWQI9GUlneoPAk=.d1a819dd-d7b7-4708-bb66-d57fab85191d@github.com>
Message-ID: <le70DlZcI-mwYKglOcWmS_ZJpeUSw51SFLPZjlCTKmM=.c07d6ca7-bcae-4f6f-acb0-f4f630268b8f@github.com>

On Mon, 18 Nov 2024 22:11:52 GMT, Phil Race <prr at openjdk.org> wrote:

> This fix deprecates for removal java.awt.Window.getWarningString() and also javax.swing.JInternalFrame.getWarningString()
> l java.awt.Window.getWarningString() is only relevant with a SecurityManager and javax.swing.JInternalFrame.getWarningString() is just there for symmetry.
> 
> A few other spec changes ensue - the serial form variable warningString is removed is the main one.
> The AWTPermission showWindowWithoutWarningBanner is obsolete
> Reference to the system property  "awt.appletWarning" was actually already removed by JEP 486
> 
> There is a CSR for the spec. changes, which will need a reviewer : https://bugs.openjdk.org/browse/JDK-8344451
> 
> But the vast majority of the changes here are all the downstream obsoleted implementation
> The warning string and warning icon, and warning windows are all obsoleted.
> I think I tracked down all of it, but it is hard to be sure.
> Automated tests are passing, and I've manually tested SwingSet2 on all 3 platforms.

make/modules/java.desktop/gensrc/GensrcIcons.gmk line 41:

> 39: 
> 40: 
> 41: AWT_ICONPATH := $(MODULE_SRC)/share/classes/sun/awt/resources

This variable looks to be unused now.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/22221#discussion_r1848772430

From naoto at openjdk.org  Tue Nov 19 17:42:07 2024
From: naoto at openjdk.org (Naoto Sato)
Date: Tue, 19 Nov 2024 17:42:07 GMT
Subject: <i18n dev> RFR: 8343788: Provide means to alter lib/tzmappings
 entries on Windows
Message-ID: <z7j5vrQoWKMnE7_RsTMDFcs2XpHkzCw1t9rTBaMM2Kg=.6c2257e5-ccdb-4f04-90e5-22e2341a2678@github.com>

Windows Java runtime has a mapping file /lib/tzmappings which maps Windows time zones to Java's time zones. The file is generated based on CLDR's windowsZones.xml, but in rare occasions, its update is out of sync with Windows updates. This enhancement is to address those discrepancies for the time being (till CLDR/Windows are in sync). This change will also address zone mapping discrepancies in the update releases where CLDR versions stay the same.

-------------

Commit messages:
 - initial commit

Changes: https://git.openjdk.org/jdk/pull/22250/files
  Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=22250&range=00
  Issue: https://bugs.openjdk.org/browse/JDK-8343788
  Stats: 54 lines in 2 files changed: 53 ins; 0 del; 1 mod
  Patch: https://git.openjdk.org/jdk/pull/22250.diff
  Fetch: git fetch https://git.openjdk.org/jdk.git pull/22250/head:pull/22250

PR: https://git.openjdk.org/jdk/pull/22250

From aivanov at openjdk.org  Tue Nov 19 19:06:49 2024
From: aivanov at openjdk.org (Alexey Ivanov)
Date: Tue, 19 Nov 2024 19:06:49 GMT
Subject: <i18n dev> RFR: 8344061: Remove doPrivileged calls from shared
 implementation code in the java.desktop module : part 2 [v4]
In-Reply-To: <CZdeyjPIhnbGNvTX_4yTE_zeI2OaH5HeWMBV7_qUOV4=.b2e5cce1-2743-4d05-aa23-053db0914be3@github.com>
References: <0ecs2MAtGLHGFdT_GvAnU6168RvQza-I0DF5Fi_KdPU=.92e80dc7-3dbb-47ea-b525-e0ffdcea8435@github.com>
 <CZdeyjPIhnbGNvTX_4yTE_zeI2OaH5HeWMBV7_qUOV4=.b2e5cce1-2743-4d05-aa23-053db0914be3@github.com>
Message-ID: <-VXkdXnNgyBvZ4biXPgDqZL19Vddu9FRXVuNFfo0730=.80b51084-96e5-40cd-a63b-6b94fbf28e5f@github.com>

On Mon, 18 Nov 2024 22:41:19 GMT, Phil Race <prr at openjdk.org> wrote:

>> Update 21 desktop module shared implementation files to remove doPrivileged.
>> All the usual tests still pass.
>
> Phil Race has updated the pull request incrementally with one additional commit since the last revision:
> 
>   v

Marked as reviewed by aivanov (Reviewer).

-------------

PR Review: https://git.openjdk.org/jdk/pull/22161#pullrequestreview-2446353571

From prr at openjdk.org  Tue Nov 19 19:29:28 2024
From: prr at openjdk.org (Phil Race)
Date: Tue, 19 Nov 2024 19:29:28 GMT
Subject: <i18n dev> RFR: 8344451: Deprecate for removal
 java.awt.Window.getWarningString() [v2]
In-Reply-To: <cZN3bZf5PIhmNeTvGZezBoleZkq5oNWQI9GUlneoPAk=.d1a819dd-d7b7-4708-bb66-d57fab85191d@github.com>
References: <cZN3bZf5PIhmNeTvGZezBoleZkq5oNWQI9GUlneoPAk=.d1a819dd-d7b7-4708-bb66-d57fab85191d@github.com>
Message-ID: <o1r6bTcg7UECs4kNq-RLY3grB9Kobn4JPCpRnbzHbc8=.9d0da935-64f1-43c7-84c6-2925eadd19bc@github.com>

> This fix deprecates for removal java.awt.Window.getWarningString() and also javax.swing.JInternalFrame.getWarningString()
> l java.awt.Window.getWarningString() is only relevant with a SecurityManager and javax.swing.JInternalFrame.getWarningString() is just there for symmetry.
> 
> A few other spec changes ensue - the serial form variable warningString is removed is the main one.
> The AWTPermission showWindowWithoutWarningBanner is obsolete
> Reference to the system property  "awt.appletWarning" was actually already removed by JEP 486
> 
> There is a CSR for the spec. changes, which will need a reviewer : https://bugs.openjdk.org/browse/JDK-8344451
> 
> But the vast majority of the changes here are all the downstream obsoleted implementation
> The warning string and warning icon, and warning windows are all obsoleted.
> I think I tracked down all of it, but it is hard to be sure.
> Automated tests are passing, and I've manually tested SwingSet2 on all 3 platforms.

Phil Race has updated the pull request incrementally with one additional commit since the last revision:

  8344451

-------------

Changes:
  - all: https://git.openjdk.org/jdk/pull/22221/files
  - new: https://git.openjdk.org/jdk/pull/22221/files/7bc7a801..cebd99ef

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jdk&pr=22221&range=01
 - incr: https://webrevs.openjdk.org/?repo=jdk&pr=22221&range=00-01

  Stats: 3 lines in 1 file changed: 0 ins; 3 del; 0 mod
  Patch: https://git.openjdk.org/jdk/pull/22221.diff
  Fetch: git fetch https://git.openjdk.org/jdk.git pull/22221/head:pull/22221

PR: https://git.openjdk.org/jdk/pull/22221

From prr at openjdk.org  Tue Nov 19 19:29:28 2024
From: prr at openjdk.org (Phil Race)
Date: Tue, 19 Nov 2024 19:29:28 GMT
Subject: <i18n dev> RFR: 8344451: Deprecate for removal
 java.awt.Window.getWarningString() [v2]
In-Reply-To: <le70DlZcI-mwYKglOcWmS_ZJpeUSw51SFLPZjlCTKmM=.c07d6ca7-bcae-4f6f-acb0-f4f630268b8f@github.com>
References: <cZN3bZf5PIhmNeTvGZezBoleZkq5oNWQI9GUlneoPAk=.d1a819dd-d7b7-4708-bb66-d57fab85191d@github.com>
 <le70DlZcI-mwYKglOcWmS_ZJpeUSw51SFLPZjlCTKmM=.c07d6ca7-bcae-4f6f-acb0-f4f630268b8f@github.com>
Message-ID: <XA9G5Q3BNfjUDSHDfd1Fys5KxAd3FO5kV49QpSCYHVg=.531f1e69-68f5-4844-9194-8c896a76d7ca@github.com>

On Tue, 19 Nov 2024 17:25:09 GMT, Erik Joelsson <erikj at openjdk.org> wrote:

>> Phil Race has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   8344451
>
> make/modules/java.desktop/gensrc/GensrcIcons.gmk line 41:
> 
>> 39: 
>> 40: 
>> 41: AWT_ICONPATH := $(MODULE_SRC)/share/classes/sun/awt/resources
> 
> This variable looks to be unused now.

you are correct. fixing.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/22221#discussion_r1848946231

From prr at openjdk.org  Tue Nov 19 19:39:51 2024
From: prr at openjdk.org (Phil Race)
Date: Tue, 19 Nov 2024 19:39:51 GMT
Subject: <i18n dev> Integrated: 8344061: Remove doPrivileged calls from
 shared implementation code in the java.desktop module : part 2
In-Reply-To: <0ecs2MAtGLHGFdT_GvAnU6168RvQza-I0DF5Fi_KdPU=.92e80dc7-3dbb-47ea-b525-e0ffdcea8435@github.com>
References: <0ecs2MAtGLHGFdT_GvAnU6168RvQza-I0DF5Fi_KdPU=.92e80dc7-3dbb-47ea-b525-e0ffdcea8435@github.com>
Message-ID: <GumFU6yAn2xOvrCCOaCtt1Aff6sDZRRgCxKc4Z_8QYE=.bb75d9db-368e-4cd1-860e-7d09dd3cf92e@github.com>

On Fri, 15 Nov 2024 19:18:15 GMT, Phil Race <prr at openjdk.org> wrote:

> Update 21 desktop module shared implementation files to remove doPrivileged.
> All the usual tests still pass.

This pull request has now been integrated.

Changeset: 69c9f256
Author:    Phil Race <prr at openjdk.org>
URL:       https://git.openjdk.org/jdk/commit/69c9f2566ea36fa3317d762d4498637489c70c45
Stats:     1049 lines in 21 files changed: 133 ins; 528 del; 388 mod

8344061: Remove doPrivileged calls from shared implementation code in the java.desktop module : part 2

Reviewed-by: aivanov

-------------

PR: https://git.openjdk.org/jdk/pull/22161

From prr at openjdk.org  Tue Nov 19 20:36:49 2024
From: prr at openjdk.org (Phil Race)
Date: Tue, 19 Nov 2024 20:36:49 GMT
Subject: <i18n dev> RFR: 8343476: Remove unnecessary @SuppressWarnings
 annotations (client) [v4]
In-Reply-To: <anBmdkjT8Ew2fkiwZtNywg2tHgFDYLcsJZxnqFcURfQ=.093f99fe-7da9-456e-a8f4-f9d707cecaa3@github.com>
References: <Sa_OdV-UQBC_8sqALNkC2gOphd6PvXZ9EeisG_If2WQ=.36470214-24b9-457e-9183-24492a0d1df8@github.com>
 <anBmdkjT8Ew2fkiwZtNywg2tHgFDYLcsJZxnqFcURfQ=.093f99fe-7da9-456e-a8f4-f9d707cecaa3@github.com>
Message-ID: <7yq-DX1COOkqLrQNZtFrMF_bvTOmTNQwMUdo9uQezD8=.af25f2a9-09e9-42c7-afee-f45f98f0fb4a@github.com>

On Wed, 13 Nov 2024 15:57:13 GMT, Archie Cobbs <acobbs at openjdk.org> wrote:

>> Please review this patch which removes unnecessary `@SuppressWarnings` annotations.
>
> Archie Cobbs has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains six additional commits since the last revision:
> 
>  - Merge branch 'master' into SuppressWarningsCleanup-client
>  - Merge branch 'master' into SuppressWarningsCleanup-client
>  - Update copyright years.
>  - Merge branch 'master' into SuppressWarningsCleanup-client
>  - Merge branch 'master' into SuppressWarningsCleanup-client
>  - Remove unnecessary @SuppressWarnings annotations.

Marked as reviewed by prr (Reviewer).

OK .. looks like I didn't save my comments last time, trying again.

I had missed this PR until recently. I think it will be good to have this sort of check.

I've verified the specific changes here by building the PR on all platforms.

I was a bit surprised how many serial annotations are present that are not needed

There are in progress PRs that remove doPrivileged calls.
They all involve removing lots of now redundant annotations and people don't always remember.
There is good chance you will either want to do a follow-up of this PR, or re-run again against the latest master.

-------------

PR Review: https://git.openjdk.org/jdk/pull/21850#pullrequestreview-2446598450
PR Comment: https://git.openjdk.org/jdk/pull/21850#issuecomment-2486694742

From naoto at openjdk.org  Tue Nov 19 21:03:07 2024
From: naoto at openjdk.org (Naoto Sato)
Date: Tue, 19 Nov 2024 21:03:07 GMT
Subject: <i18n dev> RFR: 8341923: java.util.Locale class specification
 improvements [v2]
In-Reply-To: <8W7-Y64Rn1pVLuPfLoAktG-ekfebPelcoWQbxxiEMjE=.f07e118b-99ea-4ef0-909d-6141b08e4a55@github.com>
References: <a8ibOqDLUAn4-KOJtPQtD-FKDX73ZnvMI51UWLuDhPY=.f48b60d9-fe3b-401a-a952-38bbcc6cd843@github.com>
 <8W7-Y64Rn1pVLuPfLoAktG-ekfebPelcoWQbxxiEMjE=.f07e118b-99ea-4ef0-909d-6141b08e4a55@github.com>
Message-ID: <SrzJo73RPFigmAaiueCT3eIwWsTGihps9ScE0I_kuXw=.67aa29f8-d82e-4d67-8e24-415da708d173@github.com>

On Tue, 19 Nov 2024 07:58:22 GMT, Justin Lu <jlu at openjdk.org> wrote:

>> Please review this PR and corresponding CSR which includes a wide range of specification improvements for java.util.Locale. See the CSR for further detail. Other changes/suggestions are welcomed to be included as part of this change.
>> 
>> APIDiff: https://cr.openjdk.org/~jlu/8341923_apidiff/java.base/java/util/Locale.html
>> Javadoc: https://cr.openjdk.org/~jlu/api/java.base/java/util/Locale.html
>
> Justin Lu has updated the pull request incrementally with one additional commit since the last revision:
> 
>   address Chen's review; make other similar changes

Looks good. Some comments that I missed in the initial (internal) review.

src/java.base/share/classes/java/util/Locale.java line 89:

> 87:  * exchange. Each {@code Locale} is associated with locale data which is retrieved
> 88:  * by the installed {@link java.util.spi.LocaleServiceProvider LocaleServiceProvider}
> 89:  * implementations. Depending on the implementation, such data may vary by release.

This reads like locale data are only obtained with the SPI implementations that are provided by the users. The locale data also (and mainly) come from within Java runtime itself. (BTW, "installed" should be removed, as it is no longer correct. Same applies to getAvailableLocales()/availableLocales() methods)

src/java.base/share/classes/java/util/Locale.java line 98:

> 96:  * Locale.forLanguageTag("en-Latn-US-POSIX-u-nu-latn")} would be comprised of all
> 97:  * the fields below. This particular {@code Locale} would represent English in
> 98:  * the United States using the Latin alphabet and numerics for use in POSIX

"script" is more precise than "alphabet", as the latter suggests only letters [A-Z]

src/java.base/share/classes/java/util/Locale.java line 144:

> 142:  *   each indicating its own semantics, these values should be ordered
> 143:  *   by importance, with most important first, separated by
> 144:  *   underscore('_').  The variant field is case sensitive.</dd>

This part "separated by underscore('_')" is missing in the revised doc

src/java.base/share/classes/java/util/Locale.java line 216:

> 214:  * overloads do not make any syntactic checks on the input.
> 215:  *
> 216:  * <h3><a id="def_locale_extension">Unicode locale/language extension</a></h3>

Probably using the exact name in the external spec is better [Unicode BCP 47 U Extension](https://unicode.org/reports/tr35/#u_Extension)

src/java.base/share/classes/java/util/Locale.java line 218:

> 216:  * <h3><a id="def_locale_extension">Unicode locale/language extension</a></h3>
> 217:  *
> 218:  * <p>UTS#35, "Unicode Locale Data Markup Language" defines optional

UTS35 (https://unicode.org/reports/tr35/) should be listed with @spec link

src/java.base/share/classes/java/util/Locale.java line 344:

> 342:  *  to BCP 47 syntax. Use a builder to enforce syntactic restrictions on the input.</dd>
> 343:  * </dl>
> 344:  * <p>The following are all equivalent:

"all equivalent" seems a bit vague, as the actual implementation is not equivalent (unlike other examples below). Something like "the following all produce equivalent locale objects" or along the lines?

-------------

PR Review: https://git.openjdk.org/jdk/pull/22192#pullrequestreview-2446512394
PR Review Comment: https://git.openjdk.org/jdk/pull/22192#discussion_r1848969909
PR Review Comment: https://git.openjdk.org/jdk/pull/22192#discussion_r1849007375
PR Review Comment: https://git.openjdk.org/jdk/pull/22192#discussion_r1849018322
PR Review Comment: https://git.openjdk.org/jdk/pull/22192#discussion_r1849026657
PR Review Comment: https://git.openjdk.org/jdk/pull/22192#discussion_r1849027660
PR Review Comment: https://git.openjdk.org/jdk/pull/22192#discussion_r1849032564

From erikj at openjdk.org  Tue Nov 19 21:06:07 2024
From: erikj at openjdk.org (Erik Joelsson)
Date: Tue, 19 Nov 2024 21:06:07 GMT
Subject: <i18n dev> RFR: 8342903: Deprecate for removal
 java.awt.Window.getWarningString() [v2]
In-Reply-To: <o1r6bTcg7UECs4kNq-RLY3grB9Kobn4JPCpRnbzHbc8=.9d0da935-64f1-43c7-84c6-2925eadd19bc@github.com>
References: <cZN3bZf5PIhmNeTvGZezBoleZkq5oNWQI9GUlneoPAk=.d1a819dd-d7b7-4708-bb66-d57fab85191d@github.com>
 <o1r6bTcg7UECs4kNq-RLY3grB9Kobn4JPCpRnbzHbc8=.9d0da935-64f1-43c7-84c6-2925eadd19bc@github.com>
Message-ID: <GxiujBPlWFHgAlD6Zi2cai6Owqa7T77RU1DH729DDcQ=.ed869709-42f2-4049-9d4e-3d32583858c4@github.com>

On Tue, 19 Nov 2024 19:29:28 GMT, Phil Race <prr at openjdk.org> wrote:

>> This fix deprecates for removal java.awt.Window.getWarningString() and also javax.swing.JInternalFrame.getWarningString()
>> l java.awt.Window.getWarningString() is only relevant with a SecurityManager and javax.swing.JInternalFrame.getWarningString() is just there for symmetry.
>> 
>> A few other spec changes ensue - the serial form variable warningString is removed is the main one.
>> The AWTPermission showWindowWithoutWarningBanner is obsolete
>> Reference to the system property  "awt.appletWarning" was actually already removed by JEP 486
>> 
>> There is a CSR for the spec. changes, which will need a reviewer : https://bugs.openjdk.org/browse/JDK-8344451
>> 
>> But the vast majority of the changes here are all the downstream obsoleted implementation
>> The warning string and warning icon, and warning windows are all obsoleted.
>> I think I tracked down all of it, but it is hard to be sure.
>> Automated tests are passing, and I've manually tested SwingSet2 on all 3 platforms.
>
> Phil Race has updated the pull request incrementally with one additional commit since the last revision:
> 
>   8344451

Build change looks ok.

-------------

Marked as reviewed by erikj (Reviewer).

PR Review: https://git.openjdk.org/jdk/pull/22221#pullrequestreview-2446618248

From acobbs at openjdk.org  Tue Nov 19 21:36:19 2024
From: acobbs at openjdk.org (Archie Cobbs)
Date: Tue, 19 Nov 2024 21:36:19 GMT
Subject: <i18n dev> RFR: 8343476: Remove unnecessary @SuppressWarnings
 annotations (client) [v5]
In-Reply-To: <Sa_OdV-UQBC_8sqALNkC2gOphd6PvXZ9EeisG_If2WQ=.36470214-24b9-457e-9183-24492a0d1df8@github.com>
References: <Sa_OdV-UQBC_8sqALNkC2gOphd6PvXZ9EeisG_If2WQ=.36470214-24b9-457e-9183-24492a0d1df8@github.com>
Message-ID: <o0INHPwjTlR9Upnk4N7giXvcxmLsm_vj136AE11i-eg=.e1ff5846-5e4d-4c8e-a264-bb6bf0778fe7@github.com>

> Please review this patch which removes unnecessary `@SuppressWarnings` annotations.

Archie Cobbs has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains eight commits:

 - Remove more unnecessary @SuppressWarnings annotations.
 - Merge branch 'master' into SuppressWarningsCleanup-client
 - Merge branch 'master' into SuppressWarningsCleanup-client
 - Merge branch 'master' into SuppressWarningsCleanup-client
 - Update copyright years.
 - Merge branch 'master' into SuppressWarningsCleanup-client
 - Merge branch 'master' into SuppressWarningsCleanup-client
 - Remove unnecessary @SuppressWarnings annotations.

-------------

Changes: https://git.openjdk.org/jdk/pull/21850/files
  Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=21850&range=04
  Stats: 252 lines in 107 files changed: 0 ins; 157 del; 95 mod
  Patch: https://git.openjdk.org/jdk/pull/21850.diff
  Fetch: git fetch https://git.openjdk.org/jdk.git pull/21850/head:pull/21850

PR: https://git.openjdk.org/jdk/pull/21850

From acobbs at openjdk.org  Tue Nov 19 21:36:19 2024
From: acobbs at openjdk.org (Archie Cobbs)
Date: Tue, 19 Nov 2024 21:36:19 GMT
Subject: <i18n dev> RFR: 8343476: Remove unnecessary @SuppressWarnings
 annotations (client) [v4]
In-Reply-To: <7yq-DX1COOkqLrQNZtFrMF_bvTOmTNQwMUdo9uQezD8=.af25f2a9-09e9-42c7-afee-f45f98f0fb4a@github.com>
References: <Sa_OdV-UQBC_8sqALNkC2gOphd6PvXZ9EeisG_If2WQ=.36470214-24b9-457e-9183-24492a0d1df8@github.com>
 <anBmdkjT8Ew2fkiwZtNywg2tHgFDYLcsJZxnqFcURfQ=.093f99fe-7da9-456e-a8f4-f9d707cecaa3@github.com>
 <7yq-DX1COOkqLrQNZtFrMF_bvTOmTNQwMUdo9uQezD8=.af25f2a9-09e9-42c7-afee-f45f98f0fb4a@github.com>
Message-ID: <NJun8_DngdS_KbyK7XcZHAYD0AyjbtRjnTCQbNk6bSA=.a0d2891f-efa3-4683-bb69-3d5e896fe11d@github.com>

On Tue, 19 Nov 2024 20:33:40 GMT, Phil Race <prr at openjdk.org> wrote:

>  There is good chance you will either want to do a follow-up of this PR, or re-run again against the latest master.

Indeed... just had to resolve some conflicts with recent changes.

As for now, all of the unnecessary `@SuppressWarnings` have been cleaned up but a few more will surely trickle in by the time if/when the new compiler check is active, in which case we'll deal with them then.

Thanks for the review!

-------------

PR Comment: https://git.openjdk.org/jdk/pull/21850#issuecomment-2486796620

From acobbs at openjdk.org  Tue Nov 19 21:50:13 2024
From: acobbs at openjdk.org (Archie Cobbs)
Date: Tue, 19 Nov 2024 21:50:13 GMT
Subject: <i18n dev> RFR: 8343478: Remove unnecessary @SuppressWarnings
 annotations (core-libs) [v7]
In-Reply-To: <9ZqHljyJeMr8fPG4-iU6bfQT9hQxTAwrGCl4xsQn3LA=.0b01f899-d849-4e23-8d50-8f186aade664@github.com>
References: <9ZqHljyJeMr8fPG4-iU6bfQT9hQxTAwrGCl4xsQn3LA=.0b01f899-d849-4e23-8d50-8f186aade664@github.com>
Message-ID: <FbyrPlsyHoA5n00uzetLuQwtOqeRmzjV6IRFSEveyRs=.fc5e3346-4055-4f93-b9a4-923fceded816@github.com>

> Please review this patch which removes unnecessary `@SuppressWarnings` annotations.

Archie Cobbs has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains 13 commits:

 - Remove more unnecessary @SuppressWarnings annotations.
 - Merge branch 'master' into SuppressWarningsCleanup-core-libs
 - Remove more unnecessary warning suppressions.
 - Merge branch 'master' into SuppressWarningsCleanup-core-libs
 - Put back @SuppressWarnings annotations to be fixed by JDK-8343286.
 - Merge branch 'master' into SuppressWarningsCleanup-core-libs
 - Update copyright years.
 - Remove a few more @SuppressWarnings annotations.
 - Remove a few more @SuppressWarnings annotations.
 - Update copyright years.
 - ... and 3 more: https://git.openjdk.org/jdk/compare/81e43114...1905d6e3

-------------

Changes: https://git.openjdk.org/jdk/pull/21852/files
  Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=21852&range=06
  Stats: 197 lines in 100 files changed: 0 ins; 104 del; 93 mod
  Patch: https://git.openjdk.org/jdk/pull/21852.diff
  Fetch: git fetch https://git.openjdk.org/jdk.git pull/21852/head:pull/21852

PR: https://git.openjdk.org/jdk/pull/21852

From asemenyuk at openjdk.org  Tue Nov 19 22:58:37 2024
From: asemenyuk at openjdk.org (Alexey Semenyuk)
Date: Tue, 19 Nov 2024 22:58:37 GMT
Subject: <i18n dev> RFR: 8343478: Remove unnecessary @SuppressWarnings
 annotations (core-libs) [v7]
In-Reply-To: <FbyrPlsyHoA5n00uzetLuQwtOqeRmzjV6IRFSEveyRs=.fc5e3346-4055-4f93-b9a4-923fceded816@github.com>
References: <9ZqHljyJeMr8fPG4-iU6bfQT9hQxTAwrGCl4xsQn3LA=.0b01f899-d849-4e23-8d50-8f186aade664@github.com>
 <FbyrPlsyHoA5n00uzetLuQwtOqeRmzjV6IRFSEveyRs=.fc5e3346-4055-4f93-b9a4-923fceded816@github.com>
Message-ID: <orMOnvkrksdnnyBuius74dW6mmg09oQWeoq3JaDSldA=.b65c151e-365d-4dde-bf04-8f5c09cb2018@github.com>

On Tue, 19 Nov 2024 21:50:13 GMT, Archie Cobbs <acobbs at openjdk.org> wrote:

>> Please review this patch which removes unnecessary `@SuppressWarnings` annotations.
>
> Archie Cobbs has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains 13 commits:
> 
>  - Remove more unnecessary @SuppressWarnings annotations.
>  - Merge branch 'master' into SuppressWarningsCleanup-core-libs
>  - Remove more unnecessary warning suppressions.
>  - Merge branch 'master' into SuppressWarningsCleanup-core-libs
>  - Put back @SuppressWarnings annotations to be fixed by JDK-8343286.
>  - Merge branch 'master' into SuppressWarningsCleanup-core-libs
>  - Update copyright years.
>  - Remove a few more @SuppressWarnings annotations.
>  - Remove a few more @SuppressWarnings annotations.
>  - Update copyright years.
>  - ... and 3 more: https://git.openjdk.org/jdk/compare/81e43114...1905d6e3

jpackage looks good. Thank you!

-------------

PR Comment: https://git.openjdk.org/jdk/pull/21852#issuecomment-2486917552

From prr at openjdk.org  Tue Nov 19 23:08:24 2024
From: prr at openjdk.org (Phil Race)
Date: Tue, 19 Nov 2024 23:08:24 GMT
Subject: <i18n dev> RFR: 8343476: Remove unnecessary @SuppressWarnings
 annotations (client) [v5]
In-Reply-To: <o0INHPwjTlR9Upnk4N7giXvcxmLsm_vj136AE11i-eg=.e1ff5846-5e4d-4c8e-a264-bb6bf0778fe7@github.com>
References: <Sa_OdV-UQBC_8sqALNkC2gOphd6PvXZ9EeisG_If2WQ=.36470214-24b9-457e-9183-24492a0d1df8@github.com>
 <o0INHPwjTlR9Upnk4N7giXvcxmLsm_vj136AE11i-eg=.e1ff5846-5e4d-4c8e-a264-bb6bf0778fe7@github.com>
Message-ID: <O1EWFMl_MfIPhgc8y6IrxYclUlGg1BndU7TIa1UPjxA=.9c313a44-468b-4581-b0fb-eac8f25f0934@github.com>

On Tue, 19 Nov 2024 21:36:19 GMT, Archie Cobbs <acobbs at openjdk.org> wrote:

>> Please review this patch which removes unnecessary `@SuppressWarnings` annotations.
>
> Archie Cobbs has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains eight commits:
> 
>  - Remove more unnecessary @SuppressWarnings annotations.
>  - Merge branch 'master' into SuppressWarningsCleanup-client
>  - Merge branch 'master' into SuppressWarningsCleanup-client
>  - Merge branch 'master' into SuppressWarningsCleanup-client
>  - Update copyright years.
>  - Merge branch 'master' into SuppressWarningsCleanup-client
>  - Merge branch 'master' into SuppressWarningsCleanup-client
>  - Remove unnecessary @SuppressWarnings annotations.

Updated version looks good

-------------

Marked as reviewed by prr (Reviewer).

PR Review: https://git.openjdk.org/jdk/pull/21850#pullrequestreview-2446826936

From acobbs at openjdk.org  Wed Nov 20 02:00:27 2024
From: acobbs at openjdk.org (Archie Cobbs)
Date: Wed, 20 Nov 2024 02:00:27 GMT
Subject: <i18n dev> Integrated: 8343476: Remove unnecessary
 @SuppressWarnings annotations (client)
In-Reply-To: <Sa_OdV-UQBC_8sqALNkC2gOphd6PvXZ9EeisG_If2WQ=.36470214-24b9-457e-9183-24492a0d1df8@github.com>
References: <Sa_OdV-UQBC_8sqALNkC2gOphd6PvXZ9EeisG_If2WQ=.36470214-24b9-457e-9183-24492a0d1df8@github.com>
Message-ID: <vJ0mmpoQIN_2KWW5IoFJuQNBcgZrSjCU-VFQK5U99lU=.0bc8c9bd-a312-40cd-841d-f43364fa99f4@github.com>

On Sat, 2 Nov 2024 15:22:15 GMT, Archie Cobbs <acobbs at openjdk.org> wrote:

> Please review this patch which removes unnecessary `@SuppressWarnings` annotations.

This pull request has now been integrated.

Changeset: 8a1f9f0a
Author:    Archie Cobbs <acobbs at openjdk.org>
URL:       https://git.openjdk.org/jdk/commit/8a1f9f0a324e30b5da53d58434ac1b39569fc523
Stats:     252 lines in 107 files changed: 0 ins; 157 del; 95 mod

8343476: Remove unnecessary @SuppressWarnings annotations (client)

Reviewed-by: prr

-------------

PR: https://git.openjdk.org/jdk/pull/21850

From jlu at openjdk.org  Wed Nov 20 03:03:22 2024
From: jlu at openjdk.org (Justin Lu)
Date: Wed, 20 Nov 2024 03:03:22 GMT
Subject: <i18n dev> RFR: 8341923: java.util.Locale class specification
 improvements [v3]
In-Reply-To: <a8ibOqDLUAn4-KOJtPQtD-FKDX73ZnvMI51UWLuDhPY=.f48b60d9-fe3b-401a-a952-38bbcc6cd843@github.com>
References: <a8ibOqDLUAn4-KOJtPQtD-FKDX73ZnvMI51UWLuDhPY=.f48b60d9-fe3b-401a-a952-38bbcc6cd843@github.com>
Message-ID: <vE7O7eohfvzyh6dyKqtUwNl2MgZutk8iz79kckxSttY=.762a5087-9176-4d8d-8bcc-a205d545034f@github.com>

> Please review this PR and corresponding CSR which includes a wide range of specification improvements for java.util.Locale. See the CSR for further detail. Other changes/suggestions are welcomed to be included as part of this change.
> 
> APIDiff: https://cr.openjdk.org/~jlu/8341923_apidiff/java.base/java/util/Locale.html
> Javadoc: https://cr.openjdk.org/~jlu/api/java.base/java/util/Locale.html

Justin Lu has updated the pull request incrementally with one additional commit since the last revision:

  address Naoto's comments

-------------

Changes:
  - all: https://git.openjdk.org/jdk/pull/22192/files
  - new: https://git.openjdk.org/jdk/pull/22192/files/6b5b5cd0..c8dd75cc

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jdk&pr=22192&range=02
 - incr: https://webrevs.openjdk.org/?repo=jdk&pr=22192&range=01-02

  Stats: 13 lines in 1 file changed: 3 ins; 0 del; 10 mod
  Patch: https://git.openjdk.org/jdk/pull/22192.diff
  Fetch: git fetch https://git.openjdk.org/jdk.git pull/22192/head:pull/22192

PR: https://git.openjdk.org/jdk/pull/22192

From jlu at openjdk.org  Wed Nov 20 03:03:24 2024
From: jlu at openjdk.org (Justin Lu)
Date: Wed, 20 Nov 2024 03:03:24 GMT
Subject: <i18n dev> RFR: 8341923: java.util.Locale class specification
 improvements [v2]
In-Reply-To: <SrzJo73RPFigmAaiueCT3eIwWsTGihps9ScE0I_kuXw=.67aa29f8-d82e-4d67-8e24-415da708d173@github.com>
References: <a8ibOqDLUAn4-KOJtPQtD-FKDX73ZnvMI51UWLuDhPY=.f48b60d9-fe3b-401a-a952-38bbcc6cd843@github.com>
 <8W7-Y64Rn1pVLuPfLoAktG-ekfebPelcoWQbxxiEMjE=.f07e118b-99ea-4ef0-909d-6141b08e4a55@github.com>
 <SrzJo73RPFigmAaiueCT3eIwWsTGihps9ScE0I_kuXw=.67aa29f8-d82e-4d67-8e24-415da708d173@github.com>
Message-ID: <71Ir0-EYssrJNJcR0Y6ytL2T1eCPdB9c8ERjqDVk-ts=.1bf9e7d9-b24b-4401-a663-0b045dba36be@github.com>

On Tue, 19 Nov 2024 19:46:42 GMT, Naoto Sato <naoto at openjdk.org> wrote:

>> Justin Lu has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   address Chen's review; make other similar changes
>
> src/java.base/share/classes/java/util/Locale.java line 89:
> 
>> 87:  * exchange. Each {@code Locale} is associated with locale data which is retrieved
>> 88:  * by the installed {@link java.util.spi.LocaleServiceProvider LocaleServiceProvider}
>> 89:  * implementations. Depending on the implementation, such data may vary by release.
> 
> This reads like locale data are only obtained with the SPI implementations that are provided by the users. The locale data also (and mainly) come from within Java runtime itself. (BTW, "installed" should be removed, as it is no longer correct. Same applies to getAvailableLocales()/availableLocales() methods)

Thanks for the review Naoto. 

My angle was that the `"installed LocaleServiceProvider implementations"` implicitly included the Java runtime data as the default provider. The new wording is more explicit, please let me know what you think.

Also, "installed" is now replaced with "deployed" which is consistent with `ServiceLoader`. The rest of your suggestions should be fixed in https://github.com/openjdk/jdk/pull/22192/commits/c8dd75cc738316e34d203cde8a867a77efbca63e (minus the one I left a comment on).

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/22192#discussion_r1849432962

From jlu at openjdk.org  Wed Nov 20 03:03:26 2024
From: jlu at openjdk.org (Justin Lu)
Date: Wed, 20 Nov 2024 03:03:26 GMT
Subject: <i18n dev> RFR: 8341923: java.util.Locale class specification
 improvements [v3]
In-Reply-To: <SrzJo73RPFigmAaiueCT3eIwWsTGihps9ScE0I_kuXw=.67aa29f8-d82e-4d67-8e24-415da708d173@github.com>
References: <a8ibOqDLUAn4-KOJtPQtD-FKDX73ZnvMI51UWLuDhPY=.f48b60d9-fe3b-401a-a952-38bbcc6cd843@github.com>
 <8W7-Y64Rn1pVLuPfLoAktG-ekfebPelcoWQbxxiEMjE=.f07e118b-99ea-4ef0-909d-6141b08e4a55@github.com>
 <SrzJo73RPFigmAaiueCT3eIwWsTGihps9ScE0I_kuXw=.67aa29f8-d82e-4d67-8e24-415da708d173@github.com>
Message-ID: <Y9OuBynI-KIhZQ_il_zV0csS7SxtBBPN62SFaMf1nJs=.f91540a0-740e-4ded-896c-6f50959e8c5c@github.com>

On Tue, 19 Nov 2024 20:30:11 GMT, Naoto Sato <naoto at openjdk.org> wrote:

>> Justin Lu has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   address Naoto's comments
>
> src/java.base/share/classes/java/util/Locale.java line 144:
> 
>> 142:  *   each indicating its own semantics, these values should be ordered
>> 143:  *   by importance, with most important first, separated by
>> 144:  *   underscore('_').  The variant field is case sensitive.</dd>
> 
> This part "separated by underscore('_')" is missing in the revised doc

I intentionally omitted this because

- I thought it was redundant as the syntax already follows a few lines below.
- The `Locale` syntax allows both `_` and  `-`, not just `_`.

However, if you think it should remain, I'll restore it as `separated by ('_'|'-')`.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/22192#discussion_r1849432988

From jlu at openjdk.org  Wed Nov 20 03:04:56 2024
From: jlu at openjdk.org (Justin Lu)
Date: Wed, 20 Nov 2024 03:04:56 GMT
Subject: <i18n dev> RFR: 8344589: Update IANA Language Subtag Registry to
 Version 2024-11-19
Message-ID: <gAQGUkG03O5urb6kto7g-kg9mTz0SrDPLfJj57oky8g=.1f7918c0-7edf-43c8-bd97-4bf050d8f034@github.com>

Please review this PR which keeps the IANA language subtag registry data up to date with release _2024-11-19_.

The changes are trivial and Locale tests pass as expected.

-------------

Commit messages:
 - init

Changes: https://git.openjdk.org/jdk/pull/22265/files
  Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=22265&range=00
  Issue: https://bugs.openjdk.org/browse/JDK-8344589
  Stats: 13 lines in 2 files changed: 10 ins; 0 del; 3 mod
  Patch: https://git.openjdk.org/jdk/pull/22265.diff
  Fetch: git fetch https://git.openjdk.org/jdk.git pull/22265/head:pull/22265

PR: https://git.openjdk.org/jdk/pull/22265

From iris at openjdk.org  Wed Nov 20 03:19:15 2024
From: iris at openjdk.org (Iris Clark)
Date: Wed, 20 Nov 2024 03:19:15 GMT
Subject: <i18n dev> RFR: 8344589: Update IANA Language Subtag Registry
 to Version 2024-11-19
In-Reply-To: <gAQGUkG03O5urb6kto7g-kg9mTz0SrDPLfJj57oky8g=.1f7918c0-7edf-43c8-bd97-4bf050d8f034@github.com>
References: <gAQGUkG03O5urb6kto7g-kg9mTz0SrDPLfJj57oky8g=.1f7918c0-7edf-43c8-bd97-4bf050d8f034@github.com>
Message-ID: <4pglEY5pYSPAU9uW54twpL957kaPZg-fmlqi8fDU_lQ=.265959b6-8f44-4462-8dab-871288aa75d5@github.com>

On Wed, 20 Nov 2024 02:59:54 GMT, Justin Lu <jlu at openjdk.org> wrote:

> Please review this PR which keeps the IANA language subtag registry data up to date with release _2024-11-19_.
> 
> The changes are trivial and Locale tests pass as expected.

Marked as reviewed by iris (Reviewer).

-------------

PR Review: https://git.openjdk.org/jdk/pull/22265#pullrequestreview-2447256614

From azvegint at openjdk.org  Wed Nov 20 04:08:15 2024
From: azvegint at openjdk.org (Alexander Zvegintsev)
Date: Wed, 20 Nov 2024 04:08:15 GMT
Subject: <i18n dev> RFR: 8342903: Deprecate for removal
 java.awt.Window.getWarningString() [v2]
In-Reply-To: <o1r6bTcg7UECs4kNq-RLY3grB9Kobn4JPCpRnbzHbc8=.9d0da935-64f1-43c7-84c6-2925eadd19bc@github.com>
References: <cZN3bZf5PIhmNeTvGZezBoleZkq5oNWQI9GUlneoPAk=.d1a819dd-d7b7-4708-bb66-d57fab85191d@github.com>
 <o1r6bTcg7UECs4kNq-RLY3grB9Kobn4JPCpRnbzHbc8=.9d0da935-64f1-43c7-84c6-2925eadd19bc@github.com>
Message-ID: <mpYb45jR3WSsbWMPGGnQIk_vBtmwKTvZqRKw3Qy5YC8=.52f04ef4-6b99-4a60-864e-66e6d361fbfc@github.com>

On Tue, 19 Nov 2024 19:29:28 GMT, Phil Race <prr at openjdk.org> wrote:

>> This fix deprecates for removal java.awt.Window.getWarningString() and also javax.swing.JInternalFrame.getWarningString()
>> l java.awt.Window.getWarningString() is only relevant with a SecurityManager and javax.swing.JInternalFrame.getWarningString() is just there for symmetry.
>> 
>> A few other spec changes ensue - the serial form variable warningString is removed is the main one.
>> The AWTPermission showWindowWithoutWarningBanner is obsolete
>> Reference to the system property  "awt.appletWarning" was actually already removed by JEP 486
>> 
>> There is a CSR for the spec. changes, which will need a reviewer : https://bugs.openjdk.org/browse/JDK-8344451
>> 
>> But the vast majority of the changes here are all the downstream obsoleted implementation
>> The warning string and warning icon, and warning windows are all obsoleted.
>> I think I tracked down all of it, but it is hard to be sure.
>> Automated tests are passing, and I've manually tested SwingSet2 on all 3 platforms.
>
> Phil Race has updated the pull request incrementally with one additional commit since the last revision:
> 
>   8344451

I'll still be looking further, but it seems that there are few places that need more attention:


# grep for securitywarning
./open/src/jdk.compiler/share/data/symbols/java.desktop-8.sym.txt:7709:method name repositionSecurityWarning descriptor ()V flags 401
./src/java.desktop/unix/classes/sun/awt/X11/XToolkit.java:206:    static boolean securityWarningEnabled;
./src/java.desktop/unix/classes/sun/awt/X11/XToolkit.java:218:        initSecurityWarning();
./src/java.desktop/unix/classes/sun/awt/X11/XToolkit.java:247:    static void initSecurityWarning() {
./src/java.desktop/unix/classes/sun/awt/X11/XToolkit.java:252:        securityWarningEnabled = (runtime != null && runtime.contains("internal"));
./src/java.desktop/unix/classes/sun/awt/X11/XToolkit.java:255:    static boolean isSecurityWarningEnabled() {
./src/java.desktop/unix/classes/sun/awt/X11/XToolkit.java:256:        return securityWarningEnabled;
./src/java.desktop/unix/classes/sun/awt/X11/XBaseWindow.java:947:        if (XToolkit.isSecurityWarningEnabled() && XToolkit.isToolkitThread()) {
./src/java.desktop/windows/native/libawt/windows/awt.rc:32:// securityWarningIconCounter constant in awt_Toolkit.cpp.


`XToolkit` can also be cleaned up, and all usages of `XBaseWindow#checkSecurity()` can also be removed.

The `awt.rc` file looks like another candidate for removal, along with an update of `AwtLibraries.gmk`.

-------------

PR Comment: https://git.openjdk.org/jdk/pull/22221#issuecomment-2487363775

From lancea at openjdk.org  Wed Nov 20 12:18:17 2024
From: lancea at openjdk.org (Lance Andersen)
Date: Wed, 20 Nov 2024 12:18:17 GMT
Subject: <i18n dev> RFR: 8344589: Update IANA Language Subtag Registry
 to Version 2024-11-19
In-Reply-To: <gAQGUkG03O5urb6kto7g-kg9mTz0SrDPLfJj57oky8g=.1f7918c0-7edf-43c8-bd97-4bf050d8f034@github.com>
References: <gAQGUkG03O5urb6kto7g-kg9mTz0SrDPLfJj57oky8g=.1f7918c0-7edf-43c8-bd97-4bf050d8f034@github.com>
Message-ID: <a6aTLSlFrpIK23LQObn65ZsIVkGCbAAudCTYd83G46M=.a66de53c-2dd3-4432-9ea0-5f2eaa8c83a5@github.com>

On Wed, 20 Nov 2024 02:59:54 GMT, Justin Lu <jlu at openjdk.org> wrote:

> Please review this PR which keeps the IANA language subtag registry data up to date with release _2024-11-19_.
> 
> The changes are trivial and Locale tests pass as expected.

Marked as reviewed by lancea (Reviewer).

-------------

PR Review: https://git.openjdk.org/jdk/pull/22265#pullrequestreview-2448458803

From naoto at openjdk.org  Wed Nov 20 18:03:18 2024
From: naoto at openjdk.org (Naoto Sato)
Date: Wed, 20 Nov 2024 18:03:18 GMT
Subject: <i18n dev> RFR: 8344589: Update IANA Language Subtag Registry
 to Version 2024-11-19
In-Reply-To: <gAQGUkG03O5urb6kto7g-kg9mTz0SrDPLfJj57oky8g=.1f7918c0-7edf-43c8-bd97-4bf050d8f034@github.com>
References: <gAQGUkG03O5urb6kto7g-kg9mTz0SrDPLfJj57oky8g=.1f7918c0-7edf-43c8-bd97-4bf050d8f034@github.com>
Message-ID: <lr1hr1fF3lcdGRUwW5FM0Y99t27hhomnzU9QN_dU8eI=.180a49b2-f31a-4356-bdb8-3d46078498bb@github.com>

On Wed, 20 Nov 2024 02:59:54 GMT, Justin Lu <jlu at openjdk.org> wrote:

> Please review this PR which keeps the IANA language subtag registry data up to date with release _2024-11-19_.
> 
> The changes are trivial and Locale tests pass as expected.

Marked as reviewed by naoto (Reviewer).

-------------

PR Review: https://git.openjdk.org/jdk/pull/22265#pullrequestreview-2449347637

From naoto at openjdk.org  Wed Nov 20 18:33:35 2024
From: naoto at openjdk.org (Naoto Sato)
Date: Wed, 20 Nov 2024 18:33:35 GMT
Subject: <i18n dev> RFR: 8341923: java.util.Locale class specification
 improvements [v3]
In-Reply-To: <vE7O7eohfvzyh6dyKqtUwNl2MgZutk8iz79kckxSttY=.762a5087-9176-4d8d-8bcc-a205d545034f@github.com>
References: <a8ibOqDLUAn4-KOJtPQtD-FKDX73ZnvMI51UWLuDhPY=.f48b60d9-fe3b-401a-a952-38bbcc6cd843@github.com>
 <vE7O7eohfvzyh6dyKqtUwNl2MgZutk8iz79kckxSttY=.762a5087-9176-4d8d-8bcc-a205d545034f@github.com>
Message-ID: <sRqt5oxkg9xl7W2Pxwnz0CtKbqJpMNjZ8c996a84CBQ=.67c3ab45-f6c2-496a-95cd-be406ac0f194@github.com>

On Wed, 20 Nov 2024 03:03:22 GMT, Justin Lu <jlu at openjdk.org> wrote:

>> Please review this PR and corresponding CSR which includes a wide range of specification improvements for java.util.Locale. See the CSR for further detail. Other changes/suggestions are welcomed to be included as part of this change.
>> 
>> APIDiff: https://cr.openjdk.org/~jlu/8341923_apidiff/java.base/java/util/Locale.html
>> Javadoc: https://cr.openjdk.org/~jlu/api/java.base/java/util/Locale.html
>
> Justin Lu has updated the pull request incrementally with one additional commit since the last revision:
> 
>   address Naoto's comments

Thanks for the changes. A couple of minor comments

src/java.base/share/classes/java/util/Locale.java line 1256:

> 1254: 
> 1255:     /**
> 1256:      * {@return an array of deployed locales}

Since "deployed" is the term from ServiceLoader, it might mean only referring to SPI impls, so how about simply "available"?

-------------

PR Review: https://git.openjdk.org/jdk/pull/22192#pullrequestreview-2449377299
PR Review Comment: https://git.openjdk.org/jdk/pull/22192#discussion_r1850787428

From naoto at openjdk.org  Wed Nov 20 18:33:36 2024
From: naoto at openjdk.org (Naoto Sato)
Date: Wed, 20 Nov 2024 18:33:36 GMT
Subject: <i18n dev> RFR: 8341923: java.util.Locale class specification
 improvements [v3]
In-Reply-To: <Y9OuBynI-KIhZQ_il_zV0csS7SxtBBPN62SFaMf1nJs=.f91540a0-740e-4ded-896c-6f50959e8c5c@github.com>
References: <a8ibOqDLUAn4-KOJtPQtD-FKDX73ZnvMI51UWLuDhPY=.f48b60d9-fe3b-401a-a952-38bbcc6cd843@github.com>
 <8W7-Y64Rn1pVLuPfLoAktG-ekfebPelcoWQbxxiEMjE=.f07e118b-99ea-4ef0-909d-6141b08e4a55@github.com>
 <SrzJo73RPFigmAaiueCT3eIwWsTGihps9ScE0I_kuXw=.67aa29f8-d82e-4d67-8e24-415da708d173@github.com>
 <Y9OuBynI-KIhZQ_il_zV0csS7SxtBBPN62SFaMf1nJs=.f91540a0-740e-4ded-896c-6f50959e8c5c@github.com>
Message-ID: <0i1cQoY85au5SjDgWicrVBvwWQrSDR-ju3sCVNFxZRU=.da84ec2a-47b8-4f75-ad28-38811223b7b9@github.com>

On Wed, 20 Nov 2024 02:58:45 GMT, Justin Lu <jlu at openjdk.org> wrote:

>> src/java.base/share/classes/java/util/Locale.java line 144:
>> 
>>> 142:  *   each indicating its own semantics, these values should be ordered
>>> 143:  *   by importance, with most important first, separated by
>>> 144:  *   underscore('_').  The variant field is case sensitive.</dd>
>> 
>> This part "separated by underscore('_')" is missing in the revised doc
>
> I intentionally omitted this because
> 
> - I thought it was redundant as the syntax already follows a few lines below.
> - The `Locale` syntax allows both `_` and  `-`, not just `_`.
> 
> However, if you think it should remain, I'll restore it as `separated by ('_'|'-')`.

I was thinking how to parse "XX_YY-Z" variant. Since it is not well-formed subtags in BCP 47 definition, it should be delimited by `_` so there would be two values, "XX" and "YY-Z" according to the current spec. However, I understand that the implementation treats '_' and '-' equally both for well-formed and ill-formed variant values, I think it's better to put `separated by ('_'|'-')` to remedy the spec.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/22192#discussion_r1850781651

From naoto at openjdk.org  Wed Nov 20 19:03:35 2024
From: naoto at openjdk.org (Naoto Sato)
Date: Wed, 20 Nov 2024 19:03:35 GMT
Subject: <i18n dev> RFR: 8319993: Update Unicode Data Files to 16.0.0
Message-ID: <lhjftuxraeNfYcmqtLlHjH0COs5-oyjaZlz_oMsoUG0=.5c1fc0e0-781d-4610-ab0c-6ed8fd4b525c@github.com>

Updates the JDK to use the latest Unicode 16.0.0, which also updates the ICU4J along with it (8319992: Update ICU4J to Version 76.1). The corresponding CSR has already been approved.

-------------

Commit messages:
 - icu.md changes
 - Merge branch 'master' into JDK-8319993-Unicode-16
 - Merge branch 'master' into JDK-8319993-Unicode-16
 - Merge branch 'master' into JDK-8319993-Unicode-16
 - Fixing UnicodeBlock aliases for TULU_TIGALARI
 - ICU4J 76.1 release
 - .md files
 - ICU4J changes
 - iniital commit

Changes: https://git.openjdk.org/jdk/pull/21771/files
  Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=21771&range=00
  Issue: https://bugs.openjdk.org/browse/JDK-8319993
  Stats: 8442 lines in 29 files changed: 7542 ins; 296 del; 604 mod
  Patch: https://git.openjdk.org/jdk/pull/21771.diff
  Fetch: git fetch https://git.openjdk.org/jdk.git pull/21771/head:pull/21771

PR: https://git.openjdk.org/jdk/pull/21771

From prr at openjdk.org  Wed Nov 20 19:48:23 2024
From: prr at openjdk.org (Phil Race)
Date: Wed, 20 Nov 2024 19:48:23 GMT
Subject: <i18n dev> RFR: 8342903: Deprecate for removal
 java.awt.Window.getWarningString() [v2]
In-Reply-To: <o1r6bTcg7UECs4kNq-RLY3grB9Kobn4JPCpRnbzHbc8=.9d0da935-64f1-43c7-84c6-2925eadd19bc@github.com>
References: <cZN3bZf5PIhmNeTvGZezBoleZkq5oNWQI9GUlneoPAk=.d1a819dd-d7b7-4708-bb66-d57fab85191d@github.com>
 <o1r6bTcg7UECs4kNq-RLY3grB9Kobn4JPCpRnbzHbc8=.9d0da935-64f1-43c7-84c6-2925eadd19bc@github.com>
Message-ID: <VRXIWwWPomsidZXJu0gOOwsfLUUoGHZWnJ0knyGnp5o=.57ca4c36-942d-4564-a1a4-9e9dcfe0f5f8@github.com>

On Tue, 19 Nov 2024 19:29:28 GMT, Phil Race <prr at openjdk.org> wrote:

>> This fix deprecates for removal java.awt.Window.getWarningString() and also javax.swing.JInternalFrame.getWarningString()
>> l java.awt.Window.getWarningString() is only relevant with a SecurityManager and javax.swing.JInternalFrame.getWarningString() is just there for symmetry.
>> 
>> A few other spec changes ensue - the serial form variable warningString is removed is the main one.
>> The AWTPermission showWindowWithoutWarningBanner is obsolete
>> Reference to the system property  "awt.appletWarning" was actually already removed by JEP 486
>> 
>> There is a CSR for the spec. changes, which will need a reviewer : https://bugs.openjdk.org/browse/JDK-8344451
>> 
>> But the vast majority of the changes here are all the downstream obsoleted implementation
>> The warning string and warning icon, and warning windows are all obsoleted.
>> I think I tracked down all of it, but it is hard to be sure.
>> Automated tests are passing, and I've manually tested SwingSet2 on all 3 platforms.
>
> Phil Race has updated the pull request incrementally with one additional commit since the last revision:
> 
>   8344451

> I'll still be looking further, but it seems that there are few places that need more attention:
> 
> ```shell
> # grep for securitywarning
> ./open/src/jdk.compiler/share/data/symbols/java.desktop-8.sym.txt:7709:method name repositionSecurityWarning descriptor ()V flags 401
> ./src/java.desktop/unix/classes/sun/awt/X11/XToolkit.java:206:    static boolean securityWarningEnabled;
> ./src/java.desktop/unix/classes/sun/awt/X11/XToolkit.java:218:        initSecurityWarning();
> ./src/java.desktop/unix/classes/sun/awt/X11/XToolkit.java:247:    static void initSecurityWarning() {
> ./src/java.desktop/unix/classes/sun/awt/X11/XToolkit.java:252:        securityWarningEnabled = (runtime != null && runtime.contains("internal"));
> ./src/java.desktop/unix/classes/sun/awt/X11/XToolkit.java:255:    static boolean isSecurityWarningEnabled() {
> ./src/java.desktop/unix/classes/sun/awt/X11/XToolkit.java:256:        return securityWarningEnabled;
> ./src/java.desktop/unix/classes/sun/awt/X11/XBaseWindow.java:947:        if (XToolkit.isSecurityWarningEnabled() && XToolkit.isToolkitThread()) {
> ./src/java.desktop/windows/native/libawt/windows/awt.rc:32:// securityWarningIconCounter constant in awt_Toolkit.cpp.
> ```
> 
> `XToolkit` can also be cleaned up, and all usages of `XBaseWindow#checkSecurity()` can also be removed.
> 
> The `awt.rc` file looks like another candidate for removal, along with an update of `AwtLibraries.gmk`.



> I'll still be looking further, but it seems that there are few places that need more attention:
> 
> ```shell
> # grep for securitywarning
> ./open/src/jdk.compiler/share/data/symbols/java.desktop-8.sym.txt:7709:method name repositionSecurityWarning descriptor ()V flags 401
> ./src/java.desktop/unix/classes/sun/awt/X11/XToolkit.java:206:    static boolean securityWarningEnabled;
> ./src/java.desktop/unix/classes/sun/awt/X11/XToolkit.java:218:        initSecurityWarning();
> ./src/java.desktop/unix/classes/sun/awt/X11/XToolkit.java:247:    static void initSecurityWarning() {
> ./src/java.desktop/unix/classes/sun/awt/X11/XToolkit.java:252:        securityWarningEnabled = (runtime != null && runtime.contains("internal"));
> ./src/java.desktop/unix/classes/sun/awt/X11/XToolkit.java:255:    static boolean isSecurityWarningEnabled() {
> ./src/java.desktop/unix/classes/sun/awt/X11/XToolkit.java:256:        return securityWarningEnabled;
> ./src/java.desktop/unix/classes/sun/awt/X11/XBaseWindow.java:947:        if (XToolkit.isSecurityWarningEnabled() && XToolkit.isToolkitThread()) {

I thought I'd got those (!) Must have not got back to them. So many trails to follow.
Fixing it just now I realise this is going to conflict with Harshita's PR : https://github.com/openjdk/jdk/pull/22218 - oh well .. I'll resolve that when I have to.

> ./src/java.desktop/windows/native/libawt/windows/awt.rc:32:// securityWarningIconCounter constant in awt_Toolkit.cpp.
> ```
> 
> `XToolkit` can also be cleaned up, and all usages of `XBaseWindow#checkSecurity()` can also be removed.

yes. checkSecurity can go.

> 
> The `awt.rc` file looks like another candidate for removal, along with an update of `AwtLibraries.gmk`.

It seems like it is just the refs to the SECURITY_WARNING icons (and the icon files themselves) that should be removed, so the file is edited but not removed and no change to the make file.

-------------

PR Comment: https://git.openjdk.org/jdk/pull/22221#issuecomment-2489413787

From prr at openjdk.org  Wed Nov 20 23:35:07 2024
From: prr at openjdk.org (Phil Race)
Date: Wed, 20 Nov 2024 23:35:07 GMT
Subject: <i18n dev> RFR: 8344664: Remove some un-used java/sun.security
 imports in the java.desktop module
Message-ID: <K7uRT8ay0rOXr4F1LAgBruxXbtpLeq5brvei9A9GpBM=.52e208e4-ad42-4e43-a5b6-15fec37ef103@github.com>

delete un-used imports and obsolete comments

-------------

Commit messages:
 - 8344664

Changes: https://git.openjdk.org/jdk/pull/22286/files
  Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=22286&range=00
  Issue: https://bugs.openjdk.org/browse/JDK-8344664
  Stats: 21 lines in 13 files changed: 0 ins; 21 del; 0 mod
  Patch: https://git.openjdk.org/jdk/pull/22286.diff
  Fetch: git fetch https://git.openjdk.org/jdk.git pull/22286/head:pull/22286

PR: https://git.openjdk.org/jdk/pull/22286

From prr at openjdk.org  Wed Nov 20 23:41:50 2024
From: prr at openjdk.org (Phil Race)
Date: Wed, 20 Nov 2024 23:41:50 GMT
Subject: <i18n dev> RFR: 8342903: Deprecate for removal
 java.awt.Window.getWarningString() [v3]
In-Reply-To: <cZN3bZf5PIhmNeTvGZezBoleZkq5oNWQI9GUlneoPAk=.d1a819dd-d7b7-4708-bb66-d57fab85191d@github.com>
References: <cZN3bZf5PIhmNeTvGZezBoleZkq5oNWQI9GUlneoPAk=.d1a819dd-d7b7-4708-bb66-d57fab85191d@github.com>
Message-ID: <de4sfeGG7nN0t1i_pih0ipAJ9aCIZjn69fkz_29S4x8=.be850b51-88bd-4d8e-b211-2246625bcdf4@github.com>

> This fix deprecates for removal java.awt.Window.getWarningString() and also javax.swing.JInternalFrame.getWarningString()
> l java.awt.Window.getWarningString() is only relevant with a SecurityManager and javax.swing.JInternalFrame.getWarningString() is just there for symmetry.
> 
> A few other spec changes ensue - the serial form variable warningString is removed is the main one.
> The AWTPermission showWindowWithoutWarningBanner is obsolete
> Reference to the system property  "awt.appletWarning" was actually already removed by JEP 486
> 
> There is a CSR for the spec. changes, which will need a reviewer : https://bugs.openjdk.org/browse/JDK-8344451
> 
> But the vast majority of the changes here are all the downstream obsoleted implementation
> The warning string and warning icon, and warning windows are all obsoleted.
> I think I tracked down all of it, but it is hard to be sure.
> Automated tests are passing, and I've manually tested SwingSet2 on all 3 platforms.

Phil Race has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains four additional commits since the last revision:

 - 8342903
 - Merge remote-tracking branch 'upstream/master' into warningstring
   Merge master
 - 8344451
 - 8344451

-------------

Changes:
  - all: https://git.openjdk.org/jdk/pull/22221/files
  - new: https://git.openjdk.org/jdk/pull/22221/files/cebd99ef..15b9eab4

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jdk&pr=22221&range=02
 - incr: https://webrevs.openjdk.org/?repo=jdk&pr=22221&range=01-02

  Stats: 61089 lines in 778 files changed: 26652 ins; 31198 del; 3239 mod
  Patch: https://git.openjdk.org/jdk/pull/22221.diff
  Fetch: git fetch https://git.openjdk.org/jdk.git pull/22221/head:pull/22221

PR: https://git.openjdk.org/jdk/pull/22221

From prr at openjdk.org  Wed Nov 20 23:41:50 2024
From: prr at openjdk.org (Phil Race)
Date: Wed, 20 Nov 2024 23:41:50 GMT
Subject: <i18n dev> RFR: 8342903: Deprecate for removal
 java.awt.Window.getWarningString() [v2]
In-Reply-To: <o1r6bTcg7UECs4kNq-RLY3grB9Kobn4JPCpRnbzHbc8=.9d0da935-64f1-43c7-84c6-2925eadd19bc@github.com>
References: <cZN3bZf5PIhmNeTvGZezBoleZkq5oNWQI9GUlneoPAk=.d1a819dd-d7b7-4708-bb66-d57fab85191d@github.com>
 <o1r6bTcg7UECs4kNq-RLY3grB9Kobn4JPCpRnbzHbc8=.9d0da935-64f1-43c7-84c6-2925eadd19bc@github.com>
Message-ID: <FFtGGGX4LwxPC1EYaUuPdjYvDKGixprzZ7ZoKCQcrxU=.68d7fdf1-d572-4412-af93-c3fb8e441f79@github.com>

On Tue, 19 Nov 2024 19:29:28 GMT, Phil Race <prr at openjdk.org> wrote:

>> This fix deprecates for removal java.awt.Window.getWarningString() and also javax.swing.JInternalFrame.getWarningString()
>> l java.awt.Window.getWarningString() is only relevant with a SecurityManager and javax.swing.JInternalFrame.getWarningString() is just there for symmetry.
>> 
>> A few other spec changes ensue - the serial form variable warningString is removed is the main one.
>> The AWTPermission showWindowWithoutWarningBanner is obsolete
>> Reference to the system property  "awt.appletWarning" was actually already removed by JEP 486
>> 
>> There is a CSR for the spec. changes, which will need a reviewer : https://bugs.openjdk.org/browse/JDK-8344451
>> 
>> But the vast majority of the changes here are all the downstream obsoleted implementation
>> The warning string and warning icon, and warning windows are all obsoleted.
>> I think I tracked down all of it, but it is hard to be sure.
>> Automated tests are passing, and I've manually tested SwingSet2 on all 3 platforms.
>
> Phil Race has updated the pull request incrementally with one additional commit since the last revision:
> 
>   8344451

Updated per Alexander's comments

-------------

PR Comment: https://git.openjdk.org/jdk/pull/22221#issuecomment-2489758929

From iris at openjdk.org  Thu Nov 21 04:15:17 2024
From: iris at openjdk.org (Iris Clark)
Date: Thu, 21 Nov 2024 04:15:17 GMT
Subject: <i18n dev> RFR: 8344664: Remove some un-used java/sun.security
 imports in the java.desktop module
In-Reply-To: <K7uRT8ay0rOXr4F1LAgBruxXbtpLeq5brvei9A9GpBM=.52e208e4-ad42-4e43-a5b6-15fec37ef103@github.com>
References: <K7uRT8ay0rOXr4F1LAgBruxXbtpLeq5brvei9A9GpBM=.52e208e4-ad42-4e43-a5b6-15fec37ef103@github.com>
Message-ID: <ZwRWJpAEdYTcyA1qDqddHNkFcZeobMePYrJTinV1VZs=.cce1a1c5-85b4-4748-8494-19d3498c4fbb@github.com>

On Wed, 20 Nov 2024 23:18:48 GMT, Phil Race <prr at openjdk.org> wrote:

> delete un-used imports and obsolete comments

Builds succeeded.  Deleted imports clearly not needed.

-------------

Marked as reviewed by iris (Reviewer).

PR Review: https://git.openjdk.org/jdk/pull/22286#pullrequestreview-2450188200

From prr at openjdk.org  Thu Nov 21 04:25:21 2024
From: prr at openjdk.org (Phil Race)
Date: Thu, 21 Nov 2024 04:25:21 GMT
Subject: <i18n dev> Integrated: 8344664: Remove some un-used
 java/sun.security imports in the java.desktop module
In-Reply-To: <K7uRT8ay0rOXr4F1LAgBruxXbtpLeq5brvei9A9GpBM=.52e208e4-ad42-4e43-a5b6-15fec37ef103@github.com>
References: <K7uRT8ay0rOXr4F1LAgBruxXbtpLeq5brvei9A9GpBM=.52e208e4-ad42-4e43-a5b6-15fec37ef103@github.com>
Message-ID: <eOe_QKtkUOuXvg51VnY72dEhZ0veowk90y-VQT8Mbwo=.ad941621-1a75-433c-a7e0-b88b03754bdb@github.com>

On Wed, 20 Nov 2024 23:18:48 GMT, Phil Race <prr at openjdk.org> wrote:

> delete un-used imports and obsolete comments

This pull request has now been integrated.

Changeset: 7105bb98
Author:    Phil Race <prr at openjdk.org>
URL:       https://git.openjdk.org/jdk/commit/7105bb98cf8797082d2b61f0e08a4e5ba0bae8ac
Stats:     21 lines in 13 files changed: 0 ins; 21 del; 0 mod

8344664: Remove some un-used java/sun.security imports in the java.desktop module

Reviewed-by: iris

-------------

PR: https://git.openjdk.org/jdk/pull/22286

From jlu at openjdk.org  Thu Nov 21 06:53:58 2024
From: jlu at openjdk.org (Justin Lu)
Date: Thu, 21 Nov 2024 06:53:58 GMT
Subject: <i18n dev> RFR: 8341923: java.util.Locale class specification
 improvements [v4]
In-Reply-To: <a8ibOqDLUAn4-KOJtPQtD-FKDX73ZnvMI51UWLuDhPY=.f48b60d9-fe3b-401a-a952-38bbcc6cd843@github.com>
References: <a8ibOqDLUAn4-KOJtPQtD-FKDX73ZnvMI51UWLuDhPY=.f48b60d9-fe3b-401a-a952-38bbcc6cd843@github.com>
Message-ID: <xTxbdWdErCsY1XF0SBmcUb7t4iKeuyw6fVFHkEjQ49E=.ac5332aa-f18d-466a-ba74-7e21d8e552d8@github.com>

> Please review this PR and corresponding CSR which includes a wide range of specification improvements for java.util.Locale. See the CSR for further detail. Other changes/suggestions are welcomed to be included as part of this change.
> 
> APIDiff: https://cr.openjdk.org/~jlu/8341923_apidiff/java.base/java/util/Locale.html
> Javadoc: https://cr.openjdk.org/~jlu/api/java.base/java/util/Locale.html

Justin Lu has updated the pull request incrementally with one additional commit since the last revision:

  reflect review

-------------

Changes:
  - all: https://git.openjdk.org/jdk/pull/22192/files
  - new: https://git.openjdk.org/jdk/pull/22192/files/c8dd75cc..871d635a

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jdk&pr=22192&range=03
 - incr: https://webrevs.openjdk.org/?repo=jdk&pr=22192&range=02-03

  Stats: 4 lines in 1 file changed: 0 ins; 0 del; 4 mod
  Patch: https://git.openjdk.org/jdk/pull/22192.diff
  Fetch: git fetch https://git.openjdk.org/jdk.git pull/22192/head:pull/22192

PR: https://git.openjdk.org/jdk/pull/22192

From jlu at openjdk.org  Thu Nov 21 06:53:58 2024
From: jlu at openjdk.org (Justin Lu)
Date: Thu, 21 Nov 2024 06:53:58 GMT
Subject: <i18n dev> RFR: 8341923: java.util.Locale class specification
 improvements [v3]
In-Reply-To: <sRqt5oxkg9xl7W2Pxwnz0CtKbqJpMNjZ8c996a84CBQ=.67c3ab45-f6c2-496a-95cd-be406ac0f194@github.com>
References: <a8ibOqDLUAn4-KOJtPQtD-FKDX73ZnvMI51UWLuDhPY=.f48b60d9-fe3b-401a-a952-38bbcc6cd843@github.com>
 <vE7O7eohfvzyh6dyKqtUwNl2MgZutk8iz79kckxSttY=.762a5087-9176-4d8d-8bcc-a205d545034f@github.com>
 <sRqt5oxkg9xl7W2Pxwnz0CtKbqJpMNjZ8c996a84CBQ=.67c3ab45-f6c2-496a-95cd-be406ac0f194@github.com>
Message-ID: <Kx4d5jR9rCf_7XbBX1Gizp9V-NoC3E36FmEofEbm-rY=.3b202788-5fe3-448d-a535-f4f9948ef59a@github.com>

On Wed, 20 Nov 2024 18:20:04 GMT, Naoto Sato <naoto at openjdk.org> wrote:

>> Justin Lu has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   address Naoto's comments
>
> src/java.base/share/classes/java/util/Locale.java line 1256:
> 
>> 1254: 
>> 1255:     /**
>> 1256:      * {@return an array of deployed locales}
> 
> Since "deployed" is the term from ServiceLoader, it might mean only referring to SPI impls, so how about simply "available"?

Both comments addressed. CSR will be updated once the JBS login issues get resolved :-).

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/22192#discussion_r1851456088

From prr at openjdk.org  Thu Nov 21 17:50:36 2024
From: prr at openjdk.org (Phil Race)
Date: Thu, 21 Nov 2024 17:50:36 GMT
Subject: <i18n dev> RFR: 8342903: Deprecate for removal
 java.awt.Window.getWarningString() [v4]
In-Reply-To: <cZN3bZf5PIhmNeTvGZezBoleZkq5oNWQI9GUlneoPAk=.d1a819dd-d7b7-4708-bb66-d57fab85191d@github.com>
References: <cZN3bZf5PIhmNeTvGZezBoleZkq5oNWQI9GUlneoPAk=.d1a819dd-d7b7-4708-bb66-d57fab85191d@github.com>
Message-ID: <SMSPP3aOWDww4azwQZT6bJnF16YOJMVJVIz7JKk3_bE=.a09616fc-eb60-4c43-b8cb-1688aea0d87d@github.com>

> This fix deprecates for removal java.awt.Window.getWarningString() and also javax.swing.JInternalFrame.getWarningString()
> l java.awt.Window.getWarningString() is only relevant with a SecurityManager and javax.swing.JInternalFrame.getWarningString() is just there for symmetry.
> 
> A few other spec changes ensue - the serial form variable warningString is removed is the main one.
> The AWTPermission showWindowWithoutWarningBanner is obsolete
> Reference to the system property  "awt.appletWarning" was actually already removed by JEP 486
> 
> There is a CSR for the spec. changes, which will need a reviewer : https://bugs.openjdk.org/browse/JDK-8344451
> 
> But the vast majority of the changes here are all the downstream obsoleted implementation
> The warning string and warning icon, and warning windows are all obsoleted.
> I think I tracked down all of it, but it is hard to be sure.
> Automated tests are passing, and I've manually tested SwingSet2 on all 3 platforms.

Phil Race has updated the pull request incrementally with one additional commit since the last revision:

  8342903

-------------

Changes:
  - all: https://git.openjdk.org/jdk/pull/22221/files
  - new: https://git.openjdk.org/jdk/pull/22221/files/15b9eab4..5f840077

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jdk&pr=22221&range=03
 - incr: https://webrevs.openjdk.org/?repo=jdk&pr=22221&range=02-03

  Stats: 12 lines in 1 file changed: 0 ins; 12 del; 0 mod
  Patch: https://git.openjdk.org/jdk/pull/22221.diff
  Fetch: git fetch https://git.openjdk.org/jdk.git pull/22221/head:pull/22221

PR: https://git.openjdk.org/jdk/pull/22221

From prr at openjdk.org  Thu Nov 21 17:50:38 2024
From: prr at openjdk.org (Phil Race)
Date: Thu, 21 Nov 2024 17:50:38 GMT
Subject: <i18n dev> RFR: 8342903: Deprecate for removal
 java.awt.Window.getWarningString() [v3]
In-Reply-To: <de4sfeGG7nN0t1i_pih0ipAJ9aCIZjn69fkz_29S4x8=.be850b51-88bd-4d8e-b211-2246625bcdf4@github.com>
References: <cZN3bZf5PIhmNeTvGZezBoleZkq5oNWQI9GUlneoPAk=.d1a819dd-d7b7-4708-bb66-d57fab85191d@github.com>
 <de4sfeGG7nN0t1i_pih0ipAJ9aCIZjn69fkz_29S4x8=.be850b51-88bd-4d8e-b211-2246625bcdf4@github.com>
Message-ID: <LjDh777H-n0b6v9IF2WGpfQjKnef-hnmoaWdlL1lmIY=.23327799-63e0-4d56-a1d9-9e791b9818c9@github.com>

On Wed, 20 Nov 2024 23:41:50 GMT, Phil Race <prr at openjdk.org> wrote:

>> This fix deprecates for removal java.awt.Window.getWarningString() and also javax.swing.JInternalFrame.getWarningString()
>> l java.awt.Window.getWarningString() is only relevant with a SecurityManager and javax.swing.JInternalFrame.getWarningString() is just there for symmetry.
>> 
>> A few other spec changes ensue - the serial form variable warningString is removed is the main one.
>> The AWTPermission showWindowWithoutWarningBanner is obsolete
>> Reference to the system property  "awt.appletWarning" was actually already removed by JEP 486
>> 
>> There is a CSR for the spec. changes, which will need a reviewer : https://bugs.openjdk.org/browse/JDK-8344451
>> 
>> But the vast majority of the changes here are all the downstream obsoleted implementation
>> The warning string and warning icon, and warning windows are all obsoleted.
>> I think I tracked down all of it, but it is hard to be sure.
>> Automated tests are passing, and I've manually tested SwingSet2 on all 3 platforms.
>
> Phil Race has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains four additional commits since the last revision:
> 
>  - 8342903
>  - Merge remote-tracking branch 'upstream/master' into warningstring
>    Merge master
>  - 8344451
>  - 8344451

updated the EXCLUDE list as per Alexander's off line comment.

-------------

PR Comment: https://git.openjdk.org/jdk/pull/22221#issuecomment-2491890999

From azvegint at openjdk.org  Thu Nov 21 19:39:16 2024
From: azvegint at openjdk.org (Alexander Zvegintsev)
Date: Thu, 21 Nov 2024 19:39:16 GMT
Subject: <i18n dev> RFR: 8342903: Deprecate for removal
 java.awt.Window.getWarningString() [v4]
In-Reply-To: <SMSPP3aOWDww4azwQZT6bJnF16YOJMVJVIz7JKk3_bE=.a09616fc-eb60-4c43-b8cb-1688aea0d87d@github.com>
References: <cZN3bZf5PIhmNeTvGZezBoleZkq5oNWQI9GUlneoPAk=.d1a819dd-d7b7-4708-bb66-d57fab85191d@github.com>
 <SMSPP3aOWDww4azwQZT6bJnF16YOJMVJVIz7JKk3_bE=.a09616fc-eb60-4c43-b8cb-1688aea0d87d@github.com>
Message-ID: <S5tXGsU75qOkqKm0eo1iUtC3-Bt5t-VMafcKx2jQrG4=.c6d5b2d1-59d5-4937-bf32-2476f86b5694@github.com>

On Thu, 21 Nov 2024 17:50:36 GMT, Phil Race <prr at openjdk.org> wrote:

>> This fix deprecates for removal java.awt.Window.getWarningString() and also javax.swing.JInternalFrame.getWarningString()
>> l java.awt.Window.getWarningString() is only relevant with a SecurityManager and javax.swing.JInternalFrame.getWarningString() is just there for symmetry.
>> 
>> A few other spec changes ensue - the serial form variable warningString is removed is the main one.
>> The AWTPermission showWindowWithoutWarningBanner is obsolete
>> Reference to the system property  "awt.appletWarning" was actually already removed by JEP 486
>> 
>> There is a CSR for the spec. changes, which will need a reviewer : https://bugs.openjdk.org/browse/JDK-8344451
>> 
>> But the vast majority of the changes here are all the downstream obsoleted implementation
>> The warning string and warning icon, and warning windows are all obsoleted.
>> I think I tracked down all of it, but it is hard to be sure.
>> Automated tests are passing, and I've manually tested SwingSet2 on all 3 platforms.
>
> Phil Race has updated the pull request incrementally with one additional commit since the last revision:
> 
>   8342903

There are a few minor mentions of the Warning Window left


./src/java.desktop/unix/classes/sun/awt/X11/XWindow.java:1492:     * XWarningWindow, both of which have the XWindow as a common ancestor.
./test/jdk/ProblemList.txt:468:java/awt/security/WarningWindowDisposeTest/WarningWindowDisposeTest.java 8266059 macosx-all

the test in problem list does not exist

src/java.desktop/windows/native/libawt/windows/awt_Window.cpp line 450:

> 448: }
> 449: 
> 450: void AwtWindow::FocusedWindowChanged(HWND from, HWND to)

It looks like this empty method and its usage can also be removed:


./src/java.desktop/windows/native/libawt/windows/awt_Component.cpp:6426:    AwtWindow::FocusedWindowChanged(old, window);

-------------

Marked as reviewed by azvegint (Reviewer).

PR Review: https://git.openjdk.org/jdk/pull/22221#pullrequestreview-2452443843
PR Review Comment: https://git.openjdk.org/jdk/pull/22221#discussion_r1852732769

From jlu at openjdk.org  Thu Nov 21 19:42:19 2024
From: jlu at openjdk.org (Justin Lu)
Date: Thu, 21 Nov 2024 19:42:19 GMT
Subject: <i18n dev> RFR: 8319993: Update Unicode Data Files to 16.0.0
In-Reply-To: <lhjftuxraeNfYcmqtLlHjH0COs5-oyjaZlz_oMsoUG0=.5c1fc0e0-781d-4610-ab0c-6ed8fd4b525c@github.com>
References: <lhjftuxraeNfYcmqtLlHjH0COs5-oyjaZlz_oMsoUG0=.5c1fc0e0-781d-4610-ab0c-6ed8fd4b525c@github.com>
Message-ID: <qpEBCQ6FDje5WPpgwF1kqPLsG-zQhqBa8ljB6mN_cVA=.f08fcd8c-2286-4c60-a909-5f3483e6fd53@github.com>

On Tue, 29 Oct 2024 18:01:55 GMT, Naoto Sato <naoto at openjdk.org> wrote:

> Updates the JDK to use the latest Unicode 16.0.0, which also updates the ICU4J along with it (8319992: Update ICU4J to Version 76.1). The corresponding CSR has already been approved.

Marked as reviewed by jlu (Committer).

src/java.base/share/classes/jdk/internal/util/regex/Grapheme.java line 38:

> 36:      * See Unicode Standard Annex #29 Unicode Text Segmentation for the specification
> 37:      * for the extended grapheme cluster boundary rules. The following implementation
> 38:      * is based on the annex for Unicode version 15.1.

Could bump the version 15.1 to 16.0

src/java.base/share/classes/jdk/internal/util/regex/Grapheme.java line 272:

> 270:             //  Kirat Rai vowel sign
> 271:             if (cp >= 0xD7B0 && cp <= 0xD7C6 ||
> 272:                 cp == 0x16D63 ||

LGTM as this matches up with https://www.unicode.org/reports/tr29/tr29-45.html#V and the `case 0x113D1:` lines up with _TULU-TIGALARI REPHA_.

-------------

PR Review: https://git.openjdk.org/jdk/pull/21771#pullrequestreview-2450437524
PR Review Comment: https://git.openjdk.org/jdk/pull/21771#discussion_r1851471389
PR Review Comment: https://git.openjdk.org/jdk/pull/21771#discussion_r1852722645

From prr at openjdk.org  Thu Nov 21 19:55:51 2024
From: prr at openjdk.org (Phil Race)
Date: Thu, 21 Nov 2024 19:55:51 GMT
Subject: <i18n dev> RFR: 8344782: Cleanup left over doPrivileged calls and
 imports in java.desktop
Message-ID: <XgaZis-42E3w7M7Q1BD7BQodNoqCfwGmentYcNzsJrk=.4b12d225-95b1-4cd5-92d2-47fc3aaddb9d@github.com>

Some clean up of left overs

-------------

Commit messages:
 - 8344782

Changes: https://git.openjdk.org/jdk/pull/22306/files
  Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=22306&range=00
  Issue: https://bugs.openjdk.org/browse/JDK-8344782
  Stats: 20 lines in 7 files changed: 0 ins; 19 del; 1 mod
  Patch: https://git.openjdk.org/jdk/pull/22306.diff
  Fetch: git fetch https://git.openjdk.org/jdk.git pull/22306/head:pull/22306

PR: https://git.openjdk.org/jdk/pull/22306

From honkar at openjdk.org  Thu Nov 21 20:05:19 2024
From: honkar at openjdk.org (Harshitha Onkar)
Date: Thu, 21 Nov 2024 20:05:19 GMT
Subject: <i18n dev> RFR: 8344782: Cleanup left over doPrivileged calls
 and imports in java.desktop
In-Reply-To: <XgaZis-42E3w7M7Q1BD7BQodNoqCfwGmentYcNzsJrk=.4b12d225-95b1-4cd5-92d2-47fc3aaddb9d@github.com>
References: <XgaZis-42E3w7M7Q1BD7BQodNoqCfwGmentYcNzsJrk=.4b12d225-95b1-4cd5-92d2-47fc3aaddb9d@github.com>
Message-ID: <3PaUOXMZV5pyY7j8Jw43R1Oy7YF8j4f2cqAdMKr0YdA=.9cbcb674-d88b-495f-a60b-557ea58bf013@github.com>

On Thu, 21 Nov 2024 19:51:06 GMT, Phil Race <prr at openjdk.org> wrote:

> Some clean up of left overs

LGTM

-------------

Marked as reviewed by honkar (Reviewer).

PR Review: https://git.openjdk.org/jdk/pull/22306#pullrequestreview-2452540240

From prr at openjdk.org  Thu Nov 21 20:23:01 2024
From: prr at openjdk.org (Phil Race)
Date: Thu, 21 Nov 2024 20:23:01 GMT
Subject: <i18n dev> RFR: 8342903: Deprecate for removal
 java.awt.Window.getWarningString() [v5]
In-Reply-To: <cZN3bZf5PIhmNeTvGZezBoleZkq5oNWQI9GUlneoPAk=.d1a819dd-d7b7-4708-bb66-d57fab85191d@github.com>
References: <cZN3bZf5PIhmNeTvGZezBoleZkq5oNWQI9GUlneoPAk=.d1a819dd-d7b7-4708-bb66-d57fab85191d@github.com>
Message-ID: <Q4WjV7g62PfX7FzHdbRoONn-xbbS_NnuMxznu9ATLiY=.7ed24800-9c0b-4f44-b206-f09d71c9138e@github.com>

> This fix deprecates for removal java.awt.Window.getWarningString() and also javax.swing.JInternalFrame.getWarningString()
> l java.awt.Window.getWarningString() is only relevant with a SecurityManager and javax.swing.JInternalFrame.getWarningString() is just there for symmetry.
> 
> A few other spec changes ensue - the serial form variable warningString is removed is the main one.
> The AWTPermission showWindowWithoutWarningBanner is obsolete
> Reference to the system property  "awt.appletWarning" was actually already removed by JEP 486
> 
> There is a CSR for the spec. changes, which will need a reviewer : https://bugs.openjdk.org/browse/JDK-8344451
> 
> But the vast majority of the changes here are all the downstream obsoleted implementation
> The warning string and warning icon, and warning windows are all obsoleted.
> I think I tracked down all of it, but it is hard to be sure.
> Automated tests are passing, and I've manually tested SwingSet2 on all 3 platforms.

Phil Race has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains seven additional commits since the last revision:

 - 8342903
 - Merge branch 'master' into warningstring
   Merge
 - 8342903
 - 8342903
 - Merge remote-tracking branch 'upstream/master' into warningstring
   Merge master
 - 8344451
 - 8344451

-------------

Changes:
  - all: https://git.openjdk.org/jdk/pull/22221/files
  - new: https://git.openjdk.org/jdk/pull/22221/files/5f840077..af89693f

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jdk&pr=22221&range=04
 - incr: https://webrevs.openjdk.org/?repo=jdk&pr=22221&range=03-04

  Stats: 3925 lines in 149 files changed: 1190 ins; 1920 del; 815 mod
  Patch: https://git.openjdk.org/jdk/pull/22221.diff
  Fetch: git fetch https://git.openjdk.org/jdk.git pull/22221/head:pull/22221

PR: https://git.openjdk.org/jdk/pull/22221

From prr at openjdk.org  Thu Nov 21 20:27:16 2024
From: prr at openjdk.org (Phil Race)
Date: Thu, 21 Nov 2024 20:27:16 GMT
Subject: <i18n dev> RFR: 8342903: Deprecate for removal
 java.awt.Window.getWarningString() [v4]
In-Reply-To: <S5tXGsU75qOkqKm0eo1iUtC3-Bt5t-VMafcKx2jQrG4=.c6d5b2d1-59d5-4937-bf32-2476f86b5694@github.com>
References: <cZN3bZf5PIhmNeTvGZezBoleZkq5oNWQI9GUlneoPAk=.d1a819dd-d7b7-4708-bb66-d57fab85191d@github.com>
 <SMSPP3aOWDww4azwQZT6bJnF16YOJMVJVIz7JKk3_bE=.a09616fc-eb60-4c43-b8cb-1688aea0d87d@github.com>
 <S5tXGsU75qOkqKm0eo1iUtC3-Bt5t-VMafcKx2jQrG4=.c6d5b2d1-59d5-4937-bf32-2476f86b5694@github.com>
Message-ID: <ub6naxNIRQXIAdTc6hPJkBl29QqvYnxZiXJQymfT0Zw=.199af8ab-c23f-4656-b9f3-bbd8a9d1aeb3@github.com>

On Thu, 21 Nov 2024 19:31:17 GMT, Alexander Zvegintsev <azvegint at openjdk.org> wrote:

>> Phil Race has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   8342903
>
> src/java.desktop/windows/native/libawt/windows/awt_Window.cpp line 450:
> 
>> 448: }
>> 449: 
>> 450: void AwtWindow::FocusedWindowChanged(HWND from, HWND to)
> 
> It looks like this empty method and its usage can also be removed:
> 
> 
> ./src/java.desktop/windows/native/libawt/windows/awt_Component.cpp:6426:    AwtWindow::FocusedWindowChanged(old, window);

I knew that was possible but I wasn't sure I wanted to pull on the string.
If it is really simple I will do it.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/22221#discussion_r1852825185

From prr at openjdk.org  Thu Nov 21 20:30:18 2024
From: prr at openjdk.org (Phil Race)
Date: Thu, 21 Nov 2024 20:30:18 GMT
Subject: <i18n dev> RFR: 8342903: Deprecate for removal
 java.awt.Window.getWarningString() [v5]
In-Reply-To: <S5tXGsU75qOkqKm0eo1iUtC3-Bt5t-VMafcKx2jQrG4=.c6d5b2d1-59d5-4937-bf32-2476f86b5694@github.com>
References: <cZN3bZf5PIhmNeTvGZezBoleZkq5oNWQI9GUlneoPAk=.d1a819dd-d7b7-4708-bb66-d57fab85191d@github.com>
 <SMSPP3aOWDww4azwQZT6bJnF16YOJMVJVIz7JKk3_bE=.a09616fc-eb60-4c43-b8cb-1688aea0d87d@github.com>
 <S5tXGsU75qOkqKm0eo1iUtC3-Bt5t-VMafcKx2jQrG4=.c6d5b2d1-59d5-4937-bf32-2476f86b5694@github.com>
Message-ID: <2CVQB4LWatmXzSMYApLvuvPKgjH42-Wbthz2pwLgXZc=.9b4510db-36dd-4af1-a9d1-ed135fd3df80@github.com>

On Thu, 21 Nov 2024 19:36:20 GMT, Alexander Zvegintsev <azvegint at openjdk.org> wrote:

> There are a few minor mentions of the Warning Window left
> 
> ```
> ./src/java.desktop/unix/classes/sun/awt/X11/XWindow.java:1492:     * XWarningWindow, both of which have the XWindow as a common ancestor.

I've updated the comment
> ./test/jdk/ProblemList.txt:468:java/awt/security/WarningWindowDisposeTest/WarningWindowDisposeTest.java 8266059 macosx-all
> ```
> 
> the test in problem list does not exist

I am fairly sure this test was deleted by the JEP 486 integration. It should have been removed then.

I'll fix it and close out the bug

-------------

PR Comment: https://git.openjdk.org/jdk/pull/22221#issuecomment-2492213166

From prr at openjdk.org  Thu Nov 21 20:32:24 2024
From: prr at openjdk.org (Phil Race)
Date: Thu, 21 Nov 2024 20:32:24 GMT
Subject: <i18n dev> Integrated: 8344782: Cleanup left over doPrivileged
 calls and imports in java.desktop
In-Reply-To: <XgaZis-42E3w7M7Q1BD7BQodNoqCfwGmentYcNzsJrk=.4b12d225-95b1-4cd5-92d2-47fc3aaddb9d@github.com>
References: <XgaZis-42E3w7M7Q1BD7BQodNoqCfwGmentYcNzsJrk=.4b12d225-95b1-4cd5-92d2-47fc3aaddb9d@github.com>
Message-ID: <Sk_TUB6Bz6zn4BPRIe2widY_I0MY-KYUc2qrWy-HBDM=.29656b86-ae17-488f-8622-772f2a790e7e@github.com>

On Thu, 21 Nov 2024 19:51:06 GMT, Phil Race <prr at openjdk.org> wrote:

> Some clean up of left overs

This pull request has now been integrated.

Changeset: 7709d435
Author:    Phil Race <prr at openjdk.org>
URL:       https://git.openjdk.org/jdk/commit/7709d435d080778a45bd3eb9a5754e356e94e6de
Stats:     20 lines in 7 files changed: 0 ins; 19 del; 1 mod

8344782: Cleanup left over doPrivileged calls and imports in java.desktop

Reviewed-by: honkar

-------------

PR: https://git.openjdk.org/jdk/pull/22306

From naoto at openjdk.org  Thu Nov 21 20:38:20 2024
From: naoto at openjdk.org (Naoto Sato)
Date: Thu, 21 Nov 2024 20:38:20 GMT
Subject: <i18n dev> RFR: 8341923: java.util.Locale class specification
 improvements [v4]
In-Reply-To: <xTxbdWdErCsY1XF0SBmcUb7t4iKeuyw6fVFHkEjQ49E=.ac5332aa-f18d-466a-ba74-7e21d8e552d8@github.com>
References: <a8ibOqDLUAn4-KOJtPQtD-FKDX73ZnvMI51UWLuDhPY=.f48b60d9-fe3b-401a-a952-38bbcc6cd843@github.com>
 <xTxbdWdErCsY1XF0SBmcUb7t4iKeuyw6fVFHkEjQ49E=.ac5332aa-f18d-466a-ba74-7e21d8e552d8@github.com>
Message-ID: <sS6Ljxuqd80UqGuVgyEyHVijbHFfC6g5jOzkbzY965M=.ee93eaab-547d-4d2c-9026-c07f4bccd1e2@github.com>

On Thu, 21 Nov 2024 06:53:58 GMT, Justin Lu <jlu at openjdk.org> wrote:

>> Please review this PR and corresponding CSR which includes a wide range of specification improvements for java.util.Locale. See the CSR for further detail. Other changes/suggestions are welcomed to be included as part of this change.
>> 
>> APIDiff: https://cr.openjdk.org/~jlu/8341923_apidiff/java.base/java/util/Locale.html
>> Javadoc: https://cr.openjdk.org/~jlu/api/java.base/java/util/Locale.html
>
> Justin Lu has updated the pull request incrementally with one additional commit since the last revision:
> 
>   reflect review

LGTM. Thanks for the update.

-------------

Marked as reviewed by naoto (Reviewer).

PR Review: https://git.openjdk.org/jdk/pull/22192#pullrequestreview-2452646951

From naoto at openjdk.org  Thu Nov 21 20:42:57 2024
From: naoto at openjdk.org (Naoto Sato)
Date: Thu, 21 Nov 2024 20:42:57 GMT
Subject: <i18n dev> RFR: 8319993: Update Unicode Data Files to 16.0.0
 [v2]
In-Reply-To: <lhjftuxraeNfYcmqtLlHjH0COs5-oyjaZlz_oMsoUG0=.5c1fc0e0-781d-4610-ab0c-6ed8fd4b525c@github.com>
References: <lhjftuxraeNfYcmqtLlHjH0COs5-oyjaZlz_oMsoUG0=.5c1fc0e0-781d-4610-ab0c-6ed8fd4b525c@github.com>
Message-ID: <BrxHySXQqOjVuMIYhJ3b4QZrOsiGWxd3sTYUXNhKegY=.73a489a0-d39a-424b-a452-f60c578d05a6@github.com>

> Updates the JDK to use the latest Unicode 16.0.0, which also updates the ICU4J along with it (8319992: Update ICU4J to Version 76.1). The corresponding CSR has already been approved.

Naoto Sato has updated the pull request incrementally with one additional commit since the last revision:

  Corrected the Unicode version in Grapheme.java

-------------

Changes:
  - all: https://git.openjdk.org/jdk/pull/21771/files
  - new: https://git.openjdk.org/jdk/pull/21771/files/524807a3..e87844bb

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jdk&pr=21771&range=01
 - incr: https://webrevs.openjdk.org/?repo=jdk&pr=21771&range=00-01

  Stats: 1 line in 1 file changed: 0 ins; 0 del; 1 mod
  Patch: https://git.openjdk.org/jdk/pull/21771.diff
  Fetch: git fetch https://git.openjdk.org/jdk.git pull/21771/head:pull/21771

PR: https://git.openjdk.org/jdk/pull/21771

From naoto at openjdk.org  Thu Nov 21 20:42:58 2024
From: naoto at openjdk.org (Naoto Sato)
Date: Thu, 21 Nov 2024 20:42:58 GMT
Subject: <i18n dev> RFR: 8319993: Update Unicode Data Files to 16.0.0
 [v2]
In-Reply-To: <qpEBCQ6FDje5WPpgwF1kqPLsG-zQhqBa8ljB6mN_cVA=.f08fcd8c-2286-4c60-a909-5f3483e6fd53@github.com>
References: <lhjftuxraeNfYcmqtLlHjH0COs5-oyjaZlz_oMsoUG0=.5c1fc0e0-781d-4610-ab0c-6ed8fd4b525c@github.com>
 <qpEBCQ6FDje5WPpgwF1kqPLsG-zQhqBa8ljB6mN_cVA=.f08fcd8c-2286-4c60-a909-5f3483e6fd53@github.com>
Message-ID: <bHjJkrJzAyf9OGeqLM0jORMtwFqsAFqwxEMY_pld8S0=.a94f6620-5bdd-4779-8f9d-6e1f0f89f2fe@github.com>

On Thu, 21 Nov 2024 07:07:39 GMT, Justin Lu <jlu at openjdk.org> wrote:

>> Naoto Sato has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Corrected the Unicode version in Grapheme.java
>
> src/java.base/share/classes/jdk/internal/util/regex/Grapheme.java line 38:
> 
>> 36:      * See Unicode Standard Annex #29 Unicode Text Segmentation for the specification
>> 37:      * for the extended grapheme cluster boundary rules. The following implementation
>> 38:      * is based on the annex for Unicode version 15.1.
> 
> Could bump the version 15.1 to 16.0

Good catch! Corrected.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/21771#discussion_r1852857042

From prr at openjdk.org  Thu Nov 21 20:58:59 2024
From: prr at openjdk.org (Phil Race)
Date: Thu, 21 Nov 2024 20:58:59 GMT
Subject: <i18n dev> RFR: 8342903: Deprecate for removal
 java.awt.Window.getWarningString() [v6]
In-Reply-To: <cZN3bZf5PIhmNeTvGZezBoleZkq5oNWQI9GUlneoPAk=.d1a819dd-d7b7-4708-bb66-d57fab85191d@github.com>
References: <cZN3bZf5PIhmNeTvGZezBoleZkq5oNWQI9GUlneoPAk=.d1a819dd-d7b7-4708-bb66-d57fab85191d@github.com>
Message-ID: <ZFUnYAG9okLXqrlH5l4vFIv3Nbk-BRNeg972OM4NLOg=.be85e0c8-4a91-4849-a4f7-f07349a563e3@github.com>

> This fix deprecates for removal java.awt.Window.getWarningString() and also javax.swing.JInternalFrame.getWarningString()
> l java.awt.Window.getWarningString() is only relevant with a SecurityManager and javax.swing.JInternalFrame.getWarningString() is just there for symmetry.
> 
> A few other spec changes ensue - the serial form variable warningString is removed is the main one.
> The AWTPermission showWindowWithoutWarningBanner is obsolete
> Reference to the system property  "awt.appletWarning" was actually already removed by JEP 486
> 
> There is a CSR for the spec. changes, which will need a reviewer : https://bugs.openjdk.org/browse/JDK-8344451
> 
> But the vast majority of the changes here are all the downstream obsoleted implementation
> The warning string and warning icon, and warning windows are all obsoleted.
> I think I tracked down all of it, but it is hard to be sure.
> Automated tests are passing, and I've manually tested SwingSet2 on all 3 platforms.

Phil Race has updated the pull request incrementally with one additional commit since the last revision:

  8342903

-------------

Changes:
  - all: https://git.openjdk.org/jdk/pull/22221/files
  - new: https://git.openjdk.org/jdk/pull/22221/files/af89693f..75370746

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jdk&pr=22221&range=05
 - incr: https://webrevs.openjdk.org/?repo=jdk&pr=22221&range=04-05

  Stats: 9 lines in 3 files changed: 0 ins; 9 del; 0 mod
  Patch: https://git.openjdk.org/jdk/pull/22221.diff
  Fetch: git fetch https://git.openjdk.org/jdk.git pull/22221/head:pull/22221

PR: https://git.openjdk.org/jdk/pull/22221

From prr at openjdk.org  Thu Nov 21 20:59:00 2024
From: prr at openjdk.org (Phil Race)
Date: Thu, 21 Nov 2024 20:59:00 GMT
Subject: <i18n dev> RFR: 8342903: Deprecate for removal
 java.awt.Window.getWarningString() [v4]
In-Reply-To: <ub6naxNIRQXIAdTc6hPJkBl29QqvYnxZiXJQymfT0Zw=.199af8ab-c23f-4656-b9f3-bbd8a9d1aeb3@github.com>
References: <cZN3bZf5PIhmNeTvGZezBoleZkq5oNWQI9GUlneoPAk=.d1a819dd-d7b7-4708-bb66-d57fab85191d@github.com>
 <SMSPP3aOWDww4azwQZT6bJnF16YOJMVJVIz7JKk3_bE=.a09616fc-eb60-4c43-b8cb-1688aea0d87d@github.com>
 <S5tXGsU75qOkqKm0eo1iUtC3-Bt5t-VMafcKx2jQrG4=.c6d5b2d1-59d5-4937-bf32-2476f86b5694@github.com>
 <ub6naxNIRQXIAdTc6hPJkBl29QqvYnxZiXJQymfT0Zw=.199af8ab-c23f-4656-b9f3-bbd8a9d1aeb3@github.com>
Message-ID: <dNWD6pxtqLCpmTifIU-kMwu6nnahhbS9JYsYqi1_kVE=.a5c26ee7-2880-4703-9b4d-9125cac8c150@github.com>

On Thu, 21 Nov 2024 20:24:18 GMT, Phil Race <prr at openjdk.org> wrote:

> I knew that was possible but I wasn't sure I wanted to pull on the string. If it is really simple I will do it.

OK. The string was very short. Fixed.
I believe all comments are now addressed.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/22221#discussion_r1852881277

From kizune at openjdk.org  Thu Nov 21 21:09:18 2024
From: kizune at openjdk.org (Alexander Zuev)
Date: Thu, 21 Nov 2024 21:09:18 GMT
Subject: <i18n dev> RFR: 8342903: Deprecate for removal
 java.awt.Window.getWarningString() [v6]
In-Reply-To: <ZFUnYAG9okLXqrlH5l4vFIv3Nbk-BRNeg972OM4NLOg=.be85e0c8-4a91-4849-a4f7-f07349a563e3@github.com>
References: <cZN3bZf5PIhmNeTvGZezBoleZkq5oNWQI9GUlneoPAk=.d1a819dd-d7b7-4708-bb66-d57fab85191d@github.com>
 <ZFUnYAG9okLXqrlH5l4vFIv3Nbk-BRNeg972OM4NLOg=.be85e0c8-4a91-4849-a4f7-f07349a563e3@github.com>
Message-ID: <T_NerBVzRDPJe4Ob2ccR1sKmgGAbZ7QiV5kxHr04pLM=.f4677aaf-5cc8-44c8-a6eb-720b750770dd@github.com>

On Thu, 21 Nov 2024 20:58:59 GMT, Phil Race <prr at openjdk.org> wrote:

>> This fix deprecates for removal java.awt.Window.getWarningString() and also javax.swing.JInternalFrame.getWarningString()
>> l java.awt.Window.getWarningString() is only relevant with a SecurityManager and javax.swing.JInternalFrame.getWarningString() is just there for symmetry.
>> 
>> A few other spec changes ensue - the serial form variable warningString is removed is the main one.
>> The AWTPermission showWindowWithoutWarningBanner is obsolete
>> Reference to the system property  "awt.appletWarning" was actually already removed by JEP 486
>> 
>> There is a CSR for the spec. changes, which will need a reviewer : https://bugs.openjdk.org/browse/JDK-8344451
>> 
>> But the vast majority of the changes here are all the downstream obsoleted implementation
>> The warning string and warning icon, and warning windows are all obsoleted.
>> I think I tracked down all of it, but it is hard to be sure.
>> Automated tests are passing, and I've manually tested SwingSet2 on all 3 platforms.
>
> Phil Race has updated the pull request incrementally with one additional commit since the last revision:
> 
>   8342903

Latest revision looks good.

-------------

Marked as reviewed by kizune (Reviewer).

PR Review: https://git.openjdk.org/jdk/pull/22221#pullrequestreview-2452744076

From joehw at openjdk.org  Thu Nov 21 21:14:16 2024
From: joehw at openjdk.org (Joe Wang)
Date: Thu, 21 Nov 2024 21:14:16 GMT
Subject: <i18n dev> RFR: 8343788: Provide means to alter lib/tzmappings
 entries on Windows
In-Reply-To: <z7j5vrQoWKMnE7_RsTMDFcs2XpHkzCw1t9rTBaMM2Kg=.6c2257e5-ccdb-4f04-90e5-22e2341a2678@github.com>
References: <z7j5vrQoWKMnE7_RsTMDFcs2XpHkzCw1t9rTBaMM2Kg=.6c2257e5-ccdb-4f04-90e5-22e2341a2678@github.com>
Message-ID: <rTVdEDL_g_zT2BPTdP9n2pMa5xnZAbKbzxmK96fepN8=.7a31c702-eb64-422b-93e5-1069f5fc3f18@github.com>

On Tue, 19 Nov 2024 17:31:42 GMT, Naoto Sato <naoto at openjdk.org> wrote:

> Windows Java runtime has a mapping file /lib/tzmappings which maps Windows time zones to Java's time zones. The file is generated based on CLDR's windowsZones.xml, but in rare occasions, its update is out of sync with Windows updates. This enhancement is to address those discrepancies for the time being (till CLDR/Windows are in sync). This change will also address zone mapping discrepancies in the update releases where CLDR versions stay the same.

Marked as reviewed by joehw (Reviewer).

-------------

PR Review: https://git.openjdk.org/jdk/pull/22250#pullrequestreview-2452754703

From azvegint at openjdk.org  Thu Nov 21 21:27:24 2024
From: azvegint at openjdk.org (Alexander Zvegintsev)
Date: Thu, 21 Nov 2024 21:27:24 GMT
Subject: <i18n dev> RFR: 8342903: Deprecate for removal
 java.awt.Window.getWarningString() [v6]
In-Reply-To: <ZFUnYAG9okLXqrlH5l4vFIv3Nbk-BRNeg972OM4NLOg=.be85e0c8-4a91-4849-a4f7-f07349a563e3@github.com>
References: <cZN3bZf5PIhmNeTvGZezBoleZkq5oNWQI9GUlneoPAk=.d1a819dd-d7b7-4708-bb66-d57fab85191d@github.com>
 <ZFUnYAG9okLXqrlH5l4vFIv3Nbk-BRNeg972OM4NLOg=.be85e0c8-4a91-4849-a4f7-f07349a563e3@github.com>
Message-ID: <fMziMTqoSYAZXxEhxbEd5MIb1NMmqIpPcQ52AnowSTg=.7cabc7b6-d1ae-4b5e-a05e-8db29daedc5a@github.com>

On Thu, 21 Nov 2024 20:58:59 GMT, Phil Race <prr at openjdk.org> wrote:

>> This fix deprecates for removal java.awt.Window.getWarningString() and also javax.swing.JInternalFrame.getWarningString()
>> l java.awt.Window.getWarningString() is only relevant with a SecurityManager and javax.swing.JInternalFrame.getWarningString() is just there for symmetry.
>> 
>> A few other spec changes ensue - the serial form variable warningString is removed is the main one.
>> The AWTPermission showWindowWithoutWarningBanner is obsolete
>> Reference to the system property  "awt.appletWarning" was actually already removed by JEP 486
>> 
>> There is a CSR for the spec. changes, which will need a reviewer : https://bugs.openjdk.org/browse/JDK-8344451
>> 
>> But the vast majority of the changes here are all the downstream obsoleted implementation
>> The warning string and warning icon, and warning windows are all obsoleted.
>> I think I tracked down all of it, but it is hard to be sure.
>> Automated tests are passing, and I've manually tested SwingSet2 on all 3 platforms.
>
> Phil Race has updated the pull request incrementally with one additional commit since the last revision:
> 
>   8342903

Marked as reviewed by azvegint (Reviewer).

-------------

PR Review: https://git.openjdk.org/jdk/pull/22221#pullrequestreview-2452779527

From prr at openjdk.org  Thu Nov 21 21:27:25 2024
From: prr at openjdk.org (Phil Race)
Date: Thu, 21 Nov 2024 21:27:25 GMT
Subject: <i18n dev> Integrated: 8342903: Deprecate for removal
 java.awt.Window.getWarningString()
In-Reply-To: <cZN3bZf5PIhmNeTvGZezBoleZkq5oNWQI9GUlneoPAk=.d1a819dd-d7b7-4708-bb66-d57fab85191d@github.com>
References: <cZN3bZf5PIhmNeTvGZezBoleZkq5oNWQI9GUlneoPAk=.d1a819dd-d7b7-4708-bb66-d57fab85191d@github.com>
Message-ID: <Fa5KSMDrcbol9NLMaJfOabLeoukM0vT_LNnD7B0m8rU=.6afb0c9b-fab5-4c39-abe6-2a73b15bb0c0@github.com>

On Mon, 18 Nov 2024 22:11:52 GMT, Phil Race <prr at openjdk.org> wrote:

> This fix deprecates for removal java.awt.Window.getWarningString() and also javax.swing.JInternalFrame.getWarningString()
> l java.awt.Window.getWarningString() is only relevant with a SecurityManager and javax.swing.JInternalFrame.getWarningString() is just there for symmetry.
> 
> A few other spec changes ensue - the serial form variable warningString is removed is the main one.
> The AWTPermission showWindowWithoutWarningBanner is obsolete
> Reference to the system property  "awt.appletWarning" was actually already removed by JEP 486
> 
> There is a CSR for the spec. changes, which will need a reviewer : https://bugs.openjdk.org/browse/JDK-8344451
> 
> But the vast majority of the changes here are all the downstream obsoleted implementation
> The warning string and warning icon, and warning windows are all obsoleted.
> I think I tracked down all of it, but it is hard to be sure.
> Automated tests are passing, and I've manually tested SwingSet2 on all 3 platforms.

This pull request has now been integrated.

Changeset: 0f458e2c
Author:    Phil Race <prr at openjdk.org>
URL:       https://git.openjdk.org/jdk/commit/0f458e2c3eb93641864085d18e49daf640cb3858
Stats:     2083 lines in 51 files changed: 5 ins; 2067 del; 11 mod

8342903: Deprecate for removal java.awt.Window.getWarningString()

Reviewed-by: kizune, erikj, azvegint

-------------

PR: https://git.openjdk.org/jdk/pull/22221

From prr at openjdk.org  Thu Nov 21 21:29:31 2024
From: prr at openjdk.org (Phil Race)
Date: Thu, 21 Nov 2024 21:29:31 GMT
Subject: <i18n dev> RFR: 8344795: Remove uses of AccessControlContext in
 java.desktop module
Message-ID: <I1DzBGHUo1IjWJw_R4NGh3m_-l-dC6c__9iA0ARoM64=.f5c4d821-4eb4-4d53-a4ba-899df0cd6d8e@github.com>

This removes uses of AccessControlContext in java.desktop

-------------

Commit messages:
 - 8344795

Changes: https://git.openjdk.org/jdk/pull/22308/files
  Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=22308&range=00
  Issue: https://bugs.openjdk.org/browse/JDK-8344795
  Stats: 186 lines in 8 files changed: 1 ins; 175 del; 10 mod
  Patch: https://git.openjdk.org/jdk/pull/22308.diff
  Fetch: git fetch https://git.openjdk.org/jdk.git pull/22308/head:pull/22308

PR: https://git.openjdk.org/jdk/pull/22308

From azvegint at openjdk.org  Fri Nov 22 00:53:23 2024
From: azvegint at openjdk.org (Alexander Zvegintsev)
Date: Fri, 22 Nov 2024 00:53:23 GMT
Subject: <i18n dev> RFR: 8344795: Remove uses of AccessControlContext in
 java.desktop module
In-Reply-To: <I1DzBGHUo1IjWJw_R4NGh3m_-l-dC6c__9iA0ARoM64=.f5c4d821-4eb4-4d53-a4ba-899df0cd6d8e@github.com>
References: <I1DzBGHUo1IjWJw_R4NGh3m_-l-dC6c__9iA0ARoM64=.f5c4d821-4eb4-4d53-a4ba-899df0cd6d8e@github.com>
Message-ID: <HEfU7hJDCDwSUXW4ntUzMwc54X2rWE87a9cyAa-nVmw=.1ff37646-3643-4abf-a162-d69972313e69@github.com>

On Thu, 21 Nov 2024 21:23:52 GMT, Phil Race <prr at openjdk.org> wrote:

> This removes uses of AccessControlContext in java.desktop

I think the removal of the use of the `AccessControlException` should also be part of this PR.

there is only one usage:

./src/java.desktop/share/classes/java/awt/Dialog.java:36:import java.security.AccessControlException;
./src/java.desktop/share/classes/java/awt/Dialog.java:1597:        } catch (@SuppressWarnings("removal") AccessControlException ace) {
``` 

And it seems that the `java.awt.Dialog#checkModalityPermission()` has became obsolete.

src/java.desktop/share/classes/java/awt/Component.java line 8949:

> 8947:     private void readObject(ObjectInputStream s)
> 8948:       throws ClassNotFoundException, IOException
> 8949:     {

`@SuppressWarnings("removal")` can be removed

src/java.desktop/share/classes/java/awt/MenuComponent.java line 428:

> 426:     private void readObject(ObjectInputStream s)
> 427:         throws ClassNotFoundException, IOException, HeadlessException
> 428:     {

`@SuppressWarnings("removal")` can be removed

src/java.desktop/share/classes/javax/swing/UIDefaults.java line 1116:

> 1114:          *              parameters to the static method in class c
> 1115:          */
> 1116:         @SuppressWarnings("removal")

Suggestion:

-------------

PR Review: https://git.openjdk.org/jdk/pull/22308#pullrequestreview-2453047414
PR Review Comment: https://git.openjdk.org/jdk/pull/22308#discussion_r1853110063
PR Review Comment: https://git.openjdk.org/jdk/pull/22308#discussion_r1853117233
PR Review Comment: https://git.openjdk.org/jdk/pull/22308#discussion_r1853123036

From prr at openjdk.org  Fri Nov 22 04:14:25 2024
From: prr at openjdk.org (Phil Race)
Date: Fri, 22 Nov 2024 04:14:25 GMT
Subject: <i18n dev> RFR: 8344795: Remove uses of AccessControlContext in
 java.desktop module [v2]
In-Reply-To: <I1DzBGHUo1IjWJw_R4NGh3m_-l-dC6c__9iA0ARoM64=.f5c4d821-4eb4-4d53-a4ba-899df0cd6d8e@github.com>
References: <I1DzBGHUo1IjWJw_R4NGh3m_-l-dC6c__9iA0ARoM64=.f5c4d821-4eb4-4d53-a4ba-899df0cd6d8e@github.com>
Message-ID: <Q8nFZ40q063Hvow1Y3FlcgLxs8iFCGs9d8WqaXInmso=.3dd0a6b5-48b5-4048-b526-da46f3f22597@github.com>

> This removes uses of AccessControlContext in java.desktop

Phil Race has updated the pull request incrementally with one additional commit since the last revision:

  8344795

-------------

Changes:
  - all: https://git.openjdk.org/jdk/pull/22308/files
  - new: https://git.openjdk.org/jdk/pull/22308/files/30152179..8d87389e

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jdk&pr=22308&range=01
 - incr: https://webrevs.openjdk.org/?repo=jdk&pr=22308&range=00-01

  Stats: 3 lines in 3 files changed: 0 ins; 3 del; 0 mod
  Patch: https://git.openjdk.org/jdk/pull/22308.diff
  Fetch: git fetch https://git.openjdk.org/jdk.git pull/22308/head:pull/22308

PR: https://git.openjdk.org/jdk/pull/22308

From prr at openjdk.org  Fri Nov 22 04:14:27 2024
From: prr at openjdk.org (Phil Race)
Date: Fri, 22 Nov 2024 04:14:27 GMT
Subject: <i18n dev> RFR: 8344795: Remove uses of AccessControlContext in
 java.desktop module [v2]
In-Reply-To: <HEfU7hJDCDwSUXW4ntUzMwc54X2rWE87a9cyAa-nVmw=.1ff37646-3643-4abf-a162-d69972313e69@github.com>
References: <I1DzBGHUo1IjWJw_R4NGh3m_-l-dC6c__9iA0ARoM64=.f5c4d821-4eb4-4d53-a4ba-899df0cd6d8e@github.com>
 <HEfU7hJDCDwSUXW4ntUzMwc54X2rWE87a9cyAa-nVmw=.1ff37646-3643-4abf-a162-d69972313e69@github.com>
Message-ID: <8lbkLmSxY6gNbunqbTpWZgFX-Ea8z4I8oibAz87GFIo=.1669950c-dbd9-4c84-bb91-c59b2f83fe0e@github.com>

On Fri, 22 Nov 2024 00:50:45 GMT, Alexander Zvegintsev <azvegint at openjdk.org> wrote:

> I think the removal of the use of the `AccessControlException` should also be part of this PR.
> 
> there is only one usage:
> 
> ```
> ./src/java.desktop/share/classes/java/awt/Dialog.java:36:import java.security.AccessControlException;
> ./src/java.desktop/share/classes/java/awt/Dialog.java:1597:        } catch (@SuppressWarnings("removal") AccessControlException ace) {
> ```
> 
> And it seems that the `java.awt.Dialog#checkModalityPermission()` has became obsolete.

I deliberately left these alone, because it is part of removing most AWTPermissions which I have partially prepared already for a separate PR.
The fix will come soon, perhaps tomorrow,  perhaps Monday.

> src/java.desktop/share/classes/java/awt/Component.java line 8949:
> 
>> 8947:     private void readObject(ObjectInputStream s)
>> 8948:       throws ClassNotFoundException, IOException
>> 8949:     {
> 
> `@SuppressWarnings("removal")` can be removed

ok

> src/java.desktop/share/classes/java/awt/MenuComponent.java line 428:
> 
>> 426:     private void readObject(ObjectInputStream s)
>> 427:         throws ClassNotFoundException, IOException, HeadlessException
>> 428:     {
> 
> `@SuppressWarnings("removal")` can be removed

ok

> src/java.desktop/share/classes/javax/swing/UIDefaults.java line 1116:
> 
>> 1114:          *              parameters to the static method in class c
>> 1115:          */
>> 1116:         @SuppressWarnings("removal")
> 
> Suggestion:

ok

-------------

PR Comment: https://git.openjdk.org/jdk/pull/22308#issuecomment-2492838871
PR Review Comment: https://git.openjdk.org/jdk/pull/22308#discussion_r1853256344
PR Review Comment: https://git.openjdk.org/jdk/pull/22308#discussion_r1853256435
PR Review Comment: https://git.openjdk.org/jdk/pull/22308#discussion_r1853256560

From azvegint at openjdk.org  Fri Nov 22 09:41:14 2024
From: azvegint at openjdk.org (Alexander Zvegintsev)
Date: Fri, 22 Nov 2024 09:41:14 GMT
Subject: <i18n dev> RFR: 8344795: Remove uses of AccessControlContext in
 java.desktop module [v2]
In-Reply-To: <Q8nFZ40q063Hvow1Y3FlcgLxs8iFCGs9d8WqaXInmso=.3dd0a6b5-48b5-4048-b526-da46f3f22597@github.com>
References: <I1DzBGHUo1IjWJw_R4NGh3m_-l-dC6c__9iA0ARoM64=.f5c4d821-4eb4-4d53-a4ba-899df0cd6d8e@github.com>
 <Q8nFZ40q063Hvow1Y3FlcgLxs8iFCGs9d8WqaXInmso=.3dd0a6b5-48b5-4048-b526-da46f3f22597@github.com>
Message-ID: <qx69pGy5XGwNiGnULoAGuXX-BeRRjxC0Lv9PLjyr56A=.6e53eecd-5a68-4cab-b298-8ce44cf8dac6@github.com>

On Fri, 22 Nov 2024 04:14:25 GMT, Phil Race <prr at openjdk.org> wrote:

>> This removes uses of AccessControlContext in java.desktop
>
> Phil Race has updated the pull request incrementally with one additional commit since the last revision:
> 
>   8344795

Marked as reviewed by azvegint (Reviewer).

-------------

PR Review: https://git.openjdk.org/jdk/pull/22308#pullrequestreview-2453962637

From jlu at openjdk.org  Fri Nov 22 18:00:21 2024
From: jlu at openjdk.org (Justin Lu)
Date: Fri, 22 Nov 2024 18:00:21 GMT
Subject: <i18n dev> RFR: 8319993: Update Unicode Data Files to 16.0.0
 [v2]
In-Reply-To: <BrxHySXQqOjVuMIYhJ3b4QZrOsiGWxd3sTYUXNhKegY=.73a489a0-d39a-424b-a452-f60c578d05a6@github.com>
References: <lhjftuxraeNfYcmqtLlHjH0COs5-oyjaZlz_oMsoUG0=.5c1fc0e0-781d-4610-ab0c-6ed8fd4b525c@github.com>
 <BrxHySXQqOjVuMIYhJ3b4QZrOsiGWxd3sTYUXNhKegY=.73a489a0-d39a-424b-a452-f60c578d05a6@github.com>
Message-ID: <2CXO9L1u82F2KY9Q42FtGvoqaGSRrz_I_PYfGSrE214=.d41a3a7c-9e68-44a8-af44-2c3e377f8a5f@github.com>

On Thu, 21 Nov 2024 20:42:57 GMT, Naoto Sato <naoto at openjdk.org> wrote:

>> Updates the JDK to use the latest Unicode 16.0.0, which also updates the ICU4J along with it (8319992: Update ICU4J to Version 76.1). The corresponding CSR has already been approved.
>
> Naoto Sato has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Corrected the Unicode version in Grapheme.java

Marked as reviewed by jlu (Committer).

-------------

PR Review: https://git.openjdk.org/jdk/pull/21771#pullrequestreview-2455256169

From prr at openjdk.org  Fri Nov 22 18:03:22 2024
From: prr at openjdk.org (Phil Race)
Date: Fri, 22 Nov 2024 18:03:22 GMT
Subject: <i18n dev> Integrated: 8344795: Remove uses of AccessControlContext
 in java.desktop module
In-Reply-To: <I1DzBGHUo1IjWJw_R4NGh3m_-l-dC6c__9iA0ARoM64=.f5c4d821-4eb4-4d53-a4ba-899df0cd6d8e@github.com>
References: <I1DzBGHUo1IjWJw_R4NGh3m_-l-dC6c__9iA0ARoM64=.f5c4d821-4eb4-4d53-a4ba-899df0cd6d8e@github.com>
Message-ID: <_VRE3rOJIknXPOoGoqM_va1SKEdB8YEAdb27sHK2y_w=.3a52ba25-e1f9-4706-8fb7-46ea28319e7a@github.com>

On Thu, 21 Nov 2024 21:23:52 GMT, Phil Race <prr at openjdk.org> wrote:

> This removes uses of AccessControlContext in java.desktop

This pull request has now been integrated.

Changeset: 4b165305
Author:    Phil Race <prr at openjdk.org>
URL:       https://git.openjdk.org/jdk/commit/4b1653056d39db2c85989c787364e2646e5ef463
Stats:     189 lines in 8 files changed: 1 ins; 178 del; 10 mod

8344795: Remove uses of AccessControlContext in java.desktop module

Reviewed-by: azvegint

-------------

PR: https://git.openjdk.org/jdk/pull/22308

From joehw at openjdk.org  Fri Nov 22 20:01:17 2024
From: joehw at openjdk.org (Joe Wang)
Date: Fri, 22 Nov 2024 20:01:17 GMT
Subject: <i18n dev> RFR: 8319993: Update Unicode Data Files to 16.0.0
 [v2]
In-Reply-To: <BrxHySXQqOjVuMIYhJ3b4QZrOsiGWxd3sTYUXNhKegY=.73a489a0-d39a-424b-a452-f60c578d05a6@github.com>
References: <lhjftuxraeNfYcmqtLlHjH0COs5-oyjaZlz_oMsoUG0=.5c1fc0e0-781d-4610-ab0c-6ed8fd4b525c@github.com>
 <BrxHySXQqOjVuMIYhJ3b4QZrOsiGWxd3sTYUXNhKegY=.73a489a0-d39a-424b-a452-f60c578d05a6@github.com>
Message-ID: <tzs7gVmokrq3wWGRDqmJW_PEdihRATUo5LY_cC8XZgc=.8acae8e6-f164-48c5-b6e8-ba05e17de350@github.com>

On Thu, 21 Nov 2024 20:42:57 GMT, Naoto Sato <naoto at openjdk.org> wrote:

>> Updates the JDK to use the latest Unicode 16.0.0, which also updates the ICU4J along with it (8319992: Update ICU4J to Version 76.1). The corresponding CSR has already been approved.
>
> Naoto Sato has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Corrected the Unicode version in Grapheme.java

Marked as reviewed by joehw (Reviewer).

-------------

PR Review: https://git.openjdk.org/jdk/pull/21771#pullrequestreview-2455525794

From iris at openjdk.org  Fri Nov 22 20:42:15 2024
From: iris at openjdk.org (Iris Clark)
Date: Fri, 22 Nov 2024 20:42:15 GMT
Subject: <i18n dev> RFR: 8319993: Update Unicode Data Files to 16.0.0
 [v2]
In-Reply-To: <BrxHySXQqOjVuMIYhJ3b4QZrOsiGWxd3sTYUXNhKegY=.73a489a0-d39a-424b-a452-f60c578d05a6@github.com>
References: <lhjftuxraeNfYcmqtLlHjH0COs5-oyjaZlz_oMsoUG0=.5c1fc0e0-781d-4610-ab0c-6ed8fd4b525c@github.com>
 <BrxHySXQqOjVuMIYhJ3b4QZrOsiGWxd3sTYUXNhKegY=.73a489a0-d39a-424b-a452-f60c578d05a6@github.com>
Message-ID: <Pl_XGjwF1od3rF1FqCbTJbABO8mgwxEPggYZcSnm0Vg=.64c57a1b-04bb-4cd1-9ddd-d3d2e35c94e2@github.com>

On Thu, 21 Nov 2024 20:42:57 GMT, Naoto Sato <naoto at openjdk.org> wrote:

>> Updates the JDK to use the latest Unicode 16.0.0, which also updates the ICU4J along with it (8319992: Update ICU4J to Version 76.1). The corresponding CSR has already been approved.
>
> Naoto Sato has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Corrected the Unicode version in Grapheme.java

Marked as reviewed by iris (Reviewer).

-------------

PR Review: https://git.openjdk.org/jdk/pull/21771#pullrequestreview-2455602537

From rriggs at openjdk.org  Fri Nov 22 23:16:07 2024
From: rriggs at openjdk.org (Roger Riggs)
Date: Fri, 22 Nov 2024 23:16:07 GMT
Subject: <i18n dev> RFR: 8344898: SM cleanup of java.base sun/util calendar,
 locale, cldr, and resources
Message-ID: <K8XmFHxNDu401tc4L33xtRCX-C8xv8aOZzM-j-ixkwE=.e805a911-8cae-4cb6-aa26-de4a77e02c7f@github.com>

Cleanup of doPrivileged in:
    sun.util.calendar
    sun.util.local/provider
    sun.util.cldr
    sun.util.resources

-------------

Commit messages:
 - 8344898: SM cleanup of java.base sun/util calendar, locale, clde, and resources

Changes: https://git.openjdk.org/jdk/pull/22336/files
  Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=22336&range=00
  Issue: https://bugs.openjdk.org/browse/JDK-8344898
  Stats: 271 lines in 9 files changed: 8 ins; 152 del; 111 mod
  Patch: https://git.openjdk.org/jdk/pull/22336.diff
  Fetch: git fetch https://git.openjdk.org/jdk.git pull/22336/head:pull/22336

PR: https://git.openjdk.org/jdk/pull/22336

From naoto at openjdk.org  Sat Nov 23 00:05:14 2024
From: naoto at openjdk.org (Naoto Sato)
Date: Sat, 23 Nov 2024 00:05:14 GMT
Subject: <i18n dev> RFR: 8344898: SM cleanup of java.base sun/util
 calendar, locale, cldr, and resources
In-Reply-To: <K8XmFHxNDu401tc4L33xtRCX-C8xv8aOZzM-j-ixkwE=.e805a911-8cae-4cb6-aa26-de4a77e02c7f@github.com>
References: <K8XmFHxNDu401tc4L33xtRCX-C8xv8aOZzM-j-ixkwE=.e805a911-8cae-4cb6-aa26-de4a77e02c7f@github.com>
Message-ID: <VYPJdwYAKaSHiHKQRhnQlUtMUB5TB8BB95k9_5cAWHk=.6935969e-f4f5-45c4-9125-a60368fa313a@github.com>

On Fri, 22 Nov 2024 23:05:11 GMT, Roger Riggs <rriggs at openjdk.org> wrote:

> Cleanup of doPrivileged in:
>     sun.util.calendar
>     sun.util.local/provider
>     sun.util.cldr
>     sun.util.resources

Thanks for the fix in this area. Looks good with a couple of minor nit

src/java.base/share/classes/sun/util/resources/BreakIteratorResourceBundle.java line 72:

> 70:                       + '/' + info.getString(key);
> 71:         byte[] data;
> 72:         try (InputStream is = getClass().getModule().getResourceAsStream(path);) {

`;` is not needed

src/java.base/share/classes/sun/util/resources/Bundles.java line 268:

> 266:                     return bundle;
> 267:                 }
> 268:             } catch (ServiceConfigurationError | SecurityException e) {

`SecurityException` can be removed

-------------

PR Review: https://git.openjdk.org/jdk/pull/22336#pullrequestreview-2456033295
PR Review Comment: https://git.openjdk.org/jdk/pull/22336#discussion_r1854914652
PR Review Comment: https://git.openjdk.org/jdk/pull/22336#discussion_r1854916974

From rriggs at openjdk.org  Sat Nov 23 03:09:02 2024
From: rriggs at openjdk.org (Roger Riggs)
Date: Sat, 23 Nov 2024 03:09:02 GMT
Subject: <i18n dev> RFR: 8344898: SM cleanup of java.base sun/util
 calendar, locale, cldr, and resources [v2]
In-Reply-To: <K8XmFHxNDu401tc4L33xtRCX-C8xv8aOZzM-j-ixkwE=.e805a911-8cae-4cb6-aa26-de4a77e02c7f@github.com>
References: <K8XmFHxNDu401tc4L33xtRCX-C8xv8aOZzM-j-ixkwE=.e805a911-8cae-4cb6-aa26-de4a77e02c7f@github.com>
Message-ID: <JrGnVFUBBBCQATmoVVQ956ezFaF1HFn83Y1wrh4AtzI=.30a45fdb-3e51-4198-96d0-f14cfb83da4f@github.com>

> Cleanup of doPrivileged in:
>     sun.util.calendar
>     sun.util.local/provider
>     sun.util.cldr
>     sun.util.resources

Roger Riggs has updated the pull request incrementally with one additional commit since the last revision:

  Cleanups recommended by reviewer

-------------

Changes:
  - all: https://git.openjdk.org/jdk/pull/22336/files
  - new: https://git.openjdk.org/jdk/pull/22336/files/e8135814..efa74a7e

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jdk&pr=22336&range=01
 - incr: https://webrevs.openjdk.org/?repo=jdk&pr=22336&range=00-01

  Stats: 2 lines in 2 files changed: 0 ins; 0 del; 2 mod
  Patch: https://git.openjdk.org/jdk/pull/22336.diff
  Fetch: git fetch https://git.openjdk.org/jdk.git pull/22336/head:pull/22336

PR: https://git.openjdk.org/jdk/pull/22336

From prr at openjdk.org  Sun Nov 24 23:51:52 2024
From: prr at openjdk.org (Phil Race)
Date: Sun, 24 Nov 2024 23:51:52 GMT
Subject: <i18n dev> RFR: 8344667: Remove most uses of AWT Permissions from
 the desktop module
Message-ID: <Yc0SanCXlUcmh7en3Wxmm_bREZP_uSZZwUi5aWySpAU=.38968ac3-926e-4a23-b16b-9c2fb2f51e9f@github.com>

This removes most uses of AWTPermission in the desktop module.
clipboard will be handled separately because it is less straightforward.

-------------

Commit messages:
 - 8344667
 - src/java.desktop/macosx/classes/sun/awt/CGraphicsDevice.java

Changes: https://git.openjdk.org/jdk/pull/22350/files
  Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=22350&range=00
  Issue: https://bugs.openjdk.org/browse/JDK-8344667
  Stats: 312 lines in 21 files changed: 0 ins; 306 del; 6 mod
  Patch: https://git.openjdk.org/jdk/pull/22350.diff
  Fetch: git fetch https://git.openjdk.org/jdk.git pull/22350/head:pull/22350

PR: https://git.openjdk.org/jdk/pull/22350

From naoto at openjdk.org  Mon Nov 25 15:55:18 2024
From: naoto at openjdk.org (Naoto Sato)
Date: Mon, 25 Nov 2024 15:55:18 GMT
Subject: <i18n dev> RFR: 8344898: SM cleanup of java.base sun/util
 calendar, locale, cldr, and resources [v2]
In-Reply-To: <JrGnVFUBBBCQATmoVVQ956ezFaF1HFn83Y1wrh4AtzI=.30a45fdb-3e51-4198-96d0-f14cfb83da4f@github.com>
References: <K8XmFHxNDu401tc4L33xtRCX-C8xv8aOZzM-j-ixkwE=.e805a911-8cae-4cb6-aa26-de4a77e02c7f@github.com>
 <JrGnVFUBBBCQATmoVVQ956ezFaF1HFn83Y1wrh4AtzI=.30a45fdb-3e51-4198-96d0-f14cfb83da4f@github.com>
Message-ID: <xgAW9YVpba0kj7G362fuGg85UPKYyNDmuWD4b1KTbp4=.582e6d82-55b2-43b6-927b-9af08d31ca01@github.com>

On Sat, 23 Nov 2024 03:09:02 GMT, Roger Riggs <rriggs at openjdk.org> wrote:

>> Cleanup of doPrivileged in:
>>     sun.util.calendar
>>     sun.util.local/provider
>>     sun.util.cldr
>>     sun.util.resources
>
> Roger Riggs has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Cleanups recommended by reviewer

LGTM. Thanks for the changes

-------------

Marked as reviewed by naoto (Reviewer).

PR Review: https://git.openjdk.org/jdk/pull/22336#pullrequestreview-2458844131

From naoto at openjdk.org  Mon Nov 25 15:57:24 2024
From: naoto at openjdk.org (Naoto Sato)
Date: Mon, 25 Nov 2024 15:57:24 GMT
Subject: <i18n dev> RFR: 8319993: Update Unicode Data Files to 16.0.0
 [v2]
In-Reply-To: <BrxHySXQqOjVuMIYhJ3b4QZrOsiGWxd3sTYUXNhKegY=.73a489a0-d39a-424b-a452-f60c578d05a6@github.com>
References: <lhjftuxraeNfYcmqtLlHjH0COs5-oyjaZlz_oMsoUG0=.5c1fc0e0-781d-4610-ab0c-6ed8fd4b525c@github.com>
 <BrxHySXQqOjVuMIYhJ3b4QZrOsiGWxd3sTYUXNhKegY=.73a489a0-d39a-424b-a452-f60c578d05a6@github.com>
Message-ID: <jwgzm28kKdVq0U-mq2z4KTycNtiQzBw6JKi-gIQi4ME=.23e958c3-571e-4779-b7ee-e88b6dc2c2c1@github.com>

On Thu, 21 Nov 2024 20:42:57 GMT, Naoto Sato <naoto at openjdk.org> wrote:

>> Updates the JDK to use the latest Unicode 16.0.0, which also updates the ICU4J along with it (8319992: Update ICU4J to Version 76.1). The corresponding CSR has already been approved.
>
> Naoto Sato has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Corrected the Unicode version in Grapheme.java

Thanks for the reviews!

-------------

PR Comment: https://git.openjdk.org/jdk/pull/21771#issuecomment-2498397948

From naoto at openjdk.org  Mon Nov 25 15:57:26 2024
From: naoto at openjdk.org (Naoto Sato)
Date: Mon, 25 Nov 2024 15:57:26 GMT
Subject: <i18n dev> Integrated: 8319993: Update Unicode Data Files to 16.0.0
In-Reply-To: <lhjftuxraeNfYcmqtLlHjH0COs5-oyjaZlz_oMsoUG0=.5c1fc0e0-781d-4610-ab0c-6ed8fd4b525c@github.com>
References: <lhjftuxraeNfYcmqtLlHjH0COs5-oyjaZlz_oMsoUG0=.5c1fc0e0-781d-4610-ab0c-6ed8fd4b525c@github.com>
Message-ID: <3V07MMnUK9ztPKert_2YmQZtfCCmqCUqqK3eEAYFpFM=.2acca83a-d1f1-4487-a61b-c2ef622ca64b@github.com>

On Tue, 29 Oct 2024 18:01:55 GMT, Naoto Sato <naoto at openjdk.org> wrote:

> Updates the JDK to use the latest Unicode 16.0.0, which also updates the ICU4J along with it (8319992: Update ICU4J to Version 76.1). The corresponding CSR has already been approved.

This pull request has now been integrated.

Changeset: 15ae8d02
Author:    Naoto Sato <naoto at openjdk.org>
URL:       https://git.openjdk.org/jdk/commit/15ae8d02eeb9c80f5453b88d38081debf956cb65
Stats:     8443 lines in 29 files changed: 7542 ins; 296 del; 605 mod

8319993: Update Unicode Data Files to 16.0.0
8319992: Update ICU4J to Version 76.1

Reviewed-by: jlu, joehw, iris

-------------

PR: https://git.openjdk.org/jdk/pull/21771

From azvegint at openjdk.org  Mon Nov 25 16:34:15 2024
From: azvegint at openjdk.org (Alexander Zvegintsev)
Date: Mon, 25 Nov 2024 16:34:15 GMT
Subject: <i18n dev> RFR: 8344667: Remove most uses of AWT Permissions
 from the desktop module
In-Reply-To: <Yc0SanCXlUcmh7en3Wxmm_bREZP_uSZZwUi5aWySpAU=.38968ac3-926e-4a23-b16b-9c2fb2f51e9f@github.com>
References: <Yc0SanCXlUcmh7en3Wxmm_bREZP_uSZZwUi5aWySpAU=.38968ac3-926e-4a23-b16b-9c2fb2f51e9f@github.com>
Message-ID: <uSY_xai1_uTP0Ig6jpK9N7GyH6Wz1ZrHSEWy6VA8LDQ=.1fe3e7e4-41fb-466c-b7ba-ad2c4cfc6d5a@github.com>

On Sun, 24 Nov 2024 23:46:17 GMT, Phil Race <prr at openjdk.org> wrote:

> This removes most uses of AWTPermission in the desktop module.
> clipboard will be handled separately because it is less straightforward.

A few places that probably need some attention:

`./src/java.desktop/share/classes/java/awt/Composite.java:60: * to a screen device is governed by the {@code readDisplayPixels}`


 * Since this interface must expose the contents of pixels on the
 * target device or image to potentially arbitrary code, the use of
 * custom objects which implement this interface when rendering directly
 * to a screen device is governed by the {@code readDisplayPixels}
 * {@link AWTPermission}.  The permission check will occur when such
 * a custom object is passed to the {@code setComposite} method
 * of a {@code Graphics2D} retrieved from a {@link Component}.

------

doc update:


`./src/java.desktop/share/classes/java/awt/doc-files/Modality.html:338:      A special <code>AWTPermission</code>, <code>"toolkitModality"</code>,`

    <p>
      A special <code>AWTPermission</code>, <code>"toolkitModality"</code>,
      is required to show toolkit-modal
      dialogs. This would prevent, for example, blocking a browser or
      Java Web Start (JWS) by modal dialogs shown from applets.
    </p><p>
      The same permission is required to exclude a window from toolkit modality.
      This would prevent, for example, a dialog shown from an applet not to be
      blocked by a browser's or JWS's modal dialog.



---


./test/jdk/lib/client/ExtendedRobot.java:71:     * @throws  SecurityException if {@code createRobot} permission is not granted
./test/jdk/lib/client/ExtendedRobot.java:75:     * @see     java.awt.AWTPermission
./test/jdk/lib/client/ExtendedRobot.java:102:     * @throws  SecurityException if {@code createRobot} permission is not granted
./test/jdk/lib/client/ExtendedRobot.java:107:     * @see     java.awt.AWTPermission


-----

src/java.desktop/share/classes/javax/swing/SwingUtilities.java line 1973:

> 1971:             // This frame can never be shown
> 1972:         }
> 1973:         public void dispose() {

Not directly related, but there are two unused declarations that haven't been used in ages:


    // These states are system-wide, rather than AppContext wide.
    private static boolean canAccessEventQueue = false;
    private static boolean eventQueueTested = false;

`canAccessEventQueue` looks like it was somehow related to `CHECK_AWT_EVENTQUEUE_PERMISSION`

-------------

PR Review: https://git.openjdk.org/jdk/pull/22350#pullrequestreview-2458793918
PR Review Comment: https://git.openjdk.org/jdk/pull/22350#discussion_r1856827608

From rriggs at openjdk.org  Mon Nov 25 19:19:22 2024
From: rriggs at openjdk.org (Roger Riggs)
Date: Mon, 25 Nov 2024 19:19:22 GMT
Subject: <i18n dev> RFR: 8344565: SM cleanup in jdk/internal and java/lang
 package private classes
Message-ID: <En2_7apIGmFcfpkYqm8arhXfni6WbufgC6qQmGcLr9Q=.7307e9d4-8744-44f2-9444-84a339a10b27@github.com>

SM removal for internal implementation classes: 
    java.lang.CharacterName
    java.lang.ref.Finalizer
    jdk.internal.icu.impl.ICUBinary
    jdk.internal.misc.ExtendedMapMode

-------------

Commit messages:
 - Refactored to remove additional doPrivileged calls
 - 8344565: SM cleanup in jdk/internal packages

Changes: https://git.openjdk.org/jdk/pull/22370/files
  Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=22370&range=00
  Issue: https://bugs.openjdk.org/browse/JDK-8344565
  Stats: 40 lines in 4 files changed: 0 ins; 23 del; 17 mod
  Patch: https://git.openjdk.org/jdk/pull/22370.diff
  Fetch: git fetch https://git.openjdk.org/jdk.git pull/22370/head:pull/22370

PR: https://git.openjdk.org/jdk/pull/22370

From alanb at openjdk.org  Mon Nov 25 19:24:14 2024
From: alanb at openjdk.org (Alan Bateman)
Date: Mon, 25 Nov 2024 19:24:14 GMT
Subject: <i18n dev> RFR: 8344565: SM cleanup in jdk/internal and
 java/lang package private classes
In-Reply-To: <En2_7apIGmFcfpkYqm8arhXfni6WbufgC6qQmGcLr9Q=.7307e9d4-8744-44f2-9444-84a339a10b27@github.com>
References: <En2_7apIGmFcfpkYqm8arhXfni6WbufgC6qQmGcLr9Q=.7307e9d4-8744-44f2-9444-84a339a10b27@github.com>
Message-ID: <WC1Sp6jGnQkSt-yRPD1KT8joXaIeNOIwIjX0M9BcRKw=.532e175f-5397-42bf-8db9-c3656e6b2ea5@github.com>

On Mon, 25 Nov 2024 19:14:49 GMT, Roger Riggs <rriggs at openjdk.org> wrote:

> SM removal for internal implementation classes: 
>     java.lang.CharacterName
>     java.lang.ref.Finalizer
>     jdk.internal.icu.impl.ICUBinary
>     jdk.internal.misc.ExtendedMapMode

src/java.base/share/classes/jdk/internal/misc/ExtendedMapMode.java line 44:

> 42:     static {
> 43:         try {
> 44:             Lookup lookup = MethodHandles.privateLookupIn(MapMode.class, MethodHandles.lookup());

There's probably imports to remove after this cleanup.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/22370#discussion_r1857228295

From liach at openjdk.org  Mon Nov 25 19:27:18 2024
From: liach at openjdk.org (Chen Liang)
Date: Mon, 25 Nov 2024 19:27:18 GMT
Subject: <i18n dev> RFR: 8344565: SM cleanup in jdk/internal and
 java/lang package private classes
In-Reply-To: <En2_7apIGmFcfpkYqm8arhXfni6WbufgC6qQmGcLr9Q=.7307e9d4-8744-44f2-9444-84a339a10b27@github.com>
References: <En2_7apIGmFcfpkYqm8arhXfni6WbufgC6qQmGcLr9Q=.7307e9d4-8744-44f2-9444-84a339a10b27@github.com>
Message-ID: <PST21-rAvs4TWrr4AtIOx0xtXB2BxO0SRKj0HMvpEW8=.cf1865a0-15e8-4def-ba05-ca0fd9a4f913@github.com>

On Mon, 25 Nov 2024 19:14:49 GMT, Roger Riggs <rriggs at openjdk.org> wrote:

> SM removal for internal implementation classes: 
>     java.lang.CharacterName
>     java.lang.ref.Finalizer
>     jdk.internal.icu.impl.ICUBinary
>     jdk.internal.misc.ExtendedMapMode

src/java.base/share/classes/java/lang/CharacterName.java line 50:

> 48:     private CharacterName()  {
> 49:         try (DataInputStream dis = new DataInputStream(
> 50:                 new InflaterInputStream(getClass().getResourceAsStream("uniName.dat")))) {

The old `getClass()` gets the `PrivilegedAction` anonymous class.  Should we just move this to `CharacterName.class`?

src/java.base/share/classes/java/lang/ref/Finalizer.java line 117:

> 115:      * invokers of that method from a stalled or deadlocked finalizer thread.
> 116:      */
> 117:     @SuppressWarnings("removal")

ThreadGroup doesn't seem deprecated for removal, so we can remove this suppression.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/22370#discussion_r1857229429
PR Review Comment: https://git.openjdk.org/jdk/pull/22370#discussion_r1857230768

From prr at openjdk.org  Mon Nov 25 19:44:21 2024
From: prr at openjdk.org (Phil Race)
Date: Mon, 25 Nov 2024 19:44:21 GMT
Subject: <i18n dev> RFR: 8344667: Remove most uses of AWT Permissions
 from the desktop module
In-Reply-To: <uSY_xai1_uTP0Ig6jpK9N7GyH6Wz1ZrHSEWy6VA8LDQ=.1fe3e7e4-41fb-466c-b7ba-ad2c4cfc6d5a@github.com>
References: <Yc0SanCXlUcmh7en3Wxmm_bREZP_uSZZwUi5aWySpAU=.38968ac3-926e-4a23-b16b-9c2fb2f51e9f@github.com>
 <uSY_xai1_uTP0Ig6jpK9N7GyH6Wz1ZrHSEWy6VA8LDQ=.1fe3e7e4-41fb-466c-b7ba-ad2c4cfc6d5a@github.com>
Message-ID: <pTlUdwEszvHCDFtWcUyX8TrEgXK54bGLcmzt5SrZF2Q=.4cbc2348-a0cc-4ff1-9f95-922b09b94ca9@github.com>

On Mon, 25 Nov 2024 15:34:15 GMT, Alexander Zvegintsev <azvegint at openjdk.org> wrote:

>> This removes most uses of AWTPermission in the desktop module.
>> clipboard will be handled separately because it is less straightforward.
>
> src/java.desktop/share/classes/javax/swing/SwingUtilities.java line 1973:
> 
>> 1971:             // This frame can never be shown
>> 1972:         }
>> 1973:         public void dispose() {
> 
> Not directly related, but there are two unused declarations that haven't been used in ages:
> 
> 
>     // These states are system-wide, rather than AppContext wide.
>     private static boolean canAccessEventQueue = false;
>     private static boolean eventQueueTested = false;
> 
> `canAccessEventQueue` looks like it was somehow related to `CHECK_AWT_EVENTQUEUE_PERMISSION`

Yes I noticed these too, and yesterday I filed a bug to track that https://bugs.openjdk.org/browse/JDK-8344918

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/22350#discussion_r1857250139

From rriggs at openjdk.org  Mon Nov 25 19:47:34 2024
From: rriggs at openjdk.org (Roger Riggs)
Date: Mon, 25 Nov 2024 19:47:34 GMT
Subject: <i18n dev> Integrated: 8344898: SM cleanup of java.base sun/util
 calendar, locale, cldr, and resources
In-Reply-To: <K8XmFHxNDu401tc4L33xtRCX-C8xv8aOZzM-j-ixkwE=.e805a911-8cae-4cb6-aa26-de4a77e02c7f@github.com>
References: <K8XmFHxNDu401tc4L33xtRCX-C8xv8aOZzM-j-ixkwE=.e805a911-8cae-4cb6-aa26-de4a77e02c7f@github.com>
Message-ID: <kKKQtqqtiIEczw-8ZKCHGiob-ECgHGT-cPtcblR9sXw=.b85e0076-2fc9-4c37-8080-f7f70876e804@github.com>

On Fri, 22 Nov 2024 23:05:11 GMT, Roger Riggs <rriggs at openjdk.org> wrote:

> Cleanup of doPrivileged in:
>     sun.util.calendar
>     sun.util.local/provider
>     sun.util.cldr
>     sun.util.resources

This pull request has now been integrated.

Changeset: df2d4c15
Author:    Roger Riggs <rriggs at openjdk.org>
URL:       https://git.openjdk.org/jdk/commit/df2d4c157573ae0faca039bfd3c4191475b5f0de
Stats:     271 lines in 9 files changed: 8 ins; 152 del; 111 mod

8344898: SM cleanup of java.base sun/util calendar, locale, cldr, and resources

Reviewed-by: naoto

-------------

PR: https://git.openjdk.org/jdk/pull/22336

From prr at openjdk.org  Mon Nov 25 21:17:32 2024
From: prr at openjdk.org (Phil Race)
Date: Mon, 25 Nov 2024 21:17:32 GMT
Subject: <i18n dev> RFR: 8344667: Remove most uses of AWT Permissions
 from the desktop module [v2]
In-Reply-To: <Yc0SanCXlUcmh7en3Wxmm_bREZP_uSZZwUi5aWySpAU=.38968ac3-926e-4a23-b16b-9c2fb2f51e9f@github.com>
References: <Yc0SanCXlUcmh7en3Wxmm_bREZP_uSZZwUi5aWySpAU=.38968ac3-926e-4a23-b16b-9c2fb2f51e9f@github.com>
Message-ID: <udHz2i6gd0x0zEqjUjrUY1V510I7jLAgkXRCwm9M1Jw=.d880c293-e981-44c1-b2e6-ec66c7edb146@github.com>

> This removes most uses of AWTPermission in the desktop module.
> clipboard will be handled separately because it is less straightforward.

Phil Race has updated the pull request incrementally with one additional commit since the last revision:

  8344667

-------------

Changes:
  - all: https://git.openjdk.org/jdk/pull/22350/files
  - new: https://git.openjdk.org/jdk/pull/22350/files/19723c70..0f19aedf

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jdk&pr=22350&range=01
 - incr: https://webrevs.openjdk.org/?repo=jdk&pr=22350&range=00-01

  Stats: 6 lines in 1 file changed: 0 ins; 6 del; 0 mod
  Patch: https://git.openjdk.org/jdk/pull/22350.diff
  Fetch: git fetch https://git.openjdk.org/jdk.git pull/22350/head:pull/22350

PR: https://git.openjdk.org/jdk/pull/22350

From prr at openjdk.org  Mon Nov 25 21:17:34 2024
From: prr at openjdk.org (Phil Race)
Date: Mon, 25 Nov 2024 21:17:34 GMT
Subject: <i18n dev> RFR: 8344667: Remove most uses of AWT Permissions
 from the desktop module [v2]
In-Reply-To: <uSY_xai1_uTP0Ig6jpK9N7GyH6Wz1ZrHSEWy6VA8LDQ=.1fe3e7e4-41fb-466c-b7ba-ad2c4cfc6d5a@github.com>
References: <Yc0SanCXlUcmh7en3Wxmm_bREZP_uSZZwUi5aWySpAU=.38968ac3-926e-4a23-b16b-9c2fb2f51e9f@github.com>
 <uSY_xai1_uTP0Ig6jpK9N7GyH6Wz1ZrHSEWy6VA8LDQ=.1fe3e7e4-41fb-466c-b7ba-ad2c4cfc6d5a@github.com>
Message-ID: <v6D9jkSbX2RAqexjv0vE8cx_mGEuBQuiuEqbCAmIyq8=.60d98ad4-2743-461c-ba59-fd629dfc18ad@github.com>

On Mon, 25 Nov 2024 16:31:11 GMT, Alexander Zvegintsev <azvegint at openjdk.org> wrote:

> A few places that probably need some attention:
> 
> `./src/java.desktop/share/classes/java/awt/Composite.java:60: * to a screen device is governed by the {@code readDisplayPixels}`

If you take a look at https://github.com/openjdk/jdk/pull/22338/files you will see this text is being addressed there.


> 
> doc update:
> 
> ```
> `./src/java.desktop/share/classes/java/awt/doc-files/Modality.html:338:      A special <code>AWTPermission</code>, <code>"toolkitModality"</code>,`
> 
>     <p>
>       A special <code>AWTPermission</code>, <code>"toolkitModality"</code>,
>       is required to show toolkit-modal
>       dialogs. This would prevent, for example, blocking a browser or
>       Java Web Start (JWS) by modal dialogs shown from applets.
>     </p><p>
>       The same permission is required to exclude a window from toolkit modality.
>       This would prevent, for example, a dialog shown from an applet not to be
>       blocked by a browser's or JWS's modal dialog.
> ```


thanks for reminding me about these doc-files. I've been meaning to check them.
Since those files are likely specification  I'll add that to the upcoming fix to deprecate AWTPermission since I can bundle into the CSR for that. not here.


>  ```
> ./test/jdk/lib/client/ExtendedRobot.java:71:     * @throws  SecurityException if {@code createRobot} permission is not granted
> ./test/jdk/lib/client/ExtendedRobot.java:75:     * @see     java.awt.AWTPermission
> ./test/jdk/lib/client/ExtendedRobot.java:102:     * @throws  SecurityException if {@code createRobot} permission is not granted
> ./test/jdk/lib/client/ExtendedRobot.java:107:     * @see     java.awt.AWTPermission
> ```

I guess I could do that. No spec. issue around that.

-------------

PR Comment: https://git.openjdk.org/jdk/pull/22350#issuecomment-2499042052

From azvegint at openjdk.org  Mon Nov 25 21:36:40 2024
From: azvegint at openjdk.org (Alexander Zvegintsev)
Date: Mon, 25 Nov 2024 21:36:40 GMT
Subject: <i18n dev> RFR: 8344667: Remove most uses of AWT Permissions
 from the desktop module [v2]
In-Reply-To: <udHz2i6gd0x0zEqjUjrUY1V510I7jLAgkXRCwm9M1Jw=.d880c293-e981-44c1-b2e6-ec66c7edb146@github.com>
References: <Yc0SanCXlUcmh7en3Wxmm_bREZP_uSZZwUi5aWySpAU=.38968ac3-926e-4a23-b16b-9c2fb2f51e9f@github.com>
 <udHz2i6gd0x0zEqjUjrUY1V510I7jLAgkXRCwm9M1Jw=.d880c293-e981-44c1-b2e6-ec66c7edb146@github.com>
Message-ID: <fcewWNXkkD56ISNyOmRUAL1S6FXyYXjthFq_baQjwnI=.feb500f8-4740-4ca3-ab62-019b411c8ef0@github.com>

On Mon, 25 Nov 2024 21:17:32 GMT, Phil Race <prr at openjdk.org> wrote:

>> This removes most uses of AWTPermission in the desktop module.
>> clipboard will be handled separately because it is less straightforward.
>
> Phil Race has updated the pull request incrementally with one additional commit since the last revision:
> 
>   8344667

Marked as reviewed by azvegint (Reviewer).

-------------

PR Review: https://git.openjdk.org/jdk/pull/22350#pullrequestreview-2459656112

From kizune at openjdk.org  Mon Nov 25 22:13:45 2024
From: kizune at openjdk.org (Alexander Zuev)
Date: Mon, 25 Nov 2024 22:13:45 GMT
Subject: <i18n dev> RFR: 8344667: Remove most uses of AWT Permissions
 from the desktop module [v2]
In-Reply-To: <udHz2i6gd0x0zEqjUjrUY1V510I7jLAgkXRCwm9M1Jw=.d880c293-e981-44c1-b2e6-ec66c7edb146@github.com>
References: <Yc0SanCXlUcmh7en3Wxmm_bREZP_uSZZwUi5aWySpAU=.38968ac3-926e-4a23-b16b-9c2fb2f51e9f@github.com>
 <udHz2i6gd0x0zEqjUjrUY1V510I7jLAgkXRCwm9M1Jw=.d880c293-e981-44c1-b2e6-ec66c7edb146@github.com>
Message-ID: <ratxL_JImuUOMgyjNtdXNalb8jNOX3uTgq1zYN56lPs=.65076678-92ac-4771-9be7-c443e0f16ca4@github.com>

On Mon, 25 Nov 2024 21:17:32 GMT, Phil Race <prr at openjdk.org> wrote:

>> This removes most uses of AWTPermission in the desktop module.
>> clipboard will be handled separately because it is less straightforward.
>
> Phil Race has updated the pull request incrementally with one additional commit since the last revision:
> 
>   8344667

Marked as reviewed by kizune (Reviewer).

-------------

PR Review: https://git.openjdk.org/jdk/pull/22350#pullrequestreview-2459734273

From prr at openjdk.org  Mon Nov 25 22:18:47 2024
From: prr at openjdk.org (Phil Race)
Date: Mon, 25 Nov 2024 22:18:47 GMT
Subject: <i18n dev> Integrated: 8344667: Remove most uses of AWT Permissions
 from the desktop module
In-Reply-To: <Yc0SanCXlUcmh7en3Wxmm_bREZP_uSZZwUi5aWySpAU=.38968ac3-926e-4a23-b16b-9c2fb2f51e9f@github.com>
References: <Yc0SanCXlUcmh7en3Wxmm_bREZP_uSZZwUi5aWySpAU=.38968ac3-926e-4a23-b16b-9c2fb2f51e9f@github.com>
Message-ID: <Z9sDtxxn5f7y5Jmk-SQe5KlDE3RfX52dcxpxXuxT8Zs=.707d764a-46b2-449c-80cf-927bfec7d5d9@github.com>

On Sun, 24 Nov 2024 23:46:17 GMT, Phil Race <prr at openjdk.org> wrote:

> This removes most uses of AWTPermission in the desktop module.
> clipboard will be handled separately because it is less straightforward.

This pull request has now been integrated.

Changeset: 02760796
Author:    Phil Race <prr at openjdk.org>
URL:       https://git.openjdk.org/jdk/commit/027607968b3d55b498e9f2d7a4023b8ae2d47b5b
Stats:     318 lines in 22 files changed: 0 ins; 312 del; 6 mod

8344667: Remove most uses of AWT Permissions from the desktop module

Reviewed-by: azvegint, kizune

-------------

PR: https://git.openjdk.org/jdk/pull/22350

From rriggs at openjdk.org  Mon Nov 25 23:39:39 2024
From: rriggs at openjdk.org (Roger Riggs)
Date: Mon, 25 Nov 2024 23:39:39 GMT
Subject: <i18n dev> RFR: 8344565: SM cleanup in jdk/internal and
 java/lang package private classes [v2]
In-Reply-To: <En2_7apIGmFcfpkYqm8arhXfni6WbufgC6qQmGcLr9Q=.7307e9d4-8744-44f2-9444-84a339a10b27@github.com>
References: <En2_7apIGmFcfpkYqm8arhXfni6WbufgC6qQmGcLr9Q=.7307e9d4-8744-44f2-9444-84a339a10b27@github.com>
Message-ID: <FUbD4PdLluiSMsiv-CHWkuGm_sW8pSAn9n2RZ0cCLTg=.c88d145c-0abb-46fa-b974-2b01007b515e@github.com>

> SM removal for internal implementation classes: 
>     java.lang.CharacterName
>     java.lang.ref.Finalizer
>     jdk.internal.icu.impl.ICUBinary
>     jdk.internal.misc.ExtendedMapMode

Roger Riggs has updated the pull request incrementally with one additional commit since the last revision:

  Reviewer suggested updates:
  - remove obsolete imports
  - remove unnecessary SuppressWarnings("removal")
  - Use CharacterName.class as the base for getResourceStream

-------------

Changes:
  - all: https://git.openjdk.org/jdk/pull/22370/files
  - new: https://git.openjdk.org/jdk/pull/22370/files/6a004ab9..e06e5681

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jdk&pr=22370&range=01
 - incr: https://webrevs.openjdk.org/?repo=jdk&pr=22370&range=00-01

  Stats: 5 lines in 3 files changed: 1 ins; 3 del; 1 mod
  Patch: https://git.openjdk.org/jdk/pull/22370.diff
  Fetch: git fetch https://git.openjdk.org/jdk.git pull/22370/head:pull/22370

PR: https://git.openjdk.org/jdk/pull/22370

From rriggs at openjdk.org  Tue Nov 26 15:44:40 2024
From: rriggs at openjdk.org (Roger Riggs)
Date: Tue, 26 Nov 2024 15:44:40 GMT
Subject: <i18n dev> RFR: 8344565: SM cleanup in jdk/internal and
 java/lang package private classes [v2]
In-Reply-To: <FUbD4PdLluiSMsiv-CHWkuGm_sW8pSAn9n2RZ0cCLTg=.c88d145c-0abb-46fa-b974-2b01007b515e@github.com>
References: <En2_7apIGmFcfpkYqm8arhXfni6WbufgC6qQmGcLr9Q=.7307e9d4-8744-44f2-9444-84a339a10b27@github.com>
 <FUbD4PdLluiSMsiv-CHWkuGm_sW8pSAn9n2RZ0cCLTg=.c88d145c-0abb-46fa-b974-2b01007b515e@github.com>
Message-ID: <7EGgIHmWLVRyxaVfqXxylV1ZTnZ7eMfbICYZ0njsWQc=.c8cce9ca-f646-4932-95da-dbb4840997dd@github.com>

On Mon, 25 Nov 2024 23:39:39 GMT, Roger Riggs <rriggs at openjdk.org> wrote:

>> SM removal for internal implementation classes: 
>>     java.lang.CharacterName
>>     java.lang.ref.Finalizer
>>     jdk.internal.icu.impl.ICUBinary
>>     jdk.internal.misc.ExtendedMapMode
>
> Roger Riggs has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Reviewer suggested updates:
>   - remove obsolete imports
>   - remove unnecessary SuppressWarnings("removal")
>   - Use CharacterName.class as the base for getResourceStream

Passed CI tests Tier1-3

-------------

PR Comment: https://git.openjdk.org/jdk/pull/22370#issuecomment-2501200171

From alanb at openjdk.org  Tue Nov 26 16:39:39 2024
From: alanb at openjdk.org (Alan Bateman)
Date: Tue, 26 Nov 2024 16:39:39 GMT
Subject: <i18n dev> RFR: 8344565: SM cleanup in jdk/internal and
 java/lang package private classes [v2]
In-Reply-To: <FUbD4PdLluiSMsiv-CHWkuGm_sW8pSAn9n2RZ0cCLTg=.c88d145c-0abb-46fa-b974-2b01007b515e@github.com>
References: <En2_7apIGmFcfpkYqm8arhXfni6WbufgC6qQmGcLr9Q=.7307e9d4-8744-44f2-9444-84a339a10b27@github.com>
 <FUbD4PdLluiSMsiv-CHWkuGm_sW8pSAn9n2RZ0cCLTg=.c88d145c-0abb-46fa-b974-2b01007b515e@github.com>
Message-ID: <kdUVsetD7qppIa5EPgaYJI9_szLG0KoHkpqdIRBZrp0=.1d572775-c812-457d-8645-e37cea13c67d@github.com>

On Mon, 25 Nov 2024 23:39:39 GMT, Roger Riggs <rriggs at openjdk.org> wrote:

>> SM removal for internal implementation classes: 
>>     java.lang.CharacterName
>>     java.lang.ref.Finalizer
>>     jdk.internal.icu.impl.ICUBinary
>>     jdk.internal.misc.ExtendedMapMode
>
> Roger Riggs has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Reviewer suggested updates:
>   - remove obsolete imports
>   - remove unnecessary SuppressWarnings("removal")
>   - Use CharacterName.class as the base for getResourceStream

Marked as reviewed by alanb (Reviewer).

-------------

PR Review: https://git.openjdk.org/jdk/pull/22370#pullrequestreview-2462100271

From mchung at openjdk.org  Tue Nov 26 17:09:47 2024
From: mchung at openjdk.org (Mandy Chung)
Date: Tue, 26 Nov 2024 17:09:47 GMT
Subject: <i18n dev> RFR: 8344565: SM cleanup in jdk/internal and
 java/lang package private classes [v2]
In-Reply-To: <FUbD4PdLluiSMsiv-CHWkuGm_sW8pSAn9n2RZ0cCLTg=.c88d145c-0abb-46fa-b974-2b01007b515e@github.com>
References: <En2_7apIGmFcfpkYqm8arhXfni6WbufgC6qQmGcLr9Q=.7307e9d4-8744-44f2-9444-84a339a10b27@github.com>
 <FUbD4PdLluiSMsiv-CHWkuGm_sW8pSAn9n2RZ0cCLTg=.c88d145c-0abb-46fa-b974-2b01007b515e@github.com>
Message-ID: <-t2X9_KejiplAc0-0HiMhEOtIaJuTwJLmgCimcM80yU=.165649e9-d68e-4c6c-a804-0a2ec44bc347@github.com>

On Mon, 25 Nov 2024 23:39:39 GMT, Roger Riggs <rriggs at openjdk.org> wrote:

>> SM removal for internal implementation classes: 
>>     java.lang.CharacterName
>>     java.lang.ref.Finalizer
>>     jdk.internal.icu.impl.ICUBinary
>>     jdk.internal.misc.ExtendedMapMode
>
> Roger Riggs has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Reviewer suggested updates:
>   - remove obsolete imports
>   - remove unnecessary SuppressWarnings("removal")
>   - Use CharacterName.class as the base for getResourceStream

LGTM

-------------

Marked as reviewed by mchung (Reviewer).

PR Review: https://git.openjdk.org/jdk/pull/22370#pullrequestreview-2462211378

From rriggs at openjdk.org  Tue Nov 26 17:14:42 2024
From: rriggs at openjdk.org (Roger Riggs)
Date: Tue, 26 Nov 2024 17:14:42 GMT
Subject: <i18n dev> Integrated: 8344565: SM cleanup in jdk/internal and
 java/lang package private classes
In-Reply-To: <En2_7apIGmFcfpkYqm8arhXfni6WbufgC6qQmGcLr9Q=.7307e9d4-8744-44f2-9444-84a339a10b27@github.com>
References: <En2_7apIGmFcfpkYqm8arhXfni6WbufgC6qQmGcLr9Q=.7307e9d4-8744-44f2-9444-84a339a10b27@github.com>
Message-ID: <-40zGlsqPECISaFejsQCBKszpXjmHgSElVOxi1cdDGU=.0390152c-bdec-4c2b-b1dc-0d215e86df1a@github.com>

On Mon, 25 Nov 2024 19:14:49 GMT, Roger Riggs <rriggs at openjdk.org> wrote:

> SM removal for internal implementation classes: 
>     java.lang.CharacterName
>     java.lang.ref.Finalizer
>     jdk.internal.icu.impl.ICUBinary
>     jdk.internal.misc.ExtendedMapMode

This pull request has now been integrated.

Changeset: f1b5a6e6
Author:    Roger Riggs <rriggs at openjdk.org>
URL:       https://git.openjdk.org/jdk/commit/f1b5a6e66e483ee58944fb9064e310f49975e502
Stats:     43 lines in 4 files changed: 0 ins; 25 del; 18 mod

8344565: SM cleanup in jdk/internal and java/lang package private classes

Reviewed-by: alanb, mchung

-------------

PR: https://git.openjdk.org/jdk/pull/22370

From dmarkov at openjdk.org  Wed Nov 27 12:52:47 2024
From: dmarkov at openjdk.org (Dmitry Markov)
Date: Wed, 27 Nov 2024 12:52:47 GMT
Subject: <i18n dev> RFR: 8324491: Keyboard layout did not keep it state if
 it was changed when dialog is active
Message-ID: <b7_ivsVK_TTFJGqbCbMZSR2L5gYDsXzxVEQjodWobkk=.4b196bd3-1bf5-40e4-ac91-226f80fa6ec4@github.com>

If AWT/Swing app displays several windows and an user changes the keyboard layout and then closes the focused window, the app does not keep the keyboard layout changes.

It is necessary to sync currentLocale and Windows keyboard layout values in `WInputMethod` class before component activation.

-------------

Commit messages:
 - 8324491: Keyboard layout did not keep it state if it was changed when dialog is active

Changes: https://git.openjdk.org/jdk/pull/22411/files
  Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=22411&range=00
  Issue: https://bugs.openjdk.org/browse/JDK-8324491
  Stats: 5 lines in 1 file changed: 4 ins; 0 del; 1 mod
  Patch: https://git.openjdk.org/jdk/pull/22411.diff
  Fetch: git fetch https://git.openjdk.org/jdk.git pull/22411/head:pull/22411

PR: https://git.openjdk.org/jdk/pull/22411

From liach at openjdk.org  Wed Nov 27 23:19:23 2024
From: liach at openjdk.org (Chen Liang)
Date: Wed, 27 Nov 2024 23:19:23 GMT
Subject: <i18n dev> RFR: 8334733: Remove obsolete @enablePreview from tests
 after JDK-83324714
Message-ID: <3FonQjV3pn1bynQC4dT-Mo2ttwRkmxuAkY0y9TbB0u8=.5ea6d9ce-068b-4d1d-81e1-548f59761641@github.com>

Remove the redundant `@enablePreview` and `--enable-preview` flags for enabling ClassFile API in the tests.  The remainder of these flags in all tests seem to serve preview APIs (such as ScopedValue) or language features (primitive pattern, module imports, etc.), or testing the enable preview flag itself.  Now there is fewer than 100 `@enablePreview` in the `test` directory.

To reviewers, there are some redundant changes and notes:

- There's one security test that used `ModuleInfoWriter` that depends on ClassFile API.
- Removed unnecessary exports of `jdk.internal.classfile.impl`. Remaining uses are:
  - `BoundAttribute::payloadLen` for javac attribute tests
  - Annotation reading/writing for javac annotation tests
- Line number changes to:
  - test/langtools/tools/javac/linenumbers/NestedLineNumberTest.java
  - test/langtools/tools/javac/linenumbers/NullCheckLineNumberTest.java
- Move from legacy jdk.internal.classfile to java.lang.classfile in:
  - test/langtools/tools/javac/NoStringToLower.java and 
  - test/langtools/tools/javac/T8003967/DetectMutableStaticFields.java
- Weird annotation processor behavior in test/langtools/tools/javac/annotations/parameter/ParameterAnnotations.java

  - Without preview and using explicit file name, the javac task fails; using the builder live AP object works both with and without preview.

Testing: did a quick tier 1-2 locally, waiting for CI on tier 1-3.  Please inform me if any of these tests belong to higher tiers.

-------------

Commit messages:
 - 8334733: Remove obsolete @enablePreview from tests after JDK-83324714

Changes: https://git.openjdk.org/jdk/pull/22420/files
  Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=22420&range=00
  Issue: https://bugs.openjdk.org/browse/JDK-8334733
  Stats: 635 lines in 360 files changed: 2 ins; 556 del; 77 mod
  Patch: https://git.openjdk.org/jdk/pull/22420.diff
  Fetch: git fetch https://git.openjdk.org/jdk.git pull/22420/head:pull/22420

PR: https://git.openjdk.org/jdk/pull/22420

From prr at openjdk.org  Thu Nov 28 00:41:58 2024
From: prr at openjdk.org (Phil Race)
Date: Thu, 28 Nov 2024 00:41:58 GMT
Subject: <i18n dev> RFR: 8345143: Remove uses of SecurityManager in the
 java.desktop module
Message-ID: <mvc_W5nIwFPJuSCgaQolwQR2YeOEhjdKp8qeE4h8M_w=.9d1c7822-efc8-4e46-8e3c-205cb1665f37@github.com>

Remove SecurityManager related code in the desktop module that is not covered by other PRs

-------------

Commit messages:
 - 8345143

Changes: https://git.openjdk.org/jdk/pull/22424/files
  Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=22424&range=00
  Issue: https://bugs.openjdk.org/browse/JDK-8345143
  Stats: 275 lines in 32 files changed: 5 ins; 228 del; 42 mod
  Patch: https://git.openjdk.org/jdk/pull/22424.diff
  Fetch: git fetch https://git.openjdk.org/jdk.git pull/22424/head:pull/22424

PR: https://git.openjdk.org/jdk/pull/22424

From asotona at openjdk.org  Thu Nov 28 07:16:40 2024
From: asotona at openjdk.org (Adam Sotona)
Date: Thu, 28 Nov 2024 07:16:40 GMT
Subject: <i18n dev> RFR: 8334733: Remove obsolete @enablePreview from
 tests after JDK-83324714
In-Reply-To: <3FonQjV3pn1bynQC4dT-Mo2ttwRkmxuAkY0y9TbB0u8=.5ea6d9ce-068b-4d1d-81e1-548f59761641@github.com>
References: <3FonQjV3pn1bynQC4dT-Mo2ttwRkmxuAkY0y9TbB0u8=.5ea6d9ce-068b-4d1d-81e1-548f59761641@github.com>
Message-ID: <-obkcdGi1-P2yLOYnCFIDo6z_ldLIDE90jbM847BRAU=.87b21383-ded7-4296-8d85-8b256dce0980@github.com>

On Wed, 27 Nov 2024 23:10:15 GMT, Chen Liang <liach at openjdk.org> wrote:

> Remove the redundant `@enablePreview` and `--enable-preview` flags for enabling ClassFile API in the tests.  The remainder of these flags in all tests seem to serve preview APIs (such as ScopedValue) or language features (primitive pattern, module imports, etc.), or testing the enable preview flag itself.  Now there is fewer than 100 `@enablePreview` in the `test` directory.
> 
> To reviewers, there are some redundant changes and notes:
> 
> - There's one security test that used `ModuleInfoWriter` that depends on ClassFile API.
> - Removed unnecessary exports of `jdk.internal.classfile.impl`. Remaining uses are:
>   - `BoundAttribute::payloadLen` for javac attribute tests
>   - Annotation reading/writing for javac annotation tests
> - Line number changes to:
>   - test/langtools/tools/javac/linenumbers/NestedLineNumberTest.java
>   - test/langtools/tools/javac/linenumbers/NullCheckLineNumberTest.java
> - Move from legacy jdk.internal.classfile to java.lang.classfile in:
>   - test/langtools/tools/javac/NoStringToLower.java and 
>   - test/langtools/tools/javac/T8003967/DetectMutableStaticFields.java
> - Weird annotation processor behavior in test/langtools/tools/javac/annotations/parameter/ParameterAnnotations.java
> 
>   - Without preview and using explicit file name, the javac task fails; using the builder live AP object works both with and without preview.
> 
> Testing: tier 1-5.  Please inform me if any of these tests belong to higher tiers.

I would give a go to all trivial removals of `@enablePreview` after a brief check the tests pass.
However all the more complex changes potentially affecting various parts of the JDK infrastructure require deeper review and probably involve more reviewers.
My recommendation for easier review would be to split this 360-files patch into a patch with trivial removals of `@enablePreview` and one or more patches focused on particular area.

-------------

PR Comment: https://git.openjdk.org/jdk/pull/22420#issuecomment-2505408069

From liach at openjdk.org  Thu Nov 28 07:47:37 2024
From: liach at openjdk.org (Chen Liang)
Date: Thu, 28 Nov 2024 07:47:37 GMT
Subject: <i18n dev> RFR: 8334733: Remove obsolete @enablePreview from
 tests after JDK-83324714
In-Reply-To: <3FonQjV3pn1bynQC4dT-Mo2ttwRkmxuAkY0y9TbB0u8=.5ea6d9ce-068b-4d1d-81e1-548f59761641@github.com>
References: <3FonQjV3pn1bynQC4dT-Mo2ttwRkmxuAkY0y9TbB0u8=.5ea6d9ce-068b-4d1d-81e1-548f59761641@github.com>
Message-ID: <daglE0t89kpIo-mIT1Y5MwAlgOtNqRkTsNonb4obFQw=.2dfdfc9a-50de-42be-a55d-71c6a80b8bcd@github.com>

On Wed, 27 Nov 2024 23:10:15 GMT, Chen Liang <liach at openjdk.org> wrote:

> Remove the redundant `@enablePreview` and `--enable-preview` flags for enabling ClassFile API in the tests.  The remainder of these flags in all tests seem to serve preview APIs (such as ScopedValue) or language features (primitive pattern, module imports, etc.), or testing the enable preview flag itself.  Now there is fewer than 100 `@enablePreview` in the `test` directory.
> 
> To reviewers, there are some redundant changes and notes:
> 
> - There's one security test that used `ModuleInfoWriter` that depends on ClassFile API.
> - Removed unnecessary exports of `jdk.internal.classfile.impl`. Remaining uses are:
>   - `BoundAttribute::payloadLen` for javac attribute tests
>   - Annotation reading/writing for javac annotation tests
> - Line number changes to:
>   - test/langtools/tools/javac/linenumbers/NestedLineNumberTest.java
>   - test/langtools/tools/javac/linenumbers/NullCheckLineNumberTest.java
> - Move from legacy jdk.internal.classfile to java.lang.classfile in:
>   - test/langtools/tools/javac/NoStringToLower.java and 
>   - test/langtools/tools/javac/T8003967/DetectMutableStaticFields.java
> - Weird annotation processor behavior in test/langtools/tools/javac/annotations/parameter/ParameterAnnotations.java
> 
>   - Without preview and using explicit file name, the javac task fails; using the builder live AP object works both with and without preview.
> 
> Testing: tier 1-5.  Please inform me if any of these tests belong to higher tiers.

I think the simple removal of `@enablePreview` already require multiple areas of engineers, so to involve a bit more changes to fix them throughoutly is fine; these are all test-only, so we can wait and this can go in after RDP1 began.

-------------

PR Comment: https://git.openjdk.org/jdk/pull/22420#issuecomment-2505451198

From duke at openjdk.org  Thu Nov 28 19:33:48 2024
From: duke at openjdk.org (duke)
Date: Thu, 28 Nov 2024 19:33:48 GMT
Subject: <i18n dev> Withdrawn: 8337279: Optimize format instant
In-Reply-To: <17bf2n2yLh8dwpk9nsTF9G9UKHYWLDXDh0kie-9YrcA=.f19351bb-d47f-4ded-8a63-07914de70b4f@github.com>
References: <17bf2n2yLh8dwpk9nsTF9G9UKHYWLDXDh0kie-9YrcA=.f19351bb-d47f-4ded-8a63-07914de70b4f@github.com>
Message-ID: <DSP7qTWcI0XpL5RWtpmdloO_x7G_8Uih9hFjhNgdI-A=.40f331cd-8ff3-40ec-8621-ff8546d35bd4@github.com>

On Fri, 26 Jul 2024 14:20:07 GMT, Shaojin Wen <swen at openjdk.org> wrote:

> By removing the redundant code logic in DateTimeFormatterBuilder$InstantPrinterParser#formatTo, the codeSize can be reduced and the performance can be improved.

This pull request has been closed without being integrated.

-------------

PR: https://git.openjdk.org/jdk/pull/20353

From azvegint at openjdk.org  Fri Nov 29 01:48:52 2024
From: azvegint at openjdk.org (Alexander Zvegintsev)
Date: Fri, 29 Nov 2024 01:48:52 GMT
Subject: <i18n dev> RFR: 8345143: Remove uses of SecurityManager in the
 java.desktop module
In-Reply-To: <mvc_W5nIwFPJuSCgaQolwQR2YeOEhjdKp8qeE4h8M_w=.9d1c7822-efc8-4e46-8e3c-205cb1665f37@github.com>
References: <mvc_W5nIwFPJuSCgaQolwQR2YeOEhjdKp8qeE4h8M_w=.9d1c7822-efc8-4e46-8e3c-205cb1665f37@github.com>
Message-ID: <H_UeyNzYYRcajebTTNQr42Ijpj0B5gK9RM9GS_WVI1E=.3d00aa9b-99e6-4941-99f9-f44a78c05aa5@github.com>

On Thu, 28 Nov 2024 00:36:35 GMT, Phil Race <prr at openjdk.org> wrote:

> Remove SecurityManager related code in the desktop module that is not covered by other PRs

--- a/test/jdk/lib/client/ExtendedRobot.java
+++ b/test/jdk/lib/client/ExtendedRobot.java
@@ -57,11 +57,6 @@ public class ExtendedRobot extends Robot {
 
     private final int syncDelay = DEFAULT_SYNC_DELAY;
 
-    //TODO: uncomment three lines below after moving functionality to java.awt.Robot
-    //{
-    //    syncDelay = AccessController.doPrivileged(new GetIntegerAction("java.awt.robotdelay", DEFAULT_SYNC_DELAY));
-    //}
-
     /**
      * Constructs an ExtendedRobot object in the coordinate system of the primary screen.
      *

src/java.desktop/macosx/classes/com/apple/eio/FileManager.java line 144:

> 142:     public static void setFileType(String filename, int type) throws IOException {
> 143:         _setFileType(filename, type);
> 144:         }

indentation over the entire file is very unstable.

src/java.desktop/share/classes/java/awt/Font.java line 896:

> 894:      * font bytes.
> 895:      */
> 896:     private static boolean hasTempPermission() {

It looks like the `createFont(int fontFormat, InputStream fontStream)` and `createFonts(InputStream fonts)` now have a bit of dead code that can probably be removed(along with this method).


Like


public static Font[] createFonts(InputStream fontStream)
        throws FontFormatException, IOException {

    final int fontFormat = Font.TRUETYPE_FONT;
    return createFont0(fontFormat, fontStream, true, null);
}

src/java.desktop/share/classes/java/awt/Window.java line 2188:

> 2186:             Window window = ref.get();
> 2187:             if (window != null) {
> 2188:                 window.setAlwaysOnTop(alwaysOnTop);

Line 3026, comment can be removed:


if(aot) {
    setAlwaysOnTop(aot); // since 1.5; subject to permission check
}

src/java.desktop/share/classes/javax/swing/JTable.java line 5587:

> 5585:                     type = String.class;
> 5586:                 }
> 5587:                 SwingUtilities2.checkAccess(type.getModifiers());

--- a/src/java.desktop/share/classes/javax/swing/JTable.java
+++ b/src/java.desktop/share/classes/javax/swing/JTable.java
@@ -6364,9 +6364,6 @@ public boolean print(PrintMode printMode,
             }
         }
 
-        // Get a PrinterJob.
-        // Do this before anything with side-effects since it may throw a
-        // security exception - in which case we don't want to do anything else.
         final PrinterJob job = PrinterJob.getPrinterJob();
 
         if (isEditing()) {

src/java.desktop/share/classes/javax/swing/Popup.java line 247:

> 245:             // Try to set "always-on-top" for the popup window.
> 246:             // Applets usually don't have sufficient permissions to do it.
> 247:             // In this case simply ignore the exception.

Suggestion:

src/java.desktop/share/classes/javax/swing/TimerQueue.java line 181:

> 179:                     // Allow run other threads on systems without kernel threads
> 180:                     timer.getLock().newCondition().awaitNanos(1);
> 181:                     timer.getLock().unlock();

It might be a good idea to keep the unlock in the finally block, even if there is no obvious candidate to throw an exception.


https://docs.oracle.com/en/java/javase/23/docs/api/java.base/java/util/concurrent/locks/Lock.html

> With this increased flexibility comes additional responsibility. The absence of block-structured locking removes the automatic release of locks that occurs with synchronized methods and statements. In most cases, the following idiom should be used:
>
>  <pre>
>  Lock l = ...;
>  l.lock();
>  try {
>    // access the resource protected by this lock
>  } finally {
>    l.unlock();
>  }
> </pre>

src/java.desktop/share/classes/javax/swing/plaf/basic/BasicComboBoxRenderer.java line 71:

> 69:     }
> 70: 
> 71:     @SuppressWarnings("removal")

Suggestion:

src/java.desktop/share/classes/javax/swing/plaf/basic/BasicComboBoxRenderer.java line 74:

> 72:     private static Border getNoFocusBorder() {
> 73:         if (System.getSecurityManager() != null) {
> 74:             return SAFE_NO_FOCUS_BORDER;

`SAFE_NO_FOCUS_BORDER` can be removed in 3 files: 


./src/java.desktop/share/classes/javax/swing/DefaultListCellRenderer.java:85:    private static final Border SAFE_NO_FOCUS_BORDER = new EmptyBorder(1, 1, 1, 1);
./src/java.desktop/share/classes/javax/swing/plaf/basic/BasicComboBoxRenderer.java:60:    private static final Border SAFE_NO_FOCUS_BORDER = new EmptyBorder(1, 1, 1, 1);
./src/java.desktop/share/classes/javax/swing/table/DefaultTableCellRenderer.java:96:    private static final Border SAFE_NO_FOCUS_BORDER = new EmptyBorder(1, 1, 1, 1);

src/java.desktop/share/classes/javax/swing/plaf/basic/BasicLabelUI.java line 474:

> 472:             AppContext appContext = AppContext.getAppContext();
> 473:             BasicLabelUI safeBasicLabelUI =
> 474:                     (BasicLabelUI) appContext.get(BASIC_LABEL_UI_KEY);

Declaration of the `BASIC_LABEL_UI_KEY` can be  removed

src/java.desktop/share/classes/javax/swing/plaf/metal/MetalLabelUI.java line 75:

> 73:             AppContext appContext = AppContext.getAppContext();
> 74:             MetalLabelUI safeMetalLabelUI =
> 75:                     (MetalLabelUI) appContext.get(METAL_LABEL_UI_KEY);

`METAL_LABEL_UI_KEY` is not used anymore

src/java.desktop/share/classes/javax/swing/plaf/metal/MetalSliderUI.java line 136:

> 134:     private static Icon getHorizThumbIcon() {
> 135:         if (System.getSecurityManager() != null) {
> 136:             return SAFE_HORIZ_THUMB_ICON;

`SAFE_HORIZ_THUMB_ICON` and `SAFE_VERT_THUMB_ICON` is no longer used

src/java.desktop/share/classes/sun/awt/OSInfo.java line 104:

> 102:     }
> 103: 
> 104:     public static WindowsVersion getWindowsVersion() {

--- a/src/java.desktop/share/classes/sun/awt/OSInfo.java
+++ b/src/java.desktop/share/classes/sun/awt/OSInfo.java
@@ -64,7 +64,7 @@ and so the method getWindowsVersion() will return the constant for known OS.
     private static final Map<String, WindowsVersion> windowsVersionMap = new HashMap<String, OSInfo.WindowsVersion>();
 
     // Cache the OSType for getOSType()
-    private static final OSType CURRENT_OSTYPE = getOSTypeImpl();  // No DoPriv needed
+    private static final OSType CURRENT_OSTYPE = getOSTypeImpl();
 
 
     static {

-------------

PR Review: https://git.openjdk.org/jdk/pull/22424#pullrequestreview-2468791195
PR Review Comment: https://git.openjdk.org/jdk/pull/22424#discussion_r1862664776
PR Review Comment: https://git.openjdk.org/jdk/pull/22424#discussion_r1862687940
PR Review Comment: https://git.openjdk.org/jdk/pull/22424#discussion_r1862691626
PR Review Comment: https://git.openjdk.org/jdk/pull/22424#discussion_r1862811167
PR Review Comment: https://git.openjdk.org/jdk/pull/22424#discussion_r1862801871
PR Review Comment: https://git.openjdk.org/jdk/pull/22424#discussion_r1862817529
PR Review Comment: https://git.openjdk.org/jdk/pull/22424#discussion_r1862695795
PR Review Comment: https://git.openjdk.org/jdk/pull/22424#discussion_r1862772241
PR Review Comment: https://git.openjdk.org/jdk/pull/22424#discussion_r1862774213
PR Review Comment: https://git.openjdk.org/jdk/pull/22424#discussion_r1862795969
PR Review Comment: https://git.openjdk.org/jdk/pull/22424#discussion_r1862770911
PR Review Comment: https://git.openjdk.org/jdk/pull/22424#discussion_r1862806386

From prr at openjdk.org  Sat Nov 30 03:57:33 2024
From: prr at openjdk.org (Phil Race)
Date: Sat, 30 Nov 2024 03:57:33 GMT
Subject: <i18n dev> RFR: 8345143: Remove uses of SecurityManager in the
 java.desktop module [v2]
In-Reply-To: <mvc_W5nIwFPJuSCgaQolwQR2YeOEhjdKp8qeE4h8M_w=.9d1c7822-efc8-4e46-8e3c-205cb1665f37@github.com>
References: <mvc_W5nIwFPJuSCgaQolwQR2YeOEhjdKp8qeE4h8M_w=.9d1c7822-efc8-4e46-8e3c-205cb1665f37@github.com>
Message-ID: <ktf2hJlS6IVyhTfyodmvIPs_mdt_TQl_zoBOzJef0oc=.0a793e31-8144-4a22-be73-2db6987b6bcf@github.com>

> Remove SecurityManager related code in the desktop module that is not covered by other PRs

Phil Race has updated the pull request incrementally with one additional commit since the last revision:

  8345143

-------------

Changes:
  - all: https://git.openjdk.org/jdk/pull/22424/files
  - new: https://git.openjdk.org/jdk/pull/22424/files/99be51dc..a02cecb4

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jdk&pr=22424&range=01
 - incr: https://webrevs.openjdk.org/?repo=jdk&pr=22424&range=00-01

  Stats: 50 lines in 11 files changed: 7 ins; 24 del; 19 mod
  Patch: https://git.openjdk.org/jdk/pull/22424.diff
  Fetch: git fetch https://git.openjdk.org/jdk.git pull/22424/head:pull/22424

PR: https://git.openjdk.org/jdk/pull/22424

From prr at openjdk.org  Sat Nov 30 04:40:44 2024
From: prr at openjdk.org (Phil Race)
Date: Sat, 30 Nov 2024 04:40:44 GMT
Subject: <i18n dev> RFR: 8345143: Remove uses of SecurityManager in the
 java.desktop module [v2]
In-Reply-To: <H_UeyNzYYRcajebTTNQr42Ijpj0B5gK9RM9GS_WVI1E=.3d00aa9b-99e6-4941-99f9-f44a78c05aa5@github.com>
References: <mvc_W5nIwFPJuSCgaQolwQR2YeOEhjdKp8qeE4h8M_w=.9d1c7822-efc8-4e46-8e3c-205cb1665f37@github.com>
 <H_UeyNzYYRcajebTTNQr42Ijpj0B5gK9RM9GS_WVI1E=.3d00aa9b-99e6-4941-99f9-f44a78c05aa5@github.com>
Message-ID: <gP2dzB1u_DSWBw0y8mQG_FZReYu_AHufSUSrgSBxbd4=.7a4b0b0e-a8e4-489a-a6b5-42e2f014a1fe@github.com>

On Thu, 28 Nov 2024 20:30:11 GMT, Alexander Zvegintsev <azvegint at openjdk.org> wrote:

>> Phil Race has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   8345143
>
> src/java.desktop/macosx/classes/com/apple/eio/FileManager.java line 144:
> 
>> 142:     public static void setFileType(String filename, int type) throws IOException {
>> 143:         _setFileType(filename, type);
>> 144:         }
> 
> indentation over the entire file is very unstable.

Noted : out of scope. If you think it important I can file a follow-bug for some one to address.

> src/java.desktop/share/classes/java/awt/Font.java line 896:
> 
>> 894:      * font bytes.
>> 895:      */
>> 896:     private static boolean hasTempPermission() {
> 
> It looks like the `createFont(int fontFormat, InputStream fontStream)` and `createFonts(InputStream fonts)` now have a bit of dead code that can probably be removed(along with this method).
> 
> 
> Like
> 
> 
> public static Font[] createFonts(InputStream fontStream)
>         throws FontFormatException, IOException {
> 
>     final int fontFormat = Font.TRUETYPE_FONT;
>     return createFont0(fontFormat, fontStream, true, null);
> }

Yes, I have a separate bug to clean up all of this https://bugs.openjdk.org/browse/JDK-8344146

> src/java.desktop/share/classes/java/awt/Window.java line 2188:
> 
>> 2186:             Window window = ref.get();
>> 2187:             if (window != null) {
>> 2188:                 window.setAlwaysOnTop(alwaysOnTop);
> 
> Line 3026, comment can be removed:
> 
> 
> if(aot) {
>     setAlwaysOnTop(aot); // since 1.5; subject to permission check
> }

so remove comment ..

> src/java.desktop/share/classes/javax/swing/JTable.java line 5587:
> 
>> 5585:                     type = String.class;
>> 5586:                 }
>> 5587:                 SwingUtilities2.checkAccess(type.getModifiers());
> 
> --- a/src/java.desktop/share/classes/javax/swing/JTable.java
> +++ b/src/java.desktop/share/classes/javax/swing/JTable.java
> @@ -6364,9 +6364,6 @@ public boolean print(PrintMode printMode,
>              }
>          }
>  
> -        // Get a PrinterJob.
> -        // Do this before anything with side-effects since it may throw a
> -        // security exception - in which case we don't want to do anything else.
>          final PrinterJob job = PrinterJob.getPrinterJob();
>  
>          if (isEditing()) {

removing comment

> src/java.desktop/share/classes/javax/swing/TimerQueue.java line 181:
> 
>> 179:                     // Allow run other threads on systems without kernel threads
>> 180:                     timer.getLock().newCondition().awaitNanos(1);
>> 181:                     timer.getLock().unlock();
> 
> It might be a good idea to keep the unlock in the finally block, even if there is no obvious candidate to throw an exception.
> 
> 
> https://docs.oracle.com/en/java/javase/23/docs/api/java.base/java/util/concurrent/locks/Lock.html
> 
>> With this increased flexibility comes additional responsibility. The absence of block-structured locking removes the automatic release of locks that occurs with synchronized methods and statements. In most cases, the following idiom should be used:
>>
>>  <pre>
>>  Lock l = ...;
>>  l.lock();
>>  try {
>>    // access the resource protected by this lock
>>  } finally {
>>    l.unlock();
>>  }
>> </pre>

ok

> src/java.desktop/share/classes/javax/swing/plaf/basic/BasicComboBoxRenderer.java line 71:
> 
>> 69:     }
>> 70: 
>> 71:     @SuppressWarnings("removal")
> 
> Suggestion:

ok

> src/java.desktop/share/classes/javax/swing/plaf/basic/BasicComboBoxRenderer.java line 74:
> 
>> 72:     private static Border getNoFocusBorder() {
>> 73:         if (System.getSecurityManager() != null) {
>> 74:             return SAFE_NO_FOCUS_BORDER;
> 
> `SAFE_NO_FOCUS_BORDER` can be removed in 3 files: 
> 
> 
> ./src/java.desktop/share/classes/javax/swing/DefaultListCellRenderer.java:85:    private static final Border SAFE_NO_FOCUS_BORDER = new EmptyBorder(1, 1, 1, 1);
> ./src/java.desktop/share/classes/javax/swing/plaf/basic/BasicComboBoxRenderer.java:60:    private static final Border SAFE_NO_FOCUS_BORDER = new EmptyBorder(1, 1, 1, 1);
> ./src/java.desktop/share/classes/javax/swing/table/DefaultTableCellRenderer.java:96:    private static final Border SAFE_NO_FOCUS_BORDER = new EmptyBorder(1, 1, 1, 1);

ok

> src/java.desktop/share/classes/javax/swing/plaf/basic/BasicLabelUI.java line 474:
> 
>> 472:             AppContext appContext = AppContext.getAppContext();
>> 473:             BasicLabelUI safeBasicLabelUI =
>> 474:                     (BasicLabelUI) appContext.get(BASIC_LABEL_UI_KEY);
> 
> Declaration of the `BASIC_LABEL_UI_KEY` can be  removed

ok

> src/java.desktop/share/classes/javax/swing/plaf/metal/MetalLabelUI.java line 75:
> 
>> 73:             AppContext appContext = AppContext.getAppContext();
>> 74:             MetalLabelUI safeMetalLabelUI =
>> 75:                     (MetalLabelUI) appContext.get(METAL_LABEL_UI_KEY);
> 
> `METAL_LABEL_UI_KEY` is not used anymore

ok

> src/java.desktop/share/classes/javax/swing/plaf/metal/MetalSliderUI.java line 136:
> 
>> 134:     private static Icon getHorizThumbIcon() {
>> 135:         if (System.getSecurityManager() != null) {
>> 136:             return SAFE_HORIZ_THUMB_ICON;
> 
> `SAFE_HORIZ_THUMB_ICON` and `SAFE_VERT_THUMB_ICON` is no longer used

ok

> src/java.desktop/share/classes/sun/awt/OSInfo.java line 104:
> 
>> 102:     }
>> 103: 
>> 104:     public static WindowsVersion getWindowsVersion() {
> 
> --- a/src/java.desktop/share/classes/sun/awt/OSInfo.java
> +++ b/src/java.desktop/share/classes/sun/awt/OSInfo.java
> @@ -64,7 +64,7 @@ and so the method getWindowsVersion() will return the constant for known OS.
>      private static final Map<String, WindowsVersion> windowsVersionMap = new HashMap<String, OSInfo.WindowsVersion>();
>  
>      // Cache the OSType for getOSType()
> -    private static final OSType CURRENT_OSTYPE = getOSTypeImpl();  // No DoPriv needed
> +    private static final OSType CURRENT_OSTYPE = getOSTypeImpl();
>  
>  
>      static {

removing comment

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/22424#discussion_r1864054298
PR Review Comment: https://git.openjdk.org/jdk/pull/22424#discussion_r1864055229
PR Review Comment: https://git.openjdk.org/jdk/pull/22424#discussion_r1864055747
PR Review Comment: https://git.openjdk.org/jdk/pull/22424#discussion_r1864056130
PR Review Comment: https://git.openjdk.org/jdk/pull/22424#discussion_r1864066305
PR Review Comment: https://git.openjdk.org/jdk/pull/22424#discussion_r1864057745
PR Review Comment: https://git.openjdk.org/jdk/pull/22424#discussion_r1864058236
PR Review Comment: https://git.openjdk.org/jdk/pull/22424#discussion_r1864058393
PR Review Comment: https://git.openjdk.org/jdk/pull/22424#discussion_r1864058516
PR Review Comment: https://git.openjdk.org/jdk/pull/22424#discussion_r1864058783
PR Review Comment: https://git.openjdk.org/jdk/pull/22424#discussion_r1864059005