<i18n dev> RFR: 8343777: Add since checker tests to Internationalisation modules [v2]

Naoto Sato naoto at openjdk.org
Thu Nov 14 18:09:43 UTC 2024


On Thu, 14 Nov 2024 01:13:07 GMT, Nizar Benalla <nbenalla at openjdk.org> wrote:

>> Can I please get a review for this PR that add tests to verify the value of `@since` tags to the Internationalisation area modules. The test is described in this [email](https://mail.openjdk.org/pipermail/jdk-dev/2024-October/009474.html). This issue is similar to JDK-8341399, JDK-8331051 and JDK-8343442.
>> 
>> The benefit from this is helping API authors and reviewer validate the accuracy of `@since` in their source code (and subsequently, in the generated documentation). And lessen the burden on Reviewers.
>> 
>> The test has been added for `java.base` and a few other modules and has helped catch some bugs before they make it to the JDK.
>> 
>> TIA
>
> Nizar Benalla has updated the pull request incrementally with one additional commit since the last revision:
> 
>   add explanation to test summary, add backsticks when mentionning `@since`

LGTM. Thank you for making the comments.

-------------

Marked as reviewed by naoto (Reviewer).

PR Review: https://git.openjdk.org/jdk/pull/21985#pullrequestreview-2436848962


More information about the i18n-dev mailing list