<i18n dev> RFR: 8341923: java.util.Locale class specification improvements [v2]

Justin Lu jlu at openjdk.org
Wed Nov 20 03:03:24 UTC 2024


On Tue, 19 Nov 2024 19:46:42 GMT, Naoto Sato <naoto at openjdk.org> wrote:

>> Justin Lu has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   address Chen's review; make other similar changes
>
> src/java.base/share/classes/java/util/Locale.java line 89:
> 
>> 87:  * exchange. Each {@code Locale} is associated with locale data which is retrieved
>> 88:  * by the installed {@link java.util.spi.LocaleServiceProvider LocaleServiceProvider}
>> 89:  * implementations. Depending on the implementation, such data may vary by release.
> 
> This reads like locale data are only obtained with the SPI implementations that are provided by the users. The locale data also (and mainly) come from within Java runtime itself. (BTW, "installed" should be removed, as it is no longer correct. Same applies to getAvailableLocales()/availableLocales() methods)

Thanks for the review Naoto. 

My angle was that the `"installed LocaleServiceProvider implementations"` implicitly included the Java runtime data as the default provider. The new wording is more explicit, please let me know what you think.

Also, "installed" is now replaced with "deployed" which is consistent with `ServiceLoader`. The rest of your suggestions should be fixed in https://github.com/openjdk/jdk/pull/22192/commits/c8dd75cc738316e34d203cde8a867a77efbca63e (minus the one I left a comment on).

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/22192#discussion_r1849432962


More information about the i18n-dev mailing list