<i18n dev> RFR: 8342903: Deprecate for removal java.awt.Window.getWarningString() [v4]

[Alexander Zvegintsev]

On Thu, 21 Nov 2024 17:50:36 GMT, Phil Race <prr at openjdk.org> wrote:

>> This fix deprecates for removal java.awt.Window.getWarningString() and also javax.swing.JInternalFrame.getWarningString()
>> l java.awt.Window.getWarningString() is only relevant with a SecurityManager and javax.swing.JInternalFrame.getWarningString() is just there for symmetry.
>> 
>> A few other spec changes ensue - the serial form variable warningString is removed is the main one.
>> The AWTPermission showWindowWithoutWarningBanner is obsolete
>> Reference to the system property  "awt.appletWarning" was actually already removed by JEP 486
>> 
>> There is a CSR for the spec. changes, which will need a reviewer : https://bugs.openjdk.org/browse/JDK-8344451
>> 
>> But the vast majority of the changes here are all the downstream obsoleted implementation
>> The warning string and warning icon, and warning windows are all obsoleted.
>> I think I tracked down all of it, but it is hard to be sure.
>> Automated tests are passing, and I've manually tested SwingSet2 on all 3 platforms.
>
> Phil Race has updated the pull request incrementally with one additional commit since the last revision:
> 
>   8342903

There are a few minor mentions of the Warning Window left


./src/java.desktop/unix/classes/sun/awt/X11/XWindow.java:1492:     * XWarningWindow, both of which have the XWindow as a common ancestor.
./test/jdk/ProblemList.txt:468:java/awt/security/WarningWindowDisposeTest/WarningWindowDisposeTest.java 8266059 macosx-all

the test in problem list does not exist

src/java.desktop/windows/native/libawt/windows/awt_Window.cpp line 450:

> 448: }
> 449: 
> 450: void AwtWindow::FocusedWindowChanged(HWND from, HWND to)

It looks like this empty method and its usage can also be removed:


./src/java.desktop/windows/native/libawt/windows/awt_Component.cpp:6426:    AwtWindow::FocusedWindowChanged(old, window);

-------------

Marked as reviewed by azvegint (Reviewer).

PR Review: https://git.openjdk.org/jdk/pull/22221#pullrequestreview-2452443843
PR Review Comment: https://git.openjdk.org/jdk/pull/22221#discussion_r1852732769