<i18n dev> RFR: 8195686: ISO-8859-8-i charset cannot be decoded, should be mapped to ISO-8859-8

Steven Loomis srl at openjdk.org
Thu Oct 10 19:54:14 UTC 2024


On Fri, 23 Aug 2024 10:38:38 GMT, Pratiksha.Sawant <duke at openjdk.org> wrote:

> Mapping ISO-8859-8-I charset to ISO-8859-8.
> Below mentioned 2 aliases are added as part of this:-
> **ISO-8859-8-I**
> **ISO8859-8-I**
> 
> The bug report for the same:- https://bugs.openjdk.org/browse/JDK-8195686

Fair enough and feel free to reject my review if need be. 

It seems like from an API perspective, you are both saying it should be a new Charset provider (though with identical behavior) but separate and not an alias. That preserves the invariant about IANA registration.

It does still seem that the JDK is probably currently treating ISO-8859-8 as if it were ISO-8859-8-I.  I wonder why the implementation was done the way it is, but that’s only of historical interest.

-------------

PR Comment: https://git.openjdk.org/jdk/pull/20690#issuecomment-2405915757


More information about the i18n-dev mailing list