<i18n dev> RFR: 8341445: DecimalFormatSymbols setters should throw NPE [v5]
Justin Lu
jlu at openjdk.org
Sun Oct 13 03:52:01 UTC 2024
> Please review this PR which improves the safety of equality checking for DecimalFormatSymbols. As certain setters did not throw NPE, this allowed for NPE in the equality method. This PR now updates the setters to throw NPE.
>
> In addition to the NPEs, there is also a behavioral change that `setInternationalCurrencySymbol` no longer sets currency to null if the `currencyCode` is invalid. Instead, it simply does not update `currency`. This must be done, because we do not want to allow nullable instance variables post `initalizeCurrency`.
Justin Lu has updated the pull request incrementally with one additional commit since the last revision:
reflect further review
-------------
Changes:
- all: https://git.openjdk.org/jdk/pull/21315/files
- new: https://git.openjdk.org/jdk/pull/21315/files/d0686b35..d31cb2eb
Webrevs:
- full: https://webrevs.openjdk.org/?repo=jdk&pr=21315&range=04
- incr: https://webrevs.openjdk.org/?repo=jdk&pr=21315&range=03-04
Stats: 25 lines in 2 files changed: 21 ins; 0 del; 4 mod
Patch: https://git.openjdk.org/jdk/pull/21315.diff
Fetch: git fetch https://git.openjdk.org/jdk.git pull/21315/head:pull/21315
PR: https://git.openjdk.org/jdk/pull/21315
More information about the i18n-dev
mailing list