<i18n dev> RFR: 8335271: Specify the MessageFormat ArgumentIndex Implementation Limit [v2]

Naoto Sato naoto at openjdk.org
Thu Oct 17 19:49:48 UTC 2024


On Thu, 17 Oct 2024 16:12:45 GMT, Justin Lu <jlu at openjdk.org> wrote:

>> Please review this PR which specifies the _j.text.MessageFormat_ ArgumentIndex limit. A corresponding CSR is drafted.
>> 
>> Both the existence of the limit (and behavior if violated), as well as this implementation's limit are added to the class description. See the JBS issue comments for further history.
>
> Justin Lu has updated the pull request incrementally with one additional commit since the last revision:
> 
>   review: implSpec -> implNote

LGTM, with a minor nit

src/java.base/share/classes/java/text/MessageFormat.java line 113:

> 111:  *
> 112:  * <p>
> 113:  * The <b>ArgumentIndex</b> value is a non-negative integer written

If we would deviate from the format in the above form, I'd use @code tag, instead of explicit <b>.

-------------

PR Review: https://git.openjdk.org/jdk/pull/21554#pullrequestreview-2376134108
PR Review Comment: https://git.openjdk.org/jdk/pull/21554#discussion_r1805329693


More information about the i18n-dev mailing list