<i18n dev> RFR: 8342582: user.region for formatting number no longer works for 21.0.5 [v2]

Naoto Sato naoto at openjdk.org
Tue Oct 22 22:12:12 UTC 2024


On Tue, 22 Oct 2024 21:28:27 GMT, Roger Riggs <rriggs at openjdk.org> wrote:

>> Naoto Sato has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Reflects review comments
>
> src/java.base/share/classes/jdk/internal/util/StaticProperty.java line 104:
> 
>> 102:         USER_REGION = getProperty(props, "user.region", "");
>> 103:         if (!USER_REGION.isEmpty()) {
>> 104:             // region can be of form country, country_variant, or _variant
> 
> typo "of form"? "region can be from"...

I am not the author of this comment, but I think they meant it, like "one of forms".

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/21645#discussion_r1811500994


More information about the i18n-dev mailing list