<i18n dev> RFR: 8342868: Errors related to unused code on Windows after 8339120 in core libs

Julian Waters jwaters at openjdk.org
Wed Oct 23 04:45:42 UTC 2024


After 8339120, gcc began catching many different instances of unused code in the Windows specific codebase. Some of these seem to be bugs. I've taken the effort to mark out all the relevant globals and locals that trigger the unused warnings and addressed all of them by commenting out the code as appropriate. I am confident that in many cases this simplistic approach of commenting out code does not fix the underlying issue, and the warning actually found a bug that should be fixed. In these instances, I will be aiming to fix these bugs with help from reviewers, so I recommend anyone reviewing who knows more about the code than I do to see whether there is indeed a bug that needs fixing in a different way than what I did

-------------

Commit messages:
 - 8342868

Changes: https://git.openjdk.org/jdk/pull/21654/files
  Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=21654&range=00
  Issue: https://bugs.openjdk.org/browse/JDK-8342868
  Stats: 11 lines in 4 files changed: 6 ins; 0 del; 5 mod
  Patch: https://git.openjdk.org/jdk/pull/21654.diff
  Fetch: git fetch https://git.openjdk.org/jdk.git pull/21654/head:pull/21654

PR: https://git.openjdk.org/jdk/pull/21654


More information about the i18n-dev mailing list