<i18n dev> RFR: 8340554: Improve MessageFormat readObject checks [v2]
Naoto Sato
naoto at openjdk.org
Wed Oct 23 21:40:06 UTC 2024
On Fri, 18 Oct 2024 19:39:52 GMT, Justin Lu <jlu at openjdk.org> wrote:
>> Please review this PR which improves the readObject logic for _j.text.MessageFormat_.
>>
>> No offset should be larger than the pattern length. We already ensure the offsets when consumed backwards are equal/descending. The existing first/initial check was off by 1 since it was checking against the pattern length + 1; (see L2040 and L2043).
>>
>> Please see the JBS issue for further info and other test details.
>
> Justin Lu has updated the pull request incrementally with one additional commit since the last revision:
>
> review: clarify test comments
Marked as reviewed by naoto (Reviewer).
-------------
PR Review: https://git.openjdk.org/jdk/pull/21570#pullrequestreview-2390700285
More information about the i18n-dev
mailing list