<i18n dev> RFR: 8342682: Errors related to unused code on Windows after 8339120 in dt_shmem jdwp security and jpackage

[Julian Waters]

On Wed, 23 Oct 2024 16:51:23 GMT, Chris Plummer <cjplummer at openjdk.org> wrote:

>> I wasn't sure whether the global memHandle not being used was a bug, so I commented out the local one. I missed the line 88 one because it wasn't flagged. If it really isn't needed I'll remove that one instead
>
> I'm not sure what you mean by "that one". It's the static one that should be removed. The local variables always hide the static, and there seems to be no reason for the value of memHandle to survive outside of the local scope it is used in.

Oh, I was referring to the static global one. In that case I'll remove it (Or rather, comment it so it isn't lost to time and someone can bring it back if need be)

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/21616#discussion_r1814187989