<i18n dev> Integrated: 8340554: Improve MessageFormat readObject checks

Justin Lu jlu at openjdk.org
Thu Oct 24 16:20:15 UTC 2024


On Thu, 17 Oct 2024 20:14:05 GMT, Justin Lu <jlu at openjdk.org> wrote:

> Please review this PR which improves the readObject logic for _j.text.MessageFormat_.
> 
> No offset should be larger than the pattern length. We already ensure the offsets when consumed backwards are equal/descending. The existing first/initial check was off by 1 since it was checking against the pattern length + 1; (see L2040 and L2043).
> 
> Please see the JBS issue for further info and other test details.

This pull request has now been integrated.

Changeset: 7af46a6b
Author:    Justin Lu <jlu at openjdk.org>
URL:       https://git.openjdk.org/jdk/commit/7af46a6b424cadfe298958d774da0f21db58ecd3
Stats:     9 lines in 2 files changed: 6 ins; 0 del; 3 mod

8340554: Improve MessageFormat readObject checks

Reviewed-by: naoto

-------------

PR: https://git.openjdk.org/jdk/pull/21570


More information about the i18n-dev mailing list