<i18n dev> RFR: 8340326: Remove references to Applet in core-libs/security tests [v4]

Naoto Sato naoto at openjdk.org
Thu Sep 26 16:28:36 UTC 2024


On Wed, 25 Sep 2024 23:32:08 GMT, Justin Lu <jlu at openjdk.org> wrote:

>> Please review this PR which removes usages of Applet within the corelibs tests.
>> 
>> Most changes are removed comments/updated var names. The JBS issue lists more files than the ones included in this pull request, please see the comment on the JBS issue for the reason why they were not included.
>> 
>> The following files were removed,
>> 
>> - test/jdk/java/util/TimeZone/DefaultTimeZoneTest.html
>>   - Test runner is no longer an Applet, so not needed
>> - test/jdk/sun/net/www/ParseUtil_6380332.java
>>   - Outdated test that checks a SunTea applet
>> - test/jdk/java/net/Socket/SocketImplTest.java
>>   - An old Applet test missing Jtreg tags.
>
> Justin Lu has updated the pull request incrementally with one additional commit since the last revision:
> 
>   review: update wording of instructions

LGTM

test/jdk/java/util/TimeZone/DefaultTimeZoneTest.java line 80:

> 78:               6. Turn on "Adjust for daylight saving time automatically"
> 79: 
> 80:             If the local time in the control panel and test window are always the same,

nit: "control panel" -> "Settings app"

-------------

PR Review: https://git.openjdk.org/jdk/pull/21096#pullrequestreview-2331813551
PR Review Comment: https://git.openjdk.org/jdk/pull/21096#discussion_r1777409415


More information about the i18n-dev mailing list