<i18n dev> RFR: 8301971: Make JDK source code UTF-8 [v3]
Magnus Ihse Bursie
ihse at openjdk.org
Wed Apr 16 13:44:52 UTC 2025
On Wed, 16 Apr 2025 10:35:02 GMT, Matthias Baesken <mbaesken at openjdk.org> wrote:
>> Magnus Ihse Bursie has updated the pull request incrementally with three additional commits since the last revision:
>>
>> - Also document UTF-8 requirements (solves JDK-8338973)
>> - Let configure only accept utf-8 locales
>> - Address review comments from Kim
>
> make/autoconf/basic.m4 line 155:
>
>> 153: else
>> 154: AC_MSG_RESULT([no UTF-8 locale found])
>> 155: AC_MSG_ERROR([No UTF-8 locale found. This is required for building successfully.])
>
> Seems we run into this 'else' part on AIX
>
>
> checking for locale to use... no UTF-8 locale found
> configure: error: No UTF-8 locale found. This is required for building successfully.
> configure exiting with result code 1
>
> maybe it would be nice to display the desired ones C.UTF-8 or en_US.UTF-8 in this message too for more clarity? (have to check if there are other names on AIX)
If you have a locale named `<something>.UTF-8` as your active locale, that will also be accepted, so it is not limited to C and en_US. But it might be an idea to include it in the error message, yes.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/24574#discussion_r2046971091
More information about the i18n-dev
mailing list