<i18n dev> RFR: 8354344: Test behavior after cut-over for future ISO 4217 currency [v4]

Naoto Sato naoto at openjdk.org
Fri Apr 18 17:14:52 UTC 2025


On Thu, 17 Apr 2025 23:06:04 GMT, Justin Lu <jlu at openjdk.org> wrote:

>> Please review this PR which improves the _ValidateISO4217_ Currency test by adding testing of future currencies after the transition date.
>> 
>> This is done by creating a patched version of Currency that replaces `System.currentTimeMillis()` calls with a mocked value equivalent to `Long.MAX_VALUE`. A module patch is then applied to supply the new Currency class files.
>> 
>> The mocked time behavior is tested by using the `currency.properties` override in a separate invocation.
>
> Justin Lu has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Naoto review - check instruction owner. check module patch files exist

LGTM. Thanks for providing the test!

-------------

Marked as reviewed by naoto (Reviewer).

PR Review: https://git.openjdk.org/jdk/pull/24701#pullrequestreview-2779037686


More information about the i18n-dev mailing list