<i18n dev> RFR: 8364365: HKSCS encoder does not properly set the replacement character [v3]

Volkan Yazici vyazici at openjdk.org
Fri Aug 8 11:45:05 UTC 2025


On Thu, 7 Aug 2025 19:17:03 GMT, Xueming Shen <sherman at openjdk.org> wrote:

>> Volkan Yazici has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Improve pretty-printers
>
> test/jdk/sun/nio/cs/TestEncoderReplaceLatin1.java line 251:
> 
>> 249:             sb.append("%sU+%04X".formatted(i > 0 ? ", " : "", (int) c));
>> 250:         }
>> 251:         return sb.append(']').toString();
> 
> just for fun :-)
> 
> return IntStream.range(0, cs.length)
>                             .mapToObj(i -> String.format("U+%04X", (int) cs[i]))
>                             .collect(Collectors.joining(", ", "[", "]"));

Applied suggestion to both `prettyPrint{Bytes,Chars}` in f056028a.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/26635#discussion_r2262713842


More information about the i18n-dev mailing list