<i18n dev> RFR: 8364365: HKSCS encoder does not properly set the replacement character [v3]

[Xueming Shen]

On Fri, 8 Aug 2025 11:45:04 GMT, Volkan Yazici <vyazici at openjdk.org> wrote:

>> Fix `HKSCS` encoder to correctly set the replacement character, and add tests to verify the `CodingErrorAction.REPLACE` behavior of all available encoders.
>
> Volkan Yazici has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Improve pretty-printers

LGTM

test/jdk/sun/nio/cs/TestEncoderReplaceLatin1.java line 132:

> 130:             replacement1[0] = (byte) i;
> 131:             // Skip the default value, since we're verifying if a custom one works
> 132:             if (replacement1[0] == replacementD[0]) {

nit-pick?
if (replacementD.length == 1 && replacement1[0] == replacementD[0]) { ...}

-------------

PR Review: https://git.openjdk.org/jdk/pull/26635#pullrequestreview-3101869911
PR Review Comment: https://git.openjdk.org/jdk/pull/26635#discussion_r2263778167