<i18n dev> RFR: 8366401: JCK test api/java_text/DecimalFormatSymbols/serial/InputTests.html fails after JDK-8363972
Naoto Sato
naoto at openjdk.org
Fri Aug 29 19:50:41 UTC 2025
On Fri, 29 Aug 2025 18:00:25 GMT, Justin Lu <jlu at openjdk.org> wrote:
> This PR addresses a JCK test failure related to `DecimalFormatSymbols` de-serialization. While the current public API of DFS disallows a null locale, it was possible to set in the past. Thus, the `loadNumberData(locale)` call currently throws NPE when locale is null in the stream. The call should be guarded with a null check, such that if locale is null, then `lenientMinusSigns` defaults to `minusSignText`.
>
> Defaulting the locale field when `null` to Locale.ROOT is also a reasonable solution, but I think that the current one is preferable as a user would not expect locale data related logic to occur if locale is `null`.
Since this is avoiding non-standard situations either solutions should be acceptable.
-------------
Marked as reviewed by naoto (Reviewer).
PR Review: https://git.openjdk.org/jdk/pull/27008#pullrequestreview-3169931280
More information about the i18n-dev
mailing list