<i18n dev> RFR: 8373830: Refactor test/jdk/java/time/test tests to use JUnit over TestNG
Justin Lu
jlu at openjdk.org
Fri Dec 19 00:21:40 UTC 2025
Please review this PR which migrates the java.time tests from TestNG to JUnit. The java.time tests use TestNG based on the directory level settings configured by TEST.properties, so they are best migrated altogether. This is a large PR, so I have tried to make the changes clear by commit.
First, the auto conversion tool is run in https://github.com/openjdk/jdk/commit/b1fd7dbdec85aac5a44cc875e57a36be8f1b6974.
https://github.com/openjdk/jdk/commit/3805cfd8765c0c76b61893dcf1670951402f98c3 and https://github.com/openjdk/jdk/commit/b697ca5d9a8067bcecea2dfb32f92f7699085dee are required so that the tests can actually compile and run.
https://github.com/openjdk/jdk/commit/d07c912c4c16d2b3307e489563f148f71cfdf4a4 addresses the timeout annotation which was not covered by the auto conversion tool.
The rest of the commits are aesthetic related.
Before conversion stats
Test results: passed: 187
Framework-based tests: 32,339 = 32,339 TestNG + 0 JUnit
After conversion stats
Test results: passed: 187
Framework-based tests: 32,339 = 0 TestNG + 32,339 JUnit
-------------
Commit messages:
- Fixing @timeout as well as unrelated stray spacing
- Apply copyright years
- Cleaning up some leftover whitespace from tool
- Automated conversion created statement lambdas for exception tests. Modify to expression lambdas
- Cleaning up unused JUnit imports
- Fix converted lambdas
- Mark TEST.properties as JUnit dirs
- Apply JUnitConvert
Changes: https://git.openjdk.org/jdk/pull/28911/files
Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=28911&range=00
Issue: https://bugs.openjdk.org/browse/JDK-8373830
Stats: 13726 lines in 178 files changed: 2264 ins; 690 del; 10772 mod
Patch: https://git.openjdk.org/jdk/pull/28911.diff
Fetch: git fetch https://git.openjdk.org/jdk.git pull/28911/head:pull/28911
PR: https://git.openjdk.org/jdk/pull/28911
More information about the i18n-dev
mailing list