<i18n dev> RFR: 8349200: [JMH] time.format.ZonedDateTimeFormatterBenchmark fails

Justin Lu jlu at openjdk.org
Mon Feb 3 22:07:09 UTC 2025


On Mon, 3 Feb 2025 07:49:21 GMT, SendaoYan <syan at openjdk.org> wrote:

> Hi all,
> The JMH test "org.openjdk.bench.java.time.format.ZonedDateTimeFormatterBenchmark.parse" fails "java.time.format.DateTimeParseException: Text '2015:03:10:12:13:ECT' could not be parsed at index 17".
> The `ECT` standard for "America/Guayaquil" - "Ecuador Time", and since jdk23 the `ECT` TimeZone.SHORT doesn't support anymore. Below code snippet shows the difference between jdk22 and jdk23:
> 
> 
>         TimeZone tz = TimeZone.getTimeZone("America/Guayaquil");
>         System.out.println(tz.getDisplayName());
>         System.out.println(tz.getDisplayName(true, TimeZone.SHORT));
>         System.out.println(tz.getDisplayName(false, TimeZone.SHORT));
> 
> 
> - Java 22 output:
> 
> 
> ~/software/jdk/temurin/jdk-22.0.2+9/bin/java ~/compiler-test/zzkk/TimeZoneTest.java 
> Ecuador Time
> ECST
> ECT
> 
> 
> - Java 23 output:
> 
> 
> ~/software/jdk/temurin/jdk-23+37/bin/java ~/compiler-test/zzkk/TimeZoneTest.java 
> Ecuador Time
> GMT-04:00
> GMT-05:00
> 
> 
> This PR use `Z` TimeZone.SHORT instead of `ECT` will make this test more generic. Change has been verified locally, test-fix only, no risk.

Switch to universal time for the time-zone to generalize the benchmark looks good to me.

-------------

Marked as reviewed by jlu (Committer).

PR Review: https://git.openjdk.org/jdk/pull/23414#pullrequestreview-2591146673


More information about the i18n-dev mailing list