<i18n dev> RFR: 8350646: Calendar.Builder.build() Throws ArrayIndexOutOfBoundsException [v2]

Justin Lu jlu at openjdk.org
Wed Feb 26 19:48:11 UTC 2025


On Wed, 26 Feb 2025 19:23:06 GMT, Naoto Sato <naoto at openjdk.org> wrote:

>> Justin Lu has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Naoto - correct comment regarding REIWA, add test case for IAE check w/ additional era via sys prop
>
> test/jdk/java/util/Calendar/SupplementalJapaneseEraTest.java line 75:
> 
>> 73:             new Calendar.Builder()
>> 74:                     .setCalendarType("japanese")
>> 75:                     .setFields(ERA, 7)
> 
> Sorry I suggested this immediate value "7", but this can be `JapaneseEra.values().length + 2` which might be more meaningful

Agree that is better; it's pushed.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/23789#discussion_r1972280397


More information about the i18n-dev mailing list