<i18n dev> RFR: 4745837: Make grouping usage during parsing apparent in relevant NumberFormat methods [v2]

Justin Lu jlu at openjdk.org
Thu Feb 27 18:08:35 UTC 2025


> Please review this PR which clarifies some behavior regarding NumberFormat grouping specifically in the grouping related methods.
> 
> Please see the corresponding CSR for further detail. Note that an alternative would be to specify this at the DecimalFormat level, allowing NumberFormat subclasses to define this behavior how they want. IMO, I would expect `setGroupingUsed(boolean)` to affect both; a subclass could define `(is|set)(Parsing|Formatting)GroupingUsed` if need be, thus the proposed solution.

Justin Lu has updated the pull request incrementally with one additional commit since the last revision:

  Naoto review - include strict parsing example. Also remove 'might' wording

-------------

Changes:
  - all: https://git.openjdk.org/jdk/pull/23813/files
  - new: https://git.openjdk.org/jdk/pull/23813/files/4f067f79..8c4ff2eb

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jdk&pr=23813&range=01
 - incr: https://webrevs.openjdk.org/?repo=jdk&pr=23813&range=00-01

  Stats: 12 lines in 1 file changed: 7 ins; 0 del; 5 mod
  Patch: https://git.openjdk.org/jdk/pull/23813.diff
  Fetch: git fetch https://git.openjdk.org/jdk.git pull/23813/head:pull/23813

PR: https://git.openjdk.org/jdk/pull/23813


More information about the i18n-dev mailing list