<i18n dev> RFR: 4745837: Make grouping usage during parsing apparent in relevant NumberFormat methods [v2]

[Justin Lu]

On Thu, 27 Feb 2025 19:39:53 GMT, Naoto Sato <naoto at openjdk.org> wrote:

>> Justin Lu has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Naoto review - include strict parsing example. Also remove 'might' wording
>
> src/java.base/share/classes/java/text/NumberFormat.java line 896:
> 
>> 894:      *   <li> Parsing {@code "1,234,567"} with grouping off and an implementation that
>> 895:      *        implements strict parsing with {@link #isStrict()} returning {@code true}
>> 896:      *        throws {@code ParseException}
> 
> Sorry for the nit, but I think "an implementation that implements strict parsing" can safely be removed without changing the context.

Yeah, it was a little wordy. Was worried users may not be aware that those `set/isStrict` methods need to be implemented, but the link is right there to `isStrict`, which makes it apparent they throw `UOE` by default. Shortened in https://github.com/openjdk/jdk/pull/23813/commits/f36ec09dd73ef2e88a87fa52658eb751072ed758.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/23813#discussion_r1974246647