<i18n dev> RFR: 8345668: ZoneOffset.ofTotalSeconds performance regression [v4]

Naoto Sato naoto at openjdk.org
Thu Jan 2 20:13:47 UTC 2025


On Thu, 2 Jan 2025 19:51:19 GMT, Andrey Turbanov <aturbanov at openjdk.org> wrote:

>> Naoto Sato has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains five additional commits since the last revision:
>> 
>>  - Addresses review comments
>>  - Merge branch 'master' into JDK-8345668-ofTotalSeconds-perf-regression
>>  - Fixed compile error
>>  - Update src/java.base/share/classes/java/time/ZoneOffset.java
>>    
>>    Co-authored-by: Roger Riggs <Roger.Riggs at Oracle.com>
>>  - initial commit
>
> src/java.base/share/classes/java/time/ZoneOffset.java line 2:
> 
>> 1: /*
>> 2:  * Copyright (c) 2012, 2024, Oracle and/or its affiliates. All rights reserved.
> 
> Shouldn't be 2025 too?

This PR was published last year and `ZoneOffset` has not changed since then. So I think 2024 is fine

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/22854#discussion_r1901223750


More information about the i18n-dev mailing list