<i18n dev> RFR: 8347949: Currency method to stream available Currencies [v7]
Chen Liang
liach at openjdk.org
Tue Jan 28 16:09:53 UTC 2025
On Thu, 23 Jan 2025 02:50:46 GMT, Justin Lu <jlu at openjdk.org> wrote:
>> Please review this PR and CSR which adds a method to _java.util.Currency_ which returns a stream of the available Currencies.
>>
>> The motivation can be found in the CSR.
>
> Justin Lu has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains eight additional commits since the last revision:
>
> - make 'available' un-volatile
> - Merge branch 'master' into 8347949-Currency-Stream
> - reflect feedback
> - provide message for test assertion
> - reflect Roger's review
> - init hashset w/ accurate size via HashSet.newHashSet(int)
> - synchronize init method over block
> - init
The PR looks good in the current form. Since I am no professional in locale area, requesting another review from Naoto or Roger.
-------------
Marked as reviewed by liach (Reviewer).
PR Review: https://git.openjdk.org/jdk/pull/23165#pullrequestreview-2578750128
More information about the i18n-dev
mailing list