<i18n dev> RFR: 8349000: Performance improvement for Currency.isPastCutoverDate(String) [v2]
Naoto Sato
naoto at openjdk.org
Fri Jan 31 22:30:45 UTC 2025
On Fri, 31 Jan 2025 19:46:37 GMT, Justin Lu <jlu at openjdk.org> wrote:
>> Please review this PR which improves the performance of cut-over date checking when the user supplies a properties override via the `java.util.currency.data` sys prop. Replacing the `SimpleDateFormat` with a _java.time_ alternative has better performance. It should be noted that this method is only entered when the string `s` is confirmed to adhere to the format: `yyyy-MM-ddTHH:mm:ss`.
>>
>> An alternative is using `LocalDateTime.of(..)` and extracting the date/time values ourselves from `s` with the known positions which is considerably faster but not as concise.
>
> Justin Lu has updated the pull request incrementally with one additional commit since the last revision:
>
> generalize format comment
Marked as reviewed by naoto (Reviewer).
-------------
PR Review: https://git.openjdk.org/jdk/pull/23374#pullrequestreview-2587989821
More information about the i18n-dev
mailing list