From naoto at openjdk.org  Wed Jul  2 16:25:44 2025
From: naoto at openjdk.org (Naoto Sato)
Date: Wed, 2 Jul 2025 16:25:44 GMT
Subject: <i18n dev> Withdrawn: 8360774: Use text representation of
 normalization data files
In-Reply-To: <TOEIN-RxBEAKv4Vleaa0WtyMijKUwSGuF_31bQA-pCo=.88f82538-a7ec-4dc7-b6fe-744906fbc48b@github.com>
References: <TOEIN-RxBEAKv4Vleaa0WtyMijKUwSGuF_31bQA-pCo=.88f82538-a7ec-4dc7-b6fe-744906fbc48b@github.com>
Message-ID: <qwMi_YD5Yow-pNEOATyrNKv_ANutIt16RfCk7_AXN3Q=.2078aed1-5a95-4587-ac45-b221019bd0ea@github.com>

On Fri, 27 Jun 2025 20:45:14 GMT, Naoto Sato <naoto at openjdk.org> wrote:

> The ICU4J component currently stores binary data files directly in the repository. This change replaces them with base64-encoded text files and converts them to binary during the build process

This pull request has been closed without being integrated.

-------------

PR: https://git.openjdk.org/jdk/pull/26027

From naoto at openjdk.org  Mon Jul  7 19:13:15 2025
From: naoto at openjdk.org (Naoto Sato)
Date: Mon, 7 Jul 2025 19:13:15 GMT
Subject: <i18n dev> RFR: 8361519: Obsolete Unicode Scalar Value link in
 Character class
Message-ID: <rwUkW0OqmfUERgNGYbOFQAmQaarEBkP0HuUdFByPq5Y=.79d4b106-123c-4d38-b06e-c2c986a4337d@github.com>

Refining the description of "Unicode Scalar Value" in the `Character` class.
The original description referenced the outdated Unicode 3.1 specification, which previously included the U+xxxx notation but no longer does. Updated the reference to point to the Unicode glossary, which defines the term more accurately. Additionally, replaced the obsolete `@spec` link to Unicode 3.1.0 with a reference to the current Unicode Character Database.

-------------

Commit messages:
 - initial commit

Changes: https://git.openjdk.org/jdk/pull/26169/files
  Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=26169&range=00
  Issue: https://bugs.openjdk.org/browse/JDK-8361519
  Stats: 6 lines in 1 file changed: 0 ins; 2 del; 4 mod
  Patch: https://git.openjdk.org/jdk/pull/26169.diff
  Fetch: git fetch https://git.openjdk.org/jdk.git pull/26169/head:pull/26169

PR: https://git.openjdk.org/jdk/pull/26169

From iris at openjdk.org  Mon Jul  7 19:30:40 2025
From: iris at openjdk.org (Iris Clark)
Date: Mon, 7 Jul 2025 19:30:40 GMT
Subject: <i18n dev> RFR: 8361519: Obsolete Unicode Scalar Value link in
 Character class
In-Reply-To: <rwUkW0OqmfUERgNGYbOFQAmQaarEBkP0HuUdFByPq5Y=.79d4b106-123c-4d38-b06e-c2c986a4337d@github.com>
References: <rwUkW0OqmfUERgNGYbOFQAmQaarEBkP0HuUdFByPq5Y=.79d4b106-123c-4d38-b06e-c2c986a4337d@github.com>
Message-ID: <p9NaoU7fE_8fOhUxVKkv9iQzOer-guAQwLvRm2JFL70=.80f86330-0fd0-49b6-ba1e-36f8b97d0021@github.com>

On Mon, 7 Jul 2025 19:08:22 GMT, Naoto Sato <naoto at openjdk.org> wrote:

> Refining the description of "Unicode Scalar Value" in the `Character` class.
> The original description referenced the outdated Unicode 3.1 specification, which previously included the U+xxxx notation but no longer does. Updated the reference to point to the Unicode glossary, which defines the term more accurately. Additionally, replaced the obsolete `@spec` link to Unicode 3.1.0 with a reference to the current Unicode Character Database.

Looks good.

Since this appears to be the only reference to Unicode 3.1.0 in the repo, this change should drop the line referencing "Unicode 3.1.0" in the list of external specifications, e.g.:

https://download.java.net/java/early_access/jdk26/docs/api/external-specs.html

-------------

Marked as reviewed by iris (Reviewer).

PR Review: https://git.openjdk.org/jdk/pull/26169#pullrequestreview-2995055834

From naoto at openjdk.org  Mon Jul  7 20:24:21 2025
From: naoto at openjdk.org (Naoto Sato)
Date: Mon, 7 Jul 2025 20:24:21 GMT
Subject: <i18n dev> RFR: 8361519: Obsolete Unicode Scalar Value link in
 Character class [v2]
In-Reply-To: <rwUkW0OqmfUERgNGYbOFQAmQaarEBkP0HuUdFByPq5Y=.79d4b106-123c-4d38-b06e-c2c986a4337d@github.com>
References: <rwUkW0OqmfUERgNGYbOFQAmQaarEBkP0HuUdFByPq5Y=.79d4b106-123c-4d38-b06e-c2c986a4337d@github.com>
Message-ID: <VnnQjaCmPw5sLDsF7HHJm4NFNCVJZ9ZytC63qnTp3HE=.6b36cdab-99f0-47cb-ac5d-7f07ba81d8b6@github.com>

> Refining the description of "Unicode Scalar Value" in the `Character` class.
> The original description referenced the outdated Unicode 3.1 specification, which previously included the U+xxxx notation but no longer does. Updated the reference to point to the Unicode glossary, which defines the term more accurately. Additionally, replaced the obsolete `@spec` link to Unicode 3.1.0 with a reference to the current Unicode Character Database.

Naoto Sato has updated the pull request incrementally with one additional commit since the last revision:

  Some more Unicode related spec clean up

-------------

Changes:
  - all: https://git.openjdk.org/jdk/pull/26169/files
  - new: https://git.openjdk.org/jdk/pull/26169/files/44cf51fa..69089cbc

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jdk&pr=26169&range=01
 - incr: https://webrevs.openjdk.org/?repo=jdk&pr=26169&range=00-01

  Stats: 7 lines in 1 file changed: 0 ins; 0 del; 7 mod
  Patch: https://git.openjdk.org/jdk/pull/26169.diff
  Fetch: git fetch https://git.openjdk.org/jdk.git pull/26169/head:pull/26169

PR: https://git.openjdk.org/jdk/pull/26169

From iris at openjdk.org  Mon Jul  7 20:37:38 2025
From: iris at openjdk.org (Iris Clark)
Date: Mon, 7 Jul 2025 20:37:38 GMT
Subject: <i18n dev> RFR: 8361519: Obsolete Unicode Scalar Value link in
 Character class [v2]
In-Reply-To: <VnnQjaCmPw5sLDsF7HHJm4NFNCVJZ9ZytC63qnTp3HE=.6b36cdab-99f0-47cb-ac5d-7f07ba81d8b6@github.com>
References: <rwUkW0OqmfUERgNGYbOFQAmQaarEBkP0HuUdFByPq5Y=.79d4b106-123c-4d38-b06e-c2c986a4337d@github.com>
 <VnnQjaCmPw5sLDsF7HHJm4NFNCVJZ9ZytC63qnTp3HE=.6b36cdab-99f0-47cb-ac5d-7f07ba81d8b6@github.com>
Message-ID: <5C6YrFFpsog2GZHoVNYRi_6J9cHeKSxYaaXKUdX7Pnw=.891f3c24-5ae3-409a-ab06-098500034f1d@github.com>

On Mon, 7 Jul 2025 20:24:21 GMT, Naoto Sato <naoto at openjdk.org> wrote:

>> Refining the description of "Unicode Scalar Value" in the `Character` class.
>> The original description referenced the outdated Unicode 3.1 specification, which previously included the U+xxxx notation but no longer does. Updated the reference to point to the Unicode glossary, which defines the term more accurately. Additionally, replaced the obsolete `@spec` link to Unicode 3.1.0 with a reference to the current Unicode Character Database.
>
> Naoto Sato has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Some more Unicode related spec clean up

Marked as reviewed by iris (Reviewer).

-------------

PR Review: https://git.openjdk.org/jdk/pull/26169#pullrequestreview-2995201943

From jwaters at openjdk.org  Tue Jul  8 01:32:52 2025
From: jwaters at openjdk.org (Julian Waters)
Date: Tue, 8 Jul 2025 01:32:52 GMT
Subject: <i18n dev> RFR: 8342868: Errors related to unused code on
 Windows after 8339120 in core libs [v2]
In-Reply-To: <vT6zJlWPUg235GuAHNJbyAxkoONF2vljAuFTVygBoGk=.05690f62-9641-4990-855a-c908df24e064@github.com>
References: <otTjiRgCFQEeUbpfFTMzhXUVBU1cal8q_i7IrGs_n94=.c2f02ad8-6b0c-4daa-9995-8e4b42131eb4@github.com>
 <vT6zJlWPUg235GuAHNJbyAxkoONF2vljAuFTVygBoGk=.05690f62-9641-4990-855a-c908df24e064@github.com>
Message-ID: <rfLuoC6GYaQTru1_jqseSC266NbVP4Kxe2J6FikGXeQ=.97a3a13d-4f90-41f4-b210-a0080351cc06@github.com>

On Thu, 31 Oct 2024 05:43:11 GMT, Julian Waters <jwaters at openjdk.org> wrote:

>> After 8339120, gcc began catching many different instances of unused code in the Windows specific codebase. Some of these seem to be bugs. I've taken the effort to mark out all the relevant globals and locals that trigger the unused warnings and addressed all of them by commenting out the code as appropriate. I am confident that in many cases this simplistic approach of commenting out code does not fix the underlying issue, and the warning actually found a bug that should be fixed. In these instances, I will be aiming to fix these bugs with help from reviewers, so I recommend anyone reviewing who knows more about the code than I do to see whether there is indeed a bug that needs fixing in a different way than what I did
>
> Julian Waters has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Remove the got local

Sorry for waiting so long. It's become clear that I won't be able to get awt and accessibility up to speed for a long time, so I will go ahead with this one first

-------------

PR Comment: https://git.openjdk.org/jdk/pull/21654#issuecomment-3047051283

From jwaters at openjdk.org  Tue Jul  8 01:32:52 2025
From: jwaters at openjdk.org (Julian Waters)
Date: Tue, 8 Jul 2025 01:32:52 GMT
Subject: <i18n dev> Integrated: 8342868: Errors related to unused code on
 Windows after 8339120 in core libs
In-Reply-To: <otTjiRgCFQEeUbpfFTMzhXUVBU1cal8q_i7IrGs_n94=.c2f02ad8-6b0c-4daa-9995-8e4b42131eb4@github.com>
References: <otTjiRgCFQEeUbpfFTMzhXUVBU1cal8q_i7IrGs_n94=.c2f02ad8-6b0c-4daa-9995-8e4b42131eb4@github.com>
Message-ID: <BiH2aLfK4drXAlv019OG10zJ7EVuyuXLB-U6VpprXkw=.d9de799f-7607-4ff2-b033-5614fdda16f7@github.com>

On Wed, 23 Oct 2024 04:40:50 GMT, Julian Waters <jwaters at openjdk.org> wrote:

> After 8339120, gcc began catching many different instances of unused code in the Windows specific codebase. Some of these seem to be bugs. I've taken the effort to mark out all the relevant globals and locals that trigger the unused warnings and addressed all of them by commenting out the code as appropriate. I am confident that in many cases this simplistic approach of commenting out code does not fix the underlying issue, and the warning actually found a bug that should be fixed. In these instances, I will be aiming to fix these bugs with help from reviewers, so I recommend anyone reviewing who knows more about the code than I do to see whether there is indeed a bug that needs fixing in a different way than what I did

This pull request has now been integrated.

Changeset: bbc5c98b
Author:    Julian Waters <jwaters at openjdk.org>
URL:       https://git.openjdk.org/jdk/commit/bbc5c98b144014a0423d666f74c4a5a15b08a7c2
Stats:     19 lines in 4 files changed: 9 ins; 0 del; 10 mod

8342868: Errors related to unused code on Windows after 8339120 in core libs

Reviewed-by: naoto, jlu

-------------

PR: https://git.openjdk.org/jdk/pull/21654

From dholmes at openjdk.org  Tue Jul  8 01:51:47 2025
From: dholmes at openjdk.org (David Holmes)
Date: Tue, 8 Jul 2025 01:51:47 GMT
Subject: <i18n dev> RFR: 8342868: Errors related to unused code on
 Windows after 8339120 in core libs [v2]
In-Reply-To: <rfLuoC6GYaQTru1_jqseSC266NbVP4Kxe2J6FikGXeQ=.97a3a13d-4f90-41f4-b210-a0080351cc06@github.com>
References: <otTjiRgCFQEeUbpfFTMzhXUVBU1cal8q_i7IrGs_n94=.c2f02ad8-6b0c-4daa-9995-8e4b42131eb4@github.com>
 <vT6zJlWPUg235GuAHNJbyAxkoONF2vljAuFTVygBoGk=.05690f62-9641-4990-855a-c908df24e064@github.com>
 <rfLuoC6GYaQTru1_jqseSC266NbVP4Kxe2J6FikGXeQ=.97a3a13d-4f90-41f4-b210-a0080351cc06@github.com>
Message-ID: <lZLJ957P7sONaS2DMlqED9bApOqJk3jhx910dFjSdTs=.09ca21d0-f864-4f7e-b48b-a0c9c39cebef@github.com>

On Tue, 8 Jul 2025 01:28:04 GMT, Julian Waters <jwaters at openjdk.org> wrote:

>> Julian Waters has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Remove the got local
>
> Sorry for waiting so long. It's become clear that I won't be able to get awt and accessibility up to speed for a long time, so I will go ahead with this one first

@TheShermanTanker the commented out code really should have been deleted, not just left commented out. Please file anpther JBS issue to have this cleaned up so it is not forgotten. Thanks.

-------------

PR Comment: https://git.openjdk.org/jdk/pull/21654#issuecomment-3047084740