<i18n dev> RFR: 8355522: Remove the `java.locale.useOldISOCodes` system property [v2]

Tue Jul 22 22:06:55 UTC 2025

On Tue, 22 Jul 2025 21:29:06 GMT, Justin Lu <jlu at openjdk.org> wrote:

> Should we also remove the test method, `ModuleTestUtil.runModuleWithLegacyCode` which passes the now defunct property to the process.

I thought about that, but decided to leave it as it is, just to make sure everything works as before. For the same reason, I did not remove the `-Djava.locale.useOldISOCodes=true` run in LocaleTest.java

> test/jdk/java/util/Locale/UseOldISOCodesTest.java line 56:
> 
>> 54:         public static void main(String[] args) {
>> 55:             // Ensure java.locale.useOldISOCodes should have no effect
>> 56:             System.setProperty("java.locale.useOldISOCodes", "false");
> 
> IMO, it seems weird to keep this line in the test, even if it has no effect. The original goal was to ensure the property only had impact when set during startup. The current test is no longer concerned with that (since the property no longer performs any mapping).

Right. I re-purposed the test but as you mentioned, the line is confusing. Removed.

-------------

PR Comment: https://git.openjdk.org/jdk/pull/26419#issuecomment-3104958671
PR Review Comment: https://git.openjdk.org/jdk/pull/26419#discussion_r2223912809