<i18n dev> RFR: 8358880: Performance of parsing with DecimalFormat can be improved
Naoto Sato
naoto at openjdk.org
Mon Jun 9 21:47:37 UTC 2025
On Thu, 5 Jun 2025 00:10:57 GMT, Chen Liang <liach at openjdk.org> wrote:
>> This one is a little odd. The parse methods that call `getLong` are not supposed to throw `NumberFormatException` either. So wherever `getLong` is called, it must be preceded by a check to `fitsIntoLong`, which should avoid any exceptions here. That said, rethrowing as NFE would avoid new surprises. What do you think?
>
> I will leave this question to I18N reviewers, who are ultimately in charge of DigitList.
The existing implementation does not throw `NumberFormatException`/`ArithmeticException`, but `ParseException` if parsing is failing. I would expect the same here.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/25644#discussion_r2136557633
More information about the i18n-dev
mailing list