<i18n dev> RFR: 8351074: Disallow null prefix and suffix in DecimalFormat [v3]

Naoto Sato naoto at openjdk.org
Tue Mar 4 18:32:04 UTC 2025


On Tue, 4 Mar 2025 18:12:48 GMT, Justin Lu <jlu at openjdk.org> wrote:

>> Please review this PR and associated CSR which disallows passing null to 4 `DecimalFormat` prefix/suffix setter methods.
>> 
>> Currently these setters do not check the input String for null. When the prefix/suffix is null, any such DecimalFormat instances are effectively non-functional as it will throw NPE for most operations.
>
> Justin Lu has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Make non-null apparent in param tag as well

LGTM

-------------

Marked as reviewed by naoto (Reviewer).

PR Review: https://git.openjdk.org/jdk/pull/23880#pullrequestreview-2658576784


More information about the i18n-dev mailing list