<i18n dev> Integrated: 8356040: java/util/PluggableLocale/LocaleNameProviderTest.java timed out
Justin Lu
jlu at openjdk.org
Mon May 5 16:45:51 UTC 2025
On Fri, 2 May 2025 15:49:03 GMT, Justin Lu <jlu at openjdk.org> wrote:
> Please review this PR which reduces the amount of combinations tested by `LocaleNameProviderTest`.
>
> This test was exhaustively testing over 1000x1000 `Locale` combinations which was expensive and caused a timeout in tier 5. Narrowing down the tested locales to Japanese language ones can reduce our tested input to 9x9 and provides most of the same value the test previously did. (Since our SPI provider has defined preferred Japanese Locale name values.) This change also refactors the test to use JUnit. The test now runs around ~20 times faster.
>
> Most of the diff is attributed to separating the method source from the test itself. But notice the filtering of `Locale`s done on `availloc` and `jreImplLoc`.
This pull request has now been integrated.
Changeset: 32f67a3e
Author: Justin Lu <jlu at openjdk.org>
URL: https://git.openjdk.org/jdk/commit/32f67a3e38be807164435ea0841c01d2b7c73652
Stats: 133 lines in 1 file changed: 64 ins; 48 del; 21 mod
8356040: java/util/PluggableLocale/LocaleNameProviderTest.java timed out
Reviewed-by: naoto
-------------
PR: https://git.openjdk.org/jdk/pull/25009
More information about the i18n-dev
mailing list