<i18n dev> RFR: 8301971: Make JDK source code UTF-8 [v5]
Erik Joelsson
erikj at openjdk.org
Tue May 6 17:26:23 UTC 2025
On Tue, 6 May 2025 15:39:04 GMT, Magnus Ihse Bursie <ihse at openjdk.org> wrote:
>> Most of the JDK code base has been transitioned to UTF-8, but not all. This has recently become an acute problem, since our mixing of iso-8859-1 and utf-8 in properties files confused the version of `sed` that is shipped with the new macOS 15.4.
>>
>> The fix is basically simple, and includes the following steps:
>> * Look through the code base for text files containing non-ASCII characters, and convert them to UTF-8, if they are not already
>> * Update tooling used in building to recognize the fact that files are now in UTF-8 and treat them accordingly (basically, updating compiler flags, git attributes, etc).
>
> Magnus Ihse Bursie has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains 13 additional commits since the last revision:
>
> - Merge branch 'master' into go-full-utf8
> - Add informative message about supported locales.
> - Allow C locale with warning instead of fatal error
> - Also document UTF-8 requirements (solves JDK-8338973)
> - Let configure only accept utf-8 locales
> - Address review comments from Kim
> - Also tell javadoc that we have utf-8 now
> - Fix flags for Windows
> - Mark java and native source code as utf-8
> - Don't convert properties files to iso-8859-1.
> - ... and 3 more: https://git.openjdk.org/jdk/compare/e6fcaea5...bea19a70
Marked as reviewed by erikj (Reviewer).
-------------
PR Review: https://git.openjdk.org/jdk/pull/24574#pullrequestreview-2819093476
More information about the i18n-dev
mailing list