<i18n dev> RFR: 8357224: Avoid redundant WeakHashMap.get in Toolkit.removeAWTEventListener

[Sergey Bylokhov]

On Wed, 16 Apr 2025 15:07:36 GMT, Andrey Turbanov <aturbanov at openjdk.org> wrote:

> Instead of separate `.get`+`.remove` calls we can call `.remove` and then compare result with `null`

src/java.desktop/share/classes/java/awt/Toolkit.java line 1745:

> 1743:         synchronized (this) {
> 1744:             SelectiveAWTEventListener selectiveListener =
> 1745:                 listener2SelectiveListener.remove(localL);

While analyzing the implementation of this method, I noticed a potential bug at the beginning. Should it instead be:

if (localL == null) {
    return;
}

?

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/24692#discussion_r2089545502