From cushon at openjdk.org  Sat Nov  1 16:26:04 2025
From: cushon at openjdk.org (Liam Miller-Cushon)
Date: Sat, 1 Nov 2025 16:26:04 GMT
Subject: <i18n dev> RFR: 8354548: Update CLDR to Version 48.0 [v2]
In-Reply-To: <9VpoTyAJ3oQwtSpHO6sCVwaWA_Jx3B91DS2oxOTTTcI=.afc95ec9-c937-44e8-9a0c-9b087dd3c4ff@github.com>
References: <eaNvczVXsydsLgN0PizFgyeCO4LZJcCaG4SCfCOYsKk=.5e67b56f-a4c8-4ef2-990d-b0d0b7c31a8f@github.com>
 <9VpoTyAJ3oQwtSpHO6sCVwaWA_Jx3B91DS2oxOTTTcI=.afc95ec9-c937-44e8-9a0c-9b087dd3c4ff@github.com>
Message-ID: <YHtlduwfyfFMcdTFF5_xg6NHC6Fb784snhddwlV35Wo=.7975ff5e-5231-42b3-90e8-4503c376da54@github.com>

On Thu, 30 Oct 2025 23:13:02 GMT, Naoto Sato <naoto at openjdk.org> wrote:

>> Upgrading the CLDR to version 48.0. A corresponding CSR has also been drafted.
>
> Naoto Sato has updated the pull request incrementally with one additional commit since the last revision:
> 
>   .md files

make/data/cldr/common/main/tok.xml line 444:

> 442: 					<dateFormatLength type="long">
> 443: 						<dateFormat>
> 444: 							<pattern>'tenpo' 'sike' #y 'la' 'tenpo' MMMM 'la' 'tenpo' 'suno' #d</pattern>

I think `DateTimeFormatter` doesn't handle the new patterns for `tok`, I am seeing the following crash with these changes:


jshell> Instant.parse("2018-07-16T23:58:59.000000200Z").atZone(ZoneId.of("UTC")).format(DateTimeFormatter.ofLocalizedDate(FormatStyle.LONG).withLocale(Locale.of("tok")))
|  Exception java.lang.IllegalArgumentException: Pattern includes reserved character: '#'
|        at DateTimeFormatterBuilder.parsePattern (DateTimeFormatterBuilder.java:2056)
|        at DateTimeFormatterBuilder.appendPattern (DateTimeFormatterBuilder.java:1910)
|        at DateTimeFormatterBuilder$LocalizedPrinterParser.lambda$formatter$0 (DateTimeFormatterBuilder.java:5181)
|        at ConcurrentHashMap.computeIfAbsent (ConcurrentHashMap.java:1727)
|        at DateTimeFormatterBuilder$LocalizedPrinterParser.formatter (DateTimeFormatterBuilder.java:5179)
|        at DateTimeFormatterBuilder$LocalizedPrinterParser.format (DateTimeFormatterBuilder.java:5154)
|        at DateTimeFormatterBuilder$CompositePrinterParser.format (DateTimeFormatterBuilder.java:2547)
|        at DateTimeFormatter.formatTo (DateTimeFormatter.java:1907)
|        at DateTimeFormatter.format (DateTimeFormatter.java:1881)
|        at ZonedDateTime.format (ZonedDateTime.java:2158)
|        at (#6:1)

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/28076#discussion_r2483784510

From duke at openjdk.org  Sun Nov  2 09:54:05 2025
From: duke at openjdk.org (Tatsunori Uchino)
Date: Sun, 2 Nov 2025 09:54:05 GMT
Subject: <i18n dev> RFR: 8364007: Add no-argument codePointCount method
 to CharSequence and String [v3]
In-Reply-To: <yXytI-4YecOG5cmyj97odjcDzuvDi5bpvgntMngLLBM=.8680d382-bab3-4fa5-bc21-5c4aecf3ca42@github.com>
References: <Ox7JWze6XO3MHtYkCjzFg4Oy3595mgT7AEzwzlDufhY=.9c8c43ec-10df-4f4a-857a-4af59b3ac9b2@github.com>
 <yXytI-4YecOG5cmyj97odjcDzuvDi5bpvgntMngLLBM=.8680d382-bab3-4fa5-bc21-5c4aecf3ca42@github.com>
Message-ID: <fzQCP48AOnM_sAvhD0dMRiT4X8uRzW4-TlNcTamgCmk=.480bdc6b-687a-4bc9-8d13-ff392d98c9d1@github.com>

On Sat, 26 Jul 2025 10:10:40 GMT, Tatsunori Uchino <duke at openjdk.org> wrote:

>> Adds `codePointCount()` overloads to `String`, `Character`, `(Abstract)StringBuilder`, and `StringBuffer` to make it possible to conveniently retrieve the length of a string as code points without extra boundary checks.
>> 
>> 
>> if (superTremendouslyLongExpressionYieldingAString().codePointCount() > limit) {
>>     throw new Exception("exceeding length");
>> }
>> 
>> 
>> Is a CSR required to this change?
>
> Tatsunori Uchino has updated the pull request incrementally with four additional commits since the last revision:
> 
>  - Update `@bug` in correct file
>  - Add default implementation on codePointCount in CharSequence
>  - Update `@bug` entries in test class doc comments
>  - Discard changes on code whose form is not `str.codePointCount(0, str.length())`

The CSR text is not modified from the boilerplate, but I have no authority to modify it.

-------------

PR Comment: https://git.openjdk.org/jdk/pull/26461#issuecomment-3477670082

From naoto at openjdk.org  Mon Nov  3 18:42:01 2025
From: naoto at openjdk.org (Naoto Sato)
Date: Mon, 3 Nov 2025 18:42:01 GMT
Subject: <i18n dev> RFR: 8354548: Update CLDR to Version 48.0 [v2]
In-Reply-To: <YHtlduwfyfFMcdTFF5_xg6NHC6Fb784snhddwlV35Wo=.7975ff5e-5231-42b3-90e8-4503c376da54@github.com>
References: <eaNvczVXsydsLgN0PizFgyeCO4LZJcCaG4SCfCOYsKk=.5e67b56f-a4c8-4ef2-990d-b0d0b7c31a8f@github.com>
 <9VpoTyAJ3oQwtSpHO6sCVwaWA_Jx3B91DS2oxOTTTcI=.afc95ec9-c937-44e8-9a0c-9b087dd3c4ff@github.com>
 <YHtlduwfyfFMcdTFF5_xg6NHC6Fb784snhddwlV35Wo=.7975ff5e-5231-42b3-90e8-4503c376da54@github.com>
Message-ID: <NaqWRsnchf6TXPIkGGeIioqV7iLuRfIeiYzYWB4_Y_w=.a88279e9-7907-44b2-8715-5fbb4b86f2dd@github.com>

On Sat, 1 Nov 2025 16:23:18 GMT, Liam Miller-Cushon <cushon at openjdk.org> wrote:

>> Naoto Sato has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   .md files
>
> make/data/cldr/common/main/tok.xml line 444:
> 
>> 442: 					<dateFormatLength type="long">
>> 443: 						<dateFormat>
>> 444: 							<pattern>'tenpo' 'sike' #y 'la' 'tenpo' MMMM 'la' 'tenpo' 'suno' #d</pattern>
> 
> I think `DateTimeFormatter` doesn't handle the new patterns for `tok`, I am seeing the following crash with these changes:
> 
> 
> jshell> Instant.parse("2018-07-16T23:58:59.000000200Z").atZone(ZoneId.of("UTC")).format(DateTimeFormatter.ofLocalizedDate(FormatStyle.LONG).withLocale(Locale.of("tok")))
> |  Exception java.lang.IllegalArgumentException: Pattern includes reserved character: '#'
> |        at DateTimeFormatterBuilder.parsePattern (DateTimeFormatterBuilder.java:2056)
> |        at DateTimeFormatterBuilder.appendPattern (DateTimeFormatterBuilder.java:1910)
> |        at DateTimeFormatterBuilder$LocalizedPrinterParser.lambda$formatter$0 (DateTimeFormatterBuilder.java:5181)
> |        at ConcurrentHashMap.computeIfAbsent (ConcurrentHashMap.java:1727)
> |        at DateTimeFormatterBuilder$LocalizedPrinterParser.formatter (DateTimeFormatterBuilder.java:5179)
> |        at DateTimeFormatterBuilder$LocalizedPrinterParser.format (DateTimeFormatterBuilder.java:5154)
> |        at DateTimeFormatterBuilder$CompositePrinterParser.format (DateTimeFormatterBuilder.java:2547)
> |        at DateTimeFormatter.formatTo (DateTimeFormatter.java:1907)
> |        at DateTimeFormatter.format (DateTimeFormatter.java:1881)
> |        at ZonedDateTime.format (ZonedDateTime.java:2158)
> |        at (#6:1)

Thanks. Will address this in the next version.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/28076#discussion_r2487494223

From naoto at openjdk.org  Mon Nov  3 21:27:13 2025
From: naoto at openjdk.org (Naoto Sato)
Date: Mon, 3 Nov 2025 21:27:13 GMT
Subject: <i18n dev> RFR: 8354548: Update CLDR to Version 48.0 [v3]
In-Reply-To: <eaNvczVXsydsLgN0PizFgyeCO4LZJcCaG4SCfCOYsKk=.5e67b56f-a4c8-4ef2-990d-b0d0b7c31a8f@github.com>
References: <eaNvczVXsydsLgN0PizFgyeCO4LZJcCaG4SCfCOYsKk=.5e67b56f-a4c8-4ef2-990d-b0d0b7c31a8f@github.com>
Message-ID: <SfGVmGO0gM8BP6oQdUTFxSe6B8INO7HRiADYTSh6JYo=.6c1fe3e2-2555-4cce-9c25-e08db1d79f45@github.com>

> Upgrading the CLDR to version 48.0. A corresponding CSR has also been drafted.

Naoto Sato has updated the pull request incrementally with one additional commit since the last revision:

  `#` fix for "tok" locale

-------------

Changes:
  - all: https://git.openjdk.org/jdk/pull/28076/files
  - new: https://git.openjdk.org/jdk/pull/28076/files/38f86493..41fa00fb

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jdk&pr=28076&range=02
 - incr: https://webrevs.openjdk.org/?repo=jdk&pr=28076&range=01-02

  Stats: 101 lines in 2 files changed: 99 ins; 0 del; 2 mod
  Patch: https://git.openjdk.org/jdk/pull/28076.diff
  Fetch: git fetch https://git.openjdk.org/jdk.git pull/28076/head:pull/28076

PR: https://git.openjdk.org/jdk/pull/28076

From jlu at openjdk.org  Mon Nov  3 23:54:37 2025
From: jlu at openjdk.org (Justin Lu)
Date: Mon, 3 Nov 2025 23:54:37 GMT
Subject: <i18n dev> RFR: 8370420: HostLocaleProviderAdapter_md.c from
 libjava can use GetLocaleInfoEx, GetCalendarInfoEx,
 EnumCalendarInfoExEx directly
Message-ID: <Z1dZZw56tLdc3B3htVp4GQAKcSm3n4SV7EpRvzpf-JE=.499dcc2c-15ce-4d72-b0f0-456d80ae6d7e@github.com>

This PR cleans up some native code for Windows i18n functions. These particular calls are designed to run on Windows Vista and later. Since Vista (and older) are not supported Windows platforms, the calls no longer need to be checked if they are supported and can be called directly.

Reference to docs: https://learn.microsoft.com/en-us/windows/win32/api/winnls/nf-winnls-getlocaleinfoex.

> Minimum supported client: 	Windows Vista
> Minimum supported server: 	Windows Server 2008

-------------

Commit messages:
 - Merge branch 'master' into JDK-8370420-Windows
 - init

Changes: https://git.openjdk.org/jdk/pull/28119/files
  Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=28119&range=00
  Issue: https://bugs.openjdk.org/browse/JDK-8370420
  Stats: 34 lines in 1 file changed: 1 ins; 19 del; 14 mod
  Patch: https://git.openjdk.org/jdk/pull/28119.diff
  Fetch: git fetch https://git.openjdk.org/jdk.git pull/28119/head:pull/28119

PR: https://git.openjdk.org/jdk/pull/28119

From bpb at openjdk.org  Tue Nov  4 00:07:03 2025
From: bpb at openjdk.org (Brian Burkhalter)
Date: Tue, 4 Nov 2025 00:07:03 GMT
Subject: <i18n dev> RFR: 8370420: HostLocaleProviderAdapter_md.c from
 libjava can use GetLocaleInfoEx, GetCalendarInfoEx,
 EnumCalendarInfoExEx directly
In-Reply-To: <Z1dZZw56tLdc3B3htVp4GQAKcSm3n4SV7EpRvzpf-JE=.499dcc2c-15ce-4d72-b0f0-456d80ae6d7e@github.com>
References: <Z1dZZw56tLdc3B3htVp4GQAKcSm3n4SV7EpRvzpf-JE=.499dcc2c-15ce-4d72-b0f0-456d80ae6d7e@github.com>
Message-ID: <WH_YdXi2i29b7mQneTEM-dCeMU88DJeKVSGSiRnFh_g=.ca0ee299-7c9a-45fc-8b21-7fd22518ea7e@github.com>

On Mon, 3 Nov 2025 23:48:22 GMT, Justin Lu <jlu at openjdk.org> wrote:

> This PR cleans up some native code for Windows i18n functions. These particular calls are designed to run on Windows Vista and later. Since Vista (and older) are not supported Windows platforms, the calls no longer need to be checked if they are supported and can be called directly.
> 
> Reference to docs: https://learn.microsoft.com/en-us/windows/win32/api/winnls/nf-winnls-getlocaleinfoex.
> 
>> Minimum supported client: 	Windows Vista
>> Minimum supported server: 	Windows Server 2008

Looks all right to me.

-------------

Marked as reviewed by bpb (Reviewer).

PR Review: https://git.openjdk.org/jdk/pull/28119#pullrequestreview-3413411560

From naoto at openjdk.org  Tue Nov  4 00:11:36 2025
From: naoto at openjdk.org (Naoto Sato)
Date: Tue, 4 Nov 2025 00:11:36 GMT
Subject: <i18n dev> RFR: 8354548: Update CLDR to Version 48.0 [v4]
In-Reply-To: <eaNvczVXsydsLgN0PizFgyeCO4LZJcCaG4SCfCOYsKk=.5e67b56f-a4c8-4ef2-990d-b0d0b7c31a8f@github.com>
References: <eaNvczVXsydsLgN0PizFgyeCO4LZJcCaG4SCfCOYsKk=.5e67b56f-a4c8-4ef2-990d-b0d0b7c31a8f@github.com>
Message-ID: <Ol1NumVT400IwBNQ95zYMBG-1dJxHOdVgsqowf8PIcg=.a0672072-c512-454b-bb67-46a004b64380@github.com>

> Upgrading the CLDR to version 48.0. A corresponding CSR has also been drafted.

Naoto Sato has updated the pull request incrementally with one additional commit since the last revision:

  Unicode copyright update for the generated sources

-------------

Changes:
  - all: https://git.openjdk.org/jdk/pull/28076/files
  - new: https://git.openjdk.org/jdk/pull/28076/files/41fa00fb..05f5f0d9

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jdk&pr=28076&range=03
 - incr: https://webrevs.openjdk.org/?repo=jdk&pr=28076&range=02-03

  Stats: 45 lines in 1 file changed: 8 ins; 0 del; 37 mod
  Patch: https://git.openjdk.org/jdk/pull/28076.diff
  Fetch: git fetch https://git.openjdk.org/jdk.git pull/28076/head:pull/28076

PR: https://git.openjdk.org/jdk/pull/28076

From naoto at openjdk.org  Tue Nov  4 00:49:06 2025
From: naoto at openjdk.org (Naoto Sato)
Date: Tue, 4 Nov 2025 00:49:06 GMT
Subject: <i18n dev> RFR: 8370420: HostLocaleProviderAdapter_md.c from
 libjava can use GetLocaleInfoEx, GetCalendarInfoEx,
 EnumCalendarInfoExEx directly
In-Reply-To: <Z1dZZw56tLdc3B3htVp4GQAKcSm3n4SV7EpRvzpf-JE=.499dcc2c-15ce-4d72-b0f0-456d80ae6d7e@github.com>
References: <Z1dZZw56tLdc3B3htVp4GQAKcSm3n4SV7EpRvzpf-JE=.499dcc2c-15ce-4d72-b0f0-456d80ae6d7e@github.com>
Message-ID: <SC7QgEV4ObD2N1oUMe98ScxEYxebfXv9_nAPOWiJyxU=.fc1b52f3-833e-41b9-a541-5c9ba5def683@github.com>

On Mon, 3 Nov 2025 23:48:22 GMT, Justin Lu <jlu at openjdk.org> wrote:

> This PR cleans up some native code for Windows i18n functions. These particular calls are designed to run on Windows Vista and later. Since Vista (and older) are not supported Windows platforms, the calls no longer need to be checked if they are supported and can be called directly.
> 
> Reference to docs: https://learn.microsoft.com/en-us/windows/win32/api/winnls/nf-winnls-getlocaleinfoex.
> 
>> Minimum supported client: 	Windows Vista
>> Minimum supported server: 	Windows Server 2008

I think we can clean it further, as we don't need to call Win32 through their function pointers. Specifically,

typedef int (WINAPI *PGLIE)(const jchar *, LCTYPE, LPWSTR, int);
typedef int (WINAPI *PGCIE)(const jchar *, CALID, LPCWSTR, CALTYPE, LPWSTR, int, LPDWORD);
typedef int (WINAPI *PECIEE)(CALINFO_ENUMPROCEXEX, const jchar *, CALID, LPCWSTR, CALTYPE, LPARAM);
PGLIE pGetLocaleInfoEx;
PGCIE pGetCalendarInfoEx;
PECIEE pEnumCalendarInfoExEx;
BOOL initialized = FALSE;

and it's init code can all go away, IIUC

-------------

PR Comment: https://git.openjdk.org/jdk/pull/28119#issuecomment-3483228621

From mbaesken at openjdk.org  Tue Nov  4 08:17:21 2025
From: mbaesken at openjdk.org (Matthias Baesken)
Date: Tue, 4 Nov 2025 08:17:21 GMT
Subject: <i18n dev> RFR: 8370420: HostLocaleProviderAdapter_md.c from
 libjava can use GetLocaleInfoEx, GetCalendarInfoEx,
 EnumCalendarInfoExEx directly
In-Reply-To: <SC7QgEV4ObD2N1oUMe98ScxEYxebfXv9_nAPOWiJyxU=.fc1b52f3-833e-41b9-a541-5c9ba5def683@github.com>
References: <Z1dZZw56tLdc3B3htVp4GQAKcSm3n4SV7EpRvzpf-JE=.499dcc2c-15ce-4d72-b0f0-456d80ae6d7e@github.com>
 <SC7QgEV4ObD2N1oUMe98ScxEYxebfXv9_nAPOWiJyxU=.fc1b52f3-833e-41b9-a541-5c9ba5def683@github.com>
Message-ID: <OxagcrnSxD_nxZkzoQkE0TDgntCJ11kskB0D6AZHaNY=.1e6ba5e8-3f74-4905-8526-0d7e0944fc67@github.com>

On Tue, 4 Nov 2025 00:46:37 GMT, Naoto Sato <naoto at openjdk.org> wrote:

> I think we can clean it further, as we don't need to call Win32 through their function pointers. Specifically,
> 
> ```
> typedef int (WINAPI *PGLIE)(const jchar *, LCTYPE, LPWSTR, int);
> typedef int (WINAPI *PGCIE)(const jchar *, CALID, LPCWSTR, CALTYPE, LPWSTR, int, LPDWORD);
> typedef int (WINAPI *PECIEE)(CALINFO_ENUMPROCEXEX, const jchar *, CALID, LPCWSTR, CALTYPE, LPARAM);
> PGLIE pGetLocaleInfoEx;
> PGCIE pGetCalendarInfoEx;
> PECIEE pEnumCalendarInfoExEx;
> BOOL initialized = FALSE;
> ```
> 
> and it's init code can all go away, IIUC


Yes the GetProcAddress  stuff should be removed too, see
https://github.com/openjdk/jdk/blob/c1476fca9d7a679d32b7b43956638b845d1027cc/src/java.base/windows/native/libjava/HostLocaleProviderAdapter_md.c#L189

-------------

PR Comment: https://git.openjdk.org/jdk/pull/28119#issuecomment-3484469810

From naoto at openjdk.org  Tue Nov  4 17:53:36 2025
From: naoto at openjdk.org (Naoto Sato)
Date: Tue, 4 Nov 2025 17:53:36 GMT
Subject: <i18n dev> RFR: 8354548: Update CLDR to Version 48.0 [v5]
In-Reply-To: <eaNvczVXsydsLgN0PizFgyeCO4LZJcCaG4SCfCOYsKk=.5e67b56f-a4c8-4ef2-990d-b0d0b7c31a8f@github.com>
References: <eaNvczVXsydsLgN0PizFgyeCO4LZJcCaG4SCfCOYsKk=.5e67b56f-a4c8-4ef2-990d-b0d0b7c31a8f@github.com>
Message-ID: <uQzj0iMIvdDIFMxz6ZpI8x_pFbMh2sh5okn-uBp0Qoc=.97175766-315c-414f-a129-e2e15c5fac0e@github.com>

> Upgrading the CLDR to version 48.0. A corresponding CSR has also been drafted.

Naoto Sato has updated the pull request incrementally with one additional commit since the last revision:

  Minor header fix

-------------

Changes:
  - all: https://git.openjdk.org/jdk/pull/28076/files
  - new: https://git.openjdk.org/jdk/pull/28076/files/05f5f0d9..b0bfd789

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jdk&pr=28076&range=04
 - incr: https://webrevs.openjdk.org/?repo=jdk&pr=28076&range=03-04

  Stats: 2 lines in 1 file changed: 2 ins; 0 del; 0 mod
  Patch: https://git.openjdk.org/jdk/pull/28076.diff
  Fetch: git fetch https://git.openjdk.org/jdk.git pull/28076/head:pull/28076

PR: https://git.openjdk.org/jdk/pull/28076

From jlu at openjdk.org  Tue Nov  4 19:06:31 2025
From: jlu at openjdk.org (Justin Lu)
Date: Tue, 4 Nov 2025 19:06:31 GMT
Subject: <i18n dev> RFR: 8370420: HostLocaleProviderAdapter_md.c from
 libjava can use GetLocaleInfoEx, GetCalendarInfoEx,
 EnumCalendarInfoExEx directly [v2]
In-Reply-To: <Z1dZZw56tLdc3B3htVp4GQAKcSm3n4SV7EpRvzpf-JE=.499dcc2c-15ce-4d72-b0f0-456d80ae6d7e@github.com>
References: <Z1dZZw56tLdc3B3htVp4GQAKcSm3n4SV7EpRvzpf-JE=.499dcc2c-15ce-4d72-b0f0-456d80ae6d7e@github.com>
Message-ID: <xAWa8o65tL6Syy71GCH_3gvOoeWsF3ah0OVY2snF9n4=.bb997a2c-7595-4580-abc4-43ef1c25150a@github.com>

> This PR cleans up some native code for Windows i18n functions. These particular calls are designed to run on Windows Vista and later. Since Vista (and older) are not supported Windows platforms, the calls no longer need to be checked if they are supported and can be called directly.
> 
> Reference to docs: https://learn.microsoft.com/en-us/windows/win32/api/winnls/nf-winnls-getlocaleinfoex.
> 
>> Minimum supported client: 	Windows Vista
>> Minimum supported server: 	Windows Server 2008

Justin Lu has updated the pull request incrementally with one additional commit since the last revision:

  Remove dynamic loading and call directly

-------------

Changes:
  - all: https://git.openjdk.org/jdk/pull/28119/files
  - new: https://git.openjdk.org/jdk/pull/28119/files/0ccf212a..e18a5744

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jdk&pr=28119&range=01
 - incr: https://webrevs.openjdk.org/?repo=jdk&pr=28119&range=00-01

  Stats: 62 lines in 2 files changed: 5 ins; 44 del; 13 mod
  Patch: https://git.openjdk.org/jdk/pull/28119.diff
  Fetch: git fetch https://git.openjdk.org/jdk.git pull/28119/head:pull/28119

PR: https://git.openjdk.org/jdk/pull/28119

From naoto at openjdk.org  Tue Nov  4 19:43:54 2025
From: naoto at openjdk.org (Naoto Sato)
Date: Tue, 4 Nov 2025 19:43:54 GMT
Subject: <i18n dev> RFR: 8370420: HostLocaleProviderAdapter_md.c from
 libjava can use GetLocaleInfoEx, GetCalendarInfoEx,
 EnumCalendarInfoExEx directly [v2]
In-Reply-To: <xAWa8o65tL6Syy71GCH_3gvOoeWsF3ah0OVY2snF9n4=.bb997a2c-7595-4580-abc4-43ef1c25150a@github.com>
References: <Z1dZZw56tLdc3B3htVp4GQAKcSm3n4SV7EpRvzpf-JE=.499dcc2c-15ce-4d72-b0f0-456d80ae6d7e@github.com>
 <xAWa8o65tL6Syy71GCH_3gvOoeWsF3ah0OVY2snF9n4=.bb997a2c-7595-4580-abc4-43ef1c25150a@github.com>
Message-ID: <sJv59TfcEMySyav9bXBkVLLeNlzG3K02a2znYXC2tB4=.d4156f19-3f06-4eb4-be55-072d50b153b7@github.com>

On Tue, 4 Nov 2025 19:06:31 GMT, Justin Lu <jlu at openjdk.org> wrote:

>> This PR cleans up some native code for Windows i18n functions. These particular calls are designed to run on Windows Vista and later. Since Vista (and older) are not supported Windows platforms, the calls no longer need to be checked if they are supported and can be called directly.
>> 
>> Reference to docs: https://learn.microsoft.com/en-us/windows/win32/api/winnls/nf-winnls-getlocaleinfoex.
>> 
>>> Minimum supported client: 	Windows Vista
>>> Minimum supported server: 	Windows Server 2008
>
> Justin Lu has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Remove dynamic loading and call directly

LGTM

-------------

Marked as reviewed by naoto (Reviewer).

PR Review: https://git.openjdk.org/jdk/pull/28119#pullrequestreview-3418379991

From jlu at openjdk.org  Tue Nov  4 20:07:18 2025
From: jlu at openjdk.org (Justin Lu)
Date: Tue, 4 Nov 2025 20:07:18 GMT
Subject: <i18n dev> RFR: 8354548: Update CLDR to Version 48.0 [v5]
In-Reply-To: <uQzj0iMIvdDIFMxz6ZpI8x_pFbMh2sh5okn-uBp0Qoc=.97175766-315c-414f-a129-e2e15c5fac0e@github.com>
References: <eaNvczVXsydsLgN0PizFgyeCO4LZJcCaG4SCfCOYsKk=.5e67b56f-a4c8-4ef2-990d-b0d0b7c31a8f@github.com>
 <uQzj0iMIvdDIFMxz6ZpI8x_pFbMh2sh5okn-uBp0Qoc=.97175766-315c-414f-a129-e2e15c5fac0e@github.com>
Message-ID: <Xqr1K8y32oOFAvtBNvzJHig31D6LpR7qmTQ1F4L1-4U=.e0b8c48c-bf9e-42dc-bc3c-fea415850f08@github.com>

On Tue, 4 Nov 2025 17:53:36 GMT, Naoto Sato <naoto at openjdk.org> wrote:

>> Upgrading the CLDR to version 48.0. A corresponding CSR has also been drafted.
>
> Naoto Sato has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Minor header fix

Took a look at all the changes besides the XML data itself. LGTM.

make/data/cldr/LICENSE line 1:

> 1: ?UNICODE LICENSE V3

I guess a line ending change on their end?

make/jdk/src/classes/build/tools/cldrconverter/Bundle.java line 852:

> 850: 
> 851:     /**
> 852:      * Escape reserved pattern characters, '#', '{', and '}' in the pattern

Even though they may not be offending now, should  '[' and ']' be included since they are also non CLDR date time patterns (not A-Z), but are recognized in DateTimeFormatter patterns?

-------------

Marked as reviewed by jlu (Committer).

PR Review: https://git.openjdk.org/jdk/pull/28076#pullrequestreview-3412376711
PR Review Comment: https://git.openjdk.org/jdk/pull/28076#discussion_r2491900624
PR Review Comment: https://git.openjdk.org/jdk/pull/28076#discussion_r2491874764

From jlu at openjdk.org  Tue Nov  4 20:07:21 2025
From: jlu at openjdk.org (Justin Lu)
Date: Tue, 4 Nov 2025 20:07:21 GMT
Subject: <i18n dev> RFR: 8354548: Update CLDR to Version 48.0 [v2]
In-Reply-To: <9VpoTyAJ3oQwtSpHO6sCVwaWA_Jx3B91DS2oxOTTTcI=.afc95ec9-c937-44e8-9a0c-9b087dd3c4ff@github.com>
References: <eaNvczVXsydsLgN0PizFgyeCO4LZJcCaG4SCfCOYsKk=.5e67b56f-a4c8-4ef2-990d-b0d0b7c31a8f@github.com>
 <9VpoTyAJ3oQwtSpHO6sCVwaWA_Jx3B91DS2oxOTTTcI=.afc95ec9-c937-44e8-9a0c-9b087dd3c4ff@github.com>
Message-ID: <_OeoX0nyVU3EogxGV3pXv1knDQQmDs7axRKf2QOM4wg=.b500b7df-f03b-4605-af83-8b5394a81fe6@github.com>

On Thu, 30 Oct 2025 23:13:02 GMT, Naoto Sato <naoto at openjdk.org> wrote:

>> Upgrading the CLDR to version 48.0. A corresponding CSR has also been drafted.
>
> Naoto Sato has updated the pull request incrementally with one additional commit since the last revision:
> 
>   .md files

test/jdk/java/text/Format/CompactNumberFormat/TestCompactNumber.java line 1:

> 1: /*

Bug id update needed?

test/jdk/sun/util/resources/cldr/TimeZoneNamesTest.java line 1:

> 1: /*

Bug id update needed?

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/28076#discussion_r2487475839
PR Review Comment: https://git.openjdk.org/jdk/pull/28076#discussion_r2487488844

From naoto at openjdk.org  Tue Nov  4 21:03:25 2025
From: naoto at openjdk.org (Naoto Sato)
Date: Tue, 4 Nov 2025 21:03:25 GMT
Subject: <i18n dev> RFR: 8354548: Update CLDR to Version 48.0 [v6]
In-Reply-To: <eaNvczVXsydsLgN0PizFgyeCO4LZJcCaG4SCfCOYsKk=.5e67b56f-a4c8-4ef2-990d-b0d0b7c31a8f@github.com>
References: <eaNvczVXsydsLgN0PizFgyeCO4LZJcCaG4SCfCOYsKk=.5e67b56f-a4c8-4ef2-990d-b0d0b7c31a8f@github.com>
Message-ID: <lk88O_Hl0JhBkVIT3Bo4Q2pT_nYg46lKDRR9bg3oBk8=.45d85019-7252-4ba6-b4dd-78eccb3317fa@github.com>

> Upgrading the CLDR to version 48.0. A corresponding CSR has also been drafted.

Naoto Sato has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains 58 commits:

 - Addressing review comments
 - Merge branch 'master' into JDK-8354548-CLDR-48
 - Minor header fix
 - Unicode copyright update for the generated sources
 - `#` fix for "tok" locale
 - .md files
 - v48 final
 - Merge branch 'master' into JDK-8354548-CLDR-48
 - Merge branch 'master' into JDK-8354548-CLDR-48
 - Merge branch 'master' into JDK-8354548-CLDR-48
 - ... and 48 more: https://git.openjdk.org/jdk/compare/9f972008...b5c74834

-------------

Changes: https://git.openjdk.org/jdk/pull/28076/files
  Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=28076&range=05
  Stats: 135921 lines in 390 files changed: 94379 ins; 15578 del; 25964 mod
  Patch: https://git.openjdk.org/jdk/pull/28076.diff
  Fetch: git fetch https://git.openjdk.org/jdk.git pull/28076/head:pull/28076

PR: https://git.openjdk.org/jdk/pull/28076

From naoto at openjdk.org  Tue Nov  4 21:05:06 2025
From: naoto at openjdk.org (Naoto Sato)
Date: Tue, 4 Nov 2025 21:05:06 GMT
Subject: <i18n dev> RFR: 8354548: Update CLDR to Version 48.0 [v5]
In-Reply-To: <Xqr1K8y32oOFAvtBNvzJHig31D6LpR7qmTQ1F4L1-4U=.e0b8c48c-bf9e-42dc-bc3c-fea415850f08@github.com>
References: <eaNvczVXsydsLgN0PizFgyeCO4LZJcCaG4SCfCOYsKk=.5e67b56f-a4c8-4ef2-990d-b0d0b7c31a8f@github.com>
 <uQzj0iMIvdDIFMxz6ZpI8x_pFbMh2sh5okn-uBp0Qoc=.97175766-315c-414f-a129-e2e15c5fac0e@github.com>
 <Xqr1K8y32oOFAvtBNvzJHig31D6LpR7qmTQ1F4L1-4U=.e0b8c48c-bf9e-42dc-bc3c-fea415850f08@github.com>
Message-ID: <WD2InaqAFg1m5xVBGUPjUC9AIgSizS0n-zxwuZhFNhA=.220bbe8d-8b6f-4a4c-820e-2ac694b47b06@github.com>

On Tue, 4 Nov 2025 20:02:47 GMT, Justin Lu <jlu at openjdk.org> wrote:

>> Naoto Sato has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Minor header fix
>
> make/data/cldr/LICENSE line 1:
> 
>> 1: ?UNICODE LICENSE V3
> 
> I guess a line ending change on their end?

Yes.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/28076#discussion_r2492033121

From naoto at openjdk.org  Tue Nov  4 21:47:01 2025
From: naoto at openjdk.org (Naoto Sato)
Date: Tue, 4 Nov 2025 21:47:01 GMT
Subject: <i18n dev> RFR: 8354548: Update CLDR to Version 48.0 [v7]
In-Reply-To: <eaNvczVXsydsLgN0PizFgyeCO4LZJcCaG4SCfCOYsKk=.5e67b56f-a4c8-4ef2-990d-b0d0b7c31a8f@github.com>
References: <eaNvczVXsydsLgN0PizFgyeCO4LZJcCaG4SCfCOYsKk=.5e67b56f-a4c8-4ef2-990d-b0d0b7c31a8f@github.com>
Message-ID: <c_vyr86pndvzrVNkMJiM1Y9P-IfpKFuawONeB-clCAI=.76032eb3-b8b4-4928-af98-4efce34481dc@github.com>

> Upgrading the CLDR to version 48.0. A corresponding CSR has also been drafted.

Naoto Sato has updated the pull request incrementally with one additional commit since the last revision:

  Test data fix for zh_HK which uses '[' and ']' literals

-------------

Changes:
  - all: https://git.openjdk.org/jdk/pull/28076/files
  - new: https://git.openjdk.org/jdk/pull/28076/files/b5c74834..5de0854a

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jdk&pr=28076&range=06
 - incr: https://webrevs.openjdk.org/?repo=jdk&pr=28076&range=05-06

  Stats: 2 lines in 1 file changed: 0 ins; 0 del; 2 mod
  Patch: https://git.openjdk.org/jdk/pull/28076.diff
  Fetch: git fetch https://git.openjdk.org/jdk.git pull/28076/head:pull/28076

PR: https://git.openjdk.org/jdk/pull/28076

From eawazilalwataniuh7 at gmail.com  Wed Nov  5 02:58:16 2025
From: eawazilalwataniuh7 at gmail.com (eawazilalwataniuh)
Date: Wed, 5 Nov 2025 04:58:16 +0200
Subject: <i18n dev> Commercial Roof Insulation Solutions
Message-ID: <CAA+HuEySXmaueG_KYMPo0t_+SgL9J2taFyVaMRoT34DD=b=eHQ@mail.gmail.com>

??? ?????? ??????? ???????? ?

??? ?????? ??????? ???????? ???? ???? ?????? ?????? ??? ???? ??????
???????? ?????? ?????? ???????. ?????? ??? ???????? ???????? ??????????
???????? ????? ??? ??? ??? ???? ????? ????????? ?????? ??????? ?????
???????. ??????? ????? ????? ?? ????? ????? ??????? ????? ??????? ????????
???? ??????? ?????? ??? ????? ???????.

?? ??? ???????? ????????? ???? ????? ??????? ??????? ?????? ????? ??????
????????? ?? ??????? ????????? ????? ??????? ??? ??? ??????? ???? ?????
???? ???? ??????. ??? ???? ?????? ???????? ??????? ??????? ??????? ??????
????? ???????? ???? ????? ?????? ????? ???? ??????? ????.

????? ???? ???????? ????? ???????? ?? ???? ?????? ??? *????? ??? ??????
<https://eawazilalwataniuh.com/>* ???? ????? ?????? ?? ????? ?????? ???
?????? ???????? ????? ?????. ??? ???? *????? ???????
<https://eawazilalwataniuh.com/>* ?????? ?????? ????? ????? ????? ???????
???????? ????? ???????? ??????? ?? ???????.

???? ??? ??? ?????? ????? ????? ??????? ??????? ?????? ??????? ???????
??????? ??? ???? ?????? ??????? ??? ???? ?????? ?? ???????? ??? ????? *????
??? ????? <https://eawazilalwataniuh.com/>* ???? ???? ???? ?????? ???????
????? ??????? ???????? ????? ????? ??????? ????? ???? ?????? ?????? ????
?????.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.openjdk.org/pipermail/i18n-dev/attachments/20251105/33b32ad3/attachment-0001.htm>

From mbaesken at openjdk.org  Wed Nov  5 08:08:03 2025
From: mbaesken at openjdk.org (Matthias Baesken)
Date: Wed, 5 Nov 2025 08:08:03 GMT
Subject: <i18n dev> RFR: 8370420: HostLocaleProviderAdapter_md.c from
 libjava can use GetLocaleInfoEx, GetCalendarInfoEx,
 EnumCalendarInfoExEx directly [v2]
In-Reply-To: <xAWa8o65tL6Syy71GCH_3gvOoeWsF3ah0OVY2snF9n4=.bb997a2c-7595-4580-abc4-43ef1c25150a@github.com>
References: <Z1dZZw56tLdc3B3htVp4GQAKcSm3n4SV7EpRvzpf-JE=.499dcc2c-15ce-4d72-b0f0-456d80ae6d7e@github.com>
 <xAWa8o65tL6Syy71GCH_3gvOoeWsF3ah0OVY2snF9n4=.bb997a2c-7595-4580-abc4-43ef1c25150a@github.com>
Message-ID: <3DrRXpA2tp_sHI34pEugtcLNstNe4RpekKAwgeNhS00=.983daaf2-92fd-4c21-bb32-96daac3e0bc2@github.com>

On Tue, 4 Nov 2025 19:06:31 GMT, Justin Lu <jlu at openjdk.org> wrote:

>> This PR cleans up some native code for Windows i18n functions. These particular calls are designed to run on Windows Vista and later. Since Vista (and older) are not supported Windows platforms, the calls no longer need to be checked if they are supported and can be called directly.
>> 
>> Reference to docs: https://learn.microsoft.com/en-us/windows/win32/api/winnls/nf-winnls-getlocaleinfoex.
>> 
>>> Minimum supported client: 	Windows Vista
>>> Minimum supported server: 	Windows Server 2008
>
> Justin Lu has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Remove dynamic loading and call directly

Marked as reviewed by mbaesken (Reviewer).

-------------

PR Review: https://git.openjdk.org/jdk/pull/28119#pullrequestreview-3420458873

From naoto at openjdk.org  Wed Nov  5 17:09:48 2025
From: naoto at openjdk.org (Naoto Sato)
Date: Wed, 5 Nov 2025 17:09:48 GMT
Subject: <i18n dev> RFR: 8354548: Update CLDR to Version 48.0 [v8]
In-Reply-To: <eaNvczVXsydsLgN0PizFgyeCO4LZJcCaG4SCfCOYsKk=.5e67b56f-a4c8-4ef2-990d-b0d0b7c31a8f@github.com>
References: <eaNvczVXsydsLgN0PizFgyeCO4LZJcCaG4SCfCOYsKk=.5e67b56f-a4c8-4ef2-990d-b0d0b7c31a8f@github.com>
Message-ID: <ovVSp7pCJgGGKRfERIZJ3RU8k7MdyWSryUqHWJ8Xgvo=.386ab4fe-2794-43c0-b513-8f86b0a87f7a@github.com>

> Upgrading the CLDR to version 48.0. A corresponding CSR has also been drafted.

Naoto Sato has updated the pull request incrementally with one additional commit since the last revision:

  More test data

-------------

Changes:
  - all: https://git.openjdk.org/jdk/pull/28076/files
  - new: https://git.openjdk.org/jdk/pull/28076/files/5de0854a..45ba153f

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jdk&pr=28076&range=07
 - incr: https://webrevs.openjdk.org/?repo=jdk&pr=28076&range=06-07

  Stats: 27 lines in 1 file changed: 27 ins; 0 del; 0 mod
  Patch: https://git.openjdk.org/jdk/pull/28076.diff
  Fetch: git fetch https://git.openjdk.org/jdk.git pull/28076/head:pull/28076

PR: https://git.openjdk.org/jdk/pull/28076

From jlu at openjdk.org  Wed Nov  5 22:19:36 2025
From: jlu at openjdk.org (Justin Lu)
Date: Wed, 5 Nov 2025 22:19:36 GMT
Subject: <i18n dev> RFR: 8370420: HostLocaleProviderAdapter_md.c from
 libjava can use GetLocaleInfoEx, GetCalendarInfoEx,
 EnumCalendarInfoExEx directly [v3]
In-Reply-To: <Z1dZZw56tLdc3B3htVp4GQAKcSm3n4SV7EpRvzpf-JE=.499dcc2c-15ce-4d72-b0f0-456d80ae6d7e@github.com>
References: <Z1dZZw56tLdc3B3htVp4GQAKcSm3n4SV7EpRvzpf-JE=.499dcc2c-15ce-4d72-b0f0-456d80ae6d7e@github.com>
Message-ID: <ZQeOuXAbP5kB2z1Rij8pJurBHbYGfSnI_1cxHCMUbzk=.28b7e2ae-f3f3-4206-b4ee-3d1b15169c33@github.com>

> This PR cleans up some native code for Windows i18n functions. These particular calls are designed to run on Windows Vista and later. Since Vista (and older) are not supported Windows platforms, the calls no longer need to be checked if they are supported and can be called directly.
> 
> Reference to docs: https://learn.microsoft.com/en-us/windows/win32/api/winnls/nf-winnls-getlocaleinfoex.
> 
>> Minimum supported client: 	Windows Vista
>> Minimum supported server: 	Windows Server 2008

Justin Lu has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains five additional commits since the last revision:

 - Merge branch 'master' into JDK-8370420-Windows
 - Merge branch 'master' into JDK-8370420-Windows
 - Remove dynamic loading and call directly
 - Merge branch 'master' into JDK-8370420-Windows
 - init

-------------

Changes:
  - all: https://git.openjdk.org/jdk/pull/28119/files
  - new: https://git.openjdk.org/jdk/pull/28119/files/e18a5744..e6d45424

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jdk&pr=28119&range=02
 - incr: https://webrevs.openjdk.org/?repo=jdk&pr=28119&range=01-02

  Stats: 12203 lines in 397 files changed: 7768 ins; 3189 del; 1246 mod
  Patch: https://git.openjdk.org/jdk/pull/28119.diff
  Fetch: git fetch https://git.openjdk.org/jdk.git pull/28119/head:pull/28119

PR: https://git.openjdk.org/jdk/pull/28119

From liach at openjdk.org  Wed Nov  5 23:34:14 2025
From: liach at openjdk.org (Chen Liang)
Date: Wed, 5 Nov 2025 23:34:14 GMT
Subject: <i18n dev> RFR: 8366178: Implement JEP 526: Lazy Constants
 (Second Preview) [v20]
In-Reply-To: <VwXBDgnb4wOJS9MTzrBNHzzRVvlkpysZrcrT0IIOutA=.fc1fd8ba-f415-490e-9adb-980daa25e67d@github.com>
References: <cgCEUSXiAdIu8XJxS_hmCwHevIkUDM8PYftCC9z8XnE=.8a6e191e-5574-47c3-a3a0-bd31b6fc3c98@github.com>
 <VwXBDgnb4wOJS9MTzrBNHzzRVvlkpysZrcrT0IIOutA=.fc1fd8ba-f415-490e-9adb-980daa25e67d@github.com>
Message-ID: <qdoshJM6YkMk1XK055rk8NLEb_mw0INP_ylFKSMPx2Y=.c52d2295-74d3-4681-8c56-14207a47a62e@github.com>

On Fri, 24 Oct 2025 09:01:10 GMT, Per Minborg <pminborg at openjdk.org> wrote:

>> Implement JEP 526: Lazy Constants (Second Preview)
>> 
>> The lazy list/map implementations are broken out from `ImmutableCollections` to a separate class.
>> 
>> The old benchmarks are not moved/renamed to allow comparison with previous releases.
>> 
>> `java.util.Optional` is updated so that its field is annotated with `@Stable`.  This is to allow `Optional` instances to be held in lazy constants and still provide constant folding.
>
> Per Minborg has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Rework toString implementations

src/java.base/share/classes/java/lang/LazyConstant.java line 94:

> 92:  * lazy constant remains uninitialized.
> 93:  *
> 94:  * <h2 id="composition">Composing lazy constants</h2>

This section has some interesting usage, but I don't believe it should be included in the API specification. Behaviors described here can be derived from the formal specifications.

src/java.base/share/classes/java/lang/LazyConstant.java line 209:

> 207: 
> 208:     /**
> 209:      * {@return the contents of this lazy constant if initialized, otherwise,\

Suggestion:

     * {@return the contents of this lazy constant if initialized, otherwise,

src/java.base/share/classes/java/util/AbstractMap.java line 34:

> 32: 
> 33: import jdk.internal.vm.annotation.AOTSafeClassInitializer;
> 34: import jdk.internal.vm.annotation.Stable;

Suggestion:

src/java.base/share/classes/java/util/Currency.java line 146:

> 144:     private static ConcurrentMap<String, Currency> instances = new ConcurrentHashMap<>(7);
> 145:     private static final LazyConstant<HashSet<Currency>> available =
> 146:             LazyConstant.of(new Supplier<HashSet<Currency>>() {

Why can't we retain the method reference here? This is not used in early bootstrap.

src/java.base/share/classes/java/util/LazyCollections.java line 516:

> 514: 
> 515:         @ForceInline
> 516:         private void disposeOfMutex(long offset) {

I recommend removing this unused and otherwise confusing method.

src/java.base/share/classes/java/util/LazyCollections.java line 559:

> 557:     }
> 558: 
> 559:     public static <E> int lastIndexOf(List<LazyConstant<E>> list, Object o) {

This indexOf and lastIndexOf appear unused.

src/java.base/share/classes/java/util/Map.java line 1814:

> 1812:         final Set<K> keyCopies = Set.copyOf(keys);
> 1813:         Objects.requireNonNull(computingFunction);
> 1814:         if (keys instanceof EnumSet<?> && !keys.isEmpty()) {

I wonder if it's premature for us to optimize like this - for example, this would be wasteful if the key set contains one enum constant but there are 1000 enum constants in this enum.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/27605#discussion_r2496459406
PR Review Comment: https://git.openjdk.org/jdk/pull/27605#discussion_r2496468213
PR Review Comment: https://git.openjdk.org/jdk/pull/27605#discussion_r2496478562
PR Review Comment: https://git.openjdk.org/jdk/pull/27605#discussion_r2496479687
PR Review Comment: https://git.openjdk.org/jdk/pull/27605#discussion_r2496503928
PR Review Comment: https://git.openjdk.org/jdk/pull/27605#discussion_r2496514844
PR Review Comment: https://git.openjdk.org/jdk/pull/27605#discussion_r2496516750

From darcy at openjdk.org  Thu Nov  6 05:02:15 2025
From: darcy at openjdk.org (Joe Darcy)
Date: Thu, 6 Nov 2025 05:02:15 GMT
Subject: <i18n dev> RFR: 8366178: Implement JEP 526: Lazy Constants
 (Second Preview) [v20]
In-Reply-To: <VwXBDgnb4wOJS9MTzrBNHzzRVvlkpysZrcrT0IIOutA=.fc1fd8ba-f415-490e-9adb-980daa25e67d@github.com>
References: <cgCEUSXiAdIu8XJxS_hmCwHevIkUDM8PYftCC9z8XnE=.8a6e191e-5574-47c3-a3a0-bd31b6fc3c98@github.com>
 <VwXBDgnb4wOJS9MTzrBNHzzRVvlkpysZrcrT0IIOutA=.fc1fd8ba-f415-490e-9adb-980daa25e67d@github.com>
Message-ID: <LbYfgV9Gms8dQZG--UOFnysoefCwXEDuQLHUpkToeMo=.d2d02520-bce0-44e2-ab93-fc48ed669f02@github.com>

On Fri, 24 Oct 2025 09:01:10 GMT, Per Minborg <pminborg at openjdk.org> wrote:

>> Implement JEP 526: Lazy Constants (Second Preview)
>> 
>> The lazy list/map implementations are broken out from `ImmutableCollections` to a separate class.
>> 
>> The old benchmarks are not moved/renamed to allow comparison with previous releases.
>> 
>> `java.util.Optional` is updated so that its field is annotated with `@Stable`.  This is to allow `Optional` instances to be held in lazy constants and still provide constant folding.
>
> Per Minborg has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Rework toString implementations

src/java.base/share/classes/java/lang/LazyConstant.java line 184:

> 182:  *          Use in static initializers may interact with class initialization order;
> 183:  *          cyclic initialization may result in initialization errors as described
> 184:  *          in {@jls 12.4} of <cite>The Java Language Specification</cite>.

Please use some text like "section" or "&sect;" in from of the `@jls` tag.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/27605#discussion_r2497396558

From mbaesken at openjdk.org  Thu Nov  6 08:15:04 2025
From: mbaesken at openjdk.org (Matthias Baesken)
Date: Thu, 6 Nov 2025 08:15:04 GMT
Subject: <i18n dev> RFR: 8370420: HostLocaleProviderAdapter_md.c from
 libjava can use GetLocaleInfoEx, GetCalendarInfoEx,
 EnumCalendarInfoExEx directly [v3]
In-Reply-To: <ZQeOuXAbP5kB2z1Rij8pJurBHbYGfSnI_1cxHCMUbzk=.28b7e2ae-f3f3-4206-b4ee-3d1b15169c33@github.com>
References: <Z1dZZw56tLdc3B3htVp4GQAKcSm3n4SV7EpRvzpf-JE=.499dcc2c-15ce-4d72-b0f0-456d80ae6d7e@github.com>
 <ZQeOuXAbP5kB2z1Rij8pJurBHbYGfSnI_1cxHCMUbzk=.28b7e2ae-f3f3-4206-b4ee-3d1b15169c33@github.com>
Message-ID: <DjUANKuQAUCL_BY5KYqoMRy0r2xydk-emqFMs3UK9vY=.dd76a03a-a0d4-42d3-bcae-dd56c70998c3@github.com>

On Wed, 5 Nov 2025 22:19:36 GMT, Justin Lu <jlu at openjdk.org> wrote:

>> This PR cleans up some native code for Windows i18n functions. These particular calls are designed to run on Windows Vista and later. Since Vista (and older) are not supported Windows platforms, the calls no longer need to be checked if they are supported and can be called directly.
>> 
>> Reference to docs: https://learn.microsoft.com/en-us/windows/win32/api/winnls/nf-winnls-getlocaleinfoex.
>> 
>>> Minimum supported client: 	Windows Vista
>>> Minimum supported server: 	Windows Server 2008
>
> Justin Lu has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains five additional commits since the last revision:
> 
>  - Merge branch 'master' into JDK-8370420-Windows
>  - Merge branch 'master' into JDK-8370420-Windows
>  - Remove dynamic loading and call directly
>  - Merge branch 'master' into JDK-8370420-Windows
>  - init

Marked as reviewed by mbaesken (Reviewer).

-------------

PR Review: https://git.openjdk.org/jdk/pull/28119#pullrequestreview-3426812666

From jlu at openjdk.org  Thu Nov  6 17:12:34 2025
From: jlu at openjdk.org (Justin Lu)
Date: Thu, 6 Nov 2025 17:12:34 GMT
Subject: <i18n dev> RFR: 8370420: HostLocaleProviderAdapter_md.c from
 libjava can use GetLocaleInfoEx, GetCalendarInfoEx,
 EnumCalendarInfoExEx directly [v3]
In-Reply-To: <ZQeOuXAbP5kB2z1Rij8pJurBHbYGfSnI_1cxHCMUbzk=.28b7e2ae-f3f3-4206-b4ee-3d1b15169c33@github.com>
References: <Z1dZZw56tLdc3B3htVp4GQAKcSm3n4SV7EpRvzpf-JE=.499dcc2c-15ce-4d72-b0f0-456d80ae6d7e@github.com>
 <ZQeOuXAbP5kB2z1Rij8pJurBHbYGfSnI_1cxHCMUbzk=.28b7e2ae-f3f3-4206-b4ee-3d1b15169c33@github.com>
Message-ID: <6fZEpffL-VLzAHZ1pstX_i-KlEjYev4CPGyYv2cJMDk=.83c45c0e-9051-47e6-920a-a23748313de7@github.com>

On Wed, 5 Nov 2025 22:19:36 GMT, Justin Lu <jlu at openjdk.org> wrote:

>> This PR cleans up some native code for Windows i18n functions. These particular calls are designed to run on Windows Vista and later. Since Vista (and older) are not supported Windows platforms, the calls no longer need to be checked if they are supported and can be called directly.
>> 
>> Reference to docs: https://learn.microsoft.com/en-us/windows/win32/api/winnls/nf-winnls-getlocaleinfoex.
>> 
>>> Minimum supported client: 	Windows Vista
>>> Minimum supported server: 	Windows Server 2008
>
> Justin Lu has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains five additional commits since the last revision:
> 
>  - Merge branch 'master' into JDK-8370420-Windows
>  - Merge branch 'master' into JDK-8370420-Windows
>  - Remove dynamic loading and call directly
>  - Merge branch 'master' into JDK-8370420-Windows
>  - init

Thank you all for the reviews and suggestions.

-------------

PR Comment: https://git.openjdk.org/jdk/pull/28119#issuecomment-3498417066

From jlu at openjdk.org  Thu Nov  6 17:15:45 2025
From: jlu at openjdk.org (Justin Lu)
Date: Thu, 6 Nov 2025 17:15:45 GMT
Subject: <i18n dev> Integrated: 8370420: HostLocaleProviderAdapter_md.c from
 libjava can use GetLocaleInfoEx, GetCalendarInfoEx,
 EnumCalendarInfoExEx directly
In-Reply-To: <Z1dZZw56tLdc3B3htVp4GQAKcSm3n4SV7EpRvzpf-JE=.499dcc2c-15ce-4d72-b0f0-456d80ae6d7e@github.com>
References: <Z1dZZw56tLdc3B3htVp4GQAKcSm3n4SV7EpRvzpf-JE=.499dcc2c-15ce-4d72-b0f0-456d80ae6d7e@github.com>
Message-ID: <8yUS7ZLAkcQ23T1qnXzqdWyeE0Nm3k3yG1_X2vTPkZ4=.cb20a15d-961b-4a3c-bc63-11e4de66d943@github.com>

On Mon, 3 Nov 2025 23:48:22 GMT, Justin Lu <jlu at openjdk.org> wrote:

> This PR cleans up some native code for Windows i18n functions. These particular calls are designed to run on Windows Vista and later. Since Vista (and older) are not supported Windows platforms, the calls no longer need to be checked if they are supported and can be called directly.
> 
> Reference to docs: https://learn.microsoft.com/en-us/windows/win32/api/winnls/nf-winnls-getlocaleinfoex.
> 
>> Minimum supported client: 	Windows Vista
>> Minimum supported server: 	Windows Server 2008

This pull request has now been integrated.

Changeset: 0026967e
Author:    Justin Lu <jlu at openjdk.org>
URL:       https://git.openjdk.org/jdk/commit/0026967e030fd4557b5365870d55f863fe2a4512
Stats:     90 lines in 2 files changed: 6 ins; 63 del; 21 mod

8370420: HostLocaleProviderAdapter_md.c from libjava can use GetLocaleInfoEx, GetCalendarInfoEx, EnumCalendarInfoExEx directly

Reviewed-by: naoto, mbaesken, bpb

-------------

PR: https://git.openjdk.org/jdk/pull/28119

From naoto at openjdk.org  Thu Nov  6 19:43:15 2025
From: naoto at openjdk.org (Naoto Sato)
Date: Thu, 6 Nov 2025 19:43:15 GMT
Subject: <i18n dev> RFR: 8371339: Illegal pattern char 'B' with
 locale.providers as HOST on macOS for Taiwanese
Message-ID: <30ThkifrSqifpcv8THhqYLuq535cHggNmDFIGim8F0k=.e5ea6c2c-1704-4fb7-8296-9c5756cd4b6c@github.com>

This is a leftover when we introduced "dayperiods" in the JDK ([JDK-8247781](https://bugs.openjdk.org/browse/JDK-8247781)). The CLDR Converter was modified to generate patterns for SimpleDateFormat for dayperiods (simply replacing them with ampm), and the same processing should have been applied to Host provider on mac, which also uses LDML patterns. As in the bug report, macos recently started using dayperiods, thus the issue was revealed. Regression test is not provided as it would require the macos's default locale should be configured to zh_TW. I have manually confirmed that the proposed fix would work for the problem case.

-------------

Commit messages:
 - initial commit

Changes: https://git.openjdk.org/jdk/pull/28181/files
  Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=28181&range=00
  Issue: https://bugs.openjdk.org/browse/JDK-8371339
  Stats: 12 lines in 1 file changed: 11 ins; 0 del; 1 mod
  Patch: https://git.openjdk.org/jdk/pull/28181.diff
  Fetch: git fetch https://git.openjdk.org/jdk.git pull/28181/head:pull/28181

PR: https://git.openjdk.org/jdk/pull/28181