<i18n dev> RFR: 8368001: java/text/Format/NumberFormat/NumberRoundTrip.java timed out [v2]

[Naoto Sato]

On Fri, 21 Nov 2025 17:47:43 GMT, Justin Lu <jlu at openjdk.org> wrote:

>> JDK-8260555 exposed test/jdk/java/text/Format/NumberFormat/NumberRoundTrip.java as being susceptible to timeouts.
>> While the timeout factor is reverted, this test was testing too many inputs, and should be changed. 
>> Originally, it was testing (~1000 locales * 4 factories) against ~30 numeric inputs. The test does not need to be exhaustive to this degree.
>> 
>> The total amount of locales is changed to sample around a 1/4 of those provided by the provider. The numeric inputs are reduced to about ~20. (The fixed ones remain, and the random ones are cut in half.)
>> 
>> Locally, I observe average execution for this test to be about ~1.3 seconds, compared to ~3.4 seconds previously. The PR also does a drive-by clean up of the test, i.e. getting rid of the unnecessary escaping + string manipulation/printing and separating the test inputs from the actual testing work done.
>
> Justin Lu has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Use jdk.test.lib.RandomFactory

Good refactoring. One minor comment below

test/jdk/java/text/Format/NumberFormat/NumberRoundTrip.java line 29:

> 27:  * @summary NumberFormat round trip testing of parsing and formatting.
> 28:  *      This test checks 4 factory instances per locale against ~20 numeric inputs.
> 29:  *      Samples ~1/4 of the available locales from NumberFormat SPI.

Nit: it is not using SPI

-------------

PR Review: https://git.openjdk.org/jdk/pull/28443#pullrequestreview-3493973259
PR Review Comment: https://git.openjdk.org/jdk/pull/28443#discussion_r2550667418